blob: 435ca1cad471e2e7769dcc7b1c2dc6136121d24a [file] [log] [blame]
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Andreas Gampe53c913b2014-08-12 23:19:23 -070017#include "optimizing_compiler.h"
18
Nicolas Geoffrayf635e632014-05-14 09:43:38 +010019#include <fstream>
David Srbecky5cc349f2015-12-18 15:04:48 +000020#include <memory>
Andreas Gampea0d81af2016-10-27 12:04:57 -070021#include <sstream>
22
Nicolas Geoffray787c3072014-03-17 10:20:19 +000023#include <stdint.h>
24
Andreas Gampe9186ced2016-12-12 14:28:21 -080025#include "android-base/strings.h"
26
Vladimir Markob4536b72015-11-24 13:45:23 +000027#ifdef ART_ENABLE_CODEGEN_arm64
Alexandre Rames44b9cf92015-08-19 15:39:06 +010028#include "instruction_simplifier_arm64.h"
29#endif
30
Alexey Frunzee3fb2452016-05-10 16:08:05 -070031#ifdef ART_ENABLE_CODEGEN_mips
Alexey Frunzee3fb2452016-05-10 16:08:05 -070032#include "pc_relative_fixups_mips.h"
33#endif
34
Mark Mendell0616ae02015-04-17 12:49:27 -040035#ifdef ART_ENABLE_CODEGEN_x86
Vladimir Marko0f7dca42015-11-02 14:36:43 +000036#include "pc_relative_fixups_x86.h"
Mark Mendell0616ae02015-04-17 12:49:27 -040037#endif
38
Mark Mendellee8d9712016-07-12 11:13:15 -040039#if defined(ART_ENABLE_CODEGEN_x86) || defined(ART_ENABLE_CODEGEN_x86_64)
40#include "x86_memory_gen.h"
41#endif
42
Mathieu Chartiere401d142015-04-22 13:56:20 -070043#include "art_method-inl.h"
Mathieu Chartierb666f482015-02-18 14:33:14 -080044#include "base/arena_allocator.h"
Vladimir Markof9f64412015-09-02 14:05:49 +010045#include "base/arena_containers.h"
David Brazdil5e8b1372015-01-23 14:39:08 +000046#include "base/dumpable.h"
Vladimir Markoc90d7c72015-10-06 17:30:45 +000047#include "base/macros.h"
Andreas Gampea0d81af2016-10-27 12:04:57 -070048#include "base/mutex.h"
David Brazdil5e8b1372015-01-23 14:39:08 +000049#include "base/timing_logger.h"
Mingyao Yangf384f882014-10-22 16:08:18 -070050#include "bounds_check_elimination.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000051#include "builder.h"
Mingyao Yangb0b051a2016-11-17 09:04:53 -080052#include "cha_guard_optimization.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000053#include "code_generator.h"
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +000054#include "code_sinking.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000055#include "compiled_method.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070056#include "compiler.h"
Roland Levillain75be2832014-10-17 17:02:00 +010057#include "constant_folding.h"
58#include "dead_code_elimination.h"
David Srbeckyc5bfa972016-02-05 15:49:10 +000059#include "debug/elf_debug_writer.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000060#include "debug/method_debug_info.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010061#include "dex/verification_results.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000062#include "dex/verified_method.h"
Andreas Gampea5b09a62016-11-17 15:21:22 -080063#include "dex_file_types.h"
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +000064#include "driver/compiler_driver-inl.h"
Vladimir Marko20f85592015-03-19 10:07:02 +000065#include "driver/compiler_options.h"
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +000066#include "driver/dex_compilation_unit.h"
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +000067#include "elf_writer_quick.h"
David Brazdil69ba7b72015-06-23 18:27:30 +010068#include "graph_checker.h"
Nicolas Geoffrayf635e632014-05-14 09:43:38 +010069#include "graph_visualizer.h"
Nicolas Geoffrayd31cf3d2014-09-08 17:30:24 +010070#include "gvn.h"
Aart Bik22af3be2015-09-10 12:50:58 -070071#include "induction_var_analysis.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000072#include "inliner.h"
Nicolas Geoffray3c049742014-09-24 18:10:46 +010073#include "instruction_simplifier.h"
Artem Udovichenko4a0dad62016-01-26 12:28:31 +030074#include "instruction_simplifier_arm.h"
Andreas Gampe71fb52f2014-12-29 17:43:08 -080075#include "intrinsics.h"
David Srbecky5cc349f2015-12-18 15:04:48 +000076#include "jit/debugger_interface.h"
Nicolas Geoffraya4f81542016-03-08 16:57:48 +000077#include "jit/jit.h"
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +000078#include "jit/jit_code_cache.h"
Nicolas Geoffray01db5f72017-07-19 15:05:49 +010079#include "jit/jit_logger.h"
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +000080#include "jni/quick/jni_compiler.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000081#include "licm.h"
xueliang.zhongc239a2b2017-04-27 15:31:37 +010082#include "load_store_analysis.h"
Mingyao Yang8df69d42015-10-22 15:40:58 -070083#include "load_store_elimination.h"
Aart Bik281c6812016-08-26 11:31:48 -070084#include "loop_optimization.h"
Nicolas Geoffray787c3072014-03-17 10:20:19 +000085#include "nodes.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000086#include "oat_quick_method_header.h"
Nicolas Geoffray26a25ef2014-09-30 13:54:09 +010087#include "prepare_for_register_allocation.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010088#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070089#include "register_allocator_linear_scan.h"
Alexandre Rames22aa54b2016-10-18 09:32:29 +010090#include "scheduler.h"
Andreas Gampe8cf9cb32017-07-19 09:28:38 -070091#include "select_generator.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010092#include "sharpening.h"
Nicolas Geoffray827eedb2015-01-26 15:18:36 +000093#include "side_effects_analysis.h"
Nicolas Geoffray31596742014-11-24 15:28:45 +000094#include "ssa_builder.h"
Nicolas Geoffray804d0932014-05-02 08:46:00 +010095#include "ssa_liveness_analysis.h"
David Srbecky4fda4eb2016-02-05 13:34:46 +000096#include "ssa_phi_elimination.h"
David Srbeckyc6b4dd82015-04-07 20:32:43 +010097#include "utils/assembler.h"
Andreas Gampe6d7abbd2017-04-24 13:19:09 -070098#include "verifier/verifier_compiler_binding.h"
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +000099
100namespace art {
101
Vladimir Marko3a40bf22016-03-22 16:26:33 +0000102static constexpr size_t kArenaAllocatorMemoryReportThreshold = 8 * MB;
103
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700104static constexpr const char* kPassNameSeparator = "$";
105
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000106/**
107 * Used by the code generator, to allocate the code in a vector.
108 */
109class CodeVectorAllocator FINAL : public CodeAllocator {
110 public:
Vladimir Markof9f64412015-09-02 14:05:49 +0100111 explicit CodeVectorAllocator(ArenaAllocator* arena)
112 : memory_(arena->Adapter(kArenaAllocCodeBuffer)),
113 size_(0) {}
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000114
115 virtual uint8_t* Allocate(size_t size) {
116 size_ = size;
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000117 memory_.resize(size);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000118 return &memory_[0];
119 }
120
121 size_t GetSize() const { return size_; }
Vladimir Markof9f64412015-09-02 14:05:49 +0100122 const ArenaVector<uint8_t>& GetMemory() const { return memory_; }
Nicolas Geoffray132d8362016-11-16 09:19:42 +0000123 uint8_t* GetData() { return memory_.data(); }
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000124
125 private:
Vladimir Markof9f64412015-09-02 14:05:49 +0100126 ArenaVector<uint8_t> memory_;
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000127 size_t size_;
128
129 DISALLOW_COPY_AND_ASSIGN(CodeVectorAllocator);
130};
131
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100132/**
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100133 * Filter to apply to the visualizer. Methods whose name contain that filter will
David Brazdilee690a32014-12-01 17:04:16 +0000134 * be dumped.
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100135 */
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700136static constexpr const char kStringFilter[] = "";
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100137
David Brazdil69ba7b72015-06-23 18:27:30 +0100138class PassScope;
David Brazdil809658e2015-02-05 11:34:02 +0000139
David Brazdil69ba7b72015-06-23 18:27:30 +0100140class PassObserver : public ValueObject {
David Brazdil5e8b1372015-01-23 14:39:08 +0000141 public:
David Brazdil69ba7b72015-06-23 18:27:30 +0100142 PassObserver(HGraph* graph,
David Brazdil69ba7b72015-06-23 18:27:30 +0100143 CodeGenerator* codegen,
144 std::ostream* visualizer_output,
Andreas Gampea0d81af2016-10-27 12:04:57 -0700145 CompilerDriver* compiler_driver,
146 Mutex& dump_mutex)
David Brazdil69ba7b72015-06-23 18:27:30 +0100147 : graph_(graph),
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000148 cached_method_name_(),
David Brazdil809658e2015-02-05 11:34:02 +0000149 timing_logger_enabled_(compiler_driver->GetDumpPasses()),
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000150 timing_logger_(timing_logger_enabled_ ? GetMethodName() : "", true, true),
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100151 disasm_info_(graph->GetArena()),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700152 visualizer_oss_(),
153 visualizer_output_(visualizer_output),
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000154 visualizer_enabled_(!compiler_driver->GetCompilerOptions().GetDumpCfgFileName().empty()),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700155 visualizer_(&visualizer_oss_, graph, *codegen),
156 visualizer_dump_mutex_(dump_mutex),
David Brazdil69ba7b72015-06-23 18:27:30 +0100157 graph_in_bad_state_(false) {
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700158 if (timing_logger_enabled_ || visualizer_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000159 if (!IsVerboseMethod(compiler_driver, GetMethodName())) {
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700160 timing_logger_enabled_ = visualizer_enabled_ = false;
161 }
162 if (visualizer_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000163 visualizer_.PrintHeader(GetMethodName());
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700164 codegen->SetDisassemblyInformation(&disasm_info_);
165 }
David Brazdil62e074f2015-04-07 18:09:37 +0100166 }
David Brazdil5e8b1372015-01-23 14:39:08 +0000167 }
168
David Brazdil69ba7b72015-06-23 18:27:30 +0100169 ~PassObserver() {
David Brazdil5e8b1372015-01-23 14:39:08 +0000170 if (timing_logger_enabled_) {
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000171 LOG(INFO) << "TIMINGS " << GetMethodName();
David Brazdil5e8b1372015-01-23 14:39:08 +0000172 LOG(INFO) << Dumpable<TimingLogger>(timing_logger_);
173 }
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000174 DCHECK(visualizer_oss_.str().empty());
David Brazdil5e8b1372015-01-23 14:39:08 +0000175 }
176
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000177 void DumpDisassembly() REQUIRES(!visualizer_dump_mutex_) {
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100178 if (visualizer_enabled_) {
179 visualizer_.DumpGraphWithDisassembly();
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000180 FlushVisualizer();
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100181 }
182 }
183
David Brazdil69ba7b72015-06-23 18:27:30 +0100184 void SetGraphInBadState() { graph_in_bad_state_ = true; }
185
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000186 const char* GetMethodName() {
187 // PrettyMethod() is expensive, so we delay calling it until we actually have to.
188 if (cached_method_name_.empty()) {
David Sehr709b0702016-10-13 09:12:37 -0700189 cached_method_name_ = graph_->GetDexFile().PrettyMethod(graph_->GetMethodIdx());
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000190 }
191 return cached_method_name_.c_str();
192 }
193
David Brazdil5e8b1372015-01-23 14:39:08 +0000194 private:
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000195 void StartPass(const char* pass_name) REQUIRES(!visualizer_dump_mutex_) {
Wojciech Staszkiewicze7060702016-08-16 17:31:19 -0700196 VLOG(compiler) << "Starting pass: " << pass_name;
David Brazdil809658e2015-02-05 11:34:02 +0000197 // Dump graph first, then start timer.
198 if (visualizer_enabled_) {
David Brazdilffee3d32015-07-06 11:48:53 +0100199 visualizer_.DumpGraph(pass_name, /* is_after_pass */ false, graph_in_bad_state_);
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000200 FlushVisualizer();
David Brazdil809658e2015-02-05 11:34:02 +0000201 }
202 if (timing_logger_enabled_) {
203 timing_logger_.StartTiming(pass_name);
204 }
205 }
206
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000207 void FlushVisualizer() REQUIRES(!visualizer_dump_mutex_) {
208 MutexLock mu(Thread::Current(), visualizer_dump_mutex_);
209 *visualizer_output_ << visualizer_oss_.str();
210 visualizer_output_->flush();
211 visualizer_oss_.str("");
212 visualizer_oss_.clear();
213 }
214
215 void EndPass(const char* pass_name) REQUIRES(!visualizer_dump_mutex_) {
David Brazdil809658e2015-02-05 11:34:02 +0000216 // Pause timer first, then dump graph.
217 if (timing_logger_enabled_) {
218 timing_logger_.EndTiming();
219 }
220 if (visualizer_enabled_) {
David Brazdilffee3d32015-07-06 11:48:53 +0100221 visualizer_.DumpGraph(pass_name, /* is_after_pass */ true, graph_in_bad_state_);
Nicolas Geoffray00c141a2016-11-10 15:19:15 +0000222 FlushVisualizer();
David Brazdil809658e2015-02-05 11:34:02 +0000223 }
David Brazdil69ba7b72015-06-23 18:27:30 +0100224
225 // Validate the HGraph if running in debug mode.
226 if (kIsDebugBuild) {
227 if (!graph_in_bad_state_) {
David Brazdilbadd8262016-02-02 16:28:56 +0000228 GraphChecker checker(graph_);
229 checker.Run();
230 if (!checker.IsValid()) {
231 LOG(FATAL) << "Error after " << pass_name << ": " << Dumpable<GraphChecker>(checker);
David Brazdil69ba7b72015-06-23 18:27:30 +0100232 }
233 }
234 }
David Brazdil809658e2015-02-05 11:34:02 +0000235 }
236
Andreas Gampe53fcd0f2015-07-22 12:10:13 -0700237 static bool IsVerboseMethod(CompilerDriver* compiler_driver, const char* method_name) {
238 // Test an exact match to --verbose-methods. If verbose-methods is set, this overrides an
239 // empty kStringFilter matching all methods.
240 if (compiler_driver->GetCompilerOptions().HasVerboseMethods()) {
241 return compiler_driver->GetCompilerOptions().IsVerboseMethod(method_name);
242 }
243
244 // Test the kStringFilter sub-string. constexpr helper variable to silence unreachable-code
245 // warning when the string is empty.
246 constexpr bool kStringFilterEmpty = arraysize(kStringFilter) <= 1;
247 if (kStringFilterEmpty || strstr(method_name, kStringFilter) != nullptr) {
248 return true;
249 }
250
251 return false;
252 }
253
David Brazdil69ba7b72015-06-23 18:27:30 +0100254 HGraph* const graph_;
Vladimir Marko0d1caa52015-11-20 13:02:22 +0000255
256 std::string cached_method_name_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000257
258 bool timing_logger_enabled_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000259 TimingLogger timing_logger_;
260
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100261 DisassemblyInformation disasm_info_;
262
Andreas Gampea0d81af2016-10-27 12:04:57 -0700263 std::ostringstream visualizer_oss_;
264 std::ostream* visualizer_output_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000265 bool visualizer_enabled_;
266 HGraphVisualizer visualizer_;
Andreas Gampea0d81af2016-10-27 12:04:57 -0700267 Mutex& visualizer_dump_mutex_;
David Brazdil5e8b1372015-01-23 14:39:08 +0000268
David Brazdil69ba7b72015-06-23 18:27:30 +0100269 // Flag to be set by the compiler if the pass failed and the graph is not
270 // expected to validate.
271 bool graph_in_bad_state_;
David Brazdil809658e2015-02-05 11:34:02 +0000272
David Brazdil69ba7b72015-06-23 18:27:30 +0100273 friend PassScope;
274
275 DISALLOW_COPY_AND_ASSIGN(PassObserver);
David Brazdil5e8b1372015-01-23 14:39:08 +0000276};
277
David Brazdil69ba7b72015-06-23 18:27:30 +0100278class PassScope : public ValueObject {
David Brazdil809658e2015-02-05 11:34:02 +0000279 public:
David Brazdil69ba7b72015-06-23 18:27:30 +0100280 PassScope(const char *pass_name, PassObserver* pass_observer)
David Brazdil809658e2015-02-05 11:34:02 +0000281 : pass_name_(pass_name),
David Brazdil69ba7b72015-06-23 18:27:30 +0100282 pass_observer_(pass_observer) {
283 pass_observer_->StartPass(pass_name_);
David Brazdil809658e2015-02-05 11:34:02 +0000284 }
285
David Brazdil69ba7b72015-06-23 18:27:30 +0100286 ~PassScope() {
287 pass_observer_->EndPass(pass_name_);
David Brazdil809658e2015-02-05 11:34:02 +0000288 }
289
290 private:
291 const char* const pass_name_;
David Brazdil69ba7b72015-06-23 18:27:30 +0100292 PassObserver* const pass_observer_;
David Brazdil809658e2015-02-05 11:34:02 +0000293};
294
Andreas Gampe53c913b2014-08-12 23:19:23 -0700295class OptimizingCompiler FINAL : public Compiler {
296 public:
297 explicit OptimizingCompiler(CompilerDriver* driver);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700298 ~OptimizingCompiler() OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700299
Vladimir Markodf739842016-03-23 16:59:07 +0000300 bool CanCompileMethod(uint32_t method_idx, const DexFile& dex_file) const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700301
302 CompiledMethod* Compile(const DexFile::CodeItem* code_item,
303 uint32_t access_flags,
304 InvokeType invoke_type,
305 uint16_t class_def_idx,
306 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000307 Handle<mirror::ClassLoader> class_loader,
Mathieu Chartier736b5602015-09-02 14:54:11 -0700308 const DexFile& dex_file,
309 Handle<mirror::DexCache> dex_cache) const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700310
Andreas Gampe53c913b2014-08-12 23:19:23 -0700311 CompiledMethod* JniCompile(uint32_t access_flags,
312 uint32_t method_idx,
Igor Murashkin9d4b6da2016-07-29 09:51:58 -0700313 const DexFile& dex_file,
314 JniOptimizationFlags optimization_flags) const OVERRIDE {
315 return ArtQuickJniCompileMethod(GetCompilerDriver(),
316 access_flags,
317 method_idx,
318 dex_file,
319 optimization_flags);
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000320 }
Andreas Gampe53c913b2014-08-12 23:19:23 -0700321
Mathieu Chartiere401d142015-04-22 13:56:20 -0700322 uintptr_t GetEntryPointOf(ArtMethod* method) const OVERRIDE
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700323 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000324 return reinterpret_cast<uintptr_t>(method->GetEntryPointFromQuickCompiledCodePtrSize(
325 InstructionSetPointerSize(GetCompilerDriver()->GetInstructionSet())));
326 }
Andreas Gampe53c913b2014-08-12 23:19:23 -0700327
David Brazdilee690a32014-12-01 17:04:16 +0000328 void Init() OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700329
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000330 void UnInit() const OVERRIDE;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700331
Nicolas Geoffray01db5f72017-07-19 15:05:49 +0100332 bool JitCompile(Thread* self,
333 jit::JitCodeCache* code_cache,
334 ArtMethod* method,
335 bool osr,
336 jit::JitLogger* jit_logger)
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000337 OVERRIDE
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700338 REQUIRES_SHARED(Locks::mutator_lock_);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000339
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700340 private:
341 void RunOptimizations(HGraph* graph,
342 CodeGenerator* codegen,
343 CompilerDriver* driver,
344 const DexCompilationUnit& dex_compilation_unit,
345 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700346 VariableSizedHandleScope* handles) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700347
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700348 void RunOptimizations(HOptimization* optimizations[],
349 size_t length,
350 PassObserver* pass_observer) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700351
Andreas Gampe53c913b2014-08-12 23:19:23 -0700352 private:
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000353 // Create a 'CompiledMethod' for an optimized graph.
David Brazdil58282f42016-01-14 12:45:10 +0000354 CompiledMethod* Emit(ArenaAllocator* arena,
355 CodeVectorAllocator* code_allocator,
356 CodeGenerator* codegen,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000357 CompilerDriver* driver,
358 const DexFile::CodeItem* item) const;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000359
360 // Try compiling a method and return the code generator used for
361 // compiling it.
362 // This method:
363 // 1) Builds the graph. Returns null if it failed to build it.
David Brazdil58282f42016-01-14 12:45:10 +0000364 // 2) Transforms the graph to SSA. Returns null if it failed.
365 // 3) Runs optimizations on the graph, including register allocator.
366 // 4) Generates code with the `code_allocator` provided.
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000367 CodeGenerator* TryCompile(ArenaAllocator* arena,
368 CodeVectorAllocator* code_allocator,
369 const DexFile::CodeItem* code_item,
370 uint32_t access_flags,
371 InvokeType invoke_type,
372 uint16_t class_def_idx,
373 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000374 Handle<mirror::ClassLoader> class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000375 const DexFile& dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000376 Handle<mirror::DexCache> dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000377 ArtMethod* method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000378 bool osr,
379 VariableSizedHandleScope* handles) const;
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000380
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700381 void MaybeRunInliner(HGraph* graph,
382 CodeGenerator* codegen,
383 CompilerDriver* driver,
384 const DexCompilationUnit& dex_compilation_unit,
385 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700386 VariableSizedHandleScope* handles) const;
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700387
388 void RunArchOptimizations(InstructionSet instruction_set,
389 HGraph* graph,
390 CodeGenerator* codegen,
391 PassObserver* pass_observer) const;
392
Calin Juravle2be39e02015-04-21 13:56:34 +0100393 std::unique_ptr<OptimizingCompilerStats> compilation_stats_;
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100394
Andreas Gampe53c913b2014-08-12 23:19:23 -0700395 std::unique_ptr<std::ostream> visualizer_output_;
396
Andreas Gampea0d81af2016-10-27 12:04:57 -0700397 mutable Mutex dump_mutex_; // To synchronize visualizer writing.
398
Andreas Gampe53c913b2014-08-12 23:19:23 -0700399 DISALLOW_COPY_AND_ASSIGN(OptimizingCompiler);
400};
401
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100402static const int kMaximumCompilationTimeBeforeWarning = 100; /* ms */
403
404OptimizingCompiler::OptimizingCompiler(CompilerDriver* driver)
Andreas Gampea0d81af2016-10-27 12:04:57 -0700405 : Compiler(driver, kMaximumCompilationTimeBeforeWarning),
406 dump_mutex_("Visualizer dump lock") {}
David Brazdilee690a32014-12-01 17:04:16 +0000407
408void OptimizingCompiler::Init() {
409 // Enable C1visualizer output. Must be done in Init() because the compiler
410 // driver is not fully initialized when passed to the compiler's constructor.
411 CompilerDriver* driver = GetCompilerDriver();
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000412 const std::string cfg_file_name = driver->GetCompilerOptions().GetDumpCfgFileName();
David Brazdil866c0312015-01-13 21:21:31 +0000413 if (!cfg_file_name.empty()) {
Calin Juravle87000a92015-08-24 15:34:44 +0100414 std::ios_base::openmode cfg_file_mode =
Nicolas Geoffrayc903b6a2016-01-18 12:56:06 +0000415 driver->GetCompilerOptions().GetDumpCfgAppend() ? std::ofstream::app : std::ofstream::out;
Calin Juravle87000a92015-08-24 15:34:44 +0100416 visualizer_output_.reset(new std::ofstream(cfg_file_name, cfg_file_mode));
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100417 }
Calin Juravle2be39e02015-04-21 13:56:34 +0100418 if (driver->GetDumpStats()) {
419 compilation_stats_.reset(new OptimizingCompilerStats());
420 }
Nicolas Geoffrayf635e632014-05-14 09:43:38 +0100421}
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000422
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000423void OptimizingCompiler::UnInit() const {
Nicolas Geoffray216eaa22015-03-17 17:09:30 +0000424}
425
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100426OptimizingCompiler::~OptimizingCompiler() {
Calin Juravle2be39e02015-04-21 13:56:34 +0100427 if (compilation_stats_.get() != nullptr) {
428 compilation_stats_->Log();
429 }
Nicolas Geoffray88157ef2014-09-12 10:29:53 +0100430}
431
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +0000432bool OptimizingCompiler::CanCompileMethod(uint32_t method_idx ATTRIBUTE_UNUSED,
Vladimir Markodf739842016-03-23 16:59:07 +0000433 const DexFile& dex_file ATTRIBUTE_UNUSED) const {
Nicolas Geoffraye2dc6fa2014-11-17 12:55:12 +0000434 return true;
Andreas Gampe53c913b2014-08-12 23:19:23 -0700435}
436
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000437static bool IsInstructionSetSupported(InstructionSet instruction_set) {
Calin Juravlecff8cc72015-10-09 12:03:24 +0100438 return (instruction_set == kArm && !kArm32QuickCodeUseSoftFloat)
439 || instruction_set == kArm64
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000440 || (instruction_set == kThumb2 && !kArm32QuickCodeUseSoftFloat)
Goran Jakovljevicf652cec2015-08-25 16:11:42 +0200441 || instruction_set == kMips
Alexey Frunze4dda3372015-06-01 18:31:49 -0700442 || instruction_set == kMips64
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000443 || instruction_set == kX86
444 || instruction_set == kX86_64;
445}
446
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700447// Strip pass name suffix to get optimization name.
448static std::string ConvertPassNameToOptimizationName(const std::string& pass_name) {
449 size_t pos = pass_name.find(kPassNameSeparator);
450 return pos == std::string::npos ? pass_name : pass_name.substr(0, pos);
451}
452
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700453static HOptimization* BuildOptimization(
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700454 const std::string& pass_name,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700455 ArenaAllocator* arena,
456 HGraph* graph,
457 OptimizingCompilerStats* stats,
458 CodeGenerator* codegen,
459 CompilerDriver* driver,
460 const DexCompilationUnit& dex_compilation_unit,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700461 VariableSizedHandleScope* handles,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700462 SideEffectsAnalysis* most_recent_side_effects,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100463 HInductionVarAnalysis* most_recent_induction,
464 LoadStoreAnalysis* most_recent_lsa) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700465 std::string opt_name = ConvertPassNameToOptimizationName(pass_name);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700466 if (opt_name == BoundsCheckElimination::kBoundsCheckEliminationPassName) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700467 CHECK(most_recent_side_effects != nullptr && most_recent_induction != nullptr);
468 return new (arena) BoundsCheckElimination(graph,
469 *most_recent_side_effects,
470 most_recent_induction);
471 } else if (opt_name == GVNOptimization::kGlobalValueNumberingPassName) {
472 CHECK(most_recent_side_effects != nullptr);
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700473 return new (arena) GVNOptimization(graph, *most_recent_side_effects, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700474 } else if (opt_name == HConstantFolding::kConstantFoldingPassName) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700475 return new (arena) HConstantFolding(graph, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700476 } else if (opt_name == HDeadCodeElimination::kDeadCodeEliminationPassName) {
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700477 return new (arena) HDeadCodeElimination(graph, stats, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700478 } else if (opt_name == HInliner::kInlinerPassName) {
479 size_t number_of_dex_registers = dex_compilation_unit.GetCodeItem()->registers_size_;
480 return new (arena) HInliner(graph, // outer_graph
481 graph, // outermost_graph
482 codegen,
483 dex_compilation_unit, // outer_compilation_unit
484 dex_compilation_unit, // outermost_compilation_unit
485 driver,
486 handles,
487 stats,
488 number_of_dex_registers,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000489 /* total_number_of_instructions */ 0,
490 /* parent */ nullptr);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700491 } else if (opt_name == HSharpening::kSharpeningPassName) {
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000492 return new (arena) HSharpening(graph, codegen, dex_compilation_unit, driver, handles);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700493 } else if (opt_name == HSelectGenerator::kSelectGeneratorPassName) {
494 return new (arena) HSelectGenerator(graph, stats);
495 } else if (opt_name == HInductionVarAnalysis::kInductionPassName) {
496 return new (arena) HInductionVarAnalysis(graph);
497 } else if (opt_name == InstructionSimplifier::kInstructionSimplifierPassName) {
Vladimir Marko65979462017-05-19 17:25:12 +0100498 return new (arena) InstructionSimplifier(graph, codegen, driver, stats, pass_name.c_str());
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700499 } else if (opt_name == IntrinsicsRecognizer::kIntrinsicsRecognizerPassName) {
Nicolas Geoffray762869d2016-07-15 15:28:35 +0100500 return new (arena) IntrinsicsRecognizer(graph, stats);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700501 } else if (opt_name == LICM::kLoopInvariantCodeMotionPassName) {
502 CHECK(most_recent_side_effects != nullptr);
503 return new (arena) LICM(graph, *most_recent_side_effects, stats);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100504 } else if (opt_name == LoadStoreAnalysis::kLoadStoreAnalysisPassName) {
505 return new (arena) LoadStoreAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700506 } else if (opt_name == LoadStoreElimination::kLoadStoreEliminationPassName) {
507 CHECK(most_recent_side_effects != nullptr);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100508 CHECK(most_recent_lsa != nullptr);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700509 return
510 new (arena) LoadStoreElimination(graph, *most_recent_side_effects, *most_recent_lsa, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700511 } else if (opt_name == SideEffectsAnalysis::kSideEffectsAnalysisPassName) {
512 return new (arena) SideEffectsAnalysis(graph);
Nicolas Geoffrayebe16742016-10-05 09:55:42 +0100513 } else if (opt_name == HLoopOptimization::kLoopOptimizationPassName) {
Aart Bik92685a82017-03-06 11:13:43 -0800514 return new (arena) HLoopOptimization(graph, driver, most_recent_induction);
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800515 } else if (opt_name == CHAGuardOptimization::kCHAGuardOptimizationPassName) {
516 return new (arena) CHAGuardOptimization(graph);
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000517 } else if (opt_name == CodeSinking::kCodeSinkingPassName) {
518 return new (arena) CodeSinking(graph, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700519#ifdef ART_ENABLE_CODEGEN_arm
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700520 } else if (opt_name == arm::InstructionSimplifierArm::kInstructionSimplifierArmPassName) {
521 return new (arena) arm::InstructionSimplifierArm(graph, stats);
522#endif
523#ifdef ART_ENABLE_CODEGEN_arm64
524 } else if (opt_name == arm64::InstructionSimplifierArm64::kInstructionSimplifierArm64PassName) {
525 return new (arena) arm64::InstructionSimplifierArm64(graph, stats);
526#endif
527#ifdef ART_ENABLE_CODEGEN_mips
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700528 } else if (opt_name == mips::PcRelativeFixups::kPcRelativeFixupsMipsPassName) {
529 return new (arena) mips::PcRelativeFixups(graph, codegen, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700530#endif
531#ifdef ART_ENABLE_CODEGEN_x86
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700532 } else if (opt_name == x86::PcRelativeFixups::kPcRelativeFixupsX86PassName) {
533 return new (arena) x86::PcRelativeFixups(graph, codegen, stats);
534 } else if (opt_name == x86::X86MemoryOperandGeneration::kX86MemoryOperandGenerationPassName) {
535 return new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700536#endif
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700537 }
538 return nullptr;
539}
540
541static ArenaVector<HOptimization*> BuildOptimizations(
542 const std::vector<std::string>& pass_names,
543 ArenaAllocator* arena,
544 HGraph* graph,
545 OptimizingCompilerStats* stats,
546 CodeGenerator* codegen,
547 CompilerDriver* driver,
548 const DexCompilationUnit& dex_compilation_unit,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700549 VariableSizedHandleScope* handles) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700550 // Few HOptimizations constructors require SideEffectsAnalysis or HInductionVarAnalysis
551 // instances. This method assumes that each of them expects the nearest instance preceeding it
552 // in the pass name list.
553 SideEffectsAnalysis* most_recent_side_effects = nullptr;
554 HInductionVarAnalysis* most_recent_induction = nullptr;
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100555 LoadStoreAnalysis* most_recent_lsa = nullptr;
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700556 ArenaVector<HOptimization*> ret(arena->Adapter());
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700557 for (const std::string& pass_name : pass_names) {
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700558 HOptimization* opt = BuildOptimization(
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700559 pass_name,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700560 arena,
561 graph,
562 stats,
563 codegen,
564 driver,
565 dex_compilation_unit,
566 handles,
567 most_recent_side_effects,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100568 most_recent_induction,
569 most_recent_lsa);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700570 CHECK(opt != nullptr) << "Couldn't build optimization: \"" << pass_name << "\"";
571 ret.push_back(opt);
572
Wojciech Staszkiewiczb6a128322016-08-16 16:33:00 -0700573 std::string opt_name = ConvertPassNameToOptimizationName(pass_name);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700574 if (opt_name == SideEffectsAnalysis::kSideEffectsAnalysisPassName) {
575 most_recent_side_effects = down_cast<SideEffectsAnalysis*>(opt);
576 } else if (opt_name == HInductionVarAnalysis::kInductionPassName) {
577 most_recent_induction = down_cast<HInductionVarAnalysis*>(opt);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100578 } else if (opt_name == LoadStoreAnalysis::kLoadStoreAnalysisPassName) {
579 most_recent_lsa = down_cast<LoadStoreAnalysis*>(opt);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700580 }
581 }
582 return ret;
583}
584
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700585void OptimizingCompiler::RunOptimizations(HOptimization* optimizations[],
586 size_t length,
587 PassObserver* pass_observer) const {
Calin Juravle10e244f2015-01-26 18:54:32 +0000588 for (size_t i = 0; i < length; ++i) {
David Brazdil69ba7b72015-06-23 18:27:30 +0100589 PassScope scope(optimizations[i]->GetPassName(), pass_observer);
590 optimizations[i]->Run();
Calin Juravle10e244f2015-01-26 18:54:32 +0000591 }
592}
593
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700594void OptimizingCompiler::MaybeRunInliner(HGraph* graph,
595 CodeGenerator* codegen,
596 CompilerDriver* driver,
597 const DexCompilationUnit& dex_compilation_unit,
598 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700599 VariableSizedHandleScope* handles) const {
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700600 OptimizingCompilerStats* stats = compilation_stats_.get();
Calin Juravleec748352015-07-29 13:52:12 +0100601 const CompilerOptions& compiler_options = driver->GetCompilerOptions();
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000602 bool should_inline = (compiler_options.GetInlineMaxCodeUnits() > 0);
Calin Juravleec748352015-07-29 13:52:12 +0100603 if (!should_inline) {
604 return;
605 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000606 size_t number_of_dex_registers = dex_compilation_unit.GetCodeItem()->registers_size_;
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000607 HInliner* inliner = new (graph->GetArena()) HInliner(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700608 graph, // outer_graph
609 graph, // outermost_graph
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000610 codegen,
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700611 dex_compilation_unit, // outer_compilation_unit
612 dex_compilation_unit, // outermost_compilation_unit
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000613 driver,
614 handles,
615 stats,
616 number_of_dex_registers,
Nicolas Geoffrayf6d46682017-02-28 17:41:45 +0000617 /* total_number_of_instructions */ 0,
618 /* parent */ nullptr);
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000619 HOptimization* optimizations[] = { inliner };
Calin Juravleec748352015-07-29 13:52:12 +0100620
621 RunOptimizations(optimizations, arraysize(optimizations), pass_observer);
622}
623
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700624void OptimizingCompiler::RunArchOptimizations(InstructionSet instruction_set,
625 HGraph* graph,
626 CodeGenerator* codegen,
627 PassObserver* pass_observer) const {
Wojciech Staszkiewicze28c7d02016-08-17 19:15:51 -0700628 UNUSED(codegen); // To avoid compilation error when compiling for svelte
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700629 OptimizingCompilerStats* stats = compilation_stats_.get();
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100630 ArenaAllocator* arena = graph->GetArena();
631 switch (instruction_set) {
Artem Serov2bbc9532016-10-21 11:51:50 +0100632#if defined(ART_ENABLE_CODEGEN_arm)
Vladimir Markob4536b72015-11-24 13:45:23 +0000633 case kThumb2:
634 case kArm: {
Artem Udovichenko4a0dad62016-01-26 12:28:31 +0300635 arm::InstructionSimplifierArm* simplifier =
636 new (arena) arm::InstructionSimplifierArm(graph, stats);
Artem Serov328429f2016-07-06 16:23:04 +0100637 SideEffectsAnalysis* side_effects = new (arena) SideEffectsAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700638 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects, "GVN$after_arch");
xueliang.zhongf7caf682017-03-01 16:07:02 +0000639 HInstructionScheduling* scheduling =
640 new (arena) HInstructionScheduling(graph, instruction_set, codegen);
Vladimir Markob4536b72015-11-24 13:45:23 +0000641 HOptimization* arm_optimizations[] = {
Artem Udovichenko4a0dad62016-01-26 12:28:31 +0300642 simplifier,
Artem Serov328429f2016-07-06 16:23:04 +0100643 side_effects,
644 gvn,
xueliang.zhongf7caf682017-03-01 16:07:02 +0000645 scheduling,
Vladimir Markob4536b72015-11-24 13:45:23 +0000646 };
647 RunOptimizations(arm_optimizations, arraysize(arm_optimizations), pass_observer);
648 break;
649 }
650#endif
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100651#ifdef ART_ENABLE_CODEGEN_arm64
652 case kArm64: {
653 arm64::InstructionSimplifierArm64* simplifier =
654 new (arena) arm64::InstructionSimplifierArm64(graph, stats);
655 SideEffectsAnalysis* side_effects = new (arena) SideEffectsAnalysis(graph);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700656 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects, "GVN$after_arch");
Alexandre Rames22aa54b2016-10-18 09:32:29 +0100657 HInstructionScheduling* scheduling =
658 new (arena) HInstructionScheduling(graph, instruction_set);
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100659 HOptimization* arm64_optimizations[] = {
660 simplifier,
661 side_effects,
Alexandre Rames22aa54b2016-10-18 09:32:29 +0100662 gvn,
663 scheduling,
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100664 };
665 RunOptimizations(arm64_optimizations, arraysize(arm64_optimizations), pass_observer);
666 break;
667 }
668#endif
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700669#ifdef ART_ENABLE_CODEGEN_mips
670 case kMips: {
671 mips::PcRelativeFixups* pc_relative_fixups =
672 new (arena) mips::PcRelativeFixups(graph, codegen, stats);
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700673 HOptimization* mips_optimizations[] = {
674 pc_relative_fixups,
Alexey Frunzee3fb2452016-05-10 16:08:05 -0700675 };
676 RunOptimizations(mips_optimizations, arraysize(mips_optimizations), pass_observer);
677 break;
678 }
679#endif
Mark Mendell0616ae02015-04-17 12:49:27 -0400680#ifdef ART_ENABLE_CODEGEN_x86
681 case kX86: {
Aart Bikd1c40452016-03-02 16:06:13 -0800682 x86::PcRelativeFixups* pc_relative_fixups =
683 new (arena) x86::PcRelativeFixups(graph, codegen, stats);
Mark Mendellee8d9712016-07-12 11:13:15 -0400684 x86::X86MemoryOperandGeneration* memory_gen =
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700685 new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Mark Mendell0616ae02015-04-17 12:49:27 -0400686 HOptimization* x86_optimizations[] = {
Mark Mendellee8d9712016-07-12 11:13:15 -0400687 pc_relative_fixups,
688 memory_gen
Mark Mendell0616ae02015-04-17 12:49:27 -0400689 };
690 RunOptimizations(x86_optimizations, arraysize(x86_optimizations), pass_observer);
691 break;
692 }
693#endif
Mark Mendellee8d9712016-07-12 11:13:15 -0400694#ifdef ART_ENABLE_CODEGEN_x86_64
695 case kX86_64: {
696 x86::X86MemoryOperandGeneration* memory_gen =
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700697 new (arena) x86::X86MemoryOperandGeneration(graph, codegen, stats);
Mark Mendellee8d9712016-07-12 11:13:15 -0400698 HOptimization* x86_64_optimizations[] = {
699 memory_gen
700 };
701 RunOptimizations(x86_64_optimizations, arraysize(x86_64_optimizations), pass_observer);
702 break;
703 }
704#endif
Alexandre Rames44b9cf92015-08-19 15:39:06 +0100705 default:
706 break;
707 }
708}
709
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000710NO_INLINE // Avoid increasing caller's frame size by large stack-allocated objects.
711static void AllocateRegisters(HGraph* graph,
712 CodeGenerator* codegen,
Matthew Gharrity2cd05b72016-08-03 16:57:37 -0700713 PassObserver* pass_observer,
Igor Murashkin6ef45672017-08-08 13:59:55 -0700714 RegisterAllocator::Strategy strategy,
715 OptimizingCompilerStats* stats) {
Mingyao Yang700347e2016-03-02 14:59:32 -0800716 {
717 PassScope scope(PrepareForRegisterAllocation::kPrepareForRegisterAllocationPassName,
718 pass_observer);
Igor Murashkin6ef45672017-08-08 13:59:55 -0700719 PrepareForRegisterAllocation(graph, stats).Run();
Mingyao Yang700347e2016-03-02 14:59:32 -0800720 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000721 SsaLivenessAnalysis liveness(graph, codegen);
722 {
723 PassScope scope(SsaLivenessAnalysis::kLivenessPassName, pass_observer);
724 liveness.Analyze();
725 }
726 {
727 PassScope scope(RegisterAllocator::kRegisterAllocatorPassName, pass_observer);
Matthew Gharrity2cd05b72016-08-03 16:57:37 -0700728 RegisterAllocator::Create(graph->GetArena(), codegen, liveness, strategy)->AllocateRegisters();
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000729 }
730}
731
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700732void OptimizingCompiler::RunOptimizations(HGraph* graph,
733 CodeGenerator* codegen,
734 CompilerDriver* driver,
735 const DexCompilationUnit& dex_compilation_unit,
736 PassObserver* pass_observer,
Mathieu Chartiere8a3c572016-10-11 16:52:17 -0700737 VariableSizedHandleScope* handles) const {
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700738 OptimizingCompilerStats* stats = compilation_stats_.get();
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100739 ArenaAllocator* arena = graph->GetArena();
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700740 if (driver->GetCompilerOptions().GetPassesToRun() != nullptr) {
741 ArenaVector<HOptimization*> optimizations = BuildOptimizations(
742 *driver->GetCompilerOptions().GetPassesToRun(),
743 arena,
744 graph,
745 stats,
746 codegen,
747 driver,
748 dex_compilation_unit,
749 handles);
750 RunOptimizations(&optimizations[0], optimizations.size(), pass_observer);
751 return;
752 }
753
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100754 HDeadCodeElimination* dce1 = new (arena) HDeadCodeElimination(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700755 graph, stats, "dead_code_elimination$initial");
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100756 HDeadCodeElimination* dce2 = new (arena) HDeadCodeElimination(
Aart Bik2767f4b2016-10-28 15:03:53 -0700757 graph, stats, "dead_code_elimination$after_inlining");
758 HDeadCodeElimination* dce3 = new (arena) HDeadCodeElimination(
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700759 graph, stats, "dead_code_elimination$final");
Andreas Gampeca620d72016-11-08 08:09:33 -0800760 HConstantFolding* fold1 = new (arena) HConstantFolding(graph, "constant_folding");
Vladimir Marko65979462017-05-19 17:25:12 +0100761 InstructionSimplifier* simplify1 = new (arena) InstructionSimplifier(
762 graph, codegen, driver, stats);
Jean-Philippe Halimi38e9e802016-02-18 16:42:03 +0100763 HSelectGenerator* select_generator = new (arena) HSelectGenerator(graph, stats);
Wojciech Staszkiewicz5319d3c2016-08-01 17:48:59 -0700764 HConstantFolding* fold2 = new (arena) HConstantFolding(
765 graph, "constant_folding$after_inlining");
766 HConstantFolding* fold3 = new (arena) HConstantFolding(graph, "constant_folding$after_bce");
Aart Bik92685a82017-03-06 11:13:43 -0800767 SideEffectsAnalysis* side_effects1 = new (arena) SideEffectsAnalysis(
768 graph, "side_effects$before_gvn");
769 SideEffectsAnalysis* side_effects2 = new (arena) SideEffectsAnalysis(
770 graph, "side_effects$before_lse");
771 GVNOptimization* gvn = new (arena) GVNOptimization(graph, *side_effects1);
772 LICM* licm = new (arena) LICM(graph, *side_effects1, stats);
Aart Bik22af3be2015-09-10 12:50:58 -0700773 HInductionVarAnalysis* induction = new (arena) HInductionVarAnalysis(graph);
Aart Bik92685a82017-03-06 11:13:43 -0800774 BoundsCheckElimination* bce = new (arena) BoundsCheckElimination(graph, *side_effects1, induction);
775 HLoopOptimization* loop = new (arena) HLoopOptimization(graph, driver, induction);
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100776 LoadStoreAnalysis* lsa = new (arena) LoadStoreAnalysis(graph);
Igor Murashkin1e065a52017-08-09 13:20:34 -0700777 LoadStoreElimination* lse = new (arena) LoadStoreElimination(graph, *side_effects2, *lsa, stats);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000778 HSharpening* sharpening = new (arena) HSharpening(
779 graph, codegen, dex_compilation_unit, driver, handles);
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100780 InstructionSimplifier* simplify2 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100781 graph, codegen, driver, stats, "instruction_simplifier$after_inlining");
David Brazdil4833f5a2015-12-16 10:37:39 +0000782 InstructionSimplifier* simplify3 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100783 graph, codegen, driver, stats, "instruction_simplifier$after_bce");
Aart Bik639cc8c2016-10-18 13:03:31 -0700784 InstructionSimplifier* simplify4 = new (arena) InstructionSimplifier(
Vladimir Marko65979462017-05-19 17:25:12 +0100785 graph, codegen, driver, stats, "instruction_simplifier$before_codegen");
Nicolas Geoffray762869d2016-07-15 15:28:35 +0100786 IntrinsicsRecognizer* intrinsics = new (arena) IntrinsicsRecognizer(graph, stats);
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800787 CHAGuardOptimization* cha_guard = new (arena) CHAGuardOptimization(graph);
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000788 CodeSinking* code_sinking = new (arena) CodeSinking(graph, stats);
Andreas Gampe71fb52f2014-12-29 17:43:08 -0800789
Calin Juravleec748352015-07-29 13:52:12 +0100790 HOptimization* optimizations1[] = {
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100791 intrinsics,
David Brazdil4833f5a2015-12-16 10:37:39 +0000792 sharpening,
Vladimir Markoa3a3c592015-06-12 14:30:53 +0100793 fold1,
794 simplify1,
Nicolas Geoffray18e68732015-06-17 23:09:05 +0100795 dce1,
Calin Juravleec748352015-07-29 13:52:12 +0100796 };
Calin Juravleec748352015-07-29 13:52:12 +0100797 RunOptimizations(optimizations1, arraysize(optimizations1), pass_observer);
798
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700799 MaybeRunInliner(graph, codegen, driver, dex_compilation_unit, pass_observer, handles);
David Brazdil95177982015-10-30 12:56:58 -0500800
David Brazdil8993caf2015-12-07 10:04:40 +0000801 HOptimization* optimizations2[] = {
David Brazdil74eb1b22015-12-14 11:44:01 +0000802 // SelectGenerator depends on the InstructionSimplifier removing
David Brazdil8993caf2015-12-07 10:04:40 +0000803 // redundant suspend checks to recognize empty blocks.
David Brazdil74eb1b22015-12-14 11:44:01 +0000804 select_generator,
David Brazdil8993caf2015-12-07 10:04:40 +0000805 fold2, // TODO: if we don't inline we can also skip fold2.
Aart Bik639cc8c2016-10-18 13:03:31 -0700806 simplify2,
Aart Bik2767f4b2016-10-28 15:03:53 -0700807 dce2,
Aart Bik92685a82017-03-06 11:13:43 -0800808 side_effects1,
David Brazdil8993caf2015-12-07 10:04:40 +0000809 gvn,
810 licm,
811 induction,
812 bce,
Aart Bik281c6812016-08-26 11:31:48 -0700813 loop,
David Brazdil8993caf2015-12-07 10:04:40 +0000814 fold3, // evaluates code generated by dynamic bce
Aart Bik639cc8c2016-10-18 13:03:31 -0700815 simplify3,
Aart Bik92685a82017-03-06 11:13:43 -0800816 side_effects2,
xueliang.zhongc239a2b2017-04-27 15:31:37 +0100817 lsa,
David Brazdil8993caf2015-12-07 10:04:40 +0000818 lse,
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800819 cha_guard,
Aart Bik2767f4b2016-10-28 15:03:53 -0700820 dce3,
Nicolas Geoffrayb813ca12017-02-16 22:08:29 +0000821 code_sinking,
David Brazdil8993caf2015-12-07 10:04:40 +0000822 // The codegen has a few assumptions that only the instruction simplifier
823 // can satisfy. For example, the code generator does not expect to see a
824 // HTypeConversion from a type to the same type.
Aart Bik639cc8c2016-10-18 13:03:31 -0700825 simplify4,
David Brazdil8993caf2015-12-07 10:04:40 +0000826 };
827 RunOptimizations(optimizations2, arraysize(optimizations2), pass_observer);
David Brazdilbbd733e2015-08-18 17:48:17 +0100828
Wojciech Staszkiewiczf5fb0902016-07-22 13:33:11 -0700829 RunArchOptimizations(driver->GetInstructionSet(), graph, codegen, pass_observer);
Nicolas Geoffray5e6916c2014-11-18 16:53:35 +0000830}
831
Vladimir Marko58155012015-08-19 12:49:41 +0000832static ArenaVector<LinkerPatch> EmitAndSortLinkerPatches(CodeGenerator* codegen) {
833 ArenaVector<LinkerPatch> linker_patches(codegen->GetGraph()->GetArena()->Adapter());
834 codegen->EmitLinkerPatches(&linker_patches);
835
836 // Sort patches by literal offset. Required for .oat_patches encoding.
837 std::sort(linker_patches.begin(), linker_patches.end(),
838 [](const LinkerPatch& lhs, const LinkerPatch& rhs) {
839 return lhs.LiteralOffset() < rhs.LiteralOffset();
840 });
841
842 return linker_patches;
843}
844
David Brazdil58282f42016-01-14 12:45:10 +0000845CompiledMethod* OptimizingCompiler::Emit(ArenaAllocator* arena,
846 CodeVectorAllocator* code_allocator,
847 CodeGenerator* codegen,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000848 CompilerDriver* compiler_driver,
849 const DexFile::CodeItem* code_item) const {
Vladimir Marko58155012015-08-19 12:49:41 +0000850 ArenaVector<LinkerPatch> linker_patches = EmitAndSortLinkerPatches(codegen);
Vladimir Markof9f64412015-09-02 14:05:49 +0100851 ArenaVector<uint8_t> stack_map(arena->Adapter(kArenaAllocStackMaps));
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -0700852 ArenaVector<uint8_t> method_info(arena->Adapter(kArenaAllocStackMaps));
853 size_t stack_map_size = 0;
854 size_t method_info_size = 0;
855 codegen->ComputeStackMapAndMethodInfoSize(&stack_map_size, &method_info_size);
856 stack_map.resize(stack_map_size);
857 method_info.resize(method_info_size);
858 codegen->BuildStackMaps(MemoryRegion(stack_map.data(), stack_map.size()),
859 MemoryRegion(method_info.data(), method_info.size()),
860 *code_item);
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000861
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100862 CompiledMethod* compiled_method = CompiledMethod::SwapAllocCompiledMethod(
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000863 compiler_driver,
864 codegen->GetInstructionSet(),
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000865 ArrayRef<const uint8_t>(code_allocator->GetMemory()),
Roland Levillainaa9b7c42015-02-17 15:40:09 +0000866 // Follow Quick's behavior and set the frame size to zero if it is
867 // considered "empty" (see the definition of
868 // art::CodeGenerator::HasEmptyFrame).
869 codegen->HasEmptyFrame() ? 0 : codegen->GetFrameSize(),
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000870 codegen->GetCoreSpillMask(),
Nicolas Geoffrayd97dc402015-01-22 13:50:01 +0000871 codegen->GetFpuSpillMask(),
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -0700872 ArrayRef<const uint8_t>(method_info),
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100873 ArrayRef<const uint8_t>(stack_map),
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100874 ArrayRef<const uint8_t>(*codegen->GetAssembler()->cfi().data()),
Vladimir Marko58155012015-08-19 12:49:41 +0000875 ArrayRef<const LinkerPatch>(linker_patches));
Mathieu Chartiered150002015-08-28 11:16:54 -0700876
Alexandre Rameseb7b7392015-06-19 14:47:01 +0100877 return compiled_method;
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000878}
879
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000880CodeGenerator* OptimizingCompiler::TryCompile(ArenaAllocator* arena,
881 CodeVectorAllocator* code_allocator,
882 const DexFile::CodeItem* code_item,
883 uint32_t access_flags,
884 InvokeType invoke_type,
885 uint16_t class_def_idx,
886 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000887 Handle<mirror::ClassLoader> class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000888 const DexFile& dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000889 Handle<mirror::DexCache> dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000890 ArtMethod* method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000891 bool osr,
892 VariableSizedHandleScope* handles) const {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700893 MaybeRecordStat(compilation_stats_.get(),
894 MethodCompilationStat::kAttemptCompilation);
Calin Juravlecd6dffe2015-01-08 17:35:35 +0000895 CompilerDriver* compiler_driver = GetCompilerDriver();
896 InstructionSet instruction_set = compiler_driver->GetInstructionSet();
Calin Juravlecff8cc72015-10-09 12:03:24 +0100897
Roland Levillain3b359c72015-11-17 19:35:12 +0000898 // Always use the Thumb-2 assembler: some runtime functionality
899 // (like implicit stack overflow checks) assume Thumb-2.
Artem Serovba6b6792016-08-15 14:22:07 +0100900 DCHECK_NE(instruction_set, kArm);
Nicolas Geoffray8fb5ce32014-07-04 09:43:26 +0100901
902 // Do not attempt to compile on architectures we do not support.
Nicolas Geoffray1ba0f592014-10-27 15:14:55 +0000903 if (!IsInstructionSetSupported(instruction_set)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700904 MaybeRecordStat(compilation_stats_.get(),
905 MethodCompilationStat::kNotCompiledUnsupportedIsa);
Nicolas Geoffray8fb5ce32014-07-04 09:43:26 +0100906 return nullptr;
907 }
908
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +0000909 if (Compiler::IsPathologicalCase(*code_item, method_idx, dex_file)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700910 MaybeRecordStat(compilation_stats_.get(),
911 MethodCompilationStat::kNotCompiledPathological);
Nicolas Geoffrayb5f62b32014-10-30 10:58:41 +0000912 return nullptr;
913 }
914
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000915 // Implementation of the space filter: do not compile a code item whose size in
Nicolas Geoffray432bf3d2015-07-17 11:11:09 +0100916 // code units is bigger than 128.
917 static constexpr size_t kSpaceFilterOptimizingThreshold = 128;
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000918 const CompilerOptions& compiler_options = compiler_driver->GetCompilerOptions();
Andreas Gampe29d38e72016-03-23 15:31:51 +0000919 if ((compiler_options.GetCompilerFilter() == CompilerFilter::kSpace)
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000920 && (code_item->insns_size_in_code_units_ > kSpaceFilterOptimizingThreshold)) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700921 MaybeRecordStat(compilation_stats_.get(),
922 MethodCompilationStat::kNotCompiledSpaceFilter);
Nicolas Geoffray36540cb2015-03-23 14:45:53 +0000923 return nullptr;
924 }
925
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100926 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000927 DexCompilationUnit dex_compilation_unit(
Vladimir Markodf739842016-03-23 16:59:07 +0000928 class_loader,
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100929 class_linker,
Vladimir Markodf739842016-03-23 16:59:07 +0000930 dex_file,
931 code_item,
932 class_def_idx,
933 method_idx,
934 access_flags,
935 /* verified_method */ nullptr,
936 dex_cache);
Nicolas Geoffray92cf83e2014-03-18 17:59:20 +0000937
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +0000938 HGraph* graph = new (arena) HGraph(
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000939 arena,
940 dex_file,
941 method_idx,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +0000942 compiler_driver->GetInstructionSet(),
943 kInvalidInvokeType,
944 compiler_driver->GetCompilerOptions().GetDebuggable(),
945 osr);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000946
David Brazdilbadd8262016-02-02 16:28:56 +0000947 const uint8_t* interpreter_metadata = nullptr;
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000948 if (method == nullptr) {
David Brazdilbadd8262016-02-02 16:28:56 +0000949 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000950 method = compiler_driver->ResolveMethod(
Vladimir Marko8d6768d2017-03-14 10:13:21 +0000951 soa, dex_cache, class_loader, &dex_compilation_unit, method_idx, invoke_type);
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +0000952 }
953 // For AOT compilation, we may not get a method, for example if its class is erroneous.
954 // JIT should always have a method.
955 DCHECK(Runtime::Current()->IsAotCompiler() || method != nullptr);
956 if (method != nullptr) {
957 graph->SetArtMethod(method);
958 ScopedObjectAccess soa(Thread::Current());
Vladimir Marko97d7e1c2016-10-04 14:44:28 +0100959 interpreter_metadata = method->GetQuickenedInfo(class_linker->GetImagePointerSize());
David Brazdilbadd8262016-02-02 16:28:56 +0000960 }
961
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000962 std::unique_ptr<CodeGenerator> codegen(
Calin Juravlecd6dffe2015-01-08 17:35:35 +0000963 CodeGenerator::Create(graph,
964 instruction_set,
965 *compiler_driver->GetInstructionSetFeatures(),
Calin Juravle2ae48182016-03-16 14:05:09 +0000966 compiler_driver->GetCompilerOptions(),
967 compilation_stats_.get()));
Nicolas Geoffray12df9eb2015-01-09 14:53:50 +0000968 if (codegen.get() == nullptr) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700969 MaybeRecordStat(compilation_stats_.get(),
970 MethodCompilationStat::kNotCompiledNoCodegen);
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000971 return nullptr;
972 }
David Srbeckyc6b4dd82015-04-07 20:32:43 +0100973 codegen->GetAssembler()->cfi().SetEnabled(
David Srbecky5b1c2ca2016-01-25 17:32:41 +0000974 compiler_driver->GetCompilerOptions().GenerateAnyDebugInfo());
Nicolas Geoffray787c3072014-03-17 10:20:19 +0000975
David Brazdil69ba7b72015-06-23 18:27:30 +0100976 PassObserver pass_observer(graph,
David Brazdil69ba7b72015-06-23 18:27:30 +0100977 codegen.get(),
978 visualizer_output_.get(),
Andreas Gampea0d81af2016-10-27 12:04:57 -0700979 compiler_driver,
980 dump_mutex_);
David Brazdil5e8b1372015-01-23 14:39:08 +0000981
David Brazdil809658e2015-02-05 11:34:02 +0000982 {
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000983 VLOG(compiler) << "Building " << pass_observer.GetMethodName();
984 PassScope scope(HGraphBuilder::kBuilderPassName, &pass_observer);
985 HGraphBuilder builder(graph,
986 &dex_compilation_unit,
987 &dex_compilation_unit,
988 &dex_file,
989 *code_item,
990 compiler_driver,
Nicolas Geoffray83c8e272017-01-31 14:36:37 +0000991 codegen.get(),
Nicolas Geoffray22384ae2016-12-12 22:33:36 +0000992 compilation_stats_.get(),
993 interpreter_metadata,
994 dex_cache,
995 handles);
996 GraphAnalysisResult result = builder.BuildGraph();
997 if (result != kAnalysisSuccess) {
998 switch (result) {
Igor Murashkin1e065a52017-08-09 13:20:34 -0700999 case kAnalysisSkipped: {
1000 MaybeRecordStat(compilation_stats_.get(),
1001 MethodCompilationStat::kNotCompiledSkipped);
1002 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001003 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001004 case kAnalysisInvalidBytecode: {
1005 MaybeRecordStat(compilation_stats_.get(),
1006 MethodCompilationStat::kNotCompiledInvalidBytecode);
1007 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001008 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001009 case kAnalysisFailThrowCatchLoop: {
1010 MaybeRecordStat(compilation_stats_.get(),
1011 MethodCompilationStat::kNotCompiledThrowCatchLoop);
1012 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001013 break;
Igor Murashkin1e065a52017-08-09 13:20:34 -07001014 case kAnalysisFailAmbiguousArrayOp: {
1015 MaybeRecordStat(compilation_stats_.get(),
1016 MethodCompilationStat::kNotCompiledAmbiguousArrayOp);
1017 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001018 break;
1019 case kAnalysisSuccess:
1020 UNREACHABLE();
David Brazdil809658e2015-02-05 11:34:02 +00001021 }
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001022 pass_observer.SetGraphInBadState();
1023 return nullptr;
Nicolas Geoffrayf5370122014-12-02 11:51:19 +00001024 }
David Brazdilbadd8262016-02-02 16:28:56 +00001025 }
Vladimir Markof9f64412015-09-02 14:05:49 +01001026
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001027 RunOptimizations(graph,
1028 codegen.get(),
1029 compiler_driver,
1030 dex_compilation_unit,
1031 &pass_observer,
1032 handles);
1033
1034 RegisterAllocator::Strategy regalloc_strategy =
1035 compiler_options.GetRegisterAllocationStrategy();
Igor Murashkin1e065a52017-08-09 13:20:34 -07001036 AllocateRegisters(graph,
1037 codegen.get(),
1038 &pass_observer,
Igor Murashkin6ef45672017-08-08 13:59:55 -07001039 regalloc_strategy,
1040 compilation_stats_.get());
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001041
1042 codegen->Compile(code_allocator);
1043 pass_observer.DumpDisassembly();
1044
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001045 return codegen.release();
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001046}
1047
Nicolas Geoffray216eaa22015-03-17 17:09:30 +00001048CompiledMethod* OptimizingCompiler::Compile(const DexFile::CodeItem* code_item,
1049 uint32_t access_flags,
1050 InvokeType invoke_type,
1051 uint16_t class_def_idx,
1052 uint32_t method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001053 Handle<mirror::ClassLoader> jclass_loader,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001054 const DexFile& dex_file,
1055 Handle<mirror::DexCache> dex_cache) const {
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001056 CompilerDriver* compiler_driver = GetCompilerDriver();
1057 CompiledMethod* method = nullptr;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001058 DCHECK(Runtime::Current()->IsAotCompiler());
1059 const VerifiedMethod* verified_method = compiler_driver->GetVerifiedMethod(&dex_file, method_idx);
1060 DCHECK(!verified_method->HasRuntimeThrow());
1061 if (compiler_driver->IsMethodVerifiedWithoutFailures(method_idx, class_def_idx, dex_file)
Andreas Gampe6d7abbd2017-04-24 13:19:09 -07001062 || verifier::CanCompilerHandleVerificationFailure(
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001063 verified_method->GetEncounteredVerificationFailures())) {
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001064 ArenaAllocator arena(Runtime::Current()->GetArenaPool());
1065 CodeVectorAllocator code_allocator(&arena);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001066 std::unique_ptr<CodeGenerator> codegen;
1067 {
1068 ScopedObjectAccess soa(Thread::Current());
1069 VariableSizedHandleScope handles(soa.Self());
1070 // Go to native so that we don't block GC during compilation.
1071 ScopedThreadSuspension sts(soa.Self(), kNative);
1072 codegen.reset(
1073 TryCompile(&arena,
1074 &code_allocator,
1075 code_item,
1076 access_flags,
1077 invoke_type,
1078 class_def_idx,
1079 method_idx,
1080 jclass_loader,
1081 dex_file,
1082 dex_cache,
1083 nullptr,
1084 /* osr */ false,
1085 &handles));
1086 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001087 if (codegen.get() != nullptr) {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001088 MaybeRecordStat(compilation_stats_.get(),
1089 MethodCompilationStat::kCompiled);
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001090 method = Emit(&arena, &code_allocator, codegen.get(), compiler_driver, code_item);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001091
1092 if (kArenaAllocatorCountAllocations) {
1093 if (arena.BytesAllocated() > kArenaAllocatorMemoryReportThreshold) {
1094 MemStats mem_stats(arena.GetMemStats());
David Sehr709b0702016-10-13 09:12:37 -07001095 LOG(INFO) << dex_file.PrettyMethod(method_idx) << " " << Dumpable<MemStats>(mem_stats);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001096 }
1097 }
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001098 }
Nicolas Geoffray0c3c2662015-10-15 13:53:04 +01001099 } else {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001100 MethodCompilationStat method_stat;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001101 if (compiler_driver->GetCompilerOptions().VerifyAtRuntime()) {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001102 method_stat = MethodCompilationStat::kNotCompiledVerifyAtRuntime;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001103 } else {
Igor Murashkin1e065a52017-08-09 13:20:34 -07001104 method_stat = MethodCompilationStat::kNotCompiledVerificationError;
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001105 }
Igor Murashkin1e065a52017-08-09 13:20:34 -07001106 MaybeRecordStat(compilation_stats_.get(), method_stat);
Calin Juravlef1c6d9e2015-04-13 18:42:21 +01001107 }
1108
Calin Juravlecff8cc72015-10-09 12:03:24 +01001109 if (kIsDebugBuild &&
1110 IsCompilingWithCoreImage() &&
Goran Jakovljevic9c4f0d8f2017-04-05 16:27:25 +02001111 IsInstructionSetSupported(compiler_driver->GetInstructionSet())) {
Roland Levillain0d5a2812015-11-13 10:07:31 +00001112 // For testing purposes, we put a special marker on method names
Goran Jakovljevic9c4f0d8f2017-04-05 16:27:25 +02001113 // that should be compiled with this compiler (when the
1114 // instruction set is supported). This makes sure we're not
Roland Levillain0d5a2812015-11-13 10:07:31 +00001115 // regressing.
David Sehr709b0702016-10-13 09:12:37 -07001116 std::string method_name = dex_file.PrettyMethod(method_idx);
Calin Juravle09b1d6f2015-10-07 12:08:54 +01001117 bool shouldCompile = method_name.find("$opt$") != std::string::npos;
1118 DCHECK((method != nullptr) || !shouldCompile) << "Didn't compile " << method_name;
1119 }
1120
Nicolas Geoffray12be74e2015-03-30 13:29:08 +01001121 return method;
Nicolas Geoffray216eaa22015-03-17 17:09:30 +00001122}
1123
Andreas Gampe53c913b2014-08-12 23:19:23 -07001124Compiler* CreateOptimizingCompiler(CompilerDriver* driver) {
1125 return new OptimizingCompiler(driver);
1126}
1127
Nicolas Geoffray335005e2015-06-25 10:01:47 +01001128bool IsCompilingWithCoreImage() {
1129 const std::string& image = Runtime::Current()->GetImageLocation();
Jeff Haodcdc85b2015-12-04 14:06:18 -08001130 // TODO: This is under-approximating...
Andreas Gampe9186ced2016-12-12 14:28:21 -08001131 if (android::base::EndsWith(image, "core.art") ||
1132 android::base::EndsWith(image, "core-optimizing.art")) {
Jeff Haodcdc85b2015-12-04 14:06:18 -08001133 return true;
1134 }
1135 return false;
Nicolas Geoffray335005e2015-06-25 10:01:47 +01001136}
1137
Nicolas Geoffrayfbdfa6d2017-02-03 10:43:13 +00001138bool EncodeArtMethodInInlineInfo(ArtMethod* method ATTRIBUTE_UNUSED) {
1139 // Note: the runtime is null only for unit testing.
1140 return Runtime::Current() == nullptr || !Runtime::Current()->IsAotCompiler();
1141}
1142
1143bool CanEncodeInlinedMethodInStackMap(const DexFile& caller_dex_file, ArtMethod* callee) {
1144 if (!Runtime::Current()->IsAotCompiler()) {
1145 // JIT can always encode methods in stack maps.
1146 return true;
1147 }
1148 if (IsSameDexFile(caller_dex_file, *callee->GetDexFile())) {
1149 return true;
1150 }
1151 // TODO(ngeoffray): Support more AOT cases for inlining:
1152 // - methods in multidex
1153 // - methods in boot image for on-device non-PIC compilation.
1154 return false;
1155}
1156
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001157bool OptimizingCompiler::JitCompile(Thread* self,
1158 jit::JitCodeCache* code_cache,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001159 ArtMethod* method,
Nicolas Geoffray01db5f72017-07-19 15:05:49 +01001160 bool osr,
1161 jit::JitLogger* jit_logger) {
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001162 StackHandleScope<3> hs(self);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001163 Handle<mirror::ClassLoader> class_loader(hs.NewHandle(
1164 method->GetDeclaringClass()->GetClassLoader()));
1165 Handle<mirror::DexCache> dex_cache(hs.NewHandle(method->GetDexCache()));
Nicolas Geoffray250a3782016-04-20 16:27:53 +01001166 DCHECK(method->IsCompilable());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001167
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001168 const DexFile* dex_file = method->GetDexFile();
1169 const uint16_t class_def_idx = method->GetClassDefIndex();
1170 const DexFile::CodeItem* code_item = dex_file->GetCodeItem(method->GetCodeItemOffset());
1171 const uint32_t method_idx = method->GetDexMethodIndex();
1172 const uint32_t access_flags = method->GetAccessFlags();
1173 const InvokeType invoke_type = method->GetInvokeType();
1174
Nicolas Geoffray25e04562016-03-01 13:17:58 +00001175 ArenaAllocator arena(Runtime::Current()->GetJitArenaPool());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001176 CodeVectorAllocator code_allocator(&arena);
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001177 VariableSizedHandleScope handles(self);
1178
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001179 std::unique_ptr<CodeGenerator> codegen;
1180 {
1181 // Go to native so that we don't block GC during compilation.
1182 ScopedThreadSuspension sts(self, kNative);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001183 codegen.reset(
1184 TryCompile(&arena,
1185 &code_allocator,
1186 code_item,
1187 access_flags,
1188 invoke_type,
1189 class_def_idx,
1190 method_idx,
Vladimir Marko8d6768d2017-03-14 10:13:21 +00001191 class_loader,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001192 *dex_file,
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001193 dex_cache,
Nicolas Geoffray3aaf9642016-06-07 14:14:37 +00001194 method,
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001195 osr,
1196 &handles));
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001197 if (codegen.get() == nullptr) {
1198 return false;
1199 }
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001200
1201 if (kArenaAllocatorCountAllocations) {
1202 if (arena.BytesAllocated() > kArenaAllocatorMemoryReportThreshold) {
1203 MemStats mem_stats(arena.GetMemStats());
David Sehr709b0702016-10-13 09:12:37 -07001204 LOG(INFO) << dex_file->PrettyMethod(method_idx) << " " << Dumpable<MemStats>(mem_stats);
Vladimir Marko3a40bf22016-03-22 16:26:33 +00001205 }
1206 }
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001207 }
1208
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001209 size_t stack_map_size = 0;
1210 size_t method_info_size = 0;
1211 codegen->ComputeStackMapAndMethodInfoSize(&stack_map_size, &method_info_size);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001212 size_t number_of_roots = codegen->GetNumberOfJitRoots();
1213 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1214 // We allocate an object array to ensure the JIT roots that we will collect in EmitJitRoots
1215 // will be visible by the GC between EmitLiterals and CommitCode. Once CommitCode is
1216 // executed, this array is not needed.
1217 Handle<mirror::ObjectArray<mirror::Object>> roots(
1218 hs.NewHandle(mirror::ObjectArray<mirror::Object>::Alloc(
1219 self, class_linker->GetClassRoot(ClassLinker::kObjectArrayClass), number_of_roots)));
Andreas Gampefa4333d2017-02-14 11:10:34 -08001220 if (roots == nullptr) {
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001221 // Out of memory, just clear the exception to avoid any Java exception uncaught problems.
1222 DCHECK(self->IsExceptionPending());
1223 self->ClearException();
1224 return false;
1225 }
1226 uint8_t* stack_map_data = nullptr;
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001227 uint8_t* method_info_data = nullptr;
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001228 uint8_t* roots_data = nullptr;
Orion Hodson56fe32e2017-07-21 11:42:10 +01001229 code_cache->ReserveData(self,
1230 stack_map_size,
1231 method_info_size,
1232 number_of_roots,
1233 method,
1234 &stack_map_data,
1235 &method_info_data,
1236 &roots_data);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001237 if (stack_map_data == nullptr || roots_data == nullptr) {
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001238 return false;
1239 }
Igor Murashkin1e065a52017-08-09 13:20:34 -07001240 MaybeRecordStat(compilation_stats_.get(), MethodCompilationStat::kCompiled);
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001241 codegen->BuildStackMaps(MemoryRegion(stack_map_data, stack_map_size),
1242 MemoryRegion(method_info_data, method_info_size),
1243 *code_item);
Nicolas Geoffrayf0acfe72017-01-09 20:54:52 +00001244 codegen->EmitJitRoots(code_allocator.GetData(), roots, roots_data);
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001245
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001246 const void* code = code_cache->CommitCode(
1247 self,
1248 method,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001249 stack_map_data,
Mathieu Chartiercbcedbf2017-03-12 22:24:50 -07001250 method_info_data,
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001251 roots_data,
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001252 codegen->HasEmptyFrame() ? 0 : codegen->GetFrameSize(),
1253 codegen->GetCoreSpillMask(),
1254 codegen->GetFpuSpillMask(),
1255 code_allocator.GetMemory().data(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001256 code_allocator.GetSize(),
Nicolas Geoffray132d8362016-11-16 09:19:42 +00001257 osr,
Mingyao Yang063fc772016-08-02 11:02:54 -07001258 roots,
1259 codegen->GetGraph()->HasShouldDeoptimizeFlag(),
1260 codegen->GetGraph()->GetCHASingleImplementationList());
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001261
1262 if (code == nullptr) {
Nicolas Geoffrayf46501c2016-11-22 13:45:36 +00001263 code_cache->ClearData(self, stack_map_data, roots_data);
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001264 return false;
1265 }
1266
David Srbecky91cc06c2016-03-07 16:13:58 +00001267 const CompilerOptions& compiler_options = GetCompilerDriver()->GetCompilerOptions();
1268 if (compiler_options.GetGenerateDebugInfo()) {
David Srbecky5cc349f2015-12-18 15:04:48 +00001269 const auto* method_header = reinterpret_cast<const OatQuickMethodHeader*>(code);
1270 const uintptr_t code_address = reinterpret_cast<uintptr_t>(method_header->GetCode());
David Srbecky09c2a6b2016-03-11 17:11:44 +00001271 debug::MethodDebugInfo info = debug::MethodDebugInfo();
1272 info.trampoline_name = nullptr;
David Srbecky197160d2016-03-07 17:33:57 +00001273 info.dex_file = dex_file;
1274 info.class_def_index = class_def_idx;
1275 info.dex_method_index = method_idx;
1276 info.access_flags = access_flags;
1277 info.code_item = code_item;
1278 info.isa = codegen->GetInstructionSet();
1279 info.deduped = false;
1280 info.is_native_debuggable = compiler_options.GetNativeDebuggable();
1281 info.is_optimized = true;
1282 info.is_code_address_text_relative = false;
1283 info.code_address = code_address;
1284 info.code_size = code_allocator.GetSize();
1285 info.frame_size_in_bytes = method_header->GetFrameSizeInBytes();
1286 info.code_info = stack_map_size == 0 ? nullptr : stack_map_data;
1287 info.cfi = ArrayRef<const uint8_t>(*codegen->GetAssembler()->cfi().data());
Vladimir Marko93205e32016-04-13 11:59:46 +01001288 std::vector<uint8_t> elf_file = debug::WriteDebugElfFileForMethods(
David Srbecky5d811202016-03-08 13:21:22 +00001289 GetCompilerDriver()->GetInstructionSet(),
1290 GetCompilerDriver()->GetInstructionSetFeatures(),
David Srbeckyfe736b72016-03-09 11:44:44 +00001291 ArrayRef<const debug::MethodDebugInfo>(&info, 1));
Vladimir Marko93205e32016-04-13 11:59:46 +01001292 CreateJITCodeEntryForAddress(code_address, std::move(elf_file));
David Srbecky5cc349f2015-12-18 15:04:48 +00001293 }
1294
Nicolas Geoffraya4f81542016-03-08 16:57:48 +00001295 Runtime::Current()->GetJit()->AddMemoryUsage(method, arena.BytesUsed());
Nicolas Geoffray01db5f72017-07-19 15:05:49 +01001296 if (jit_logger != nullptr) {
1297 jit_logger->WriteLog(code, code_allocator.GetSize(), method);
1298 }
Nicolas Geoffraya4f81542016-03-08 16:57:48 +00001299
Nicolas Geoffrayd28b9692015-11-04 14:36:55 +00001300 return true;
1301}
1302
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +00001303} // namespace art