blob: a4dcb3aeba3e3fd6db40882c3c650813d7601e60 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
24#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010025#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/dex_compilation_unit.h"
27#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010028#include "intrinsics.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "mirror/class_loader.h"
30#include "mirror/dex_cache.h"
31#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010032#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010033#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000034#include "register_allocator.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010035#include "sharpening.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000036#include "ssa_phi_elimination.h"
37#include "scoped_thread_state_change.h"
38#include "thread.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010039#include "dex/verified_method.h"
40#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000041
42namespace art {
43
Nicolas Geoffrayb17d1cc2015-12-17 15:26:21 +000044static constexpr size_t kMaximumNumberOfHInstructions = 12;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070045
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000046void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010047 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
48 if ((compiler_options.GetInlineDepthLimit() == 0)
49 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
50 return;
51 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000052 if (graph_->IsDebuggable()) {
53 // For simplicity, we currently never inline when the graph is debuggable. This avoids
54 // doing some logic in the runtime to discover if a method could have been inlined.
55 return;
56 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010057 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
58 DCHECK(!blocks.empty());
59 HBasicBlock* next_block = blocks[0];
60 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010061 // Because we are changing the graph when inlining, we need to remember the next block.
62 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010063 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010064 continue;
65 }
66 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010067 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000068 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
69 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010070 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070071 // As long as the call is not intrinsified, it is worth trying to inline.
72 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000073 // We use the original invoke type to ensure the resolution of the called method
74 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000075 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010076 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000077 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000078 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000079 bool should_inline = callee_name.find("$inline$") != std::string::npos;
80 CHECK(!should_inline) << "Could not inline " << callee_name;
81 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010082 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010083 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010084 std::string callee_name =
85 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
86 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
87 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
88 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000089 }
90 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000091 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000092 }
93 }
94}
95
Nicolas Geoffray454a4812015-06-09 10:37:32 +010096static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -070097 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +010098 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
99}
100
101/**
102 * Given the `resolved_method` looked up in the dex cache, try to find
103 * the actual runtime target of an interface or virtual call.
104 * Return nullptr if the runtime target cannot be proven.
105 */
106static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700107 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100108 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
109 // No need to lookup further, the resolved method will be the target.
110 return resolved_method;
111 }
112
113 HInstruction* receiver = invoke->InputAt(0);
114 if (receiver->IsNullCheck()) {
115 // Due to multiple levels of inlining within the same pass, it might be that
116 // null check does not have the reference type of the actual receiver.
117 receiver = receiver->InputAt(0);
118 }
119 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000120 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
121 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100122 // We currently only support inlining with known receivers.
123 // TODO: Remove this check, we should be able to inline final methods
124 // on unknown receivers.
125 return nullptr;
126 } else if (info.GetTypeHandle()->IsInterface()) {
127 // Statically knowing that the receiver has an interface type cannot
128 // help us find what is the target method.
129 return nullptr;
130 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
131 // The method that we're trying to call is not in the receiver's class or super classes.
132 return nullptr;
133 }
134
135 ClassLinker* cl = Runtime::Current()->GetClassLinker();
136 size_t pointer_size = cl->GetImagePointerSize();
137 if (invoke->IsInvokeInterface()) {
138 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
139 resolved_method, pointer_size);
140 } else {
141 DCHECK(invoke->IsInvokeVirtual());
142 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
143 resolved_method, pointer_size);
144 }
145
146 if (resolved_method == nullptr) {
147 // The information we had on the receiver was not enough to find
148 // the target method. Since we check above the exact type of the receiver,
149 // the only reason this can happen is an IncompatibleClassChangeError.
150 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700151 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100152 // The information we had on the receiver was not enough to find
153 // the target method. Since we check above the exact type of the receiver,
154 // the only reason this can happen is an IncompatibleClassChangeError.
155 return nullptr;
156 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
157 // A final method has to be the target method.
158 return resolved_method;
159 } else if (info.IsExact()) {
160 // If we found a method and the receiver's concrete type is statically
161 // known, we know for sure the target.
162 return resolved_method;
163 } else {
164 // Even if we did find a method, the receiver type was not enough to
165 // statically find the runtime target.
166 return nullptr;
167 }
168}
169
170static uint32_t FindMethodIndexIn(ArtMethod* method,
171 const DexFile& dex_file,
172 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700173 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100174 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100175 return method->GetDexMethodIndex();
176 } else {
177 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
178 }
179}
180
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100181static uint32_t FindClassIndexIn(mirror::Class* cls, const DexFile& dex_file)
182 SHARED_REQUIRES(Locks::mutator_lock_) {
183 if (cls->GetDexCache() == nullptr) {
184 DCHECK(cls->IsArrayClass());
185 // TODO: find the class in `dex_file`.
186 return DexFile::kDexNoIndex;
187 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
188 // TODO: deal with proxy classes.
189 return DexFile::kDexNoIndex;
190 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
191 // Update the dex cache to ensure the class is in. The generated code will
192 // consider it is. We make it safe by updating the dex cache, as other
193 // dex files might also load the class, and there is no guarantee the dex
194 // cache of the dex file of the class will be updated.
195 if (cls->GetDexCache()->GetResolvedType(cls->GetDexTypeIndex()) == nullptr) {
196 cls->GetDexCache()->SetResolvedType(cls->GetDexTypeIndex(), cls);
197 }
198 return cls->GetDexTypeIndex();
199 } else {
200 // TODO: find the class in `dex_file`.
201 return DexFile::kDexNoIndex;
202 }
203}
204
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700205bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100206 if (invoke_instruction->IsInvokeUnresolved()) {
207 return false; // Don't bother to move further if we know the method is unresolved.
208 }
209
Vladimir Marko58155012015-08-19 12:49:41 +0000210 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000211 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000212 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
213 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000214
Nicolas Geoffray35071052015-06-09 15:43:38 +0100215 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
216 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000217 ArtMethod* resolved_method;
218 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000219 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
220 VLOG(compiler) << "Not inlining a String.<init> method";
221 return false;
222 }
Vladimir Marko58155012015-08-19 12:49:41 +0000223 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700224 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
225 ? caller_compilation_unit_.GetDexCache().Get()
226 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
227 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000228 ref.dex_method_index, class_linker->GetImagePointerSize());
229 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700230 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000231 method_index, class_linker->GetImagePointerSize());
232 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000233
Mathieu Chartiere401d142015-04-22 13:56:20 -0700234 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100235 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100236 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000237 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000238 return false;
239 }
240
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100241 if (invoke_instruction->IsInvokeStaticOrDirect()) {
242 return TryInline(invoke_instruction, resolved_method);
243 }
244
245 // Check if we can statically find the method.
246 ArtMethod* actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
247 if (actual_method != nullptr) {
248 return TryInline(invoke_instruction, actual_method);
249 }
250
251 // Check if we can use an inline cache.
252 ArtMethod* caller = graph_->GetArtMethod();
253 size_t pointer_size = class_linker->GetImagePointerSize();
254 // Under JIT, we should always know the caller.
255 DCHECK(!Runtime::Current()->UseJit() || (caller != nullptr));
256 if (caller != nullptr && caller->GetProfilingInfo(pointer_size) != nullptr) {
257 ProfilingInfo* profiling_info = caller->GetProfilingInfo(pointer_size);
258 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
259 if (ic.IsUnitialized()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100260 VLOG(compiler) << "Interface or virtual call to "
261 << PrettyMethod(method_index, caller_dex_file)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100262 << " is not hit and not inlined";
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100263 return false;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100264 } else if (ic.IsMonomorphic()) {
265 MaybeRecordStat(kMonomorphicCall);
266 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
267 } else if (ic.IsPolymorphic()) {
268 MaybeRecordStat(kPolymorphicCall);
269 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
270 } else {
271 DCHECK(ic.IsMegamorphic());
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100272 VLOG(compiler) << "Interface or virtual call to "
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100273 << PrettyMethod(method_index, caller_dex_file)
274 << " is megamorphic and not inlined";
275 MaybeRecordStat(kMegamorphicCall);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100276 return false;
277 }
278 }
279
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100280 VLOG(compiler) << "Interface or virtual call to "
281 << PrettyMethod(method_index, caller_dex_file)
282 << " could not be statically determined";
283 return false;
284}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000285
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100286bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
287 ArtMethod* resolved_method,
288 const InlineCache& ic) {
289 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
290 uint32_t class_index = FindClassIndexIn(ic.GetMonomorphicType(), caller_dex_file);
291 if (class_index == DexFile::kDexNoIndex) {
292 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
293 << " from inline cache is not inlined because its class is not"
294 << " accessible to the caller";
295 return false;
296 }
297
298 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
299 size_t pointer_size = class_linker->GetImagePointerSize();
300 if (invoke_instruction->IsInvokeInterface()) {
301 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
302 resolved_method, pointer_size);
303 } else {
304 DCHECK(invoke_instruction->IsInvokeVirtual());
305 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
306 resolved_method, pointer_size);
307 }
308 DCHECK(resolved_method != nullptr);
309 HInstruction* receiver = invoke_instruction->InputAt(0);
310 HInstruction* cursor = invoke_instruction->GetPrevious();
311 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
312
313 if (!TryInline(invoke_instruction, resolved_method, /* do_rtp */ false)) {
314 return false;
315 }
316
317 // We successfully inlined, now add a guard.
318 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
319 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
320 HInstanceFieldGet* field_get = new (graph_->GetArena()) HInstanceFieldGet(
321 receiver,
322 Primitive::kPrimNot,
323 field->GetOffset(),
324 field->IsVolatile(),
325 field->GetDexFieldIndex(),
326 field->GetDeclaringClass()->GetDexClassDefIndex(),
327 *field->GetDexFile(),
328 handles_->NewHandle(field->GetDexCache()),
329 invoke_instruction->GetDexPc());
330
331 bool is_referrer =
332 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
333 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
334 class_index,
335 caller_dex_file,
336 is_referrer,
337 invoke_instruction->GetDexPc(),
338 /* needs_access_check */ false,
339 /* is_in_dex_cache */ true);
340
341 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, field_get);
342 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
343 compare, invoke_instruction->GetDexPc());
344 // TODO: Extend reference type propagation to understand the guard.
345 if (cursor != nullptr) {
346 bb_cursor->InsertInstructionAfter(load_class, cursor);
347 } else {
348 bb_cursor->InsertInstructionBefore(load_class, bb_cursor->GetFirstInstruction());
349 }
350 bb_cursor->InsertInstructionAfter(field_get, load_class);
351 bb_cursor->InsertInstructionAfter(compare, field_get);
352 bb_cursor->InsertInstructionAfter(deoptimize, compare);
353 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
354
355 // Run type propagation to get the guard typed, and eventually propagate the
356 // type of the receiver.
357 ReferenceTypePropagation rtp_fixup(graph_, handles_);
358 rtp_fixup.Run();
359
360 MaybeRecordStat(kInlinedMonomorphicCall);
361 return true;
362}
363
364bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction ATTRIBUTE_UNUSED,
365 ArtMethod* resolved_method,
366 const InlineCache& ic ATTRIBUTE_UNUSED) {
367 // TODO
368 VLOG(compiler) << "Unimplemented polymorphic inlining for "
369 << PrettyMethod(resolved_method);
370 return false;
371}
372
373bool HInliner::TryInline(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
374 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
375 uint32_t method_index = FindMethodIndexIn(
376 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
377 if (method_index == DexFile::kDexNoIndex) {
378 VLOG(compiler) << "Call to "
379 << PrettyMethod(method)
380 << " cannot be inlined because unaccessible to caller";
381 return false;
382 }
383
384 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
385
386 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000387
388 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100389 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000390 << " is not inlined because it is native";
391 return false;
392 }
393
Calin Juravleec748352015-07-29 13:52:12 +0100394 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
395 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100396 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000397 << " is too big to inline";
398 return false;
399 }
400
401 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100402 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000403 << " is not inlined because of try block";
404 return false;
405 }
406
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100407 if (!method->GetDeclaringClass()->IsVerified()) {
408 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100409 if (!compiler_driver_->IsMethodVerifiedWithoutFailures(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100410 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100411 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
412 << " couldn't be verified, so it cannot be inlined";
413 return false;
414 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000415 }
416
Roland Levillain4c0eb422015-04-24 16:43:49 +0100417 if (invoke_instruction->IsInvokeStaticOrDirect() &&
418 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
419 // Case of a static method that cannot be inlined because it implicitly
420 // requires an initialization check of its declaring class.
421 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
422 << " is not inlined because it is static and requires a clinit"
423 << " check that cannot be emitted due to Dex cache limitations";
424 return false;
425 }
426
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100427 if (!TryBuildAndInline(method, invoke_instruction, same_dex_file, do_rtp)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000428 return false;
429 }
430
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000431 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000432 MaybeRecordStat(kInlinedInvoke);
433 return true;
434}
435
Mathieu Chartiere401d142015-04-22 13:56:20 -0700436bool HInliner::TryBuildAndInline(ArtMethod* resolved_method,
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000437 HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100438 bool same_dex_file,
439 bool do_rtp) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000440 ScopedObjectAccess soa(Thread::Current());
441 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100442 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
443 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +0000444 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700445 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000446 DexCompilationUnit dex_compilation_unit(
447 nullptr,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000448 caller_compilation_unit_.GetClassLoader(),
Calin Juravle2e768302015-07-28 14:41:11 +0000449 class_linker,
Nicolas Geoffray8dbf0cf2015-08-11 02:14:38 +0000450 callee_dex_file,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000451 code_item,
452 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
Nicolas Geoffray8dbf0cf2015-08-11 02:14:38 +0000453 method_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000454 resolved_method->GetAccessFlags(),
Mathieu Chartier736b5602015-09-02 14:54:11 -0700455 compiler_driver_->GetVerifiedMethod(&callee_dex_file, method_index),
456 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000457
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100458 bool requires_ctor_barrier = false;
459
460 if (dex_compilation_unit.IsConstructor()) {
461 // If it's a super invocation and we already generate a barrier there's no need
462 // to generate another one.
463 // We identify super calls by looking at the "this" pointer. If its value is the
464 // same as the local "this" pointer then we must have a super invocation.
465 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
466 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
467 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
468 requires_ctor_barrier = false;
469 } else {
470 Thread* self = Thread::Current();
471 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
472 dex_compilation_unit.GetDexFile(),
473 dex_compilation_unit.GetClassDefIndex());
474 }
475 }
476
Nicolas Geoffray35071052015-06-09 15:43:38 +0100477 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
478 if (invoke_type == kInterface) {
479 // We have statically resolved the dispatch. To please the class linker
480 // at runtime, we change this call as if it was a virtual call.
481 invoke_type = kVirtual;
482 }
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000483 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100484 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100485 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100486 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100487 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -0700488 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +0100489 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100490 graph_->IsDebuggable(),
491 graph_->GetCurrentInstructionId());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100492 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +0000493
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000494 OptimizingCompilerStats inline_stats;
David Brazdil5e8b1372015-01-23 14:39:08 +0000495 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000496 &dex_compilation_unit,
497 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000498 resolved_method->GetDexFile(),
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000499 compiler_driver_,
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +0000500 &inline_stats,
Mathieu Chartier736b5602015-09-02 14:54:11 -0700501 resolved_method->GetQuickenedInfo(),
502 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000503
David Brazdil5e8b1372015-01-23 14:39:08 +0000504 if (!builder.BuildGraph(*code_item)) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100505 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000506 << " could not be built, so cannot be inlined";
507 return false;
508 }
509
Nicolas Geoffray259136f2014-12-17 23:21:58 +0000510 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
511 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100512 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +0000513 << " cannot be inlined because of the register allocator";
514 return false;
515 }
516
Alex Light68289a52015-12-15 17:30:30 -0800517 if (!callee_graph->TryBuildingSsa()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100518 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000519 << " could not be transformed to SSA";
520 return false;
521 }
522
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700523 size_t parameter_index = 0;
524 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
525 !instructions.Done();
526 instructions.Advance()) {
527 HInstruction* current = instructions.Current();
528 if (current->IsParameterValue()) {
529 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
530 if (argument->IsNullConstant()) {
531 current->ReplaceWith(callee_graph->GetNullConstant());
532 } else if (argument->IsIntConstant()) {
533 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
534 } else if (argument->IsLongConstant()) {
535 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
536 } else if (argument->IsFloatConstant()) {
537 current->ReplaceWith(
538 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
539 } else if (argument->IsDoubleConstant()) {
540 current->ReplaceWith(
541 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
542 } else if (argument->GetType() == Primitive::kPrimNot) {
543 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
544 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
545 }
546 }
547 }
548
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000549 // Run simple optimizations on the graph.
Calin Juravle7a9c8852015-04-21 14:07:50 +0100550 HDeadCodeElimination dce(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +0000551 HConstantFolding fold(callee_graph);
Alex Light68289a52015-12-15 17:30:30 -0800552 ReferenceTypePropagation type_propagation(callee_graph, handles_);
Vladimir Markodc151b22015-10-15 18:02:30 +0100553 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
Calin Juravleacf735c2015-02-12 15:25:22 +0000554 InstructionSimplifier simplify(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +0000555 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000556
557 HOptimization* optimizations[] = {
Scott Wakelingd60a1af2015-07-22 14:32:44 +0100558 &intrinsics,
Alex Light68289a52015-12-15 17:30:30 -0800559 &type_propagation,
Vladimir Markodc151b22015-10-15 18:02:30 +0100560 &sharpening,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000561 &simplify,
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700562 &fold,
Vladimir Marko9e23df52015-11-10 17:14:35 +0000563 &dce,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000564 };
565
566 for (size_t i = 0; i < arraysize(optimizations); ++i) {
567 HOptimization* optimization = optimizations[i];
568 optimization->Run();
569 }
570
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700571 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Calin Juravleec748352015-07-29 13:52:12 +0100572 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000573 HInliner inliner(callee_graph,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100574 outermost_graph_,
Vladimir Markodc151b22015-10-15 18:02:30 +0100575 codegen_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000576 outer_compilation_unit_,
577 dex_compilation_unit,
578 compiler_driver_,
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100579 handles_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000580 stats_,
581 depth_ + 1);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000582 inliner.Run();
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700583 number_of_instructions_budget += inliner.number_of_inlined_instructions_;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000584 }
585
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100586 // TODO: We should abort only if all predecessors throw. However,
587 // HGraph::InlineInto currently does not handle an exit block with
588 // a throw predecessor.
589 HBasicBlock* exit_block = callee_graph->GetExitBlock();
590 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100591 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100592 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100593 return false;
594 }
595
596 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +0000597 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
598 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100599 has_throw_predecessor = true;
600 break;
601 }
602 }
603 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100604 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100605 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100606 return false;
607 }
608
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000609 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000610 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700611 size_t number_of_instructions = 0;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000612 for (; !it.Done(); it.Advance()) {
613 HBasicBlock* block = it.Current();
614 if (block->IsLoopHeader()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100615 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000616 << " could not be inlined because it contains a loop";
617 return false;
618 }
619
620 for (HInstructionIterator instr_it(block->GetInstructions());
621 !instr_it.Done();
622 instr_it.Advance()) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700623 if (number_of_instructions++ == number_of_instructions_budget) {
624 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayb17d1cc2015-12-17 15:26:21 +0000625 << " could not be inlined because it is too big.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700626 return false;
627 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000628 HInstruction* current = instr_it.Current();
Nicolas Geoffray276d9da2015-02-02 18:24:11 +0000629
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100630 if (current->IsInvokeInterface()) {
631 // Disable inlining of interface calls. The cost in case of entering the
632 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100633 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100634 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000635 return false;
636 }
637
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100638 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100639 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000640 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100641 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000642 return false;
643 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000644
Vladimir Markodc151b22015-10-15 18:02:30 +0100645 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100646 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000647 << " could not be inlined because " << current->DebugName()
648 << " it is in a different dex file and requires access to the dex cache";
649 return false;
650 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +0000651
652 if (current->IsNewInstance() &&
653 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
654 // Allocation entrypoint does not handle inlined frames.
655 return false;
656 }
657
658 if (current->IsNewArray() &&
659 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
660 // Allocation entrypoint does not handle inlined frames.
661 return false;
662 }
663
664 if (current->IsUnresolvedStaticFieldGet() ||
665 current->IsUnresolvedInstanceFieldGet() ||
666 current->IsUnresolvedStaticFieldSet() ||
667 current->IsUnresolvedInstanceFieldSet()) {
668 // Entrypoint for unresolved fields does not handle inlined frames.
669 return false;
670 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000671 }
672 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700673 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000674
Calin Juravle2e768302015-07-28 14:41:11 +0000675 HInstruction* return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Calin Juravle214bbcd2015-10-20 14:54:07 +0100676 if (return_replacement != nullptr) {
677 DCHECK_EQ(graph_, return_replacement->GetBlock()->GetGraph());
678 }
Calin Juravle2e768302015-07-28 14:41:11 +0000679
Alex Light68289a52015-12-15 17:30:30 -0800680 // When merging the graph we might create a new NullConstant in the caller graph which does
681 // not have the chance to be typed. We assign the correct type here so that we can keep the
682 // assertion that every reference has a valid type. This also simplifies checks along the way.
683 HNullConstant* null_constant = graph_->GetNullConstant();
684 if (!null_constant->GetReferenceTypeInfo().IsValid()) {
685 ReferenceTypeInfo::TypeHandle obj_handle =
686 handles_->NewHandle(class_linker->GetClassRoot(ClassLinker::kJavaLangObject));
687 null_constant->SetReferenceTypeInfo(
688 ReferenceTypeInfo::Create(obj_handle, false /* is_exact */));
689 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000690
Alex Light68289a52015-12-15 17:30:30 -0800691 // Check the integrity of reference types and run another type propagation if needed.
692 if ((return_replacement != nullptr)
693 && (return_replacement->GetType() == Primitive::kPrimNot)) {
694 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
695 // Make sure that we have a valid type for the return. We may get an invalid one when
696 // we inline invokes with multiple branches and create a Phi for the result.
697 // TODO: we could be more precise by merging the phi inputs but that requires
698 // some functionality from the reference type propagation.
699 DCHECK(return_replacement->IsPhi());
700 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
701 ReferenceTypeInfo::TypeHandle return_handle =
702 handles_->NewHandle(resolved_method->GetReturnType(true /* resolve */, pointer_size));
703 return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create(
704 return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */));
705 }
706
707 if (do_rtp) {
708 // If the return type is a refinement of the declared type run the type propagation again.
709 ReferenceTypeInfo return_rti = return_replacement->GetReferenceTypeInfo();
710 ReferenceTypeInfo invoke_rti = invoke_instruction->GetReferenceTypeInfo();
711 if (invoke_rti.IsStrictSupertypeOf(return_rti)
712 || (return_rti.IsExact() && !invoke_rti.IsExact())
713 || !return_replacement->CanBeNull()) {
714 ReferenceTypePropagation rtp_fixup(graph_, handles_);
715 rtp_fixup.Run();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100716 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000717 }
Calin Juravle2e768302015-07-28 14:41:11 +0000718 }
Nicolas Geoffray7c5367b2014-12-17 10:13:46 +0000719
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000720 return true;
721}
722
723} // namespace art