summaryrefslogtreecommitdiff
path: root/libs/shaders/shaders.cpp
diff options
context:
space:
mode:
author Robert Carr <racarr@google.com> 2022-01-07 18:23:06 -0800
committer Rob Carr <racarr@google.com> 2022-04-03 17:05:21 +0000
commit842a412840fbab2332a27d646a167177b110abf4 (patch)
tree65855dae2b788b4efb8f64ea61a05c48e930052b /libs/shaders/shaders.cpp
parent18a6f9eece32ba291999f970500e299d866ff57d (diff)
DO NOT MERGE: SurfaceFlinger: Add Transaction#sanitize
Various elements of the Transaction interface require a permission in order to apply. In particular the setTrustedOverlay and setInputWindowInfo fields. These permission checks are implemented by checking the PID and the UID of the process which sent the transaction. Unfortunately widespread use of transaction merging makes this inadequate. At the moment IWindowSession#finishDrawing seems to be the only boundary on which transactions move from client to system processes, and so we expose a sanitize method and use it from there to resolve the situation in an easily backportable way. Moving forward it likely make sense to move security sensitive interfaces off of Transaction. Most of the things behind permissions currently are not truly security sensitive, more of just a request not to use them. It was also considered to sanitize transactions at all process boundaries through writeToParcel, however this could be disruptive as previously permissioned processes (WM and SysUI) could freely exchange transactions. As the change needs to be backportable the lowest risk option was chosen. Bug: 213644870 Test: Existing tests pass Change-Id: I424f45bc30ea8e56e4c4493203ee0749eabf239c (cherry picked from commit de6d7b467e572d384f2bc1bc788259340ebe2f93)
Diffstat (limited to 'libs/shaders/shaders.cpp')
0 files changed, 0 insertions, 0 deletions