1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
|
/*
* Copyright (C) 2018 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "Command.h"
#include "test/Test.h"
using ::testing::Eq;
using namespace std::literals;
namespace aapt {
class TestCommand : public Command {
public:
explicit TestCommand() : Command("command") {}
int Action(const std::vector<std::string>& args) override {
args_ = args;
return 0;
}
std::vector<std::string> args_;
};
#ifdef _WIN32
TEST(CommandTest, LongFullyQualifiedPathWindows) {
TestCommand command;
std::string required_flag;
command.AddRequiredFlag("--rflag", "", &required_flag, Command::kPath);
std::optional<std::string> optional_flag;
command.AddOptionalFlag("--oflag", "", &optional_flag, Command::kPath);
std::vector<std::string> required_flag_list;
command.AddRequiredFlagList("--rlflag", "", &required_flag_list, Command::kPath);
std::vector<std::string> optional_flag_list;
command.AddOptionalFlagList("--olflag", "", &optional_flag_list, Command::kPath);
std::string non_path_flag;
command.AddRequiredFlag("--nflag", "", &non_path_flag);
const std::string kLongPath =
"C:\\Users\\jedo\\_bazel_jedo\\vcmdctjv\\execroot\\__main__\\_tmp"
"\\6767b4778f8798efc0f784ee74fa70ee\\tests\\testApksAr8c7560a9a65"
"\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
"\\intermediates\\processed_res\\minified\\processMinifiedResources"
"\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
"\\intermediates\\processed_res\\minified\\processMinifiedResources"
"\\out\\resources-minified.ap_";
const std::string kExpected =
"\\\\?\\C:\\Users\\jedo\\_bazel_jedo\\vcmdctjv\\execroot\\__main__\\_tmp"
"\\6767b4778f8798efc0f784ee74fa70ee\\tests\\testApksAr8c7560a9a65"
"\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
"\\intermediates\\processed_res\\minified\\processMinifiedResources"
"\\1346ee7c014a089fb55d8c46cf3d9\\project\\baseModule\\build"
"\\intermediates\\processed_res\\minified\\processMinifiedResources"
"\\out\\resources-minified.ap_";
ASSERT_THAT(command.Execute({"--rflag", kLongPath,
"--oflag", kLongPath,
"--rlflag", kLongPath,
"--rlflag", kLongPath,
"--olflag", kLongPath,
"--olflag", kLongPath,
"--nflag", kLongPath,
kLongPath, kLongPath}, &std::cerr), Eq(0));
ASSERT_THAT(required_flag, Eq(kExpected));
ASSERT_THAT(optional_flag, Eq(kExpected));
ASSERT_THAT(required_flag_list.size(), Eq(2));
ASSERT_THAT(required_flag_list[0], Eq(kExpected));
ASSERT_THAT(required_flag_list[1], Eq(kExpected));
ASSERT_THAT(optional_flag_list.size(), Eq(2));
ASSERT_THAT(optional_flag_list[0], Eq(kExpected));
ASSERT_THAT(optional_flag_list[1], Eq(kExpected));
// File arguments should also be converted to use the long path prefix
ASSERT_THAT(command.args_.size(), Eq(2));
ASSERT_THAT(command.args_[0], Eq(kExpected));
ASSERT_THAT(command.args_[1], Eq(kExpected));
// Do not convert flags that are not marged as paths
ASSERT_THAT(non_path_flag, Eq(kLongPath));
}
#endif
TEST(CommandTest, OptionsWithValues) {
TestCommand command;
std::string flag;
command.AddRequiredFlag("--flag", "", &flag);
ASSERT_EQ(0, command.Execute({"--flag"s, "1"s}, &std::cerr));
EXPECT_STREQ("1", flag.c_str());
ASSERT_EQ(0, command.Execute({"--flag=1"s}, &std::cerr));
EXPECT_STREQ("1", flag.c_str());
ASSERT_EQ(0, command.Execute({"--flag"s, "=2"s}, &std::cerr));
EXPECT_STREQ("=2", flag.c_str());
ASSERT_EQ(0, command.Execute({"--flag"s, "--flag"s}, &std::cerr));
EXPECT_STREQ("--flag", flag.c_str());
EXPECT_NE(0, command.Execute({"--flag"s}, &std::cerr));
EXPECT_NE(0, command.Execute({"--flag="s}, &std::cerr));
EXPECT_NE(0, command.Execute({"--flag1=2"s}, &std::cerr));
EXPECT_NE(0, command.Execute({"--flag1"s, "2"s}, &std::cerr));
}
TEST(CommandTest, ShortOptions) {
TestCommand command;
bool flag = false;
command.AddOptionalSwitch("--flag", "", &flag);
ASSERT_EQ(0, command.Execute({"--flag"s}, &std::cerr));
EXPECT_TRUE(flag);
// Short version of a switch should work.
flag = false;
ASSERT_EQ(0, command.Execute({"-f"s}, &std::cerr));
EXPECT_TRUE(flag);
// Ambiguous names shouldn't parse via short options.
command.AddOptionalSwitch("--flag-2", "", &flag);
ASSERT_NE(0, command.Execute({"-f"s}, &std::cerr));
// But when we have a proper flag like that it should still work.
flag = false;
command.AddOptionalSwitch("-f", "", &flag);
ASSERT_EQ(0, command.Execute({"-f"s}, &std::cerr));
EXPECT_TRUE(flag);
// A regular short flag works fine as well.
flag = false;
command.AddOptionalSwitch("-d", "", &flag);
ASSERT_EQ(0, command.Execute({"-d"s}, &std::cerr));
EXPECT_TRUE(flag);
// A flag with a value only works via its long name syntax.
std::optional<std::string> val;
command.AddOptionalFlag("--with-val", "", &val);
ASSERT_EQ(0, command.Execute({"--with-val"s, "1"s}, &std::cerr));
EXPECT_TRUE(val);
EXPECT_STREQ("1", val->c_str());
// Make sure the flags that require a value can't be parsed via short syntax, -w=blah
// looks weird.
ASSERT_NE(0, command.Execute({"-w"s, "2"s}, &std::cerr));
}
} // namespace aapt
|