summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author John Reck <jreck@google.com> 2014-04-07 17:31:44 -0700
committer John Reck <jreck@google.com> 2014-04-07 17:38:47 -0700
commite2c455264351964bf1ae78da2256c17258f0d3ea (patch)
treed6be1f13fce173fb067ea82c623be172c46875e3
parent85189c5dafb08f051c7024f42ceedcbcf5dbbc7c (diff)
Veto pool TODO
Change-Id: I50067dba630b75aa539e4406cfc15f66949684b3
-rw-r--r--libs/hwui/renderthread/RenderProxy.cpp7
-rw-r--r--libs/hwui/renderthread/RenderProxy.h1
2 files changed, 1 insertions, 7 deletions
diff --git a/libs/hwui/renderthread/RenderProxy.cpp b/libs/hwui/renderthread/RenderProxy.cpp
index 43e653ca76ec..489dc9026af6 100644
--- a/libs/hwui/renderthread/RenderProxy.cpp
+++ b/libs/hwui/renderthread/RenderProxy.cpp
@@ -48,7 +48,7 @@ namespace renderthread {
LOG_ALWAYS_FATAL_IF( METHOD_INVOKE_PAYLOAD_SIZE < sizeof(ARGS(method)), \
"METHOD_INVOKE_PAYLOAD_SIZE %d is smaller than sizeof(" #method "Args) %d", \
METHOD_INVOKE_PAYLOAD_SIZE, sizeof(ARGS(method))); \
- MethodInvokeRenderTask* task = createTask((RunnableMethod) Bridge_ ## method); \
+ MethodInvokeRenderTask* task = new MethodInvokeRenderTask((RunnableMethod) Bridge_ ## method); \
ARGS(method) *args = (ARGS(method) *) task->payload()
CREATE_BRIDGE1(createContext, bool translucent) {
@@ -269,11 +269,6 @@ void RenderProxy::fence() {
postAndWait(task);
}
-MethodInvokeRenderTask* RenderProxy::createTask(RunnableMethod method) {
- // TODO: Consider having a small pool of these to avoid alloc churn
- return new MethodInvokeRenderTask(method);
-}
-
void RenderProxy::post(RenderTask* task) {
mRenderThread.queue(task);
}
diff --git a/libs/hwui/renderthread/RenderProxy.h b/libs/hwui/renderthread/RenderProxy.h
index fc51d218b1d6..c50da7976bb5 100644
--- a/libs/hwui/renderthread/RenderProxy.h
+++ b/libs/hwui/renderthread/RenderProxy.h
@@ -91,7 +91,6 @@ private:
void destroyContext();
- MethodInvokeRenderTask* createTask(RunnableMethod method);
void post(RenderTask* task);
void* postAndWait(MethodInvokeRenderTask* task);