From e2c455264351964bf1ae78da2256c17258f0d3ea Mon Sep 17 00:00:00 2001 From: John Reck Date: Mon, 7 Apr 2014 17:31:44 -0700 Subject: Veto pool TODO Change-Id: I50067dba630b75aa539e4406cfc15f66949684b3 --- libs/hwui/renderthread/RenderProxy.cpp | 7 +------ libs/hwui/renderthread/RenderProxy.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/libs/hwui/renderthread/RenderProxy.cpp b/libs/hwui/renderthread/RenderProxy.cpp index 43e653ca76ec..489dc9026af6 100644 --- a/libs/hwui/renderthread/RenderProxy.cpp +++ b/libs/hwui/renderthread/RenderProxy.cpp @@ -48,7 +48,7 @@ namespace renderthread { LOG_ALWAYS_FATAL_IF( METHOD_INVOKE_PAYLOAD_SIZE < sizeof(ARGS(method)), \ "METHOD_INVOKE_PAYLOAD_SIZE %d is smaller than sizeof(" #method "Args) %d", \ METHOD_INVOKE_PAYLOAD_SIZE, sizeof(ARGS(method))); \ - MethodInvokeRenderTask* task = createTask((RunnableMethod) Bridge_ ## method); \ + MethodInvokeRenderTask* task = new MethodInvokeRenderTask((RunnableMethod) Bridge_ ## method); \ ARGS(method) *args = (ARGS(method) *) task->payload() CREATE_BRIDGE1(createContext, bool translucent) { @@ -269,11 +269,6 @@ void RenderProxy::fence() { postAndWait(task); } -MethodInvokeRenderTask* RenderProxy::createTask(RunnableMethod method) { - // TODO: Consider having a small pool of these to avoid alloc churn - return new MethodInvokeRenderTask(method); -} - void RenderProxy::post(RenderTask* task) { mRenderThread.queue(task); } diff --git a/libs/hwui/renderthread/RenderProxy.h b/libs/hwui/renderthread/RenderProxy.h index fc51d218b1d6..c50da7976bb5 100644 --- a/libs/hwui/renderthread/RenderProxy.h +++ b/libs/hwui/renderthread/RenderProxy.h @@ -91,7 +91,6 @@ private: void destroyContext(); - MethodInvokeRenderTask* createTask(RunnableMethod method); void post(RenderTask* task); void* postAndWait(MethodInvokeRenderTask* task); -- cgit v1.2.3-59-g8ed1b