diff options
| author | 2022-12-16 14:37:11 +0000 | |
|---|---|---|
| committer | 2023-01-03 15:11:58 +0000 | |
| commit | d3389a31c8beba969238693ef6573096360526b5 (patch) | |
| tree | bd03134d9c33c4421112fee6cc707c29d9aabc63 /compiler/optimizing/graph_checker.cc | |
| parent | 4a526080aa905803fe0e4061e09c4d7607e3f0ac (diff) | |
GraphChecker: Call VisitInstruction in VisitConstant
Fix some LSE gtests that were adding some instructions in
the entry block which don't belong there in normal graphs
(e.g. ArraySet, NewInstance)
Bug: 262862764
Fixes: 262862764
Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b
Test: m test-art-host-gtest-art_compiler_tests64
Change-Id: I1ea4f3eaf79d4b98b441dcf89f73c7009a6fa9b4
Diffstat (limited to 'compiler/optimizing/graph_checker.cc')
| -rw-r--r-- | compiler/optimizing/graph_checker.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/compiler/optimizing/graph_checker.cc b/compiler/optimizing/graph_checker.cc index 32b3bc1d9b..b20b53178f 100644 --- a/compiler/optimizing/graph_checker.cc +++ b/compiler/optimizing/graph_checker.cc @@ -1159,9 +1159,7 @@ void GraphChecker::VisitBinaryOperation(HBinaryOperation* op) { } void GraphChecker::VisitConstant(HConstant* instruction) { - // TODO(solanes, 262862764): We should call VisitInstruction here but doing so makes the - // LoadStoreEliminationTest gtests fail. - // VisitInstruction(instruction); + VisitInstruction(instruction); HBasicBlock* block = instruction->GetBlock(); if (!block->IsEntryBlock()) { |