From d3389a31c8beba969238693ef6573096360526b5 Mon Sep 17 00:00:00 2001 From: Santiago Aboy Solanes Date: Fri, 16 Dec 2022 14:37:11 +0000 Subject: GraphChecker: Call VisitInstruction in VisitConstant Fix some LSE gtests that were adding some instructions in the entry block which don't belong there in normal graphs (e.g. ArraySet, NewInstance) Bug: 262862764 Fixes: 262862764 Test: art/test/testrunner/testrunner.py --host --64 --optimizing -b Test: m test-art-host-gtest-art_compiler_tests64 Change-Id: I1ea4f3eaf79d4b98b441dcf89f73c7009a6fa9b4 --- compiler/optimizing/graph_checker.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'compiler/optimizing/graph_checker.cc') diff --git a/compiler/optimizing/graph_checker.cc b/compiler/optimizing/graph_checker.cc index 32b3bc1d9b..b20b53178f 100644 --- a/compiler/optimizing/graph_checker.cc +++ b/compiler/optimizing/graph_checker.cc @@ -1159,9 +1159,7 @@ void GraphChecker::VisitBinaryOperation(HBinaryOperation* op) { } void GraphChecker::VisitConstant(HConstant* instruction) { - // TODO(solanes, 262862764): We should call VisitInstruction here but doing so makes the - // LoadStoreEliminationTest gtests fail. - // VisitInstruction(instruction); + VisitInstruction(instruction); HBasicBlock* block = instruction->GetBlock(); if (!block->IsEntryBlock()) { -- cgit v1.2.3-59-g8ed1b