Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "transaction.h" |
| 18 | |
Andreas Gampe | 5794381 | 2017-12-06 21:39:13 -0800 | [diff] [blame] | 19 | #include <android-base/logging.h> |
| 20 | |
Vladimir Marko | 7ed2d38 | 2019-11-25 10:41:53 +0000 | [diff] [blame] | 21 | #include "aot_class_linker.h" |
Andreas Gampe | 88dbad3 | 2018-06-26 19:54:12 -0700 | [diff] [blame] | 22 | #include "base/mutex-inl.h" |
Andreas Gampe | 8cf9cb3 | 2017-07-19 09:28:38 -0700 | [diff] [blame] | 23 | #include "base/stl_util.h" |
Vladimir Marko | 0685b98 | 2021-03-25 11:59:22 +0000 | [diff] [blame] | 24 | #include "dex/descriptors_names.h" |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 25 | #include "gc/accounting/card_table-inl.h" |
Vladimir Marko | 672c080 | 2019-07-26 13:03:13 +0100 | [diff] [blame] | 26 | #include "gc/heap.h" |
Andreas Gampe | 508fdf3 | 2017-06-05 16:42:13 -0700 | [diff] [blame] | 27 | #include "gc_root-inl.h" |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 28 | #include "intern_table.h" |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 29 | #include "mirror/class-inl.h" |
Andreas Gampe | 508fdf3 | 2017-06-05 16:42:13 -0700 | [diff] [blame] | 30 | #include "mirror/dex_cache-inl.h" |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 31 | #include "mirror/object-inl.h" |
| 32 | #include "mirror/object_array-inl.h" |
Vladimir Marko | 672c080 | 2019-07-26 13:03:13 +0100 | [diff] [blame] | 33 | #include "obj_ptr-inl.h" |
| 34 | #include "runtime.h" |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 35 | |
| 36 | #include <list> |
| 37 | |
| 38 | namespace art { |
| 39 | |
| 40 | // TODO: remove (only used for debugging purpose). |
| 41 | static constexpr bool kEnableTransactionStats = false; |
| 42 | |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 43 | Transaction::Transaction(bool strict, |
| 44 | mirror::Class* root, |
| 45 | ArenaStack* arena_stack, |
| 46 | ArenaPool* arena_pool) |
| 47 | : arena_stack_(std::nullopt), |
| 48 | allocator_(arena_stack != nullptr ? arena_stack : &arena_stack_.emplace(arena_pool)), |
| 49 | object_logs_(std::less<mirror::Object*>(), allocator_.Adapter(kArenaAllocTransaction)), |
| 50 | array_logs_(std::less<mirror::Array*>(), allocator_.Adapter(kArenaAllocTransaction)), |
| 51 | intern_string_logs_(allocator_.Adapter(kArenaAllocTransaction)), |
| 52 | resolve_string_logs_(allocator_.Adapter(kArenaAllocTransaction)), |
| 53 | resolve_method_type_logs_(allocator_.Adapter(kArenaAllocTransaction)), |
| 54 | aborted_(false), |
Vladimir Marko | 672c080 | 2019-07-26 13:03:13 +0100 | [diff] [blame] | 55 | rolling_back_(false), |
Vladimir Marko | 4d7b689 | 2020-01-16 17:06:35 +0000 | [diff] [blame] | 56 | heap_(Runtime::Current()->GetHeap()), |
| 57 | strict_(strict), |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 58 | root_(root), |
| 59 | assert_no_new_records_reason_(nullptr) { |
Vladimir Marko | 672c080 | 2019-07-26 13:03:13 +0100 | [diff] [blame] | 60 | DCHECK(Runtime::Current()->IsAotCompiler()); |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 61 | DCHECK_NE(arena_stack != nullptr, arena_pool != nullptr); |
Chang Xing | cade5c3 | 2017-07-20 17:56:26 -0700 | [diff] [blame] | 62 | } |
| 63 | |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 64 | Transaction::~Transaction() { |
| 65 | if (kEnableTransactionStats) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 66 | size_t objects_count = object_logs_.size(); |
| 67 | size_t field_values_count = 0; |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 68 | for (const auto& it : object_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 69 | field_values_count += it.second.Size(); |
| 70 | } |
| 71 | size_t array_count = array_logs_.size(); |
| 72 | size_t array_values_count = 0; |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 73 | for (const auto& it : array_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 74 | array_values_count += it.second.Size(); |
| 75 | } |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 76 | size_t intern_string_count = |
| 77 | std::distance(intern_string_logs_.begin(), intern_string_logs_.end()); |
| 78 | size_t resolve_string_count = |
| 79 | std::distance(resolve_string_logs_.begin(), resolve_string_logs_.end()); |
| 80 | size_t resolve_method_type_count = |
| 81 | std::distance(resolve_method_type_logs_.begin(), resolve_method_type_logs_.end()); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 82 | LOG(INFO) << "Transaction::~Transaction" |
| 83 | << ": objects_count=" << objects_count |
| 84 | << ", field_values_count=" << field_values_count |
| 85 | << ", array_count=" << array_count |
| 86 | << ", array_values_count=" << array_values_count |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 87 | << ", intern_string_count=" << intern_string_count |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 88 | << ", resolve_string_count=" << resolve_string_count |
| 89 | << ", resolve_method_type_count=" << resolve_method_type_count; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 90 | } |
| 91 | } |
| 92 | |
Sebastien Hertz | 1c80bec | 2015-02-03 11:58:06 +0100 | [diff] [blame] | 93 | void Transaction::Abort(const std::string& abort_message) { |
Sebastien Hertz | 2fd7e69 | 2015-04-02 11:11:19 +0200 | [diff] [blame] | 94 | // We may abort more than once if the exception thrown at the time of the |
| 95 | // previous abort has been caught during execution of a class initializer. |
Sebastien Hertz | 1c80bec | 2015-02-03 11:58:06 +0100 | [diff] [blame] | 96 | // We just keep the message of the first abort because it will cause the |
| 97 | // transaction to be rolled back anyway. |
| 98 | if (!aborted_) { |
| 99 | aborted_ = true; |
| 100 | abort_message_ = abort_message; |
| 101 | } |
| 102 | } |
| 103 | |
Sebastien Hertz | b81e1cd | 2015-04-28 12:31:41 +0200 | [diff] [blame] | 104 | void Transaction::ThrowAbortError(Thread* self, const std::string* abort_message) { |
| 105 | const bool rethrow = (abort_message == nullptr); |
Sebastien Hertz | bd9cf9f | 2015-03-03 12:16:13 +0100 | [diff] [blame] | 106 | if (kIsDebugBuild && rethrow) { |
Vladimir Marko | 0685b98 | 2021-03-25 11:59:22 +0000 | [diff] [blame] | 107 | CHECK(IsAborted()) << "Rethrow " << DescriptorToDot(Transaction::kAbortExceptionDescriptor) |
Sebastien Hertz | 2fd7e69 | 2015-04-02 11:11:19 +0200 | [diff] [blame] | 108 | << " while transaction is not aborted"; |
Sebastien Hertz | bd9cf9f | 2015-03-03 12:16:13 +0100 | [diff] [blame] | 109 | } |
Sebastien Hertz | b81e1cd | 2015-04-28 12:31:41 +0200 | [diff] [blame] | 110 | if (rethrow) { |
| 111 | // Rethrow an exception with the earlier abort message stored in the transaction. |
Vladimir Marko | 0685b98 | 2021-03-25 11:59:22 +0000 | [diff] [blame] | 112 | self->ThrowNewWrappedException(Transaction::kAbortExceptionDescriptor, |
Sebastien Hertz | b81e1cd | 2015-04-28 12:31:41 +0200 | [diff] [blame] | 113 | GetAbortMessage().c_str()); |
| 114 | } else { |
| 115 | // Throw an exception with the given abort message. |
Vladimir Marko | 0685b98 | 2021-03-25 11:59:22 +0000 | [diff] [blame] | 116 | self->ThrowNewWrappedException(Transaction::kAbortExceptionDescriptor, |
Sebastien Hertz | b81e1cd | 2015-04-28 12:31:41 +0200 | [diff] [blame] | 117 | abort_message->c_str()); |
| 118 | } |
Sebastien Hertz | 1c80bec | 2015-02-03 11:58:06 +0100 | [diff] [blame] | 119 | } |
| 120 | |
Vladimir Marko | 24c080f | 2021-07-06 14:04:30 +0100 | [diff] [blame] | 121 | const std::string& Transaction::GetAbortMessage() const { |
Sebastien Hertz | 1c80bec | 2015-02-03 11:58:06 +0100 | [diff] [blame] | 122 | return abort_message_; |
| 123 | } |
| 124 | |
Vladimir Marko | 24c080f | 2021-07-06 14:04:30 +0100 | [diff] [blame] | 125 | bool Transaction::WriteConstraint(ObjPtr<mirror::Object> obj) const { |
Vladimir Marko | 4d7b689 | 2020-01-16 17:06:35 +0000 | [diff] [blame] | 126 | DCHECK(obj != nullptr); |
Vladimir Marko | 4d7b689 | 2020-01-16 17:06:35 +0000 | [diff] [blame] | 127 | |
| 128 | // Prevent changes in boot image spaces for app or boot image extension. |
| 129 | // For boot image there are no boot image spaces and this condition evaluates to false. |
| 130 | if (heap_->ObjectIsInBootImageSpace(obj)) { |
| 131 | return true; |
Chang Xing | bd208d8 | 2017-07-12 14:53:17 -0700 | [diff] [blame] | 132 | } |
Vladimir Marko | 4d7b689 | 2020-01-16 17:06:35 +0000 | [diff] [blame] | 133 | |
| 134 | // For apps, also prevent writing to other classes. |
| 135 | return IsStrict() && |
| 136 | obj->IsClass() && // no constraint updating instances or arrays |
| 137 | obj != root_; // modifying other classes' static field, fail |
Chang Xing | bd208d8 | 2017-07-12 14:53:17 -0700 | [diff] [blame] | 138 | } |
| 139 | |
Vladimir Marko | 24c080f | 2021-07-06 14:04:30 +0100 | [diff] [blame] | 140 | bool Transaction::WriteValueConstraint(ObjPtr<mirror::Object> value) const { |
Vladimir Marko | 149cdda | 2019-11-12 15:02:51 +0000 | [diff] [blame] | 141 | if (value == nullptr) { |
| 142 | return false; // We can always store null values. |
| 143 | } |
| 144 | gc::Heap* heap = Runtime::Current()->GetHeap(); |
Vladimir Marko | 149cdda | 2019-11-12 15:02:51 +0000 | [diff] [blame] | 145 | if (IsStrict()) { |
| 146 | // TODO: Should we restrict writes the same way as for boot image extension? |
| 147 | return false; |
| 148 | } else if (heap->GetBootImageSpaces().empty()) { |
| 149 | return false; // No constraints for boot image. |
| 150 | } else { |
| 151 | // Boot image extension. |
Vladimir Marko | 149cdda | 2019-11-12 15:02:51 +0000 | [diff] [blame] | 152 | ObjPtr<mirror::Class> klass = value->IsClass() ? value->AsClass() : value->GetClass(); |
Vladimir Marko | 7ed2d38 | 2019-11-25 10:41:53 +0000 | [diff] [blame] | 153 | return !AotClassLinker::CanReferenceInBootImageExtension(klass, heap); |
Vladimir Marko | 149cdda | 2019-11-12 15:02:51 +0000 | [diff] [blame] | 154 | } |
| 155 | } |
| 156 | |
Vladimir Marko | 24c080f | 2021-07-06 14:04:30 +0100 | [diff] [blame] | 157 | bool Transaction::ReadConstraint(ObjPtr<mirror::Object> obj) const { |
Vladimir Marko | 4d7b689 | 2020-01-16 17:06:35 +0000 | [diff] [blame] | 158 | // Read constraints are checked only for static field reads as there are |
| 159 | // no constraints on reading instance fields and array elements. |
Chang Xing | bd208d8 | 2017-07-12 14:53:17 -0700 | [diff] [blame] | 160 | DCHECK(obj->IsClass()); |
Vladimir Marko | 672c080 | 2019-07-26 13:03:13 +0100 | [diff] [blame] | 161 | if (IsStrict()) { |
| 162 | return obj != root_; // fail if not self-updating |
| 163 | } else { |
| 164 | // For boot image and boot image extension, allow reading any field. |
Chang Xing | bd208d8 | 2017-07-12 14:53:17 -0700 | [diff] [blame] | 165 | return false; |
| 166 | } |
Chang Xing | bd208d8 | 2017-07-12 14:53:17 -0700 | [diff] [blame] | 167 | } |
| 168 | |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 169 | inline Transaction::ObjectLog& Transaction::GetOrCreateObjectLog(mirror::Object* obj) { |
| 170 | return object_logs_.GetOrCreate(obj, [&]() { return ObjectLog(&allocator_); }); |
| 171 | } |
| 172 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 173 | void Transaction::RecordWriteFieldBoolean(mirror::Object* obj, |
| 174 | MemberOffset field_offset, |
| 175 | uint8_t value, |
| 176 | bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 177 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 178 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 179 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 180 | object_log.LogBooleanValue(field_offset, value, is_volatile); |
| 181 | } |
| 182 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 183 | void Transaction::RecordWriteFieldByte(mirror::Object* obj, |
| 184 | MemberOffset field_offset, |
| 185 | int8_t value, |
| 186 | bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 187 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 188 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 189 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 190 | object_log.LogByteValue(field_offset, value, is_volatile); |
| 191 | } |
| 192 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 193 | void Transaction::RecordWriteFieldChar(mirror::Object* obj, |
| 194 | MemberOffset field_offset, |
| 195 | uint16_t value, |
| 196 | bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 197 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 198 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 199 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 200 | object_log.LogCharValue(field_offset, value, is_volatile); |
| 201 | } |
| 202 | |
| 203 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 204 | void Transaction::RecordWriteFieldShort(mirror::Object* obj, |
| 205 | MemberOffset field_offset, |
| 206 | int16_t value, |
| 207 | bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 208 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 209 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 210 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 211 | object_log.LogShortValue(field_offset, value, is_volatile); |
| 212 | } |
| 213 | |
| 214 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 215 | void Transaction::RecordWriteField32(mirror::Object* obj, |
| 216 | MemberOffset field_offset, |
| 217 | uint32_t value, |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 218 | bool is_volatile) { |
| 219 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 220 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 221 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 222 | object_log.Log32BitsValue(field_offset, value, is_volatile); |
| 223 | } |
| 224 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 225 | void Transaction::RecordWriteField64(mirror::Object* obj, |
| 226 | MemberOffset field_offset, |
| 227 | uint64_t value, |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 228 | bool is_volatile) { |
| 229 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 230 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 231 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 232 | object_log.Log64BitsValue(field_offset, value, is_volatile); |
| 233 | } |
| 234 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 235 | void Transaction::RecordWriteFieldReference(mirror::Object* obj, |
| 236 | MemberOffset field_offset, |
| 237 | mirror::Object* value, |
| 238 | bool is_volatile) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 239 | DCHECK(obj != nullptr); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 240 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 241 | ObjectLog& object_log = GetOrCreateObjectLog(obj); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 242 | object_log.LogReferenceValue(field_offset, value, is_volatile); |
| 243 | } |
| 244 | |
| 245 | void Transaction::RecordWriteArray(mirror::Array* array, size_t index, uint64_t value) { |
| 246 | DCHECK(array != nullptr); |
| 247 | DCHECK(array->IsArrayInstance()); |
Sebastien Hertz | ee1d79a | 2014-02-21 15:46:30 +0100 | [diff] [blame] | 248 | DCHECK(!array->IsObjectArray()); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 249 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 250 | ArrayLog& array_log = array_logs_.GetOrCreate(array, [&]() { return ArrayLog(&allocator_); }); |
| 251 | array_log.LogValue(index, value); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 252 | } |
| 253 | |
Andreas Gampe | 8a0128a | 2016-11-28 07:38:35 -0800 | [diff] [blame] | 254 | void Transaction::RecordResolveString(ObjPtr<mirror::DexCache> dex_cache, |
| 255 | dex::StringIndex string_idx) { |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 256 | DCHECK(dex_cache != nullptr); |
Andreas Gampe | 8a0128a | 2016-11-28 07:38:35 -0800 | [diff] [blame] | 257 | DCHECK_LT(string_idx.index_, dex_cache->GetDexFile()->NumStringIds()); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 258 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 259 | resolve_string_logs_.emplace_front(dex_cache, string_idx); |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 260 | } |
| 261 | |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 262 | void Transaction::RecordResolveMethodType(ObjPtr<mirror::DexCache> dex_cache, |
| 263 | dex::ProtoIndex proto_idx) { |
| 264 | DCHECK(dex_cache != nullptr); |
| 265 | DCHECK_LT(proto_idx.index_, dex_cache->GetDexFile()->NumProtoIds()); |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 266 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 267 | resolve_method_type_logs_.emplace_front(dex_cache, proto_idx); |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 268 | } |
| 269 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 270 | void Transaction::RecordStrongStringInsertion(ObjPtr<mirror::String> s) { |
Mathieu Chartier | cdfd39f | 2014-08-29 18:16:58 -0700 | [diff] [blame] | 271 | InternStringLog log(s, InternStringLog::kStrongString, InternStringLog::kInsert); |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 272 | LogInternedString(std::move(log)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 273 | } |
| 274 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 275 | void Transaction::RecordWeakStringInsertion(ObjPtr<mirror::String> s) { |
Mathieu Chartier | cdfd39f | 2014-08-29 18:16:58 -0700 | [diff] [blame] | 276 | InternStringLog log(s, InternStringLog::kWeakString, InternStringLog::kInsert); |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 277 | LogInternedString(std::move(log)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 278 | } |
| 279 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 280 | void Transaction::RecordStrongStringRemoval(ObjPtr<mirror::String> s) { |
Mathieu Chartier | cdfd39f | 2014-08-29 18:16:58 -0700 | [diff] [blame] | 281 | InternStringLog log(s, InternStringLog::kStrongString, InternStringLog::kRemove); |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 282 | LogInternedString(std::move(log)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 283 | } |
| 284 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 285 | void Transaction::RecordWeakStringRemoval(ObjPtr<mirror::String> s) { |
Mathieu Chartier | cdfd39f | 2014-08-29 18:16:58 -0700 | [diff] [blame] | 286 | InternStringLog log(s, InternStringLog::kWeakString, InternStringLog::kRemove); |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 287 | LogInternedString(std::move(log)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 288 | } |
| 289 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 290 | void Transaction::LogInternedString(InternStringLog&& log) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 291 | Locks::intern_table_lock_->AssertExclusiveHeld(Thread::Current()); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 292 | DCHECK(assert_no_new_records_reason_ == nullptr) << assert_no_new_records_reason_; |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 293 | intern_string_logs_.push_front(std::move(log)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 294 | } |
| 295 | |
Sebastien Hertz | 1c80bec | 2015-02-03 11:58:06 +0100 | [diff] [blame] | 296 | void Transaction::Rollback() { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 297 | Thread* self = Thread::Current(); |
| 298 | self->AssertNoPendingException(); |
Vladimir Marko | 24c080f | 2021-07-06 14:04:30 +0100 | [diff] [blame] | 299 | MutexLock mu(self, *Locks::intern_table_lock_); |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 300 | rolling_back_ = true; |
| 301 | CHECK(!Runtime::Current()->IsActiveTransaction()); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 302 | UndoObjectModifications(); |
| 303 | UndoArrayModifications(); |
| 304 | UndoInternStringTableModifications(); |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 305 | UndoResolveStringModifications(); |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 306 | UndoResolveMethodTypeModifications(); |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 307 | rolling_back_ = false; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 308 | } |
| 309 | |
| 310 | void Transaction::UndoObjectModifications() { |
| 311 | // TODO we may not need to restore objects allocated during this transaction. Or we could directly |
| 312 | // remove them from the heap. |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 313 | for (const auto& it : object_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 314 | it.second.Undo(it.first); |
| 315 | } |
| 316 | object_logs_.clear(); |
| 317 | } |
| 318 | |
| 319 | void Transaction::UndoArrayModifications() { |
| 320 | // TODO we may not need to restore array allocated during this transaction. Or we could directly |
| 321 | // remove them from the heap. |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 322 | for (const auto& it : array_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 323 | it.second.Undo(it.first); |
| 324 | } |
| 325 | array_logs_.clear(); |
| 326 | } |
| 327 | |
| 328 | void Transaction::UndoInternStringTableModifications() { |
| 329 | InternTable* const intern_table = Runtime::Current()->GetInternTable(); |
| 330 | // We want to undo each operation from the most recent to the oldest. List has been filled so the |
| 331 | // most recent operation is at list begin so just have to iterate over it. |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 332 | for (const InternStringLog& string_log : intern_string_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 333 | string_log.Undo(intern_table); |
| 334 | } |
| 335 | intern_string_logs_.clear(); |
| 336 | } |
| 337 | |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 338 | void Transaction::UndoResolveStringModifications() { |
| 339 | for (ResolveStringLog& string_log : resolve_string_logs_) { |
| 340 | string_log.Undo(); |
| 341 | } |
| 342 | resolve_string_logs_.clear(); |
| 343 | } |
| 344 | |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 345 | void Transaction::UndoResolveMethodTypeModifications() { |
| 346 | for (ResolveMethodTypeLog& method_type_log : resolve_method_type_logs_) { |
| 347 | method_type_log.Undo(); |
| 348 | } |
| 349 | resolve_method_type_logs_.clear(); |
| 350 | } |
| 351 | |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 352 | void Transaction::VisitRoots(RootVisitor* visitor) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 353 | // Transactions are used for single-threaded initialization. |
| 354 | // This is the only function that should be called from a different thread, |
| 355 | // namely the GC thread, and it is called with the mutator lock held exclusively, |
| 356 | // so the data structures in the `Transaction` are protected from concurrent use. |
| 357 | DCHECK(Locks::mutator_lock_->IsExclusiveHeld(Thread::Current())); |
| 358 | |
Chang Xing | cade5c3 | 2017-07-20 17:56:26 -0700 | [diff] [blame] | 359 | visitor->VisitRoot(reinterpret_cast<mirror::Object**>(&root_), RootInfo(kRootUnknown)); |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 360 | { |
| 361 | // Create a separate `ArenaStack` for this thread. |
| 362 | ArenaStack arena_stack(Runtime::Current()->GetArenaPool()); |
| 363 | VisitObjectLogs(visitor, &arena_stack); |
| 364 | VisitArrayLogs(visitor, &arena_stack); |
| 365 | } |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 366 | VisitInternStringLogs(visitor); |
| 367 | VisitResolveStringLogs(visitor); |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 368 | VisitResolveMethodTypeLogs(visitor); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 369 | } |
| 370 | |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 371 | template <typename MovingRoots, typename Container> |
| 372 | void UpdateKeys(const MovingRoots& moving_roots, Container& container) { |
| 373 | for (const auto& pair : moving_roots) { |
| 374 | auto* old_root = pair.first; |
| 375 | auto* new_root = pair.second; |
| 376 | auto node = container.extract(old_root); |
| 377 | CHECK(!node.empty()); |
| 378 | node.key() = new_root; |
| 379 | bool inserted = container.insert(std::move(node)).inserted; |
| 380 | CHECK(inserted); |
| 381 | } |
| 382 | } |
| 383 | |
| 384 | void Transaction::VisitObjectLogs(RootVisitor* visitor, ArenaStack* arena_stack) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 385 | // List of moving roots. |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 386 | ScopedArenaAllocator allocator(arena_stack); |
Andreas Gampe | c55bb39 | 2018-09-21 00:02:02 +0000 | [diff] [blame] | 387 | using ObjectPair = std::pair<mirror::Object*, mirror::Object*>; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 388 | ScopedArenaForwardList<ObjectPair> moving_roots(allocator.Adapter(kArenaAllocTransaction)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 389 | |
| 390 | // Visit roots. |
Mathieu Chartier | 5f257b1 | 2017-02-03 14:47:36 -0800 | [diff] [blame] | 391 | for (auto& it : object_logs_) { |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 392 | it.second.VisitRoots(visitor); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 393 | mirror::Object* old_root = it.first; |
Mathieu Chartier | 815873e | 2014-02-13 18:02:13 -0800 | [diff] [blame] | 394 | mirror::Object* new_root = old_root; |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 395 | visitor->VisitRoot(&new_root, RootInfo(kRootUnknown)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 396 | if (new_root != old_root) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 397 | moving_roots.push_front(std::make_pair(old_root, new_root)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 398 | } |
| 399 | } |
| 400 | |
| 401 | // Update object logs with moving roots. |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 402 | UpdateKeys(moving_roots, object_logs_); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 403 | } |
| 404 | |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 405 | void Transaction::VisitArrayLogs(RootVisitor* visitor, ArenaStack* arena_stack) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 406 | // List of moving roots. |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 407 | ScopedArenaAllocator allocator(arena_stack); |
Andreas Gampe | c55bb39 | 2018-09-21 00:02:02 +0000 | [diff] [blame] | 408 | using ArrayPair = std::pair<mirror::Array*, mirror::Array*>; |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 409 | ScopedArenaForwardList<ArrayPair> moving_roots(allocator.Adapter(kArenaAllocTransaction)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 410 | |
Mathieu Chartier | 5f257b1 | 2017-02-03 14:47:36 -0800 | [diff] [blame] | 411 | for (auto& it : array_logs_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 412 | mirror::Array* old_root = it.first; |
Mathieu Chartier | 815873e | 2014-02-13 18:02:13 -0800 | [diff] [blame] | 413 | mirror::Array* new_root = old_root; |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 414 | visitor->VisitRoot(reinterpret_cast<mirror::Object**>(&new_root), RootInfo(kRootUnknown)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 415 | if (new_root != old_root) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 416 | moving_roots.push_front(std::make_pair(old_root, new_root)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 417 | } |
| 418 | } |
| 419 | |
| 420 | // Update array logs with moving roots. |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 421 | UpdateKeys(moving_roots, array_logs_); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 422 | } |
| 423 | |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 424 | void Transaction::VisitInternStringLogs(RootVisitor* visitor) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 425 | for (InternStringLog& log : intern_string_logs_) { |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 426 | log.VisitRoots(visitor); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 427 | } |
| 428 | } |
| 429 | |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 430 | void Transaction::VisitResolveStringLogs(RootVisitor* visitor) { |
| 431 | for (ResolveStringLog& log : resolve_string_logs_) { |
| 432 | log.VisitRoots(visitor); |
| 433 | } |
| 434 | } |
| 435 | |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 436 | void Transaction::VisitResolveMethodTypeLogs(RootVisitor* visitor) { |
| 437 | for (ResolveMethodTypeLog& log : resolve_method_type_logs_) { |
| 438 | log.VisitRoots(visitor); |
| 439 | } |
| 440 | } |
| 441 | |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 442 | void Transaction::ObjectLog::LogBooleanValue(MemberOffset offset, uint8_t value, bool is_volatile) { |
| 443 | LogValue(ObjectLog::kBoolean, offset, value, is_volatile); |
| 444 | } |
| 445 | |
| 446 | void Transaction::ObjectLog::LogByteValue(MemberOffset offset, int8_t value, bool is_volatile) { |
| 447 | LogValue(ObjectLog::kByte, offset, value, is_volatile); |
| 448 | } |
| 449 | |
| 450 | void Transaction::ObjectLog::LogCharValue(MemberOffset offset, uint16_t value, bool is_volatile) { |
| 451 | LogValue(ObjectLog::kChar, offset, value, is_volatile); |
| 452 | } |
| 453 | |
| 454 | void Transaction::ObjectLog::LogShortValue(MemberOffset offset, int16_t value, bool is_volatile) { |
| 455 | LogValue(ObjectLog::kShort, offset, value, is_volatile); |
| 456 | } |
| 457 | |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 458 | void Transaction::ObjectLog::Log32BitsValue(MemberOffset offset, uint32_t value, bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 459 | LogValue(ObjectLog::k32Bits, offset, value, is_volatile); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 460 | } |
| 461 | |
| 462 | void Transaction::ObjectLog::Log64BitsValue(MemberOffset offset, uint64_t value, bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 463 | LogValue(ObjectLog::k64Bits, offset, value, is_volatile); |
| 464 | } |
| 465 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 466 | void Transaction::ObjectLog::LogReferenceValue(MemberOffset offset, |
| 467 | mirror::Object* obj, |
| 468 | bool is_volatile) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 469 | LogValue(ObjectLog::kReference, offset, reinterpret_cast<uintptr_t>(obj), is_volatile); |
| 470 | } |
| 471 | |
| 472 | void Transaction::ObjectLog::LogValue(ObjectLog::FieldValueKind kind, |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 473 | MemberOffset offset, |
| 474 | uint64_t value, |
| 475 | bool is_volatile) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 476 | auto it = field_values_.find(offset.Uint32Value()); |
| 477 | if (it == field_values_.end()) { |
| 478 | ObjectLog::FieldValue field_value; |
| 479 | field_value.value = value; |
| 480 | field_value.is_volatile = is_volatile; |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 481 | field_value.kind = kind; |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 482 | field_values_.emplace(offset.Uint32Value(), std::move(field_value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 483 | } |
| 484 | } |
| 485 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 486 | void Transaction::ObjectLog::Undo(mirror::Object* obj) const { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 487 | for (auto& it : field_values_) { |
| 488 | // Garbage collector needs to access object's class and array's length. So we don't rollback |
| 489 | // these values. |
| 490 | MemberOffset field_offset(it.first); |
| 491 | if (field_offset.Uint32Value() == mirror::Class::ClassOffset().Uint32Value()) { |
| 492 | // Skip Object::class field. |
| 493 | continue; |
| 494 | } |
| 495 | if (obj->IsArrayInstance() && |
| 496 | field_offset.Uint32Value() == mirror::Array::LengthOffset().Uint32Value()) { |
| 497 | // Skip Array::length field. |
| 498 | continue; |
| 499 | } |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 500 | const FieldValue& field_value = it.second; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 501 | UndoFieldWrite(obj, field_offset, field_value); |
| 502 | } |
| 503 | } |
| 504 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 505 | void Transaction::ObjectLog::UndoFieldWrite(mirror::Object* obj, |
| 506 | MemberOffset field_offset, |
| 507 | const FieldValue& field_value) const { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 508 | // TODO We may want to abort a transaction while still being in transaction mode. In this case, |
| 509 | // we'd need to disable the check. |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 510 | constexpr bool kCheckTransaction = false; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 511 | switch (field_value.kind) { |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 512 | case kBoolean: |
| 513 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 514 | obj->SetFieldBooleanVolatile<false, kCheckTransaction>( |
| 515 | field_offset, |
Andreas Gampe | 7c5acbb | 2018-09-20 13:54:52 -0700 | [diff] [blame] | 516 | field_value.value); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 517 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 518 | obj->SetFieldBoolean<false, kCheckTransaction>( |
| 519 | field_offset, |
Andreas Gampe | 7c5acbb | 2018-09-20 13:54:52 -0700 | [diff] [blame] | 520 | field_value.value); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 521 | } |
| 522 | break; |
| 523 | case kByte: |
| 524 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 525 | obj->SetFieldByteVolatile<false, kCheckTransaction>( |
| 526 | field_offset, |
| 527 | static_cast<int8_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 528 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 529 | obj->SetFieldByte<false, kCheckTransaction>( |
| 530 | field_offset, |
| 531 | static_cast<int8_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 532 | } |
| 533 | break; |
| 534 | case kChar: |
| 535 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 536 | obj->SetFieldCharVolatile<false, kCheckTransaction>( |
| 537 | field_offset, |
| 538 | static_cast<uint16_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 539 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 540 | obj->SetFieldChar<false, kCheckTransaction>( |
| 541 | field_offset, |
| 542 | static_cast<uint16_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 543 | } |
| 544 | break; |
| 545 | case kShort: |
| 546 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 547 | obj->SetFieldShortVolatile<false, kCheckTransaction>( |
| 548 | field_offset, |
| 549 | static_cast<int16_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 550 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 551 | obj->SetFieldShort<false, kCheckTransaction>( |
| 552 | field_offset, |
| 553 | static_cast<int16_t>(field_value.value)); |
Fred Shih | 37f05ef | 2014-07-16 18:38:08 -0700 | [diff] [blame] | 554 | } |
| 555 | break; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 556 | case k32Bits: |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 557 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 558 | obj->SetField32Volatile<false, kCheckTransaction>( |
| 559 | field_offset, |
| 560 | static_cast<uint32_t>(field_value.value)); |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 561 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 562 | obj->SetField32<false, kCheckTransaction>( |
| 563 | field_offset, |
| 564 | static_cast<uint32_t>(field_value.value)); |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 565 | } |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 566 | break; |
| 567 | case k64Bits: |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 568 | if (UNLIKELY(field_value.is_volatile)) { |
| 569 | obj->SetField64Volatile<false, kCheckTransaction>(field_offset, field_value.value); |
| 570 | } else { |
| 571 | obj->SetField64<false, kCheckTransaction>(field_offset, field_value.value); |
| 572 | } |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 573 | break; |
| 574 | case kReference: |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 575 | if (UNLIKELY(field_value.is_volatile)) { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 576 | obj->SetFieldObjectVolatile<false, kCheckTransaction>( |
| 577 | field_offset, |
| 578 | reinterpret_cast<mirror::Object*>(field_value.value)); |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 579 | } else { |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 580 | obj->SetFieldObject<false, kCheckTransaction>( |
| 581 | field_offset, |
| 582 | reinterpret_cast<mirror::Object*>(field_value.value)); |
Ian Rogers | b0fa5dc | 2014-04-28 16:47:08 -0700 | [diff] [blame] | 583 | } |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 584 | break; |
| 585 | default: |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 586 | LOG(FATAL) << "Unknown value kind " << static_cast<int>(field_value.kind); |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 587 | UNREACHABLE(); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 588 | } |
| 589 | } |
| 590 | |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 591 | void Transaction::ObjectLog::VisitRoots(RootVisitor* visitor) { |
Mathieu Chartier | 5f257b1 | 2017-02-03 14:47:36 -0800 | [diff] [blame] | 592 | for (auto& it : field_values_) { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 593 | FieldValue& field_value = it.second; |
| 594 | if (field_value.kind == ObjectLog::kReference) { |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 595 | visitor->VisitRootIfNonNull(reinterpret_cast<mirror::Object**>(&field_value.value), |
| 596 | RootInfo(kRootUnknown)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 597 | } |
| 598 | } |
| 599 | } |
| 600 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 601 | void Transaction::InternStringLog::Undo(InternTable* intern_table) const { |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 602 | DCHECK(!Runtime::Current()->IsActiveTransaction()); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 603 | DCHECK(intern_table != nullptr); |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 604 | ObjPtr<mirror::String> s = str_.Read(); |
| 605 | uint32_t hash = static_cast<uint32_t>(s->GetStoredHashCode()); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 606 | switch (string_op_) { |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 607 | case InternStringLog::kInsert: { |
| 608 | switch (string_kind_) { |
| 609 | case InternStringLog::kStrongString: |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 610 | intern_table->RemoveStrong(s, hash); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 611 | break; |
| 612 | case InternStringLog::kWeakString: |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 613 | intern_table->RemoveWeak(s, hash); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 614 | break; |
| 615 | default: |
| 616 | LOG(FATAL) << "Unknown interned string kind"; |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 617 | UNREACHABLE(); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 618 | } |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 619 | break; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 620 | } |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 621 | case InternStringLog::kRemove: { |
| 622 | switch (string_kind_) { |
| 623 | case InternStringLog::kStrongString: |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 624 | intern_table->InsertStrong(s, hash); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 625 | break; |
| 626 | case InternStringLog::kWeakString: |
Vladimir Marko | 365c020 | 2022-03-22 09:53:31 +0000 | [diff] [blame] | 627 | intern_table->InsertWeak(s, hash); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 628 | break; |
| 629 | default: |
| 630 | LOG(FATAL) << "Unknown interned string kind"; |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 631 | UNREACHABLE(); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 632 | } |
| 633 | break; |
| 634 | } |
| 635 | default: |
| 636 | LOG(FATAL) << "Unknown interned string op"; |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 637 | UNREACHABLE(); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 638 | } |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 639 | } |
| 640 | |
Mathieu Chartier | bb87e0f | 2015-04-03 11:21:55 -0700 | [diff] [blame] | 641 | void Transaction::InternStringLog::VisitRoots(RootVisitor* visitor) { |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 642 | str_.VisitRoot(visitor, RootInfo(kRootInternedString)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 643 | } |
| 644 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 645 | void Transaction::ResolveStringLog::Undo() const { |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 646 | dex_cache_.Read()->ClearString(string_idx_); |
| 647 | } |
| 648 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 649 | Transaction::ResolveStringLog::ResolveStringLog(ObjPtr<mirror::DexCache> dex_cache, |
Andreas Gampe | 8a0128a | 2016-11-28 07:38:35 -0800 | [diff] [blame] | 650 | dex::StringIndex string_idx) |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 651 | : dex_cache_(dex_cache), |
| 652 | string_idx_(string_idx) { |
| 653 | DCHECK(dex_cache != nullptr); |
Andreas Gampe | 8a0128a | 2016-11-28 07:38:35 -0800 | [diff] [blame] | 654 | DCHECK_LT(string_idx_.index_, dex_cache->GetDexFile()->NumStringIds()); |
Mathieu Chartier | bb816d6 | 2016-09-07 10:17:46 -0700 | [diff] [blame] | 655 | } |
| 656 | |
| 657 | void Transaction::ResolveStringLog::VisitRoots(RootVisitor* visitor) { |
| 658 | dex_cache_.VisitRoot(visitor, RootInfo(kRootVMInternal)); |
| 659 | } |
| 660 | |
Vladimir Marko | e9a4a60 | 2021-06-22 16:33:34 +0100 | [diff] [blame] | 661 | void Transaction::ResolveMethodTypeLog::Undo() const { |
| 662 | dex_cache_.Read()->ClearMethodType(proto_idx_); |
| 663 | } |
| 664 | |
| 665 | Transaction::ResolveMethodTypeLog::ResolveMethodTypeLog(ObjPtr<mirror::DexCache> dex_cache, |
| 666 | dex::ProtoIndex proto_idx) |
| 667 | : dex_cache_(dex_cache), |
| 668 | proto_idx_(proto_idx) { |
| 669 | DCHECK(dex_cache != nullptr); |
| 670 | DCHECK_LT(proto_idx_.index_, dex_cache->GetDexFile()->NumProtoIds()); |
| 671 | } |
| 672 | |
| 673 | void Transaction::ResolveMethodTypeLog::VisitRoots(RootVisitor* visitor) { |
| 674 | dex_cache_.VisitRoot(visitor, RootInfo(kRootVMInternal)); |
| 675 | } |
| 676 | |
Mathieu Chartier | 9e86809 | 2016-10-31 14:58:04 -0700 | [diff] [blame] | 677 | Transaction::InternStringLog::InternStringLog(ObjPtr<mirror::String> s, |
| 678 | StringKind kind, |
| 679 | StringOp op) |
| 680 | : str_(s), |
| 681 | string_kind_(kind), |
| 682 | string_op_(op) { |
| 683 | DCHECK(s != nullptr); |
| 684 | } |
| 685 | |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 686 | void Transaction::ArrayLog::LogValue(size_t index, uint64_t value) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 687 | // Add a mapping if there is none yet. |
| 688 | array_values_.FindOrAdd(index, value); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 689 | } |
| 690 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 691 | void Transaction::ArrayLog::Undo(mirror::Array* array) const { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 692 | DCHECK(array != nullptr); |
| 693 | DCHECK(array->IsArrayInstance()); |
| 694 | Primitive::Type type = array->GetClass()->GetComponentType()->GetPrimitiveType(); |
| 695 | for (auto it : array_values_) { |
| 696 | UndoArrayWrite(array, type, it.first, it.second); |
| 697 | } |
| 698 | } |
| 699 | |
Mathieu Chartier | 38e954c | 2017-02-03 16:06:35 -0800 | [diff] [blame] | 700 | void Transaction::ArrayLog::UndoArrayWrite(mirror::Array* array, |
| 701 | Primitive::Type array_type, |
| 702 | size_t index, |
| 703 | uint64_t value) const { |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 704 | // TODO We may want to abort a transaction while still being in transaction mode. In this case, |
| 705 | // we'd need to disable the check. |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 706 | constexpr bool kCheckTransaction = false; |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 707 | switch (array_type) { |
| 708 | case Primitive::kPrimBoolean: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 709 | array->AsBooleanArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 710 | index, static_cast<uint8_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 711 | break; |
| 712 | case Primitive::kPrimByte: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 713 | array->AsByteArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 714 | index, static_cast<int8_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 715 | break; |
| 716 | case Primitive::kPrimChar: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 717 | array->AsCharArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 718 | index, static_cast<uint16_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 719 | break; |
| 720 | case Primitive::kPrimShort: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 721 | array->AsShortArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 722 | index, static_cast<int16_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 723 | break; |
| 724 | case Primitive::kPrimInt: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 725 | array->AsIntArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 726 | index, static_cast<int32_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 727 | break; |
| 728 | case Primitive::kPrimFloat: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 729 | array->AsFloatArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 730 | index, static_cast<float>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 731 | break; |
| 732 | case Primitive::kPrimLong: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 733 | array->AsLongArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 734 | index, static_cast<int64_t>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 735 | break; |
| 736 | case Primitive::kPrimDouble: |
Chang Xing | 605fe24 | 2017-07-20 15:57:21 -0700 | [diff] [blame] | 737 | array->AsDoubleArray()->SetWithoutChecks<false, kCheckTransaction>( |
| 738 | index, static_cast<double>(value)); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 739 | break; |
Sebastien Hertz | ee1d79a | 2014-02-21 15:46:30 +0100 | [diff] [blame] | 740 | case Primitive::kPrimNot: |
| 741 | LOG(FATAL) << "ObjectArray should be treated as Object"; |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 742 | UNREACHABLE(); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 743 | default: |
| 744 | LOG(FATAL) << "Unsupported type " << array_type; |
Elliott Hughes | c1896c9 | 2018-11-29 11:33:18 -0800 | [diff] [blame] | 745 | UNREACHABLE(); |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 746 | } |
| 747 | } |
| 748 | |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 749 | Transaction* ScopedAssertNoNewTransactionRecords::InstallAssertion(const char* reason) { |
| 750 | Transaction* transaction = nullptr; |
| 751 | if (kIsDebugBuild && Runtime::Current()->IsActiveTransaction()) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 752 | transaction = Runtime::Current()->GetTransaction(); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 753 | if (transaction != nullptr) { |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 754 | CHECK(transaction->assert_no_new_records_reason_ == nullptr) |
| 755 | << "old: " << transaction->assert_no_new_records_reason_ << " new: " << reason; |
| 756 | transaction->assert_no_new_records_reason_ = reason; |
| 757 | } |
| 758 | } |
| 759 | return transaction; |
| 760 | } |
| 761 | |
| 762 | void ScopedAssertNoNewTransactionRecords::RemoveAssertion(Transaction* transaction) { |
| 763 | if (kIsDebugBuild) { |
Vladimir Marko | b6e6792 | 2021-07-06 15:53:07 +0100 | [diff] [blame] | 764 | CHECK(Runtime::Current()->GetTransaction() == transaction); |
Vladimir Marko | b68bb7a | 2020-03-17 10:55:25 +0000 | [diff] [blame] | 765 | CHECK(transaction->assert_no_new_records_reason_ != nullptr); |
| 766 | transaction->assert_no_new_records_reason_ = nullptr; |
| 767 | } |
| 768 | } |
| 769 | |
Sebastien Hertz | d2fe10a | 2014-01-15 10:20:56 +0100 | [diff] [blame] | 770 | } // namespace art |