blob: 937e2585ef4d19320d2e3f9c013fe416de303b88 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "compiler_internals.h"
18#include "local_value_numbering.h"
Ian Rogers8d3a1172013-06-04 01:13:28 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko9820b7c2014-01-02 16:40:37 +000020#include "dex/quick/dex_file_method_inliner.h"
21#include "dex/quick/dex_file_to_method_inliner_map.h"
buzbee311ca162013-02-28 15:56:43 -080022
23namespace art {
24
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070025static unsigned int Predecessors(BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -070026 return bb->predecessors->Size();
buzbee311ca162013-02-28 15:56:43 -080027}
28
29/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030void MIRGraph::SetConstant(int32_t ssa_reg, int value) {
buzbee862a7602013-04-05 10:58:54 -070031 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080032 constant_values_[ssa_reg] = value;
33}
34
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070035void MIRGraph::SetConstantWide(int ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = Low32Bits(value);
38 constant_values_[ssa_reg + 1] = High32Bits(value);
39}
40
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080041void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080042 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080043
44 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070045 // Skip pass if BB has MIR without SSA representation.
46 if (mir->ssa_rep == NULL) {
47 return;
48 }
49
buzbee1da1e2f2013-11-15 13:37:01 -080050 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -080051
52 DecodedInstruction *d_insn = &mir->dalvikInsn;
53
54 if (!(df_attributes & DF_HAS_DEFS)) continue;
55
56 /* Handle instructions that set up constants directly */
57 if (df_attributes & DF_SETS_CONST) {
58 if (df_attributes & DF_DA) {
59 int32_t vB = static_cast<int32_t>(d_insn->vB);
60 switch (d_insn->opcode) {
61 case Instruction::CONST_4:
62 case Instruction::CONST_16:
63 case Instruction::CONST:
64 SetConstant(mir->ssa_rep->defs[0], vB);
65 break;
66 case Instruction::CONST_HIGH16:
67 SetConstant(mir->ssa_rep->defs[0], vB << 16);
68 break;
69 case Instruction::CONST_WIDE_16:
70 case Instruction::CONST_WIDE_32:
71 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
72 break;
73 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070074 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080075 break;
76 case Instruction::CONST_WIDE_HIGH16:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
78 break;
79 default:
80 break;
81 }
82 }
83 /* Handle instructions that set up constants directly */
84 } else if (df_attributes & DF_IS_MOVE) {
85 int i;
86
87 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070088 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080089 }
90 /* Move a register holding a constant to another register */
91 if (i == mir->ssa_rep->num_uses) {
92 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
93 if (df_attributes & DF_A_WIDE) {
94 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
95 }
96 }
97 }
98 }
99 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800100}
101
buzbee311ca162013-02-28 15:56:43 -0800102/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700103MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800104 BasicBlock* bb = *p_bb;
105 if (mir != NULL) {
106 mir = mir->next;
107 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700108 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800109 if ((bb == NULL) || Predecessors(bb) != 1) {
110 mir = NULL;
111 } else {
112 *p_bb = bb;
113 mir = bb->first_mir_insn;
114 }
115 }
116 }
117 return mir;
118}
119
120/*
121 * To be used at an invoke mir. If the logically next mir node represents
122 * a move-result, return it. Else, return NULL. If a move-result exists,
123 * it is required to immediately follow the invoke with no intervening
124 * opcodes or incoming arcs. However, if the result of the invoke is not
125 * used, a move-result may not be present.
126 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700127MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800128 BasicBlock* tbb = bb;
129 mir = AdvanceMIR(&tbb, mir);
130 while (mir != NULL) {
131 int opcode = mir->dalvikInsn.opcode;
132 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
133 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
134 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
135 break;
136 }
137 // Keep going if pseudo op, otherwise terminate
138 if (opcode < kNumPackedOpcodes) {
139 mir = NULL;
140 } else {
141 mir = AdvanceMIR(&tbb, mir);
142 }
143 }
144 return mir;
145}
146
buzbee0d829482013-10-11 15:24:55 -0700147BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800148 if (bb->block_type == kDead) {
149 return NULL;
150 }
151 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
152 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700153 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
154 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800155 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700156 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700157 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700158 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700159 } else {
160 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700161 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700162 }
buzbee311ca162013-02-28 15:56:43 -0800163 if (bb == NULL || (Predecessors(bb) != 1)) {
164 return NULL;
165 }
166 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
167 return bb;
168}
169
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700170static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800171 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
172 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
173 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
174 if (mir->ssa_rep->uses[i] == ssa_name) {
175 return mir;
176 }
177 }
178 }
179 }
180 return NULL;
181}
182
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700183static SelectInstructionKind SelectKind(MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800184 switch (mir->dalvikInsn.opcode) {
185 case Instruction::MOVE:
186 case Instruction::MOVE_OBJECT:
187 case Instruction::MOVE_16:
188 case Instruction::MOVE_OBJECT_16:
189 case Instruction::MOVE_FROM16:
190 case Instruction::MOVE_OBJECT_FROM16:
191 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700192 case Instruction::CONST:
193 case Instruction::CONST_4:
194 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800195 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700196 case Instruction::GOTO:
197 case Instruction::GOTO_16:
198 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800199 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700200 default:
201 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800202 }
buzbee311ca162013-02-28 15:56:43 -0800203}
204
Vladimir Markoa1a70742014-03-03 10:28:05 +0000205static constexpr ConditionCode kIfCcZConditionCodes[] = {
206 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
207};
208
209COMPILE_ASSERT(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
210 if_ccz_ccodes_size1);
211
212static constexpr bool IsInstructionIfCcZ(Instruction::Code opcode) {
213 return Instruction::IF_EQZ <= opcode && opcode <= Instruction::IF_LEZ;
214}
215
216static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
217 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
218}
219
220COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, check_if_eqz_ccode);
221COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, check_if_nez_ccode);
222COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, check_if_ltz_ccode);
223COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, check_if_gez_ccode);
224COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, check_if_gtz_ccode);
225COMPILE_ASSERT(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, check_if_lez_ccode);
226
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700227int MIRGraph::GetSSAUseCount(int s_reg) {
buzbee862a7602013-04-05 10:58:54 -0700228 return raw_use_counts_.Get(s_reg);
buzbee311ca162013-02-28 15:56:43 -0800229}
230
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800231size_t MIRGraph::GetNumAvailableNonSpecialCompilerTemps() {
232 if (num_non_special_compiler_temps_ >= max_available_non_special_compiler_temps_) {
233 return 0;
234 } else {
235 return max_available_non_special_compiler_temps_ - num_non_special_compiler_temps_;
236 }
237}
238
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000239
240// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241static const RegLocation temp_loc = {kLocCompilerTemp,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000242 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/, kVectorNotUsed,
243 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800244
245CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
246 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
247 if (ct_type == kCompilerTempVR) {
248 size_t available_temps = GetNumAvailableNonSpecialCompilerTemps();
249 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
250 return 0;
251 }
252 }
253
254 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000255 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800256
257 // Create the type of temp requested. Special temps need special handling because
258 // they have a specific virtual register assignment.
259 if (ct_type == kCompilerTempSpecialMethodPtr) {
260 DCHECK_EQ(wide, false);
261 compiler_temp->v_reg = static_cast<int>(kVRegMethodPtrBaseReg);
262 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
263
264 // The MIR graph keeps track of the sreg for method pointer specially, so record that now.
265 method_sreg_ = compiler_temp->s_reg_low;
266 } else {
267 DCHECK_EQ(ct_type, kCompilerTempVR);
268
269 // The new non-special compiler temp must receive a unique v_reg with a negative value.
270 compiler_temp->v_reg = static_cast<int>(kVRegNonSpecialTempBaseReg) - num_non_special_compiler_temps_;
271 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
272 num_non_special_compiler_temps_++;
273
274 if (wide) {
275 // Ensure that the two registers are consecutive. Since the virtual registers used for temps grow in a
276 // negative fashion, we need the smaller to refer to the low part. Thus, we redefine the v_reg and s_reg_low.
277 compiler_temp->v_reg--;
278 int ssa_reg_high = compiler_temp->s_reg_low;
279 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
280 int ssa_reg_low = compiler_temp->s_reg_low;
281
282 // If needed initialize the register location for the high part.
283 // The low part is handled later in this method on a common path.
284 if (reg_location_ != nullptr) {
285 reg_location_[ssa_reg_high] = temp_loc;
286 reg_location_[ssa_reg_high].high_word = 1;
287 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
288 reg_location_[ssa_reg_high].wide = true;
289
290 // A new SSA needs new use counts.
291 use_counts_.Insert(0);
292 raw_use_counts_.Insert(0);
293 }
294
295 num_non_special_compiler_temps_++;
296 }
297 }
298
299 // Have we already allocated the register locations?
300 if (reg_location_ != nullptr) {
301 int ssa_reg_low = compiler_temp->s_reg_low;
302 reg_location_[ssa_reg_low] = temp_loc;
303 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
304 reg_location_[ssa_reg_low].wide = wide;
305
306 // A new SSA needs new use counts.
307 use_counts_.Insert(0);
308 raw_use_counts_.Insert(0);
309 }
310
311 compiler_temps_.Insert(compiler_temp);
312 return compiler_temp;
313}
buzbee311ca162013-02-28 15:56:43 -0800314
315/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700316bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800317 if (bb->block_type == kDead) {
318 return true;
319 }
buzbee1da1e2f2013-11-15 13:37:01 -0800320 bool use_lvn = bb->use_lvn;
321 UniquePtr<LocalValueNumbering> local_valnum;
322 if (use_lvn) {
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000323 local_valnum.reset(LocalValueNumbering::Create(cu_));
buzbee1da1e2f2013-11-15 13:37:01 -0800324 }
buzbee311ca162013-02-28 15:56:43 -0800325 while (bb != NULL) {
326 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
327 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800328 if (use_lvn) {
329 local_valnum->GetValueNumber(mir);
330 }
buzbee311ca162013-02-28 15:56:43 -0800331 // Look for interesting opcodes, skip otherwise
332 Instruction::Code opcode = mir->dalvikInsn.opcode;
333 switch (opcode) {
334 case Instruction::CMPL_FLOAT:
335 case Instruction::CMPL_DOUBLE:
336 case Instruction::CMPG_FLOAT:
337 case Instruction::CMPG_DOUBLE:
338 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700339 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800340 // Bitcode doesn't allow this optimization.
341 break;
342 }
343 if (mir->next != NULL) {
344 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800345 // Make sure result of cmp is used by next insn and nowhere else
Vladimir Markoa1a70742014-03-03 10:28:05 +0000346 if (IsInstructionIfCcZ(mir->next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800347 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
348 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000349 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700350 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800351 case Instruction::CMPL_FLOAT:
352 mir_next->dalvikInsn.opcode =
353 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
354 break;
355 case Instruction::CMPL_DOUBLE:
356 mir_next->dalvikInsn.opcode =
357 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
358 break;
359 case Instruction::CMPG_FLOAT:
360 mir_next->dalvikInsn.opcode =
361 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
362 break;
363 case Instruction::CMPG_DOUBLE:
364 mir_next->dalvikInsn.opcode =
365 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
366 break;
367 case Instruction::CMP_LONG:
368 mir_next->dalvikInsn.opcode =
369 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
370 break;
371 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
372 }
373 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
374 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
375 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
376 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
377 mir_next->ssa_rep->num_defs = 0;
378 mir->ssa_rep->num_uses = 0;
379 mir->ssa_rep->num_defs = 0;
380 }
381 }
382 break;
383 case Instruction::GOTO:
384 case Instruction::GOTO_16:
385 case Instruction::GOTO_32:
386 case Instruction::IF_EQ:
387 case Instruction::IF_NE:
388 case Instruction::IF_LT:
389 case Instruction::IF_GE:
390 case Instruction::IF_GT:
391 case Instruction::IF_LE:
392 case Instruction::IF_EQZ:
393 case Instruction::IF_NEZ:
394 case Instruction::IF_LTZ:
395 case Instruction::IF_GEZ:
396 case Instruction::IF_GTZ:
397 case Instruction::IF_LEZ:
buzbeecbcfaf32013-08-19 07:37:40 -0700398 // If we've got a backwards branch to return, no need to suspend check.
buzbee0d829482013-10-11 15:24:55 -0700399 if ((IsBackedge(bb, bb->taken) && GetBasicBlock(bb->taken)->dominates_return) ||
400 (IsBackedge(bb, bb->fall_through) &&
401 GetBasicBlock(bb->fall_through)->dominates_return)) {
buzbee311ca162013-02-28 15:56:43 -0800402 mir->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
403 if (cu_->verbose) {
buzbee0d829482013-10-11 15:24:55 -0700404 LOG(INFO) << "Suppressed suspend check on branch to return at 0x" << std::hex
405 << mir->offset;
buzbee311ca162013-02-28 15:56:43 -0800406 }
407 }
408 break;
409 default:
410 break;
411 }
412 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800413 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800414 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000415 if (!cu_->compiler->IsPortable() &&
Dmitry Petrochenko6a58cb12014-04-02 17:27:59 +0700416 (cu_->instruction_set == kThumb2 || cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000417 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700418 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800419 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700420 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
421 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800422
buzbee0d829482013-10-11 15:24:55 -0700423 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800424 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700425 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
426 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800427
428 /*
429 * In the select pattern, the taken edge goes to a block that unconditionally
430 * transfers to the rejoin block and the fall_though edge goes to a block that
431 * unconditionally falls through to the rejoin block.
432 */
433 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
434 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
435 /*
436 * Okay - we have the basic diamond shape. At the very least, we can eliminate the
437 * suspend check on the taken-taken branch back to the join point.
438 */
439 if (SelectKind(tk->last_mir_insn) == kSelectGoto) {
440 tk->last_mir_insn->optimization_flags |= (MIR_IGNORE_SUSPEND_CHECK);
441 }
442 // Are the block bodies something we can handle?
443 if ((ft->first_mir_insn == ft->last_mir_insn) &&
444 (tk->first_mir_insn != tk->last_mir_insn) &&
445 (tk->first_mir_insn->next == tk->last_mir_insn) &&
446 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
447 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
448 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
449 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
450 // Almost there. Are the instructions targeting the same vreg?
451 MIR* if_true = tk->first_mir_insn;
452 MIR* if_false = ft->first_mir_insn;
453 // It's possible that the target of the select isn't used - skip those (rare) cases.
454 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
455 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
456 /*
457 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
458 * Phi node in the merge block and delete it (while using the SSA name
459 * of the merge as the target of the SELECT. Delete both taken and
460 * fallthrough blocks, and set fallthrough to merge block.
461 * NOTE: not updating other dataflow info (no longer used at this point).
462 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
463 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000464 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800465 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
466 bool const_form = (SelectKind(if_true) == kSelectConst);
467 if ((SelectKind(if_true) == kSelectMove)) {
468 if (IsConst(if_true->ssa_rep->uses[0]) &&
469 IsConst(if_false->ssa_rep->uses[0])) {
470 const_form = true;
471 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
472 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
473 }
474 }
475 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800476 /*
477 * TODO: If both constants are the same value, then instead of generating
478 * a select, we should simply generate a const bytecode. This should be
479 * considered after inlining which can lead to CFG of this form.
480 */
buzbee311ca162013-02-28 15:56:43 -0800481 // "true" set val in vB
482 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
483 // "false" set val in vC
484 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
485 } else {
486 DCHECK_EQ(SelectKind(if_true), kSelectMove);
487 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700488 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000489 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800490 src_ssa[0] = mir->ssa_rep->uses[0];
491 src_ssa[1] = if_true->ssa_rep->uses[0];
492 src_ssa[2] = if_false->ssa_rep->uses[0];
493 mir->ssa_rep->uses = src_ssa;
494 mir->ssa_rep->num_uses = 3;
495 }
496 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700497 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000498 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700499 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000500 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800501 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700502 // Match type of uses to def.
503 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700504 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000505 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700506 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
507 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
508 }
buzbee311ca162013-02-28 15:56:43 -0800509 /*
510 * There is usually a Phi node in the join block for our two cases. If the
511 * Phi node only contains our two cases as input, we will use the result
512 * SSA name of the Phi node as our select result and delete the Phi. If
513 * the Phi node has more than two operands, we will arbitrarily use the SSA
514 * name of the "true" path, delete the SSA name of the "false" path from the
515 * Phi node (and fix up the incoming arc list).
516 */
517 if (phi->ssa_rep->num_uses == 2) {
518 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
519 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
520 } else {
521 int dead_def = if_false->ssa_rep->defs[0];
522 int live_def = if_true->ssa_rep->defs[0];
523 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700524 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800525 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
526 if (phi->ssa_rep->uses[i] == live_def) {
527 incoming[i] = bb->id;
528 }
529 }
530 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
531 if (phi->ssa_rep->uses[i] == dead_def) {
532 int last_slot = phi->ssa_rep->num_uses - 1;
533 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
534 incoming[i] = incoming[last_slot];
535 }
536 }
537 }
538 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700539 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800540 tk->block_type = kDead;
541 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
542 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
543 }
544 }
545 }
546 }
547 }
548 }
buzbee1da1e2f2013-11-15 13:37:01 -0800549 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800550 }
551
buzbee311ca162013-02-28 15:56:43 -0800552 return true;
553}
554
buzbee311ca162013-02-28 15:56:43 -0800555/* Collect stats on number of checks removed */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700556void MIRGraph::CountChecks(struct BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700557 if (bb->data_flow_info != NULL) {
558 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
559 if (mir->ssa_rep == NULL) {
560 continue;
buzbee311ca162013-02-28 15:56:43 -0800561 }
buzbee1da1e2f2013-11-15 13:37:01 -0800562 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee862a7602013-04-05 10:58:54 -0700563 if (df_attributes & DF_HAS_NULL_CHKS) {
564 checkstats_->null_checks++;
565 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
566 checkstats_->null_checks_eliminated++;
567 }
568 }
569 if (df_attributes & DF_HAS_RANGE_CHKS) {
570 checkstats_->range_checks++;
571 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
572 checkstats_->range_checks_eliminated++;
573 }
buzbee311ca162013-02-28 15:56:43 -0800574 }
575 }
576 }
buzbee311ca162013-02-28 15:56:43 -0800577}
578
579/* Try to make common case the fallthrough path */
buzbee0d829482013-10-11 15:24:55 -0700580bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800581 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback
582 if (!bb->explicit_throw) {
583 return false;
584 }
585 BasicBlock* walker = bb;
586 while (true) {
587 // Check termination conditions
588 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
589 break;
590 }
buzbee0d829482013-10-11 15:24:55 -0700591 BasicBlock* prev = GetBasicBlock(walker->predecessors->Get(0));
buzbee311ca162013-02-28 15:56:43 -0800592 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700593 if (GetBasicBlock(prev->fall_through) == walker) {
buzbee311ca162013-02-28 15:56:43 -0800594 // Already done - return
595 break;
596 }
buzbee0d829482013-10-11 15:24:55 -0700597 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
buzbee311ca162013-02-28 15:56:43 -0800598 // Got one. Flip it and exit
599 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
600 switch (opcode) {
601 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
602 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
603 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
604 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
605 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
606 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
607 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
608 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
609 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
610 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
611 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
612 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
613 default: LOG(FATAL) << "Unexpected opcode " << opcode;
614 }
615 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700616 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800617 prev->taken = prev->fall_through;
618 prev->fall_through = t_bb;
619 break;
620 }
621 walker = prev;
622 }
623 return false;
624}
625
626/* Combine any basic blocks terminated by instructions that we now know can't throw */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800627void MIRGraph::CombineBlocks(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800628 // Loop here to allow combining a sequence of blocks
629 while (true) {
630 // Check termination conditions
631 if ((bb->first_mir_insn == NULL)
632 || (bb->data_flow_info == NULL)
633 || (bb->block_type == kExceptionHandling)
634 || (bb->block_type == kExitBlock)
635 || (bb->block_type == kDead)
buzbee0d829482013-10-11 15:24:55 -0700636 || (bb->taken == NullBasicBlockId)
637 || (GetBasicBlock(bb->taken)->block_type != kExceptionHandling)
638 || (bb->successor_block_list_type != kNotUsed)
buzbee311ca162013-02-28 15:56:43 -0800639 || (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) != kMirOpCheck)) {
640 break;
641 }
642
643 // Test the kMirOpCheck instruction
644 MIR* mir = bb->last_mir_insn;
645 // Grab the attributes from the paired opcode
646 MIR* throw_insn = mir->meta.throw_insn;
buzbee1da1e2f2013-11-15 13:37:01 -0800647 uint64_t df_attributes = oat_data_flow_attributes_[throw_insn->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800648 bool can_combine = true;
649 if (df_attributes & DF_HAS_NULL_CHKS) {
650 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) != 0);
651 }
652 if (df_attributes & DF_HAS_RANGE_CHKS) {
653 can_combine &= ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
654 }
655 if (!can_combine) {
656 break;
657 }
658 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700659 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800660 DCHECK(!bb_next->catch_entry);
661 DCHECK_EQ(Predecessors(bb_next), 1U);
buzbee311ca162013-02-28 15:56:43 -0800662 // Overwrite the kOpCheck insn with the paired opcode
663 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
664 *bb->last_mir_insn = *throw_insn;
buzbee311ca162013-02-28 15:56:43 -0800665 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700666 bb->successor_block_list_type = bb_next->successor_block_list_type;
667 bb->successor_blocks = bb_next->successor_blocks;
buzbee311ca162013-02-28 15:56:43 -0800668 // Use the ending block linkage from the next block
669 bb->fall_through = bb_next->fall_through;
buzbee0d829482013-10-11 15:24:55 -0700670 GetBasicBlock(bb->taken)->block_type = kDead; // Kill the unused exception block
buzbee311ca162013-02-28 15:56:43 -0800671 bb->taken = bb_next->taken;
672 // Include the rest of the instructions
673 bb->last_mir_insn = bb_next->last_mir_insn;
674 /*
675 * If lower-half of pair of blocks to combine contained a return, move the flag
676 * to the newly combined block.
677 */
678 bb->terminated_by_return = bb_next->terminated_by_return;
679
680 /*
681 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
682 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
683 */
684
685 // Kill bb_next and remap now-dead id to parent
686 bb_next->block_type = kDead;
buzbee1fd33462013-03-25 13:40:45 -0700687 block_id_map_.Overwrite(bb_next->id, bb->id);
buzbee311ca162013-02-28 15:56:43 -0800688
689 // Now, loop back and see if we can keep going
690 }
buzbee311ca162013-02-28 15:56:43 -0800691}
692
Vladimir Markobfea9c22014-01-17 17:49:33 +0000693void MIRGraph::EliminateNullChecksAndInferTypesStart() {
694 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
695 if (kIsDebugBuild) {
696 AllNodesIterator iter(this);
697 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
698 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
699 }
700 }
701
702 DCHECK(temp_scoped_alloc_.get() == nullptr);
703 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
704 temp_bit_vector_size_ = GetNumSSARegs();
705 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
706 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapTempSSARegisterV);
707 }
708}
709
buzbee1da1e2f2013-11-15 13:37:01 -0800710/*
711 * Eliminate unnecessary null checks for a basic block. Also, while we're doing
712 * an iterative walk go ahead and perform type and size inference.
713 */
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -0800714bool MIRGraph::EliminateNullChecksAndInferTypes(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800715 if (bb->data_flow_info == NULL) return false;
buzbee1da1e2f2013-11-15 13:37:01 -0800716 bool infer_changed = false;
717 bool do_nce = ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0);
buzbee311ca162013-02-28 15:56:43 -0800718
Vladimir Markobfea9c22014-01-17 17:49:33 +0000719 ArenaBitVector* ssa_regs_to_check = temp_bit_vector_;
buzbee1da1e2f2013-11-15 13:37:01 -0800720 if (do_nce) {
721 /*
722 * Set initial state. Be conservative with catch
723 * blocks and start with no assumptions about null check
724 * status (except for "this").
725 */
726 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000727 ssa_regs_to_check->ClearAllBits();
buzbee1da1e2f2013-11-15 13:37:01 -0800728 // Assume all ins are objects.
729 for (uint16_t in_reg = cu_->num_dalvik_registers - cu_->num_ins;
730 in_reg < cu_->num_dalvik_registers; in_reg++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000731 ssa_regs_to_check->SetBit(in_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800732 }
733 if ((cu_->access_flags & kAccStatic) == 0) {
734 // If non-static method, mark "this" as non-null
735 int this_reg = cu_->num_dalvik_registers - cu_->num_ins;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000736 ssa_regs_to_check->ClearBit(this_reg);
buzbee1da1e2f2013-11-15 13:37:01 -0800737 }
738 } else if (bb->predecessors->Size() == 1) {
739 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
Vladimir Markobfea9c22014-01-17 17:49:33 +0000740 // pred_bb must have already been processed at least once.
741 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
742 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800743 if (pred_bb->block_type == kDalvikByteCode) {
744 // Check to see if predecessor had an explicit null-check.
745 MIR* last_insn = pred_bb->last_mir_insn;
746 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
747 if (last_opcode == Instruction::IF_EQZ) {
748 if (pred_bb->fall_through == bb->id) {
749 // The fall-through of a block following a IF_EQZ, set the vA of the IF_EQZ to show that
750 // it can't be null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000751 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800752 }
753 } else if (last_opcode == Instruction::IF_NEZ) {
754 if (pred_bb->taken == bb->id) {
755 // The taken block following a IF_NEZ, set the vA of the IF_NEZ to show that it can't be
756 // null.
Vladimir Markobfea9c22014-01-17 17:49:33 +0000757 ssa_regs_to_check->ClearBit(last_insn->ssa_rep->uses[0]);
buzbee1da1e2f2013-11-15 13:37:01 -0800758 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700759 }
760 }
buzbee1da1e2f2013-11-15 13:37:01 -0800761 } else {
762 // Starting state is union of all incoming arcs
763 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
764 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
Vladimir Markobfea9c22014-01-17 17:49:33 +0000765 CHECK(pred_bb != NULL);
766 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
767 pred_bb = GetBasicBlock(iter.Next());
768 // At least one predecessor must have been processed before this bb.
769 DCHECK(pred_bb != nullptr);
770 DCHECK(pred_bb->data_flow_info != nullptr);
771 }
772 ssa_regs_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
buzbee1da1e2f2013-11-15 13:37:01 -0800773 while (true) {
774 pred_bb = GetBasicBlock(iter.Next());
775 if (!pred_bb) break;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000776 DCHECK(pred_bb->data_flow_info != nullptr);
777 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
buzbee1da1e2f2013-11-15 13:37:01 -0800778 continue;
779 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000780 ssa_regs_to_check->Union(pred_bb->data_flow_info->ending_check_v);
buzbee311ca162013-02-28 15:56:43 -0800781 }
buzbee311ca162013-02-28 15:56:43 -0800782 }
Vladimir Markobfea9c22014-01-17 17:49:33 +0000783 // At this point, ssa_regs_to_check shows which sregs have an object definition with
buzbee1da1e2f2013-11-15 13:37:01 -0800784 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -0800785 }
786
787 // Walk through the instruction in the block, updating as necessary
788 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
789 if (mir->ssa_rep == NULL) {
790 continue;
791 }
buzbee1da1e2f2013-11-15 13:37:01 -0800792
793 // Propagate type info.
794 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
795 if (!do_nce) {
796 continue;
797 }
798
799 uint64_t df_attributes = oat_data_flow_attributes_[mir->dalvikInsn.opcode];
buzbee311ca162013-02-28 15:56:43 -0800800
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000801 // Might need a null check?
802 if (df_attributes & DF_HAS_NULL_CHKS) {
803 int src_idx;
804 if (df_attributes & DF_NULL_CHK_1) {
805 src_idx = 1;
806 } else if (df_attributes & DF_NULL_CHK_2) {
807 src_idx = 2;
808 } else {
809 src_idx = 0;
810 }
811 int src_sreg = mir->ssa_rep->uses[src_idx];
Vladimir Markobfea9c22014-01-17 17:49:33 +0000812 if (!ssa_regs_to_check->IsBitSet(src_sreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000813 // Eliminate the null check.
814 mir->optimization_flags |= MIR_IGNORE_NULL_CHECK;
815 } else {
816 // Do the null check.
817 mir->optimization_flags &= ~MIR_IGNORE_NULL_CHECK;
818 // Mark s_reg as null-checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000819 ssa_regs_to_check->ClearBit(src_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000820 }
821 }
822
823 if ((df_attributes & DF_A_WIDE) ||
824 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
825 continue;
826 }
827
828 /*
829 * First, mark all object definitions as requiring null check.
830 * Note: we can't tell if a CONST definition might be used as an object, so treat
831 * them all as object definitions.
832 */
833 if (((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A)) ||
834 (df_attributes & DF_SETS_CONST)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000835 ssa_regs_to_check->SetBit(mir->ssa_rep->defs[0]);
buzbee4db179d2013-10-23 12:16:39 -0700836 }
837
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000838 // Now, remove mark from all object definitions we know are non-null.
839 if (df_attributes & DF_NON_NULL_DST) {
840 // Mark target of NEW* as non-null
Vladimir Markobfea9c22014-01-17 17:49:33 +0000841 ssa_regs_to_check->ClearBit(mir->ssa_rep->defs[0]);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000842 }
843
buzbee311ca162013-02-28 15:56:43 -0800844 // Mark non-null returns from invoke-style NEW*
845 if (df_attributes & DF_NON_NULL_RET) {
846 MIR* next_mir = mir->next;
847 // Next should be an MOVE_RESULT_OBJECT
848 if (next_mir &&
849 next_mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
850 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000851 ssa_regs_to_check->ClearBit(next_mir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800852 } else {
853 if (next_mir) {
854 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee0d829482013-10-11 15:24:55 -0700855 } else if (bb->fall_through != NullBasicBlockId) {
buzbee311ca162013-02-28 15:56:43 -0800856 // Look in next basic block
buzbee0d829482013-10-11 15:24:55 -0700857 struct BasicBlock* next_bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800858 for (MIR* tmir = next_bb->first_mir_insn; tmir != NULL;
859 tmir =tmir->next) {
860 if (static_cast<int>(tmir->dalvikInsn.opcode) >= static_cast<int>(kMirOpFirst)) {
861 continue;
862 }
863 // First non-pseudo should be MOVE_RESULT_OBJECT
864 if (tmir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) {
865 // Mark as null checked
Vladimir Markobfea9c22014-01-17 17:49:33 +0000866 ssa_regs_to_check->ClearBit(tmir->ssa_rep->defs[0]);
buzbee311ca162013-02-28 15:56:43 -0800867 } else {
868 LOG(WARNING) << "Unexpected op after new: " << tmir->dalvikInsn.opcode;
869 }
870 break;
871 }
872 }
873 }
874 }
875
876 /*
877 * Propagate nullcheck state on register copies (including
878 * Phi pseudo copies. For the latter, nullcheck state is
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000879 * the "or" of all the Phi's operands.
buzbee311ca162013-02-28 15:56:43 -0800880 */
881 if (df_attributes & (DF_NULL_TRANSFER_0 | DF_NULL_TRANSFER_N)) {
882 int tgt_sreg = mir->ssa_rep->defs[0];
883 int operands = (df_attributes & DF_NULL_TRANSFER_0) ? 1 :
884 mir->ssa_rep->num_uses;
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000885 bool needs_null_check = false;
buzbee311ca162013-02-28 15:56:43 -0800886 for (int i = 0; i < operands; i++) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000887 needs_null_check |= ssa_regs_to_check->IsBitSet(mir->ssa_rep->uses[i]);
buzbee311ca162013-02-28 15:56:43 -0800888 }
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000889 if (needs_null_check) {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000890 ssa_regs_to_check->SetBit(tgt_sreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +0000891 } else {
Vladimir Markobfea9c22014-01-17 17:49:33 +0000892 ssa_regs_to_check->ClearBit(tgt_sreg);
buzbee311ca162013-02-28 15:56:43 -0800893 }
894 }
buzbee311ca162013-02-28 15:56:43 -0800895 }
896
897 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +0000898 bool nce_changed = false;
899 if (do_nce) {
900 if (bb->data_flow_info->ending_check_v == nullptr) {
901 DCHECK(temp_scoped_alloc_.get() != nullptr);
902 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
903 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapNullCheck);
904 nce_changed = ssa_regs_to_check->GetHighestBitSet() != -1;
905 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
906 } else if (!ssa_regs_to_check->Equal(bb->data_flow_info->ending_check_v)) {
907 nce_changed = true;
908 bb->data_flow_info->ending_check_v->Copy(ssa_regs_to_check);
909 }
buzbee311ca162013-02-28 15:56:43 -0800910 }
buzbee1da1e2f2013-11-15 13:37:01 -0800911 return infer_changed | nce_changed;
buzbee311ca162013-02-28 15:56:43 -0800912}
913
Vladimir Markobfea9c22014-01-17 17:49:33 +0000914void MIRGraph::EliminateNullChecksAndInferTypesEnd() {
915 if ((cu_->disable_opt & (1 << kNullCheckElimination)) == 0) {
916 // Clean up temporaries.
917 temp_bit_vector_size_ = 0u;
918 temp_bit_vector_ = nullptr;
919 AllNodesIterator iter(this);
920 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
921 if (bb->data_flow_info != nullptr) {
922 bb->data_flow_info->ending_check_v = nullptr;
923 }
924 }
925 DCHECK(temp_scoped_alloc_.get() != nullptr);
926 temp_scoped_alloc_.reset();
927 }
928}
929
930bool MIRGraph::EliminateClassInitChecksGate() {
931 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
932 !cu_->mir_graph->HasStaticFieldAccess()) {
933 return false;
934 }
935
936 if (kIsDebugBuild) {
937 AllNodesIterator iter(this);
938 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
939 CHECK(bb->data_flow_info == nullptr || bb->data_flow_info->ending_check_v == nullptr);
940 }
941 }
942
943 DCHECK(temp_scoped_alloc_.get() == nullptr);
944 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
945
946 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
947 const size_t end = (cu_->code_item->insns_size_in_code_units_ + 1u) / 2u;
948 temp_insn_data_ = static_cast<uint16_t*>(
949 temp_scoped_alloc_->Alloc(end * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
950
951 uint32_t unique_class_count = 0u;
952 {
953 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
954 // ScopedArenaAllocator.
955
956 // Embed the map value in the entry to save space.
957 struct MapEntry {
958 // Map key: the class identified by the declaring dex file and type index.
959 const DexFile* declaring_dex_file;
960 uint16_t declaring_class_idx;
961 // Map value: index into bit vectors of classes requiring initialization checks.
962 uint16_t index;
963 };
964 struct MapEntryComparator {
965 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
966 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
967 return lhs.declaring_class_idx < rhs.declaring_class_idx;
968 }
969 return lhs.declaring_dex_file < rhs.declaring_dex_file;
970 }
971 };
972
973 typedef std::set<MapEntry, MapEntryComparator, ScopedArenaAllocatorAdapter<MapEntry> >
974 ClassToIndexMap;
975
976 ScopedArenaAllocator allocator(&cu_->arena_stack);
977 ClassToIndexMap class_to_index_map(MapEntryComparator(), allocator.Adapter());
978
979 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
980 AllNodesIterator iter(this);
981 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
982 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
983 DCHECK(bb->data_flow_info != nullptr);
984 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
985 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
986 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
987 uint16_t index = 0xffffu;
988 if (field_info.IsResolved() && !field_info.IsInitialized()) {
989 DCHECK_LT(class_to_index_map.size(), 0xffffu);
990 MapEntry entry = {
991 field_info.DeclaringDexFile(),
992 field_info.DeclaringClassIndex(),
993 static_cast<uint16_t>(class_to_index_map.size())
994 };
995 index = class_to_index_map.insert(entry).first->index;
996 }
997 // Using offset/2 for index into temp_insn_data_.
998 temp_insn_data_[mir->offset / 2u] = index;
999 }
1000 }
1001 }
1002 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1003 }
1004
1005 if (unique_class_count == 0u) {
1006 // All SGET/SPUTs refer to initialized classes. Nothing to do.
1007 temp_insn_data_ = nullptr;
1008 temp_scoped_alloc_.reset();
1009 return false;
1010 }
1011
1012 temp_bit_vector_size_ = unique_class_count;
1013 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1014 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1015 DCHECK_GT(temp_bit_vector_size_, 0u);
1016 return true;
1017}
1018
1019/*
1020 * Eliminate unnecessary class initialization checks for a basic block.
1021 */
1022bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1023 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
1024 if (bb->data_flow_info == NULL) {
1025 return false;
1026 }
1027
1028 /*
1029 * Set initial state. Be conservative with catch
1030 * blocks and start with no assumptions about class init check status.
1031 */
1032 ArenaBitVector* classes_to_check = temp_bit_vector_;
1033 DCHECK(classes_to_check != nullptr);
1034 if ((bb->block_type == kEntryBlock) | bb->catch_entry) {
1035 classes_to_check->SetInitialBits(temp_bit_vector_size_);
1036 } else if (bb->predecessors->Size() == 1) {
1037 BasicBlock* pred_bb = GetBasicBlock(bb->predecessors->Get(0));
1038 // pred_bb must have already been processed at least once.
1039 DCHECK(pred_bb != nullptr);
1040 DCHECK(pred_bb->data_flow_info != nullptr);
1041 DCHECK(pred_bb->data_flow_info->ending_check_v != nullptr);
1042 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1043 } else {
1044 // Starting state is union of all incoming arcs
1045 GrowableArray<BasicBlockId>::Iterator iter(bb->predecessors);
1046 BasicBlock* pred_bb = GetBasicBlock(iter.Next());
1047 DCHECK(pred_bb != NULL);
1048 DCHECK(pred_bb->data_flow_info != NULL);
1049 while (pred_bb->data_flow_info->ending_check_v == nullptr) {
1050 pred_bb = GetBasicBlock(iter.Next());
1051 // At least one predecessor must have been processed before this bb.
1052 DCHECK(pred_bb != nullptr);
1053 DCHECK(pred_bb->data_flow_info != nullptr);
1054 }
1055 classes_to_check->Copy(pred_bb->data_flow_info->ending_check_v);
1056 while (true) {
1057 pred_bb = GetBasicBlock(iter.Next());
1058 if (!pred_bb) break;
1059 DCHECK(pred_bb->data_flow_info != nullptr);
1060 if (pred_bb->data_flow_info->ending_check_v == nullptr) {
1061 continue;
1062 }
1063 classes_to_check->Union(pred_bb->data_flow_info->ending_check_v);
1064 }
1065 }
1066 // At this point, classes_to_check shows which classes need clinit checks.
1067
1068 // Walk through the instruction in the block, updating as necessary
1069 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1070 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1071 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1072 uint16_t index = temp_insn_data_[mir->offset / 2u];
1073 if (index != 0xffffu) {
1074 if (mir->dalvikInsn.opcode >= Instruction::SGET &&
1075 mir->dalvikInsn.opcode <= Instruction::SPUT_SHORT) {
1076 if (!classes_to_check->IsBitSet(index)) {
1077 // Eliminate the class init check.
1078 mir->optimization_flags |= MIR_IGNORE_CLINIT_CHECK;
1079 } else {
1080 // Do the class init check.
1081 mir->optimization_flags &= ~MIR_IGNORE_CLINIT_CHECK;
1082 }
1083 }
1084 // Mark the class as initialized.
1085 classes_to_check->ClearBit(index);
1086 }
1087 }
1088 }
1089
1090 // Did anything change?
1091 bool changed = false;
1092 if (bb->data_flow_info->ending_check_v == nullptr) {
1093 DCHECK(temp_scoped_alloc_.get() != nullptr);
1094 DCHECK(bb->data_flow_info != nullptr);
1095 bb->data_flow_info->ending_check_v = new (temp_scoped_alloc_.get()) ArenaBitVector(
1096 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapClInitCheck);
1097 changed = classes_to_check->GetHighestBitSet() != -1;
1098 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1099 } else if (!classes_to_check->Equal(bb->data_flow_info->ending_check_v)) {
1100 changed = true;
1101 bb->data_flow_info->ending_check_v->Copy(classes_to_check);
1102 }
1103 return changed;
1104}
1105
1106void MIRGraph::EliminateClassInitChecksEnd() {
1107 // Clean up temporaries.
1108 temp_bit_vector_size_ = 0u;
1109 temp_bit_vector_ = nullptr;
1110 AllNodesIterator iter(this);
1111 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1112 if (bb->data_flow_info != nullptr) {
1113 bb->data_flow_info->ending_check_v = nullptr;
1114 }
1115 }
1116
1117 DCHECK(temp_insn_data_ != nullptr);
1118 temp_insn_data_ = nullptr;
1119 DCHECK(temp_scoped_alloc_.get() != nullptr);
1120 temp_scoped_alloc_.reset();
1121}
1122
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001123void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1124 uint32_t method_index = invoke->meta.method_lowering_info;
1125 if (temp_bit_vector_->IsBitSet(method_index)) {
1126 iget_or_iput->meta.ifield_lowering_info = temp_insn_data_[method_index];
1127 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1128 return;
1129 }
1130
1131 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1132 MethodReference target = method_info.GetTargetMethod();
1133 DexCompilationUnit inlined_unit(
1134 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1135 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1136 0u /* access_flags not used */, nullptr /* verified_method not used */);
1137 MirIFieldLoweringInfo inlined_field_info(field_idx);
1138 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1139 DCHECK(inlined_field_info.IsResolved());
1140
1141 uint32_t field_info_index = ifield_lowering_infos_.Size();
1142 ifield_lowering_infos_.Insert(inlined_field_info);
1143 temp_bit_vector_->SetBit(method_index);
1144 temp_insn_data_[method_index] = field_info_index;
1145 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1146}
1147
1148bool MIRGraph::InlineCallsGate() {
1149 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
1150 method_lowering_infos_.Size() == 0u) {
1151 return false;
1152 }
1153 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1154 // This isn't the Quick compiler.
1155 return false;
1156 }
1157 return true;
1158}
1159
1160void MIRGraph::InlineCallsStart() {
1161 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1162 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1163
1164 DCHECK(temp_scoped_alloc_.get() == nullptr);
1165 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1166 temp_bit_vector_size_ = method_lowering_infos_.Size();
1167 temp_bit_vector_ = new (temp_scoped_alloc_.get()) ArenaBitVector(
1168 temp_scoped_alloc_.get(), temp_bit_vector_size_, false, kBitMapMisc);
1169 temp_bit_vector_->ClearAllBits();
1170 temp_insn_data_ = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1171 temp_bit_vector_size_ * sizeof(*temp_insn_data_), kArenaAllocGrowableArray));
1172}
1173
1174void MIRGraph::InlineCalls(BasicBlock* bb) {
1175 if (bb->block_type != kDalvikByteCode) {
1176 return;
1177 }
1178 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1179 if (!(Instruction::FlagsOf(mir->dalvikInsn.opcode) & Instruction::kInvoke)) {
1180 continue;
1181 }
1182 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1183 if (!method_info.FastPath()) {
1184 continue;
1185 }
1186 InvokeType sharp_type = method_info.GetSharpType();
1187 if ((sharp_type != kDirect) &&
1188 (sharp_type != kStatic || method_info.NeedsClassInitialization())) {
1189 continue;
1190 }
1191 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1192 MethodReference target = method_info.GetTargetMethod();
1193 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1194 ->GenInline(this, bb, mir, target.dex_method_index)) {
1195 if (cu_->verbose) {
1196 LOG(INFO) << "In \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1197 << "\" @0x" << std::hex << mir->offset
1198 << " inlined " << method_info.GetInvokeType() << " (" << sharp_type << ") call to \""
1199 << PrettyMethod(target.dex_method_index, *target.dex_file) << "\"";
1200 }
1201 }
1202 }
1203}
1204
1205void MIRGraph::InlineCallsEnd() {
1206 DCHECK(temp_insn_data_ != nullptr);
1207 temp_insn_data_ = nullptr;
1208 DCHECK(temp_bit_vector_ != nullptr);
1209 temp_bit_vector_ = nullptr;
1210 DCHECK(temp_scoped_alloc_.get() != nullptr);
1211 temp_scoped_alloc_.reset();
1212}
1213
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001214void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001215 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001216 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001217 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001218 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001219 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1220 CountChecks(bb);
1221 }
1222 if (stats->null_checks > 0) {
1223 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1224 float checks = static_cast<float>(stats->null_checks);
1225 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1226 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1227 << (eliminated/checks) * 100.0 << "%";
1228 }
1229 if (stats->range_checks > 0) {
1230 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1231 float checks = static_cast<float>(stats->range_checks);
1232 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1233 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1234 << (eliminated/checks) * 100.0 << "%";
1235 }
1236}
1237
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001238bool MIRGraph::BuildExtendedBBList(struct BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001239 if (bb->visited) return false;
1240 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1241 || (bb->block_type == kExitBlock))) {
1242 // Ignore special blocks
1243 bb->visited = true;
1244 return false;
1245 }
1246 // Must be head of extended basic block.
1247 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001248 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001249 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001250 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001251 // Visit blocks strictly dominated by this head.
1252 while (bb != NULL) {
1253 bb->visited = true;
1254 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001255 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001256 bb = NextDominatedBlock(bb);
1257 }
buzbee1da1e2f2013-11-15 13:37:01 -08001258 if (terminated_by_return || do_local_value_numbering) {
1259 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001260 bb = start_bb;
1261 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001262 bb->use_lvn = do_local_value_numbering;
1263 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001264 bb = NextDominatedBlock(bb);
1265 }
1266 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001267 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001268}
1269
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001270void MIRGraph::BasicBlockOptimization() {
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001271 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1272 ClearAllVisitedFlags();
1273 PreOrderDfsIterator iter2(this);
1274 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1275 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001276 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001277 // Perform extended basic block optimizations.
1278 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1279 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1280 }
1281 } else {
1282 PreOrderDfsIterator iter(this);
1283 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1284 BasicBlockOpt(bb);
1285 }
buzbee311ca162013-02-28 15:56:43 -08001286 }
1287}
1288
1289} // namespace art