summaryrefslogtreecommitdiff
path: root/errorprone
diff options
context:
space:
mode:
author Cole Faust <colefaust@google.com> 2022-10-15 21:33:32 -0700
committer Cole Faust <colefaust@google.com> 2022-10-19 10:00:37 -0700
commit1942af48eeddd9c243c74224a73761ccb3e5eb18 (patch)
treee369076701f563c4145365a119a064e8a6aaab6b /errorprone
parent5a7dc874a09a08b289cdd085e1f255e238dbcd78 (diff)
Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: Ibcfac3adb22e1b46e35eb0f952c67987011fd435
Diffstat (limited to 'errorprone')
-rw-r--r--errorprone/src/com/android/providers/media/MimeTypeChecker.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/errorprone/src/com/android/providers/media/MimeTypeChecker.java b/errorprone/src/com/android/providers/media/MimeTypeChecker.java
index 997c1ba7c..02672fe60 100644
--- a/errorprone/src/com/android/providers/media/MimeTypeChecker.java
+++ b/errorprone/src/com/android/providers/media/MimeTypeChecker.java
@@ -89,6 +89,7 @@ public final class MimeTypeChecker extends BugChecker
private static class MimeWithoutCaseFoldingMatcher
implements Matcher<ExpressionTree>, Predicate<ExpressionTree> {
+ @SuppressWarnings("TreeToString") //TODO(b/254480640): https://errorprone.info/bugpattern/TreeToString
@Override
public boolean matches(ExpressionTree tree, VisitorState state) {
// This is a pretty rough way to match raw names, but it works