diff options
author | 2022-11-28 19:02:04 +0000 | |
---|---|---|
committer | 2022-11-28 19:02:04 +0000 | |
commit | 824749c272bf1d63d251ab5677da337cee484eb0 (patch) | |
tree | b9872dc3f72be073cdfa6f0d535f3f69e156aaa5 | |
parent | 3d158914d3b1775140c72af2a8e541c8011e6fcb (diff) | |
parent | 818ed43fd9f04ed17de87fb012b847c35ed9ec6b (diff) |
Merge "Add checks to verify that the Wifi HAL is initialized."
-rw-r--r-- | service/java/com/android/server/wifi/HalDeviceManager.java | 8 | ||||
-rw-r--r-- | service/tests/wifitests/src/com/android/server/wifi/HalDeviceManagerTest.java | 1 |
2 files changed, 9 insertions, 0 deletions
diff --git a/service/java/com/android/server/wifi/HalDeviceManager.java b/service/java/com/android/server/wifi/HalDeviceManager.java index 73ffd2734b..919ecd19c8 100644 --- a/service/java/com/android/server/wifi/HalDeviceManager.java +++ b/service/java/com/android/server/wifi/HalDeviceManager.java @@ -801,6 +801,10 @@ public class HalDeviceManager { IfaceCreationData creationData; synchronized (mLock) { + if (!mWifiHal.isInitializationComplete()) { + Log.e(TAG, "reportImpactToCreateIface: Wifi Hal is not available"); + return null; + } WifiChipInfo[] chipInfos = getAllChipInfo(); if (chipInfos == null) { Log.e(TAG, "createIface: no chip info found"); @@ -1373,6 +1377,10 @@ public class HalDeviceManager { private void stopWifi() { if (VDBG) Log.d(TAG, "stopWifi"); synchronized (mLock) { + if (!mWifiHal.isInitializationComplete()) { + Log.w(TAG, "stopWifi was called, but Wifi Hal is not initialized"); + return; + } if (!mWifiHal.stop()) { Log.e(TAG, "Cannot stop IWifi"); } diff --git a/service/tests/wifitests/src/com/android/server/wifi/HalDeviceManagerTest.java b/service/tests/wifitests/src/com/android/server/wifi/HalDeviceManagerTest.java index 48f3bdfef3..1b8750e746 100644 --- a/service/tests/wifitests/src/com/android/server/wifi/HalDeviceManagerTest.java +++ b/service/tests/wifitests/src/com/android/server/wifi/HalDeviceManagerTest.java @@ -182,6 +182,7 @@ public class HalDeviceManagerTest extends WifiBaseTest { when(mWifiMock.start()).thenReturn(WifiHal.WIFI_STATUS_SUCCESS); when(mWifiMock.stop()).thenReturn(true); when(mWifiMock.isStarted()).thenReturn(true); + when(mWifiMock.isInitializationComplete()).thenReturn(true); when(mContext.getResources()).thenReturn(mResources); when(mResources.getBoolean(R.bool.config_wifiBridgedSoftApSupported)) .thenReturn(mIsBridgedSoftApSupported); |