From f39014be3c1c5ef04894e7489e8a62d51d672314 Mon Sep 17 00:00:00 2001 From: Mark Kim Date: Tue, 19 Dec 2023 00:42:28 +0000 Subject: Change the strings on the opt-out toggle to also account for archiving Test: n/a Bug: 304257274 Change-Id: Ia96eaabcd9fa20fa2d030d2e09bc5ba388247e52 --- PermissionController/res/values/strings.xml | 6 ++++++ .../permission/ui/handheld/AppPermissionGroupsFragment.java | 11 +++++++++-- flags/flags.aconfig | 7 +++++++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/PermissionController/res/values/strings.xml b/PermissionController/res/values/strings.xml index b9895d611..24db04f2d 100644 --- a/PermissionController/res/values/strings.xml +++ b/PermissionController/res/values/strings.xml @@ -645,9 +645,15 @@ Pause app activity if unused + + Manage app if unused + Remove permissions, delete temporary files, and stop notifications + + Remove permissions, delete temporary files, stop notifications, and archive the app + To protect your data, permissions for this app will be removed if the app is unused for a few months. diff --git a/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/AppPermissionGroupsFragment.java b/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/AppPermissionGroupsFragment.java index 4bc14ed24..84d019bad 100644 --- a/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/AppPermissionGroupsFragment.java +++ b/PermissionController/src/com/android/permissioncontroller/permission/ui/handheld/AppPermissionGroupsFragment.java @@ -64,6 +64,7 @@ import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; import com.android.modules.utils.build.SdkLevel; +import com.android.permission.flags.Flags; import com.android.permissioncontroller.PermissionControllerStatsLog; import com.android.permissioncontroller.R; import com.android.permissioncontroller.permission.model.livedatatypes.HibernationSettingState; @@ -431,8 +432,10 @@ public final class AppPermissionGroupsFragment extends SettingsWithLargeHeader i int switchTitleId; if (isHibernationEnabled()) { if (SdkLevel.isAtLeastT()) { - switchTitleId = R.string.unused_apps_label_v2; - autoRevokeSwitch.setSummary(R.string.unused_apps_summary); + switchTitleId = isArchivingEnabled() ? R.string.unused_apps_label_v3 + : R.string.unused_apps_label_v2; + autoRevokeSwitch.setSummary(isArchivingEnabled() ? R.string.unused_apps_summary_v2 + : R.string.unused_apps_summary); } else { switchTitleId = R.string.unused_apps_label; } @@ -456,6 +459,10 @@ public final class AppPermissionGroupsFragment extends SettingsWithLargeHeader i autoRevokeCategory.addPreference(autoRevokeSummary); } + private boolean isArchivingEnabled() { + return SdkLevel.isAtLeastV() && Flags.archiving(); + } + private void setAutoRevokeToggleState(HibernationSettingState state) { if (state == null || !mViewModel.getPackagePermGroupsLiveData().isInitialized() || getPreferenceScreen() == null || getListView() == null || getView() == null) { diff --git a/flags/flags.aconfig b/flags/flags.aconfig index 37aca2a56..49b086b2b 100644 --- a/flags/flags.aconfig +++ b/flags/flags.aconfig @@ -19,4 +19,11 @@ flag { namespace: "wear_security" description: "This flag is used to support Privacy dashboard for Wear" bug: "309721061" +} + +flag { + name: "archiving" + namespace: "permissions" + description: "Feature flag to enable the archiving feature." + bug: "278553670" } \ No newline at end of file -- cgit v1.2.3-59-g8ed1b