From 2e28840848a34a525ab17241730da98920da8dda Mon Sep 17 00:00:00 2001 From: Nate Myren Date: Fri, 4 Apr 2025 16:14:44 -0700 Subject: Temporarily stop getting user from call This is being removed, due to unidentified crashed. Ensures the incall test doesn't run on HSUM builds. Bug: 408470449 Test: atest EnhancedConfirmationInCallTest Flag: EXEMPT critical crash fix Relnote: None (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:671bad75d3c80c9ac73b767b3e06f71c29ce8f86) Merged-In: I38253e0cdae80fb9116e38926af81c642cbbd144 Change-Id: I38253e0cdae80fb9116e38926af81c642cbbd144 --- service/java/com/android/ecm/EnhancedConfirmationService.java | 5 +++-- .../src/android/permissionui/cts/EnhancedConfirmationInCallTest.kt | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/service/java/com/android/ecm/EnhancedConfirmationService.java b/service/java/com/android/ecm/EnhancedConfirmationService.java index 1cc3a743e..64b5724a2 100644 --- a/service/java/com/android/ecm/EnhancedConfirmationService.java +++ b/service/java/com/android/ecm/EnhancedConfirmationService.java @@ -37,7 +37,6 @@ import android.app.ecm.IEnhancedConfirmationManager; import android.app.role.RoleManager; import android.content.ContentResolver; import android.content.Context; -import android.content.Intent; import android.content.pm.ApplicationInfo; import android.content.pm.InstallSourceInfo; import android.content.pm.PackageInstaller; @@ -48,7 +47,6 @@ import android.database.Cursor; import android.net.Uri; import android.os.Binder; import android.os.Build; -import android.os.Bundle; import android.os.Looper; import android.os.SystemClock; import android.os.SystemConfigManager; @@ -691,10 +689,13 @@ public class EnhancedConfirmationService extends SystemService { // telephony service is unavailable. } UserHandle user = mContext.getUser(); + /* + TODO b/408470449: reenable once call extras are fixed Bundle extras = call.getDetails().getExtras(); if (extras != null) { user = extras.getParcelable(Intent.EXTRA_USER_HANDLE, UserHandle.class); } + */ if (number != null) { return hasContactWithPhoneNumber(number, user) ? CALL_TYPE_TRUSTED : CALL_TYPE_UNTRUSTED; diff --git a/tests/cts/permissionui/src/android/permissionui/cts/EnhancedConfirmationInCallTest.kt b/tests/cts/permissionui/src/android/permissionui/cts/EnhancedConfirmationInCallTest.kt index 9a4908c79..c1fca6398 100644 --- a/tests/cts/permissionui/src/android/permissionui/cts/EnhancedConfirmationInCallTest.kt +++ b/tests/cts/permissionui/src/android/permissionui/cts/EnhancedConfirmationInCallTest.kt @@ -25,6 +25,7 @@ import android.content.pm.PackageManager import android.net.Uri import android.os.Build import android.os.Process +import android.os.UserManager import android.permission.flags.Flags import android.platform.test.annotations.AppModeFull import android.platform.test.annotations.RequiresFlagsEnabled @@ -68,9 +69,11 @@ class EnhancedConfirmationInCallTest { val checkFlagsRule: CheckFlagsRule = DeviceFlagsValueProvider.createCheckFlagsRule() @Before - fun assumeNotAutoOrTv() { + fun assumeNotAutoTvOrHsum() { Assume.assumeFalse(packageManager.hasSystemFeature(PackageManager.FEATURE_LEANBACK)) Assume.assumeFalse(packageManager.hasSystemFeature(PackageManager.FEATURE_AUTOMOTIVE)) + // TODO b/408470449: remove once call extras are fixed + Assume.assumeFalse(UserManager.isHeadlessSystemUserMode()) } companion object { -- cgit v1.2.3-59-g8ed1b From 453adc2a8275c5437c1c488bba51847590499800 Mon Sep 17 00:00:00 2001 From: Chris Antol Date: Wed, 9 Apr 2025 13:41:38 -0700 Subject: Revert "Add READ/WRITE_SYSTEM_PREFERENCES permissions to ASSISTANT role" This reverts commit 0b3022e555fdf158dbdcc5171e24e1c574e0a9fe. Reason for revert: b/409604217 Relnote: N/A NO_IFTTT=not applicable (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0c8729509e4e444734e4d8827ad4e5b29b14fc62) Merged-In: Iab3a924bb0d9a2b81e19ec04d74c50491a062faa Change-Id: Iab3a924bb0d9a2b81e19ec04d74c50491a062faa --- PermissionController/jarjar-rules.txt | 4 ---- PermissionController/res/xml/roles.xml | 4 ---- PermissionController/role-controller/Android.bp | 1 - service/jarjar-rules.txt | 4 ---- 4 files changed, 13 deletions(-) diff --git a/PermissionController/jarjar-rules.txt b/PermissionController/jarjar-rules.txt index ceac6c3a7..7d6e56a70 100644 --- a/PermissionController/jarjar-rules.txt +++ b/PermissionController/jarjar-rules.txt @@ -34,8 +34,4 @@ rule com.android.permission.flags.*FeatureFlags* com.android.permissioncontrolle rule com.android.permission.flags.FeatureFlags* com.android.permissioncontroller.jarjar.@0 rule com.android.permission.flags.FeatureFlags com.android.permissioncontroller.jarjar.@0 rule com.android.permission.flags.Flags com.android.permissioncontroller.jarjar.@0 -rule com.android.settingslib.flags.*FeatureFlags* com.android.permissioncontroller.jarjar.@0 -rule com.android.settingslib.flags.FeatureFlags* com.android.permissioncontroller.jarjar.@0 -rule com.android.settingslib.flags.FeatureFlags com.android.permissioncontroller.jarjar.@0 -rule com.android.settingslib.flags.Flags com.android.permissioncontroller.jarjar.@0 # LINT.ThenChange(PermissionController/role-controller/java/com/android/role/controller/model/RoleParser.java:applyJarjarTransform) diff --git a/PermissionController/res/xml/roles.xml b/PermissionController/res/xml/roles.xml index 1339152d7..78017c32e 100644 --- a/PermissionController/res/xml/roles.xml +++ b/PermissionController/res/xml/roles.xml @@ -155,13 +155,9 @@ minSdkVersion="35" optionalMinSdkVersion="34" /> - - diff --git a/PermissionController/role-controller/Android.bp b/PermissionController/role-controller/Android.bp index f89fd140c..9f217660a 100644 --- a/PermissionController/role-controller/Android.bp +++ b/PermissionController/role-controller/Android.bp @@ -32,7 +32,6 @@ java_library { ], static_libs: [ "modules-utils-build_system", - "aconfig_settingslib_exported_flags_java_lib", "android.app.appfunctions.exported-flags-aconfig-java", "android.companion.virtualdevice.flags-aconfig-java-export", "android.content.pm.flags-aconfig-java-export", diff --git a/service/jarjar-rules.txt b/service/jarjar-rules.txt index bad5c7666..d9833ca56 100644 --- a/service/jarjar-rules.txt +++ b/service/jarjar-rules.txt @@ -42,10 +42,6 @@ rule com.android.safetycenter.annotations.** com.android.permission.jarjar.@0 rule com.android.safetycenter.internaldata.** com.android.permission.jarjar.@0 rule com.android.safetycenter.pendingintents.** com.android.permission.jarjar.@0 rule com.android.safetycenter.resources.** com.android.permission.jarjar.@0 -rule com.android.settingslib.flags.*FeatureFlags* com.android.permission.jarjar.@0 -rule com.android.settingslib.flags.FeatureFlags* com.android.permission.jarjar.@0 -rule com.android.settingslib.flags.FeatureFlags com.android.permission.jarjar.@0 -rule com.android.settingslib.flags.Flags com.android.permission.jarjar.@0 rule com.google.protobuf.** com.android.permission.jarjar.@0 rule kotlin.** com.android.permission.jarjar.@0 rule com.android.permissioncontroller.PermissionControllerStatsLog com.android.permission.jarjar.@0 -- cgit v1.2.3-59-g8ed1b