summaryrefslogtreecommitdiff
path: root/framework-s/java
diff options
context:
space:
mode:
author Jay Thomas Sullivan <jaysullivan@google.com> 2023-11-03 13:56:00 -0700
committer Jay Thomas Sullivan <jaysullivan@google.com> 2023-11-17 15:48:12 -0800
commit137f496ad679f6f5753732364ab0cf0e2231ce79 (patch)
tree96fe5e46a9a48aa4ea30a3168936a4717e8e9934 /framework-s/java
parent83c155a41932d3d81c4a5039dc6bb34c044647e5 (diff)
[Role Logic Move] Migrate isVisible behavior
The goal of this change is to move any remaining PermissionController- specific dependencies out of RoleControllerServiceImpl. This includes the following two methods calls: - RoleUiBehaviorUtils::isVisibleAsUser - RoleUiBehaviorUtils::isApplicationVisibleAsUser ...which in turn call RoleUiBehavior::isVisibleAsUser and RoleUiBehavior::isApplicationVisibleAsUser, which are implemented in various RoleUiBehavior implementations. Move all of this logic into the role-controller module. After this change, RoleControllerServiceImpl now calls: - Role::isVisibleAsUser - Role::isApplicationVisibleAsUser ...which in turn call RoleBehavior::isVisibleAsUser and RoleBehavior::isApplicationVisibleAsUser, which are implemented in various RoleBehavior implementations.(All of these classes are in role-controller.) Also, our RoleUiBehavior implementations fetch app resources. But, resources are app-specific, some of our behaviors need PermissionController-specific resources, and those behaviors currently assume that PermissionController is the "current" app, and therefore this will break if we move this code to SystemServer. So, change the behaviors to explicitly fetch the resource from SystemServer or PermissionController as needed (now encapsulated within VisibilityMixin), without assuming the current app. Bug: 309139048 Test: atest CtsRoleTestCases Change-Id: I535239c8ad869e70ad5c76f95925979dff16eb71
Diffstat (limited to 'framework-s/java')
0 files changed, 0 insertions, 0 deletions