summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Hai Zhang <zhanghai@google.com> 2024-12-27 10:27:53 -0800
committer Hai Zhang <zhanghai@google.com> 2024-12-27 10:30:20 -0800
commita6aa6a5eeba381c4e313b2afab35c7b88c270954 (patch)
treeff0f46ccd8ddac796ceead8d285e2a9d75bc1682
parent29f0d823d360f0cf512bcfea946067188d06ba6f (diff)
Move to Kotlin requireNotNull() from Preconditions.checkNotNull()
We are in Kotlin so the Kotlin way can be preferred. Somehow the JSpecify @NonNull from Preconditions.checkNotNull() isn't being recognized as non-null by the Kotlin compiler used for the code here and that's blocking AndroidX prebuilt drop, so let's get out of the way for that first, while improving our code a tiny bit. Bug: 385912424 Flag: EXEMPT bugfix Relnote: N/A Test: build Change-Id: I42504a24a8544b56dbbbf5e0cd707355304717de
-rw-r--r--PermissionController/src/com/android/permissioncontroller/privacysources/AccessibilitySourceService.kt3
-rw-r--r--PermissionController/src/com/android/permissioncontroller/privacysources/NotificationListenerCheck.kt3
2 files changed, 2 insertions, 4 deletions
diff --git a/PermissionController/src/com/android/permissioncontroller/privacysources/AccessibilitySourceService.kt b/PermissionController/src/com/android/permissioncontroller/privacysources/AccessibilitySourceService.kt
index c633c013a..1610901bc 100644
--- a/PermissionController/src/com/android/permissioncontroller/privacysources/AccessibilitySourceService.kt
+++ b/PermissionController/src/com/android/permissioncontroller/privacysources/AccessibilitySourceService.kt
@@ -48,7 +48,6 @@ import androidx.annotation.GuardedBy
import androidx.annotation.RequiresApi
import androidx.annotation.VisibleForTesting
import androidx.annotation.WorkerThread
-import androidx.core.util.Preconditions
import com.android.modules.utils.build.SdkLevel
import com.android.permissioncontroller.Constants
import com.android.permissioncontroller.PermissionControllerStatsLog
@@ -712,7 +711,7 @@ class AccessibilityPackageResetHandler : BroadcastReceiver() {
return
}
- val data = Preconditions.checkNotNull(intent.data)
+ val data = requireNotNull(intent.data)
val coroutineScope = CoroutineScope(Dispatchers.Default + SupervisorJob())
coroutineScope.launch(Dispatchers.Default) {
if (DEBUG) {
diff --git a/PermissionController/src/com/android/permissioncontroller/privacysources/NotificationListenerCheck.kt b/PermissionController/src/com/android/permissioncontroller/privacysources/NotificationListenerCheck.kt
index 43b3edc04..58a6f1bc4 100644
--- a/PermissionController/src/com/android/permissioncontroller/privacysources/NotificationListenerCheck.kt
+++ b/PermissionController/src/com/android/permissioncontroller/privacysources/NotificationListenerCheck.kt
@@ -57,7 +57,6 @@ import androidx.annotation.GuardedBy
import androidx.annotation.RequiresApi
import androidx.annotation.VisibleForTesting
import androidx.annotation.WorkerThread
-import androidx.core.util.Preconditions
import com.android.modules.utils.build.SdkLevel
import com.android.permissioncontroller.Constants
import com.android.permissioncontroller.Constants.KEY_LAST_NOTIFICATION_LISTENER_NOTIFICATION_SHOWN
@@ -1146,7 +1145,7 @@ class NotificationListenerPackageResetHandler : BroadcastReceiver() {
return
}
- val data = Preconditions.checkNotNull(intent.data)
+ val data = requireNotNull(intent.data)
val pkg: String = data.schemeSpecificPart
if (DEBUG) Log.i(TAG, "Reset $pkg")