diff options
author | 2023-01-04 16:08:14 +0000 | |
---|---|---|
committer | 2023-01-09 11:11:47 +0000 | |
commit | 55ef4cd8d49dbebe9d8f7966c85c7a08cd800dce (patch) | |
tree | e662940d6cf56a35aeae5db389ab4b938f6c88af | |
parent | f3d89f40901f46d6d643cfc54280a9767c757437 (diff) |
Better names for Confirmation dialog details for Issue Action
Test: atest CtsSafetyCenterTestCases
Bug: 264251865
Change-Id: I6727d62145e2826e29c439215d99981b79ef1f37
5 files changed, 253 insertions, 206 deletions
diff --git a/framework-s/api/system-current.txt b/framework-s/api/system-current.txt index 3a3acda7c..8a32bb7f4 100644 --- a/framework-s/api/system-current.txt +++ b/framework-s/api/system-current.txt @@ -186,7 +186,7 @@ package android.safetycenter { public static final class SafetyCenterIssue.Action implements android.os.Parcelable { method public int describeContents(); - method @Nullable public android.safetycenter.SafetyCenterIssue.Action.Confirmation getConfirmation(); + method @Nullable public android.safetycenter.SafetyCenterIssue.Action.ConfirmationDialogDetails getConfirmationDialogDetails(); method @NonNull public String getId(); method @NonNull public CharSequence getLabel(); method @NonNull public android.app.PendingIntent getPendingIntent(); @@ -201,7 +201,7 @@ package android.safetycenter { ctor public SafetyCenterIssue.Action.Builder(@NonNull String, @NonNull CharSequence, @NonNull android.app.PendingIntent); ctor public SafetyCenterIssue.Action.Builder(@NonNull android.safetycenter.SafetyCenterIssue.Action); method @NonNull public android.safetycenter.SafetyCenterIssue.Action build(); - method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setConfirmation(@Nullable android.safetycenter.SafetyCenterIssue.Action.Confirmation); + method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setConfirmationDialogDetails(@Nullable android.safetycenter.SafetyCenterIssue.Action.ConfirmationDialogDetails); method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setId(@NonNull String); method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setIsInFlight(boolean); method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setLabel(@NonNull CharSequence); @@ -210,15 +210,15 @@ package android.safetycenter { method @NonNull public android.safetycenter.SafetyCenterIssue.Action.Builder setWillResolve(boolean); } - public static final class SafetyCenterIssue.Action.Confirmation implements android.os.Parcelable { - ctor public SafetyCenterIssue.Action.Confirmation(@NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence); + public static final class SafetyCenterIssue.Action.ConfirmationDialogDetails implements android.os.Parcelable { + ctor public SafetyCenterIssue.Action.ConfirmationDialogDetails(@NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence); method public int describeContents(); - method @NonNull public CharSequence getAccept(); - method @NonNull public CharSequence getDeny(); + method @NonNull public CharSequence getAcceptButtonText(); + method @NonNull public CharSequence getDenyButtonText(); method @NonNull public CharSequence getText(); method @NonNull public CharSequence getTitle(); method public void writeToParcel(@NonNull android.os.Parcel, int); - field @NonNull public static final android.os.Parcelable.Creator<android.safetycenter.SafetyCenterIssue.Action.Confirmation> CREATOR; + field @NonNull public static final android.os.Parcelable.Creator<android.safetycenter.SafetyCenterIssue.Action.ConfirmationDialogDetails> CREATOR; } public static final class SafetyCenterIssue.Builder { @@ -424,7 +424,7 @@ package android.safetycenter { public static final class SafetySourceIssue.Action implements android.os.Parcelable { method public int describeContents(); - method @Nullable public android.safetycenter.SafetySourceIssue.Action.Confirmation getConfirmation(); + method @Nullable public android.safetycenter.SafetySourceIssue.Action.ConfirmationDialogDetails getConfirmationDialogDetails(); method @NonNull public String getId(); method @NonNull public CharSequence getLabel(); method @NonNull public android.app.PendingIntent getPendingIntent(); @@ -438,20 +438,20 @@ package android.safetycenter { ctor public SafetySourceIssue.Action.Builder(@NonNull String, @NonNull CharSequence, @NonNull android.app.PendingIntent); ctor public SafetySourceIssue.Action.Builder(@NonNull android.safetycenter.SafetySourceIssue.Action); method @NonNull public android.safetycenter.SafetySourceIssue.Action build(); - method @NonNull public android.safetycenter.SafetySourceIssue.Action.Builder setConfirmation(@Nullable android.safetycenter.SafetySourceIssue.Action.Confirmation); + method @NonNull public android.safetycenter.SafetySourceIssue.Action.Builder setConfirmationDialogDetails(@Nullable android.safetycenter.SafetySourceIssue.Action.ConfirmationDialogDetails); method @NonNull public android.safetycenter.SafetySourceIssue.Action.Builder setSuccessMessage(@Nullable CharSequence); method @NonNull public android.safetycenter.SafetySourceIssue.Action.Builder setWillResolve(boolean); } - public static final class SafetySourceIssue.Action.Confirmation implements android.os.Parcelable { - ctor public SafetySourceIssue.Action.Confirmation(@NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence); + public static final class SafetySourceIssue.Action.ConfirmationDialogDetails implements android.os.Parcelable { + ctor public SafetySourceIssue.Action.ConfirmationDialogDetails(@NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence, @NonNull CharSequence); method public int describeContents(); - method @NonNull public CharSequence getAccept(); - method @NonNull public CharSequence getDeny(); + method @NonNull public CharSequence getAcceptButtonText(); + method @NonNull public CharSequence getDenyButtonText(); method @NonNull public CharSequence getText(); method @NonNull public CharSequence getTitle(); method public void writeToParcel(@NonNull android.os.Parcel, int); - field @NonNull public static final android.os.Parcelable.Creator<android.safetycenter.SafetySourceIssue.Action.Confirmation> CREATOR; + field @NonNull public static final android.os.Parcelable.Creator<android.safetycenter.SafetySourceIssue.Action.ConfirmationDialogDetails> CREATOR; } public static final class SafetySourceIssue.Builder { diff --git a/framework-s/java/android/safetycenter/SafetyCenterIssue.java b/framework-s/java/android/safetycenter/SafetyCenterIssue.java index 6b4d02b7e..cee872a3a 100644 --- a/framework-s/java/android/safetycenter/SafetyCenterIssue.java +++ b/framework-s/java/android/safetycenter/SafetyCenterIssue.java @@ -508,8 +508,9 @@ public final class SafetyCenterIssue implements Parcelable { TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel( in)); if (SdkLevel.isAtLeastU()) { - Confirmation confirmation = in.readTypedObject(Confirmation.CREATOR); - builder.setConfirmation(confirmation); + ConfirmationDialogDetails confirmationDialogDetails = + in.readTypedObject(ConfirmationDialogDetails.CREATOR); + builder.setConfirmationDialogDetails(confirmationDialogDetails); } return builder.build(); } @@ -526,7 +527,7 @@ public final class SafetyCenterIssue implements Parcelable { private final boolean mWillResolve; private final boolean mInFlight; @Nullable private final CharSequence mSuccessMessage; - @Nullable private final Confirmation mConfirmation; + @Nullable private final ConfirmationDialogDetails mConfirmationDialogDetails; private Action( @NonNull String id, @@ -535,14 +536,14 @@ public final class SafetyCenterIssue implements Parcelable { boolean willResolve, boolean inFlight, @Nullable CharSequence successMessage, - @Nullable Confirmation confirmation) { + @Nullable ConfirmationDialogDetails confirmationDialogDetails) { mId = id; mLabel = label; mPendingIntent = pendingIntent; mWillResolve = willResolve; mInFlight = inFlight; mSuccessMessage = successMessage; - mConfirmation = confirmation; + mConfirmationDialogDetails = confirmationDialogDetails; } /** Returns the ID of this action. */ @@ -596,11 +597,11 @@ public final class SafetyCenterIssue implements Parcelable { */ @Nullable @RequiresApi(UPSIDE_DOWN_CAKE) - public Confirmation getConfirmation() { + public ConfirmationDialogDetails getConfirmationDialogDetails() { if (!SdkLevel.isAtLeastU()) { throw new UnsupportedOperationException(); } - return mConfirmation; + return mConfirmationDialogDetails; } @Override @@ -614,7 +615,8 @@ public final class SafetyCenterIssue implements Parcelable { && mWillResolve == action.mWillResolve && mInFlight == action.mInFlight && TextUtils.equals(mSuccessMessage, action.mSuccessMessage) - && Objects.equals(mConfirmation, action.mConfirmation); + && Objects.equals( + mConfirmationDialogDetails, action.mConfirmationDialogDetails); } @Override @@ -626,7 +628,7 @@ public final class SafetyCenterIssue implements Parcelable { mWillResolve, mInFlight, mPendingIntent, - mConfirmation); + mConfirmationDialogDetails); } @Override @@ -644,8 +646,8 @@ public final class SafetyCenterIssue implements Parcelable { + mInFlight + ", mSuccessMessage=" + mSuccessMessage - + ", mConfirmation=" - + mConfirmation + + ", mConfirmationDialogDetails=" + + mConfirmationDialogDetails + '}'; } @@ -663,50 +665,51 @@ public final class SafetyCenterIssue implements Parcelable { dest.writeBoolean(mInFlight); TextUtils.writeToParcel(mSuccessMessage, dest, flags); if (SdkLevel.isAtLeastU()) { - dest.writeTypedObject(mConfirmation, flags); + dest.writeTypedObject(mConfirmationDialogDetails, flags); } } /** Data for an action confirmation dialog to be shown before action is executed. */ @RequiresApi(UPSIDE_DOWN_CAKE) - public static final class Confirmation implements Parcelable { + public static final class ConfirmationDialogDetails implements Parcelable { @NonNull - public static final Creator<Confirmation> CREATOR = - new Creator<Confirmation>() { + public static final Creator<ConfirmationDialogDetails> CREATOR = + new Creator<ConfirmationDialogDetails>() { @Override - public Confirmation createFromParcel(Parcel in) { + public ConfirmationDialogDetails createFromParcel(Parcel in) { CharSequence title = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); CharSequence text = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - CharSequence accept = + CharSequence acceptButtonText = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - CharSequence deny = + CharSequence denyButtonText = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - return new Confirmation(title, text, accept, deny); + return new ConfirmationDialogDetails( + title, text, acceptButtonText, denyButtonText); } @Override - public Confirmation[] newArray(int size) { - return new Confirmation[size]; + public ConfirmationDialogDetails[] newArray(int size) { + return new ConfirmationDialogDetails[size]; } }; @NonNull private final CharSequence mTitle; @NonNull private final CharSequence mText; - @NonNull private final CharSequence mAccept; - @NonNull private final CharSequence mDeny; + @NonNull private final CharSequence mAcceptButtonText; + @NonNull private final CharSequence mDenyButtonText; - public Confirmation( + public ConfirmationDialogDetails( @NonNull CharSequence title, @NonNull CharSequence text, - @NonNull CharSequence accept, - @NonNull CharSequence deny) { + @NonNull CharSequence acceptButtonText, + @NonNull CharSequence denyButtonText) { mTitle = requireNonNull(title); mText = requireNonNull(text); - mAccept = requireNonNull(accept); - mDeny = requireNonNull(deny); + mAcceptButtonText = requireNonNull(acceptButtonText); + mDenyButtonText = requireNonNull(denyButtonText); } /** Returns the title of action confirmation dialog. */ @@ -723,14 +726,14 @@ public final class SafetyCenterIssue implements Parcelable { /** Returns the text of the button to accept action execution. */ @NonNull - public CharSequence getAccept() { - return mAccept; + public CharSequence getAcceptButtonText() { + return mAcceptButtonText; } /** Returns the text of the button to deny action execution. */ @NonNull - public CharSequence getDeny() { - return mDeny; + public CharSequence getDenyButtonText() { + return mDenyButtonText; } @Override @@ -742,37 +745,37 @@ public final class SafetyCenterIssue implements Parcelable { public void writeToParcel(@NonNull Parcel dest, int flags) { TextUtils.writeToParcel(mTitle, dest, flags); TextUtils.writeToParcel(mText, dest, flags); - TextUtils.writeToParcel(mAccept, dest, flags); - TextUtils.writeToParcel(mDeny, dest, flags); + TextUtils.writeToParcel(mAcceptButtonText, dest, flags); + TextUtils.writeToParcel(mDenyButtonText, dest, flags); } @Override public boolean equals(Object o) { if (this == o) return true; - if (!(o instanceof Confirmation)) return false; - Confirmation that = (Confirmation) o; + if (!(o instanceof ConfirmationDialogDetails)) return false; + ConfirmationDialogDetails that = (ConfirmationDialogDetails) o; return TextUtils.equals(mTitle, that.mTitle) && TextUtils.equals(mText, that.mText) - && TextUtils.equals(mAccept, that.mAccept) - && TextUtils.equals(mDeny, that.mDeny); + && TextUtils.equals(mAcceptButtonText, that.mAcceptButtonText) + && TextUtils.equals(mDenyButtonText, that.mDenyButtonText); } @Override public int hashCode() { - return Objects.hash(mTitle, mText, mAccept, mDeny); + return Objects.hash(mTitle, mText, mAcceptButtonText, mDenyButtonText); } @Override public String toString() { - return "Confirmation{" + return "ConfirmationDialogDetails{" + "mTitle=" + mTitle + ", mText=" + mText - + ", mAccept=" - + mAccept - + ", mDeny=" - + mDeny + + ", mAcceptButtonText=" + + mAcceptButtonText + + ", mDenyButtonText=" + + mDenyButtonText + '}'; } } @@ -786,7 +789,7 @@ public final class SafetyCenterIssue implements Parcelable { private boolean mWillResolve; private boolean mInFlight; @Nullable private CharSequence mSuccessMessage; - @Nullable private Confirmation mConfirmation; + @Nullable private ConfirmationDialogDetails mConfirmationDialogDetails; /** * Creates a new {@link Builder} for an {@link Action}. @@ -817,7 +820,7 @@ public final class SafetyCenterIssue implements Parcelable { mWillResolve = action.mWillResolve; mInFlight = action.mInFlight; mSuccessMessage = action.mSuccessMessage; - mConfirmation = action.mConfirmation; + mConfirmationDialogDetails = action.mConfirmationDialogDetails; } /** Sets the ID of this {@link Action} */ @@ -884,11 +887,12 @@ public final class SafetyCenterIssue implements Parcelable { */ @NonNull @RequiresApi(UPSIDE_DOWN_CAKE) - public Builder setConfirmation(@Nullable Confirmation confirmation) { + public Builder setConfirmationDialogDetails( + @Nullable ConfirmationDialogDetails confirmationDialogDetails) { if (!SdkLevel.isAtLeastU()) { throw new UnsupportedOperationException(); } - mConfirmation = confirmation; + mConfirmationDialogDetails = confirmationDialogDetails; return this; } @@ -902,7 +906,7 @@ public final class SafetyCenterIssue implements Parcelable { mWillResolve, mInFlight, mSuccessMessage, - mConfirmation); + mConfirmationDialogDetails); } } } diff --git a/framework-s/java/android/safetycenter/SafetySourceIssue.java b/framework-s/java/android/safetycenter/SafetySourceIssue.java index eda346326..985131764 100644 --- a/framework-s/java/android/safetycenter/SafetySourceIssue.java +++ b/framework-s/java/android/safetycenter/SafetySourceIssue.java @@ -637,8 +637,9 @@ public final class SafetySourceIssue implements Parcelable { TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel( in)); if (SdkLevel.isAtLeastU()) { - Confirmation confirmation = in.readTypedObject(Confirmation.CREATOR); - builder.setConfirmation(confirmation); + ConfirmationDialogDetails confirmationDialogDetails = + in.readTypedObject(ConfirmationDialogDetails.CREATOR); + builder.setConfirmationDialogDetails(confirmationDialogDetails); } return builder.build(); } @@ -666,7 +667,7 @@ public final class SafetySourceIssue implements Parcelable { @NonNull private final PendingIntent mPendingIntent; private final boolean mWillResolve; @Nullable private final CharSequence mSuccessMessage; - @Nullable private final Confirmation mConfirmation; + @Nullable private final ConfirmationDialogDetails mConfirmationDialogDetails; private Action( @NonNull String id, @@ -674,13 +675,13 @@ public final class SafetySourceIssue implements Parcelable { @NonNull PendingIntent pendingIntent, boolean willResolve, @Nullable CharSequence successMessage, - @Nullable Confirmation confirmation) { + @Nullable ConfirmationDialogDetails confirmationDialogDetails) { mId = id; mLabel = label; mPendingIntent = pendingIntent; mWillResolve = willResolve; mSuccessMessage = successMessage; - mConfirmation = confirmation; + mConfirmationDialogDetails = confirmationDialogDetails; } /** @@ -736,11 +737,11 @@ public final class SafetySourceIssue implements Parcelable { */ @Nullable @RequiresApi(UPSIDE_DOWN_CAKE) - public Confirmation getConfirmation() { + public ConfirmationDialogDetails getConfirmationDialogDetails() { if (!SdkLevel.isAtLeastU()) { throw new UnsupportedOperationException(); } - return mConfirmation; + return mConfirmationDialogDetails; } @Override @@ -756,7 +757,7 @@ public final class SafetySourceIssue implements Parcelable { dest.writeBoolean(mWillResolve); TextUtils.writeToParcel(mSuccessMessage, dest, flags); if (SdkLevel.isAtLeastU()) { - dest.writeTypedObject(mConfirmation, flags); + dest.writeTypedObject(mConfirmationDialogDetails, flags); } } @@ -770,13 +771,18 @@ public final class SafetySourceIssue implements Parcelable { && mPendingIntent.equals(that.mPendingIntent) && mWillResolve == that.mWillResolve && TextUtils.equals(mSuccessMessage, that.mSuccessMessage) - && Objects.equals(mConfirmation, that.mConfirmation); + && Objects.equals(mConfirmationDialogDetails, that.mConfirmationDialogDetails); } @Override public int hashCode() { return Objects.hash( - mId, mLabel, mPendingIntent, mWillResolve, mSuccessMessage, mConfirmation); + mId, + mLabel, + mPendingIntent, + mWillResolve, + mSuccessMessage, + mConfirmationDialogDetails); } @Override @@ -792,51 +798,52 @@ public final class SafetySourceIssue implements Parcelable { + mWillResolve + ", mSuccessMessage=" + mSuccessMessage - + ", mConfirmation=" - + mConfirmation + + ", mConfirmationDialogDetails=" + + mConfirmationDialogDetails + '}'; } /** Data for an action confirmation dialog to be shown before action is executed. */ @RequiresApi(UPSIDE_DOWN_CAKE) - public static final class Confirmation implements Parcelable { + public static final class ConfirmationDialogDetails implements Parcelable { @NonNull - public static final Creator<Confirmation> CREATOR = - new Creator<Confirmation>() { + public static final Creator<ConfirmationDialogDetails> CREATOR = + new Creator<ConfirmationDialogDetails>() { @Override - public Confirmation createFromParcel(Parcel in) { + public ConfirmationDialogDetails createFromParcel(Parcel in) { CharSequence title = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); CharSequence text = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - CharSequence accept = + CharSequence acceptButtonText = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - CharSequence deny = + CharSequence denyButtonText = TextUtils.CHAR_SEQUENCE_CREATOR.createFromParcel(in); - return new Confirmation(title, text, accept, deny); + return new ConfirmationDialogDetails( + title, text, acceptButtonText, denyButtonText); } @Override - public Confirmation[] newArray(int size) { - return new Confirmation[size]; + public ConfirmationDialogDetails[] newArray(int size) { + return new ConfirmationDialogDetails[size]; } }; @NonNull private final CharSequence mTitle; @NonNull private final CharSequence mText; - @NonNull private final CharSequence mAccept; - @NonNull private final CharSequence mDeny; + @NonNull private final CharSequence mAcceptButtonText; + @NonNull private final CharSequence mDenyButtonText; - public Confirmation( + public ConfirmationDialogDetails( @NonNull CharSequence title, @NonNull CharSequence text, - @NonNull CharSequence accept, - @NonNull CharSequence deny) { + @NonNull CharSequence acceptButtonText, + @NonNull CharSequence denyButtonText) { mTitle = requireNonNull(title); mText = requireNonNull(text); - mAccept = requireNonNull(accept); - mDeny = requireNonNull(deny); + mAcceptButtonText = requireNonNull(acceptButtonText); + mDenyButtonText = requireNonNull(denyButtonText); } /** Returns the title of action confirmation dialog. */ @@ -853,14 +860,14 @@ public final class SafetySourceIssue implements Parcelable { /** Returns the text of the button to accept action execution. */ @NonNull - public CharSequence getAccept() { - return mAccept; + public CharSequence getAcceptButtonText() { + return mAcceptButtonText; } /** Returns the text of the button to deny action execution. */ @NonNull - public CharSequence getDeny() { - return mDeny; + public CharSequence getDenyButtonText() { + return mDenyButtonText; } @Override @@ -872,37 +879,37 @@ public final class SafetySourceIssue implements Parcelable { public void writeToParcel(@NonNull Parcel dest, int flags) { TextUtils.writeToParcel(mTitle, dest, flags); TextUtils.writeToParcel(mText, dest, flags); - TextUtils.writeToParcel(mAccept, dest, flags); - TextUtils.writeToParcel(mDeny, dest, flags); + TextUtils.writeToParcel(mAcceptButtonText, dest, flags); + TextUtils.writeToParcel(mDenyButtonText, dest, flags); } @Override public boolean equals(Object o) { if (this == o) return true; - if (!(o instanceof Confirmation)) return false; - Confirmation that = (Confirmation) o; + if (!(o instanceof ConfirmationDialogDetails)) return false; + ConfirmationDialogDetails that = (ConfirmationDialogDetails) o; return TextUtils.equals(mTitle, that.mTitle) && TextUtils.equals(mText, that.mText) - && TextUtils.equals(mAccept, that.mAccept) - && TextUtils.equals(mDeny, that.mDeny); + && TextUtils.equals(mAcceptButtonText, that.mAcceptButtonText) + && TextUtils.equals(mDenyButtonText, that.mDenyButtonText); } @Override public int hashCode() { - return Objects.hash(mTitle, mText, mAccept, mDeny); + return Objects.hash(mTitle, mText, mAcceptButtonText, mDenyButtonText); } @Override public String toString() { - return "Confirmation{" + return "ConfirmationDialogDetails{" + "mTitle=" + mTitle + ", mText=" + mText - + ", mAccept=" - + mAccept - + ", mDeny=" - + mDeny + + ", mAcceptButtonText=" + + mAcceptButtonText + + ", mDenyButtonText=" + + mDenyButtonText + '}'; } } @@ -915,7 +922,7 @@ public final class SafetySourceIssue implements Parcelable { @NonNull private final PendingIntent mPendingIntent; private boolean mWillResolve = false; @Nullable private CharSequence mSuccessMessage; - @Nullable private Confirmation mConfirmation; + @Nullable private ConfirmationDialogDetails mConfirmationDialogDetails; /** Creates a {@link Builder} for an {@link Action}. */ public Builder( @@ -939,7 +946,7 @@ public final class SafetySourceIssue implements Parcelable { mPendingIntent = action.mPendingIntent; mWillResolve = action.mWillResolve; mSuccessMessage = action.mSuccessMessage; - mConfirmation = action.mConfirmation; + mConfirmationDialogDetails = action.mConfirmationDialogDetails; } /** @@ -947,7 +954,7 @@ public final class SafetySourceIssue implements Parcelable { * * <p>Note: It is not allowed for resolvable actions to have a {@link PendingIntent} * that launches activity. When extra confirmation is needed consider using {@link - * Builder#setConfirmation}. + * Builder#setConfirmationDialogDetails}. * * @see #willResolve() */ @@ -974,11 +981,12 @@ public final class SafetySourceIssue implements Parcelable { */ @NonNull @RequiresApi(UPSIDE_DOWN_CAKE) - public Builder setConfirmation(@Nullable Confirmation confirmation) { + public Builder setConfirmationDialogDetails( + @Nullable ConfirmationDialogDetails confirmationDialogDetails) { if (!SdkLevel.isAtLeastU()) { throw new UnsupportedOperationException(); } - mConfirmation = confirmation; + mConfirmationDialogDetails = confirmationDialogDetails; return this; } @@ -996,7 +1004,12 @@ public final class SafetySourceIssue implements Parcelable { + " broadcast."); } return new Action( - mId, mLabel, mPendingIntent, mWillResolve, mSuccessMessage, mConfirmation); + mId, + mLabel, + mPendingIntent, + mWillResolve, + mSuccessMessage, + mConfirmationDialogDetails); } } } diff --git a/tests/cts/safetycenter/src/android/safetycenter/cts/SafetyCenterIssueTest.kt b/tests/cts/safetycenter/src/android/safetycenter/cts/SafetyCenterIssueTest.kt index c39bbeb10..0181e469d 100644 --- a/tests/cts/safetycenter/src/android/safetycenter/cts/SafetyCenterIssueTest.kt +++ b/tests/cts/safetycenter/src/android/safetycenter/cts/SafetyCenterIssueTest.kt @@ -23,7 +23,7 @@ import android.os.Build import android.os.Build.VERSION_CODES.TIRAMISU import android.os.Build.VERSION_CODES.UPSIDE_DOWN_CAKE import android.safetycenter.SafetyCenterIssue -import android.safetycenter.SafetyCenterIssue.Action.Confirmation +import android.safetycenter.SafetyCenterIssue.Action.ConfirmationDialogDetails import androidx.annotation.RequiresApi import androidx.test.core.app.ApplicationProvider import androidx.test.ext.junit.runners.AndroidJUnit4 @@ -309,7 +309,9 @@ class SafetyCenterIssueTest { .setActions( listOf( SafetyCenterIssue.Action.Builder(action1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() ) ) @@ -369,42 +371,47 @@ class SafetyCenterIssueTest { @Test @SdkSuppress(maxSdkVersion = TIRAMISU) - fun action_getConfirmation_withVersionLessThanU_throwsUnsupportedOperationException() { + fun action_getConfirmationDialogDetails_withVersionLessThanU_throwsUnsupportedOperation() { // TODO(b/258228790): Remove after U is no longer in pre-release assumeFalse(Build.VERSION.CODENAME == "UpsideDownCake") - assertFailsWith(UnsupportedOperationException::class) { action1.confirmation } + assertFailsWith(UnsupportedOperationException::class) { action1.confirmationDialogDetails } } @Test @SdkSuppress(maxSdkVersion = TIRAMISU) - fun action_setConfirmation_withVersionLessThanU_throwsUnsupportedOperationException() { + fun action_setConfirmationDialogDetails_withVersionLessThanU_throwsUnsupportedOperation() { // TODO(b/258228790): Remove after U is no longer in pre-release assumeFalse(Build.VERSION.CODENAME == "UpsideDownCake") assertFailsWith(UnsupportedOperationException::class) { SafetyCenterIssue.Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) } } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun action_getConfirmation_withDefaultBuilder_returnsNull() { + fun action_getConfirmationDialogDetails_withDefaultBuilder_returnsNull() { val action = SafetyCenterIssue.Action.Builder("action_id", "Action label", pendingIntent1).build() - assertThat(action.confirmation).isNull() + assertThat(action.confirmationDialogDetails).isNull() } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun action_getConfirmation_whenSetExplicitly_returnsConfirmation() { + fun action_getConfirmationDialogDetails_whenSetExplicitly_returnsConfirmation() { val action = SafetyCenterIssue.Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() - assertThat(action.confirmation).isEqualTo(Confirmation("Title", "Text", "Accept", "Deny")) + assertThat(action.confirmationDialogDetails) + .isEqualTo(ConfirmationDialogDetails("Title", "Text", "Accept", "Deny")) } @Test @@ -424,7 +431,9 @@ class SafetyCenterIssueTest { fun action_parcelRoundTrip_recreatesEqual_atLeastAndroidU() { val action = SafetyCenterIssue.Action.Builder(action1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() assertThat(action).recreatesEqual(SafetyCenterIssue.Action.CREATOR) @@ -438,72 +447,76 @@ class SafetyCenterIssueTest { @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun action_equalsHashCodeToString_usingEqualsHashCodeToStringTester_atLeastAndroidU() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") issueActionNewTiramisuEqualsHashCodeToStringTester( createCopyFromBuilder = { SafetyCenterIssue.Action.Builder(it).build() } ) .addEqualityGroup( - SafetyCenterIssue.Action.Builder(action1).setConfirmation(confirmation).build() + SafetyCenterIssue.Action.Builder(action1) + .setConfirmationDialogDetails(confirmationDialogDetails) + .build() ) .addEqualityGroup( - SafetyCenterIssue.Action.Builder(action2).setConfirmation(confirmation).build() + SafetyCenterIssue.Action.Builder(action2) + .setConfirmationDialogDetails(confirmationDialogDetails) + .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setWillResolve(true) .setIsInFlight(true) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build(), SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setWillResolve(true) .setIsInFlight(true) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("a_different_id", "a label", pendingIntent1) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a different label", pendingIntent1) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent2) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setWillResolve(true) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setIsInFlight(true) .setSuccessMessage("a success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( SafetyCenterIssue.Action.Builder("an_id", "a label", pendingIntent1) .setSuccessMessage("a different success message") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( @@ -511,7 +524,7 @@ class SafetyCenterIssueTest { .setId("another_id") .setLabel("another_label") .setPendingIntent(pendingIntent2) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .test() @@ -533,7 +546,7 @@ class SafetyCenterIssueTest { .setShouldConfirmDismissal(true) .setActions(listOf(action1)) .build() - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") return newTiramisuEqualsHashCodeToStringTester( createCopyFromBuilder = { SafetyCenterIssue.Builder(it).build() } ) @@ -570,7 +583,7 @@ class SafetyCenterIssueTest { .setActions( listOf( SafetyCenterIssue.Action.Builder(action1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) ) @@ -581,63 +594,65 @@ class SafetyCenterIssueTest { @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_getTitle_returnsTitle() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.title).isEqualTo("Title") + assertThat(confirmationDialogDetails.title).isEqualTo("Title") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_getText_returnsText() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.text).isEqualTo("Text") + assertThat(confirmationDialogDetails.text).isEqualTo("Text") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun actionConfirmation_getAccept_returnsAccept() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + fun actionConfirmation_getAcceptButtonText_returnsAcceptButtonText() { + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.accept).isEqualTo("Accept") + assertThat(confirmationDialogDetails.acceptButtonText).isEqualTo("Accept") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun actionConfirmation_getDeny_returnsDeny() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + fun actionConfirmation_getDenyButtonText_returnsDenyButtonText() { + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.deny).isEqualTo("Deny") + assertThat(confirmationDialogDetails.denyButtonText).isEqualTo("Deny") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_describeContents_returns0() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.describeContents()).isEqualTo(0) + assertThat(confirmationDialogDetails.describeContents()).isEqualTo(0) } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_parcelRoundTrip_recreatesEqual() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation).recreatesEqual(Confirmation.CREATOR) + assertThat(confirmationDialogDetails).recreatesEqual(ConfirmationDialogDetails.CREATOR) } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_equalsHashCodeToString_usingEqualsHashCodeToStringTester() { - EqualsHashCodeToStringTester.ofParcelable(parcelableCreator = Confirmation.CREATOR) + EqualsHashCodeToStringTester.ofParcelable( + parcelableCreator = ConfirmationDialogDetails.CREATOR + ) .addEqualityGroup( - Confirmation("Title", "Text", "Accept", "Deny"), - Confirmation("Title", "Text", "Accept", "Deny") + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny"), + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") ) - .addEqualityGroup(Confirmation("Other title", "Text", "Accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Other text", "Accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Text", "Other accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Text", "Accept", "Other deny")) + .addEqualityGroup(ConfirmationDialogDetails("Other title", "Text", "Accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Other text", "Accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Text", "Other accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Text", "Accept", "Other deny")) .test() } diff --git a/tests/cts/safetycenter/src/android/safetycenter/cts/SafetySourceIssueTest.kt b/tests/cts/safetycenter/src/android/safetycenter/cts/SafetySourceIssueTest.kt index b45202f69..b2b62a6eb 100644 --- a/tests/cts/safetycenter/src/android/safetycenter/cts/SafetySourceIssueTest.kt +++ b/tests/cts/safetycenter/src/android/safetycenter/cts/SafetySourceIssueTest.kt @@ -28,7 +28,7 @@ import android.safetycenter.SafetySourceData.SEVERITY_LEVEL_INFORMATION import android.safetycenter.SafetySourceData.SEVERITY_LEVEL_UNSPECIFIED import android.safetycenter.SafetySourceIssue import android.safetycenter.SafetySourceIssue.Action -import android.safetycenter.SafetySourceIssue.Action.Confirmation +import android.safetycenter.SafetySourceIssue.Action.ConfirmationDialogDetails import android.safetycenter.SafetySourceIssue.ISSUE_CATEGORY_ACCOUNT import android.safetycenter.SafetySourceIssue.ISSUE_CATEGORY_DEVICE import android.safetycenter.SafetySourceIssue.ISSUE_CATEGORY_GENERAL @@ -119,42 +119,47 @@ class SafetySourceIssueTest { @Test @SdkSuppress(maxSdkVersion = TIRAMISU) - fun action_getConfirmation_withVersionLessThanU_throwsUnsupportedOperationException() { + fun action_getConfirmationDialogDetails_withVersionLessThanU_throwsUnsupportedOperation() { // TODO(b/258228790): Remove after U is no longer in pre-release assumeFalse(Build.VERSION.CODENAME == "UpsideDownCake") val action = Action.Builder("action_id", "Action label", pendingIntent1).build() - assertFailsWith(UnsupportedOperationException::class) { action.confirmation } + assertFailsWith(UnsupportedOperationException::class) { action.confirmationDialogDetails } } @Test @SdkSuppress(maxSdkVersion = TIRAMISU) - fun action_setConfirmation_withVersionLessThanU_throwsUnsupportedOperationException() { + fun action_setConfirmationDialogDetails_withVersionLessThanU_throwsUnsupportedOperation() { // TODO(b/258228790): Remove after U is no longer in pre-release assumeFalse(Build.VERSION.CODENAME == "UpsideDownCake") assertFailsWith(UnsupportedOperationException::class) { Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) } } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun action_getConfirmation_withDefaultBuilder_returnsNull() { + fun action_getConfirmationDialogDetails_withDefaultBuilder_returnsNull() { val action = Action.Builder("action_id", "Action label", pendingIntent1).build() - assertThat(action.confirmation).isNull() + assertThat(action.confirmationDialogDetails).isNull() } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun action_getConfirmation_whenSetExplicitly_returnsConfirmation() { + fun action_getConfirmationDialogDetails_whenSetExplicitly_returnsConfirmation() { val action = Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() - assertThat(action.confirmation).isEqualTo(Confirmation("Title", "Text", "Accept", "Deny")) + assertThat(action.confirmationDialogDetails) + .isEqualTo(ConfirmationDialogDetails("Title", "Text", "Accept", "Deny")) } @Test @@ -208,7 +213,9 @@ class SafetySourceIssueTest { fun action_parcelRoundTrip_recreatesEqual_atLeastAndroidU() { val action = Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() assertThat(action).recreatesEqual(Action.CREATOR) @@ -222,42 +229,42 @@ class SafetySourceIssueTest { @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun action_equalsHashCodeToString_usingEqualsHashCodeToStringTester_atLeastAndroidU() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") actionNewTiramisuEqualsHashCodeToStringTester( createCopyFromBuilder = { Action.Builder(it).build() } ) .addEqualityGroup( Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build(), Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build(), Action.Builder("action_id", "Action label", pendingIntent1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .setWillResolve(false) .build() ) .addEqualityGroup( Action.Builder("action_id", "Action label", pendingIntent1) .setSuccessMessage("Action successfully completed") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( Action.Builder("action_id", "Other action label", pendingIntent1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( Action.Builder("other_action_id", "Action label", pendingIntent1) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( Action.Builder("action_id", "Action label", pendingIntentService) .setWillResolve(true) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( @@ -271,13 +278,13 @@ class SafetySourceIssueTest { FLAG_IMMUTABLE ) ) - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .addEqualityGroup( Action.Builder("action_id", "Action label", pendingIntent1) .setSuccessMessage("Other action successfully completed") - .setConfirmation(confirmation) + .setConfirmationDialogDetails(confirmationDialogDetails) .build() ) .test() @@ -483,63 +490,65 @@ class SafetySourceIssueTest { @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_getTitle_returnsTitle() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.title).isEqualTo("Title") + assertThat(confirmationDialogDetails.title).isEqualTo("Title") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_getText_returnsText() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.text).isEqualTo("Text") + assertThat(confirmationDialogDetails.text).isEqualTo("Text") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun actionConfirmation_getAccept_returnsAccept() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + fun actionConfirmation_getAcceptButtonText_returnsAcceptButtonText() { + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.accept).isEqualTo("Accept") + assertThat(confirmationDialogDetails.acceptButtonText).isEqualTo("Accept") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") - fun actionConfirmation_getDeny_returnsDeny() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + fun actionConfirmation_getDenyButtonText_returnsDenyButtonText() { + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.deny).isEqualTo("Deny") + assertThat(confirmationDialogDetails.denyButtonText).isEqualTo("Deny") } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_describeContents_returns0() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation.describeContents()).isEqualTo(0) + assertThat(confirmationDialogDetails.describeContents()).isEqualTo(0) } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_parcelRoundTrip_recreatesEqual() { - val confirmation = Confirmation("Title", "Text", "Accept", "Deny") + val confirmationDialogDetails = ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") - assertThat(confirmation).recreatesEqual(Confirmation.CREATOR) + assertThat(confirmationDialogDetails).recreatesEqual(ConfirmationDialogDetails.CREATOR) } @Test @SdkSuppress(minSdkVersion = UPSIDE_DOWN_CAKE, codeName = "UpsideDownCake") fun actionConfirmation_equalsHashCodeToString_usingEqualsHashCodeToStringTester() { - EqualsHashCodeToStringTester.ofParcelable(parcelableCreator = Confirmation.CREATOR) + EqualsHashCodeToStringTester.ofParcelable( + parcelableCreator = ConfirmationDialogDetails.CREATOR + ) .addEqualityGroup( - Confirmation("Title", "Text", "Accept", "Deny"), - Confirmation("Title", "Text", "Accept", "Deny") + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny"), + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") ) - .addEqualityGroup(Confirmation("Other title", "Text", "Accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Other text", "Accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Text", "Other accept", "Deny")) - .addEqualityGroup(Confirmation("Title", "Text", "Accept", "Other deny")) + .addEqualityGroup(ConfirmationDialogDetails("Other title", "Text", "Accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Other text", "Accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Text", "Other accept", "Deny")) + .addEqualityGroup(ConfirmationDialogDetails("Title", "Text", "Accept", "Other deny")) .test() } @@ -1566,7 +1575,9 @@ class SafetySourceIssueTest { .setIssueCategory(ISSUE_CATEGORY_ACCOUNT) .addAction( Action.Builder(action1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() ) .addAction(action2) @@ -1881,7 +1892,9 @@ class SafetySourceIssueTest { .setIssueCategory(ISSUE_CATEGORY_ACCOUNT) .addAction( Action.Builder(action1) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() ) .addAction(action2) @@ -1901,7 +1914,9 @@ class SafetySourceIssueTest { .addAction(action1) .addAction( Action.Builder(action2) - .setConfirmation(Confirmation("Title", "Text", "Accept", "Deny")) + .setConfirmationDialogDetails( + ConfirmationDialogDetails("Title", "Text", "Accept", "Deny") + ) .build() ) .setOnDismissPendingIntent(pendingIntentService) |