From b24a2c4f0110afec2b6f1ba6ff06dc8a6b82a716 Mon Sep 17 00:00:00 2001 From: Govinda Wasserman Date: Mon, 4 Nov 2024 15:02:38 -0500 Subject: Fix Shareousel not always centering initial selection Makes starting index correctly update as pages load/unload. This allows us to correctly initialize the scroll without using a LaunchedEffect. Also consolidates measurement-related logic into a helper class for consistency. Test: atest com.android.intentresolver Test: manual test using Sharetest with 5 images and selected index 3 or 4 BUG: 351911089 FIX: 351911089 flag: EXEMPT Bugfix Change-Id: I5a10b5d50f393958b3574bf0a7742b5af93d4a67 --- .../payloadtoggle/domain/interactor/CursorPreviewsInteractorTest.kt | 2 +- .../payloadtoggle/domain/interactor/FetchPreviewsInteractorTest.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/CursorPreviewsInteractorTest.kt b/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/CursorPreviewsInteractorTest.kt index f43f1467..5d29b4f3 100644 --- a/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/CursorPreviewsInteractorTest.kt +++ b/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/CursorPreviewsInteractorTest.kt @@ -172,7 +172,7 @@ class CursorPreviewsInteractorTest { } ) .inOrder() - assertThat(startIdx).isEqualTo(0) + assertThat(startIdx).isEqualTo(2) assertThat(loadMoreLeft).isNull() assertThat(loadMoreRight).isNotNull() assertThat(leftTriggerIndex).isEqualTo(2) diff --git a/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/FetchPreviewsInteractorTest.kt b/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/FetchPreviewsInteractorTest.kt index 09d254f3..0a56a2d0 100644 --- a/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/FetchPreviewsInteractorTest.kt +++ b/tests/unit/src/com/android/intentresolver/contentpreview/payloadtoggle/domain/interactor/FetchPreviewsInteractorTest.kt @@ -167,7 +167,7 @@ class FetchPreviewsInteractorTest { with(cursorPreviewsRepository) { assertThat(previewsModel.value).isNotNull() - assertThat(previewsModel.value!!.startIdx).isEqualTo(0) + assertThat(previewsModel.value!!.startIdx).isEqualTo(2) assertThat(previewsModel.value!!.loadMoreLeft).isNull() assertThat(previewsModel.value!!.loadMoreRight).isNull() assertThat(previewsModel.value!!.previewModels) -- cgit v1.2.3-59-g8ed1b