From 34ec7d2e9baa86b434ca3506c31257887a198c5b Mon Sep 17 00:00:00 2001 From: Andrey Epin Date: Mon, 31 Oct 2022 14:00:37 -0700 Subject: Remove SelectableTargetInfo#SelectableTargetInfoCommunicator interface Both SelectableTargetInfo#SelectableTargetInfoCommunicator and ChooserListAdapter#ChooserListCommunicator are used and implemented by the same classes: ChooserListAdapter and ChooserActivity respectively. Fix: 257483782 Test: manual test Test: atest IntentResolverUnitTests Change-Id: Ia0f5e0637c63cdf3e7b53f9e77c4b94dea81475c --- .../src/com/android/intentresolver/ChooserListAdapterTest.kt | 7 +------ .../com/android/intentresolver/ChooserWrapperActivity.java | 12 +++++++++--- 2 files changed, 10 insertions(+), 9 deletions(-) (limited to 'java/tests/src') diff --git a/java/tests/src/com/android/intentresolver/ChooserListAdapterTest.kt b/java/tests/src/com/android/intentresolver/ChooserListAdapterTest.kt index c43b014c..bcb6c240 100644 --- a/java/tests/src/com/android/intentresolver/ChooserListAdapterTest.kt +++ b/java/tests/src/com/android/intentresolver/ChooserListAdapterTest.kt @@ -28,7 +28,6 @@ import androidx.test.ext.junit.runners.AndroidJUnit4 import androidx.test.platform.app.InstrumentationRegistry import com.android.intentresolver.ChooserListAdapter.LoadDirectShareIconTask import com.android.intentresolver.chooser.SelectableTargetInfo -import com.android.intentresolver.chooser.SelectableTargetInfo.SelectableTargetInfoCommunicator import com.android.intentresolver.chooser.TargetInfo import com.android.internal.R import org.junit.Before @@ -48,11 +47,8 @@ class ChooserListAdapterTest { private val resolverListController = mock() private val chooserListCommunicator = mock { whenever(maxRankedTargets).thenReturn(0) + whenever(targetIntent).thenReturn(mock()) } - private val selectableTargetInfoCommunicator = - mock { - whenever(targetIntent).thenReturn(mock()) - } private val chooserActivityLogger = mock() private fun createChooserListAdapter( @@ -65,7 +61,6 @@ class ChooserListAdapterTest { false, resolverListController, chooserListCommunicator, - selectableTargetInfoCommunicator, packageManager, chooserActivityLogger, ) { diff --git a/java/tests/src/com/android/intentresolver/ChooserWrapperActivity.java b/java/tests/src/com/android/intentresolver/ChooserWrapperActivity.java index 079fbb9d..c1d20b44 100644 --- a/java/tests/src/com/android/intentresolver/ChooserWrapperActivity.java +++ b/java/tests/src/com/android/intentresolver/ChooserWrapperActivity.java @@ -80,9 +80,15 @@ public class ChooserWrapperActivity PackageManager packageManager = sOverrides.packageManager == null ? context.getPackageManager() : sOverrides.packageManager; - return new ChooserListAdapter(context, payloadIntents, initialIntents, rList, - filterLastUsed, resolverListController, - this, this, packageManager, + return new ChooserListAdapter( + context, + payloadIntents, + initialIntents, + rList, + filterLastUsed, + resolverListController, + this, + packageManager, getChooserActivityLogger()); } -- cgit v1.2.3-59-g8ed1b