From 50a7e3ea4113a3f6fb4e21c36fc7da89862f36e1 Mon Sep 17 00:00:00 2001 From: Andrey Epin Date: Tue, 20 Dec 2022 10:17:36 -0800 Subject: Feature flags support in Chooser A minimalistic replica of the SysUI feature flag infrastructure so the app could both reuse some of the existing flag infrastructure (local flag flipping) and have features controlled remotely (through DeviceConfig). A re-introduction of reverted ag/20796272 with the fixed release build variant. Bug: 262578843 Test: Manual tests with some injected debug code and local flag flipping Test: Smoke tests both build variants Change-Id: Ie536172020bcb7e6cd96f44c228a6941004858f8 --- .../flags/FeatureFlagRepositoryFactory.kt | 24 +++++++++++++++++ .../flags/ReleaseFeatureFlagRepository.kt | 31 ++++++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 java/src-release/com/android/intentresolver/flags/FeatureFlagRepositoryFactory.kt create mode 100644 java/src-release/com/android/intentresolver/flags/ReleaseFeatureFlagRepository.kt (limited to 'java/src-release/com') diff --git a/java/src-release/com/android/intentresolver/flags/FeatureFlagRepositoryFactory.kt b/java/src-release/com/android/intentresolver/flags/FeatureFlagRepositoryFactory.kt new file mode 100644 index 00000000..6bf7579e --- /dev/null +++ b/java/src-release/com/android/intentresolver/flags/FeatureFlagRepositoryFactory.kt @@ -0,0 +1,24 @@ +/* + * Copyright (C) 2022 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.intentresolver.flags + +import android.content.Context + +class FeatureFlagRepositoryFactory { + fun create(context: Context): FeatureFlagRepository = + ReleaseFeatureFlagRepository(DeviceConfigProxy()) +} diff --git a/java/src-release/com/android/intentresolver/flags/ReleaseFeatureFlagRepository.kt b/java/src-release/com/android/intentresolver/flags/ReleaseFeatureFlagRepository.kt new file mode 100644 index 00000000..f9fa2c6a --- /dev/null +++ b/java/src-release/com/android/intentresolver/flags/ReleaseFeatureFlagRepository.kt @@ -0,0 +1,31 @@ +/* + * Copyright (C) 2022 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.android.intentresolver.flags + +import com.android.systemui.flags.ReleasedFlag +import com.android.systemui.flags.UnreleasedFlag +import javax.annotation.concurrent.ThreadSafe + +@ThreadSafe +internal class ReleaseFeatureFlagRepository( + private val deviceConfig: DeviceConfigProxy, +) : FeatureFlagRepository { + override fun isEnabled(flag: UnreleasedFlag): Boolean = flag.default + + override fun isEnabled(flag: ReleasedFlag): Boolean = + deviceConfig.isEnabled(flag) ?: flag.default +} -- cgit v1.2.3-59-g8ed1b