summaryrefslogtreecommitdiff
path: root/java
AgeCommit message (Collapse)Author
2024-09-25Fix keyboard naviagation for the nested preview scrolling Andrey Epin
NestedScrollView is copied into the project from the prebuilt sources and trivially refactored (the differerence is saved in NestedScrollView.java.patch file). ChooserNestedScrollView extends the copied NestedScrollView and disabled scolling to the child that requests focus. Bug: 325259478 Test: attach keboard and test that keyboard navigation is working Flag: com.android.intentresolver.keyboard_navigation_fix Change-Id: I759f3a21aad9197148df31c55ed1534021072bd9
2024-09-25Merge "Import translations. DO NOT MERGE ANYWHERE" into main Treehugger Robot
2024-09-24Merge "Update Chooser drawer max width value on config change." into main Andrey Yepin
2024-09-24Merge "Do not store the initial intent's extra in the saved state." into main Treehugger Robot
2024-09-23Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: Ie85c840821b09508d7b0504ad49cfc43f21c7de4
2024-09-20Update Chooser drawer max width value on config change. Andrey Yepin
Fix: 368654066 Test: manual testing Flag: EXEMPT bug fix Change-Id: Ia4828dcff85fc8c73d8892a764883270fcacb808
2024-09-19Merge "Import translations. DO NOT MERGE ANYWHERE" into main Treehugger Robot
2024-09-18Replace atomicfu with AtomicReference Sunny Goyal
atomicfu internally replaces it with AtomicReference during compile This avoids an additional preprocessing step during compile, and also makes the gradle setup easier Bug: 368177559 Test: Presubmit Flag: EXEMPT refactor Change-Id: I6840e0687b78b38df7ac5d187bf147e0c5a33e24
2024-09-18Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: I4585376ea7bb4b45f668ab1debd5bfe5773ad660
2024-09-17Do not store the initial intent's extra in the saved state. Andrey Yepin
CreationExtras's DEFAULT_ARGS_KEY vlaue gets saved in SavedStateHandle for each view model the activity creates. Thus by storing the ActivityModel in there we effectively duplicated the initial intent's extra in the activity's saved state 4 times: DEFAULT_ARGS_KEY contains the extras (put there by ComponentActivity) plus ActivityModel per two view models we created. This change makes Chooser and Resolver activities provide default CreationExtras with empty DEFAULT_ARGS_KEY values and stores ActivityModel in the new repository class (instead of the SavedStateHandle instance). Fix: 331897641 Test: manual testing with injected logging the values being put in the activity's saved state Test: atest IntentResolver-tests-unit Test: atest Intentresolver-tests-activity Flag: EXEMPT bugfix Change-Id: Ice2e51971476b2bb963f04275d7b180c85126288
2024-09-10Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: I44752e030d10f135671046403fc867bece2de6c1
2024-08-29Log payload selection changes Andrey Yepin
Bug: 329068612 Test: manual testing with an injected debug logging Test: atest IntentResolver-tests-unit Flag: EXEMPT ui events logging Change-Id: Iac9e2bcf93375d5761be5287b6cf9297be399e77
2024-08-29Report Shareousel preview type Andrey Yepin
Bug: 329068612 Test: atest IntentResolver-tests-unit Flag: EXEMPT ui events logging Change-Id: I0a9cd4d50f4a883c162be153c9e0a0a8f10816c2
2024-08-27Merge "Import translations. DO NOT MERGE ANYWHERE" into main Treehugger Robot
2024-08-27Merge "Fix ChooserRequest.sharedText value parsing" into main Treehugger Robot
2024-08-26Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: If56d90961f430145e5b9b69f33fcb4866cfaafcb
2024-08-22Fix ChooserRequest.sharedText value parsing Andrey Yepin
readChooserRequest was reading sharedText value from the chooser intent's extra instead of the target intent's extra. Additional refactorings: * sharedTextTitle is added to the ChooserReqeust (read from target intent's EXTRA_TITLE extra); * ChooserContentPreviewUi is modified to use ChooserReqeust instead of extracting values form the target intent. Fix: 361654855 Test: atest IntentResolver-tests-unit Test: manual testing various previw variations with the ShareTest app Flag: EXEMPT bugfix Change-Id: Ic9e0e200f4b9a84df4830e99dd42cb1bc7258caf
2024-08-22Scroll partially offscreen items to be fully onscreen when toggled Govinda Wasserman
Test: manual test using ShareTest BUG: 351883537 FIX: 351883537 Flag: com.android.intentresolver.shareousel_scroll_offscreen_selections Change-Id: Id9c7e31169bce11b722868338f87228c9450c9aa
2024-08-22Remove FLAG_ENABLE_CHOOSER_RESULT (IntentResolver) Matt Casey
Launched in V. Bug: 263474465 Test: atest ShareResultSenderImplTest Flag: EXEMPT flag removal Change-Id: I5cd53e1608b415e3b9db80ce48899c42c755660d
2024-08-21Merge "Import translations. DO NOT MERGE ANYWHERE" into main Treehugger Robot
2024-08-19Use a viewmodel property instead of reaching to the repository Andrey Yepin
A small adjustment to ag/28621884 to use the ShareouselViewModel.hasSelectedItems property instead of reaching to the selection repository. Fix: 349468879 Test: atest IntentResolver-tests-unit Test: manual functionality testing Flag: com.android.intentresolver.unselect_final_item Change-Id: Ifded6890acd116a6dacb76ca2adccafccc1fb5f3
2024-08-19Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: Ie0b046b273f07376c8fa8282df26e68a055ad883
2024-08-15Allow toggling of final shareousel item Andrey Yepin
When no items selected the UI will: * change the chooser headline; * make the custom action row invisible; * make all targets disabled and all target icons greyscale. Fix: 349468879 Test: atest IntentResolver-tests-unit Test: manual functionality testing Flag: com.android.intentresolver.unselect_final_item Change-Id: I53b9c908943b1f1003cb0131a6dec8abc26ec782
2024-08-14Add timeout for AppPredictor response. Andrey Yepin
Timeout AppPredictor callbacks and fallback to ShortcutManager. Bug: 295956687 Bug: 343300158 Test: atest IntentResolver-tests-unit Flag: com.android.intentresolver.fix_shortcuts_flashing Change-Id: Ia6e5643451a840e10213f242c6c79364b0193e78
2024-08-14Fix direct share row flashing upon Shareousel selection change. Andrey Yepin
Upon payload selection change, copy direct share targets into the new adapters but keep the items disabled until the new set of shortcuts is loaded. To have all targets updated at once, publish the caller-provided targets together with the remaining direct shares. Fix: 343300158 Test: manual testing: using the ShareTest app, launch the Shareousel with a caller-provided targets and make the payload selection. Flag: com.android.intentresolver.fix_shortcuts_flashing Change-Id: Iff5ea6c892708daa9cca968a56a03aaaf80196f6
2024-08-14Merge "Per-profile caller-provided direct target collections" into main Treehugger Robot
2024-08-14Merge "Unify profile records and profile tabs creation." into main Andrey Yepin
2024-08-13Use nested scope for ShortcutLoader Andrey Yepin
Use a nested coroutine scope for each ShortcutLoader instance and close it when the instance is stopped being used. Fix: 358135601 Test: atest IntentResolver-tests-unit Test: manual testing checking the logs Flag: com.android.intentresolver.fix_shortcut_loader_job_leak Change-Id: I84bbca75612f153193b03e24bfc0cb8842a8d3e2
2024-08-12Per-profile caller-provided direct target collections Andrey Yepin
Instead of (partially) relying on the active profile value when deciding whether the caller-provided direct targets should be added to the list, define a list of caller-provided targets for each profile and use those lists unconditionally. Bug: 343300158 Test: manual tests: launche the ShareTest app from different profiles and confirm that the caller-provided targes are added only to the right profile (the profile the Chooser was launched from). Flag: EXEMPT refactoring Change-Id: I9c4ba35d48a090b21f96ddf4723f7b28654acb48
2024-08-12Unify profile records and profile tabs creation. Andrey Yepin
Create one ProfileRecord per profile tab. Utilize legacy profile tab logic to build an ordered map of ProfileRecords and generate profile tabs from these records. This change enforces 1:1 relation between profile records and tabs and highlights the exsiting dependency between them. Bug: 343300158 Test: manual testing with varius profile combinations available on the device Flag: EXEMPT refactoring Change-Id: I47bbbbdcc7832d6b881a272b0e489622c31de231
2024-08-12Merge "Don't send target selection callbacks crossprofile" into main Treehugger Robot
2024-08-12Merge "Update excluded components from payload selection callback" into main Treehugger Robot
2024-08-08Merge "Add a null check in decorateActionFactoryWithRefinement" into main Alan Chen
2024-08-08Add disabled state to chooser targets Andrey Yepin
The new functinality is not used yet as this is a preparation step. Allows chooser targets to be disabled: unclickable with grey-scale icons. Bug: 349468879 Test: presubmits Flag: EXEMPT refactoring Change-Id: I202a496954c08da27b7cc7c0f9df8d04d9916350
2024-08-05Update excluded components from payload selection callback Andrey Yepin
Bug: 352496527 Test: atest IntentResolver-tests-unit Test: manual testing using ShareTest app Flag: com.android.intentresolver.shareousel_update_exclude_components_extra Change-Id: I610edf2c11a5beb114185c8724347b0eb0487ef1
2024-08-05Don't send target selection callbacks crossprofile Joshua Trask
Test: existing + new unit case in ShareResultSenderImplTest Bug: 319671608 Flag: EXEMPT bugfix Change-Id: I9e6f3a531ee6b35cd62a67f33836fa02ce7e70cf
2024-07-30Merge "Do not crash when fail to read from the additional content cursor" ↵ Andrey Yepin
into main
2024-07-30Add a null check in decorateActionFactoryWithRefinement Alan Chen
Since originalFactory.getEditButtonRunnable is nullable, a check needs to be added to avoid an NPE. Bug: 353397828 Flag: EXEMPT bugfix Test: manual Change-Id: I9f028e30e7f6232fcd9c2cd3df423715c81e806b
2024-07-30Do not crash when fail to read from the additional content cursor Andrey Yepin
Bug: 354546194 Test: atest IntentResolver-tests-unit Flag: EXEMPT bugfix Change-Id: I5123fe6c1cabbbae7479d2cea8bd9e4b8ff0b4a8
2024-07-29Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: I93b7cf02f696dc798599944851e8c098bd638a86
2024-07-25Merge "Center initial item in Sharousel" into main Treehugger Robot
2024-07-25Center initial item in Sharousel Govinda Wasserman
As long as there are enough items in the row to center the initial item, it will be centered, otherwise it will be as close to center as the scroll bounds allow. Test: manual testing BUG: 341925364 Flag: android.service.chooser.chooser_payload_toggling Change-Id: Ifb96071ba70c3ba42f53d584ddfc31d4fc62cedf
2024-07-25Merge "Unified preview image loader." into main Treehugger Robot
2024-07-25Unified preview image loader. Andrey Epin
Replace ImagePreviewImageLoader and CachingPreviewImageLoader with the new class, PreviewImageLoader. Fix: 348665058 Fix: 343819590 Test: atest IntentResolver-tests-unit Test: atest IntentResolver-tests-activity Test: inject debugging logs for image requests, loadings, and cancellations and verify common scenarios. Flag: com.android.intentresolver.preview_image_loader Change-Id: Ib54ea0d538cd2cbaef6041f09eeb2b9eb6ada4cf
2024-07-24Merge "Import translations. DO NOT MERGE ANYWHERE" into main Bill Yi
2024-07-24Merge "Fix drawer offset calculation when rotating from a non-initial ↵ Andrey Yepin
profile" into main
2024-07-23Do not crash if max aspect ratio falls below min aspect ratio Andrey Yepin
The effective aspect ratio for the item will be in the range of [minOf(MIN_ASPECT_RATIO, maxAspectRatio), maxOf(MIN_ASPECT_RATIO, maxAspectRatio)] i.e. we always try to fit items into the view port even if the effective AR will be lower than the minimum AR. Bug: 351094699 Test: manual testing Flag: EXEMPT bugfix Change-Id: I6ae117ff816f47185caebc68c7fd3c670eacff33
2024-07-22Fix drawer offset calculation when rotating from a non-initial profile Andrey Yepin
Fix: 344057117 Test: manual testing Flag: com.android.intentresolver.fix_drawer_offset_on_config_change Change-Id: I0fb633b02299c0a4845bfa09bbbb234915ccb487
2024-07-22Import translations. DO NOT MERGE ANYWHERE Bill Yi
Auto-generated-cl: translation import Change-Id: I9a2c47097565f3ec77fdb6ba5e8e4d1594214d74
2024-07-16Merge "Request preview size, WIDTH and HEIGHT columns for additional ↵ Andrey Yepin
content" into main