| Age | Commit message (Collapse) | Author |
|---|
|
Fix: 379009353
Test: visual verification
Flag: EXEMPT bugfix
Change-Id: I0943da3328e779259d676364a4026a9e9615d626
|
|
Fix: 390704615
Test: visual check
Flag: EXEMPT resources only
Change-Id: I4e92e64bdfccfc8a7ff93cb040b2eb73073e7f92
|
|
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.
Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Ibf06926ca0489a5daed54dd234f3eb4dd557ada0
|
|
Increase profile buttons clickable area while preserving their
appearance.
Fix: 333992288
Test: use layout inspection tools to verify the new view sizes; visual
verification
Change-Id: I73c0b076503763482b4552a07668d13d113c7f43
|
|
Initial activity animation caused button animation to be unnoticeable.
Removing the button animation prevents buttons from "blinking" when the
payload selection has changed.
Bug: 325465291
Test: manual visual testing
Change-Id: I340b38b07a324c1423c259a795c14d713002ed61
|
|
Bug: 302691505
Flag: ACONFIG android.service.chooser.chooser_payload_toggling DEVELOPMENT
Test: N/A - code isn't live
Change-Id: Ibf197591b238a286b12290ccc33d69ab3efd56d8
|
|
Caused by ag/24642135: legacy code, effectively, did not set background
for the shortcut placeholder labels. Specifically, for a placeholder
TargetInfo with isPlaceholderTargetInfo() returning true, neither
isMultiDisplayResolveInfo() nor isPinned() returned true as well thus
the background drawable set for the label got immediately reset by the
following logic (and ag/24642135 removed this overriding logic).
This change removes the placeholder label background drawable and
related view size limitation.
Fix: 302391707
Test: manual testing -- simulate long shortcut loading (by a code
injection), observe no visual artifacts in the shortcuts row.
Change-Id: I86975407b729b488a0a5c924859bc218abc4444e
|
|
Fix: 298437830
Test: visual testing
Change-Id: Icdcd4317123998d2a86ed9ccb616cf9234fa2e68
|
|
Test: Visual testing in landscape and portrait (including with an
almost-white preview image)
Bug: 283245199
Change-Id: I5228946fa8639b73e562fad4d783e2ab4cd41554
|
|
- Remove divider above actions.
- Some color fixes.
- Actions are always horizontal, no attr needed.
- Lots of margin and padding tweaks per mocks.
- Fix horizontal recyclerview padding in RTL
Test: Lots of manual inspection with a variety of share payloads.
Test: atest IntentResolverUnitTests
Bug: 283245199
Change-Id: Ica2757a90387afd6be793b8c44fa47fd136056c7
|
|
Omitting edit action from landscape phones for now.
Bug: 283245199
Test: Manual test with ShareTest with varying combinations of text
length, title, icon, image shares.
Test: atest IntentResolverUnitTests
Change-Id: Iea40bd95db5665fb59684bf317bcac5e33b080bb
|
|
Test: Install and launch Share Test
Test: Choose Five Actions and tap Share
Test: Observe the action chips match design
Test: Rotate the device to landscape
Test: Observe the action chips match design
BUG: 283245199
Change-Id: If7969168b9d63d74484aabf6c5dee07745276e8c
|
|
- Make the image 46x46dp centerCrop.
- Center the file type overlay
- Modify the video icon drawable to align it to the center.
Bug: 281541996
Test: portrait and landscape shares with images, files and videos.
Change-Id: I9168d49506be74f73c39a6920e7d9071ec336d10
|
|
- Align colors with mocks.
- Increase custom action vertical padding
- Align text + image and file + text to the same 56x56 image size
- Reduce target vertical padding
- Don't disable text when share is "image only"
- Add an icon for single-file shares
- Update multi-file icon to align with mocks.
- Vertically align image in text+image
- Show image and title with text in landscape
- Reduce text preview padding to align with file+text padding.
Bug: 281541996
Test: build and test with ShareTest, Files and Photos.
Change-Id: Ia58315d765a824cb45ee1b84625c1262a8a3e76d
|
|
Moved to upper right, updated vector.
Bug: 280480573
Test: Visual verification
Change-Id: I708121f56a6544b2d40a4c70646e2abe8ec9475d
|
|
Mocks:
https://www.figma.com/file/PbCDWn695Eoy2r2fP5Ksrd/Screenshot-(U)?node-id=1641-12474&t=W7OrDXq41Tl7vcdM-0
Converted handle to a View to let accessibility scanner stop worrying
about the contrast.
Bug: 279068333
Bug: 274408139
Test: Visual verification
Change-Id: I642c04a4a5a9793c7b5d538e6afeca1ff8c122ba
|
|
To better align with text vertically.
Bug: 277936540
Test: Visual inspection
Change-Id: I223ade530fb41e7e13af1b772448f2434de76122
|
|
Slightly modified a preexisting asset to make the visual alignment work
properly. Small cleanups on the styling.
Bug: 276773348
Test: Visual evaluation with UX
Change-Id: I6e087c2b80c59aae3f9a5ee516b58bcb358a221b
|
|
Still more details to refine, but structurally this is closer.
- Merge text preview, title and icon into one space.
- Shaded background instead of border (using a themed color, though probably
not the right one yet, waiting on UX)
- Less padding around text preview area.
- Give title 1 line, text preview 3.
- No border around icon image.
- Move actions to the bottom of the preview.
Test: atest IntentResolverUnitTests
Bug: 273784361
Bug: 271158656
Change-Id: I6ee364fa699a252519ea51bce47792ebecece817
|
|
ChooserContentPreviewUi applies various heuristic to determine if each
shared URI has a preview and, if any, displays a scrollable preview
list. Each preview item in the list is badge accroding ot its type: no
badge for images, a video-file badge for videos and a generic-file badge
for all others. All URIs without a previwe are groupped under a single
item at list end (+N files).
Collateral changes:
* FileContentPreviewUi$FileInfo is moved into the package level;
* ChooserContentPreviewUi$ImageMimeTypeClassifier internface is moved
into the package level, renamted to MimeTypeClassifier and defines a
new method, isVideoType();
* ScrollableImagePreviewView is modified to support badges and the
"+N" item;
* A new class, UnfifiedContentPreviewUi is clonned from
ImageContentPreviewUi class, and is reponsible for drawing the new
unified preview ui, ImageContentPreviewUi is used only with the
legacy image content preview.
Bug: 271613784
Test: manual testing
Change-Id: Ia25f5a1565226ac679cc8ecefd58acb95cb60142
|
|
Test: Treehugger
Bug: 268682423
Change-Id: I4869e4d75ca56c74afc96813f2b2d6aa7a7b953c
|
|
This copies Chooser classes and (as needed) their transitive
dependencies, while making minor mechanical changes to fix up
references for the new package. This is a large CL, especially
since we don't track the history of these files across projects
(framework vs. "unbundled"), and the meaningful changes could
easily get lost in the noise; reviewers should see accompanying
notes at go/chooser-fork-cl.
Test: locally re-enabled and ran UnbundledChooserActivityTest
(as updated in this CL to match the framework version), then
re-disabled before uploading. See notes for more info.
Change-Id: I6708e3563d18a9e31894dd36dcd65e9a5815abcf
|