summaryrefslogtreecommitdiff
path: root/java
diff options
context:
space:
mode:
author Andrey Epin <ayepin@google.com> 2022-10-05 11:43:30 -0700
committer Andrey Epin <ayepin@google.com> 2022-10-11 14:10:25 -0700
commit93d10c4ef29b35aeee4cbbe01d2feda2dc8e6d67 (patch)
tree8bfb49249fe8d57168fdd1ef998748be10bc81c3 /java
parentc168f984875ff096720e0a2b092f14c601b5102f (diff)
Change ResolverActivity base class to FragmentActivity
Change ResolverActivity's base class to FragmentMnager to make lifecycle and view model related functionality available. Only a few Activity's methods used by either ResolverActivity or ChooserActivity are changed in the FragmentActivity hierarchy (except for lifecycle methods e.g. onCreate): - setContentView: adds support for view lifecycle; - setEnterSharedElemenCallabck: adds support for older SDK versions, no-op in our case; - getFragmentManager(): deprecated by FragmetnActivity, switched over to getSupportFragmentManager(). Test: manual general functinality test, pinning (ChooserTargetActionDialogFragment) Test: atest IntentResolverUnitTests Change-Id: If3b80c63facb9de04343409cf64db758700ec147
Diffstat (limited to 'java')
-rw-r--r--java/src/com/android/intentresolver/ChooserActivity.java6
-rw-r--r--java/src/com/android/intentresolver/ChooserTargetActionsDialogFragment.java2
-rw-r--r--java/src/com/android/intentresolver/IntentForwarderActivity.java3
-rw-r--r--java/src/com/android/intentresolver/ResolverActivity.java7
4 files changed, 5 insertions, 13 deletions
diff --git a/java/src/com/android/intentresolver/ChooserActivity.java b/java/src/com/android/intentresolver/ChooserActivity.java
index 36b32f6a..c4b7874c 100644
--- a/java/src/com/android/intentresolver/ChooserActivity.java
+++ b/java/src/com/android/intentresolver/ChooserActivity.java
@@ -38,7 +38,6 @@ import android.app.prediction.AppPredictor;
import android.app.prediction.AppTarget;
import android.app.prediction.AppTargetEvent;
import android.app.prediction.AppTargetId;
-import android.compat.annotation.UnsupportedAppUsage;
import android.content.ClipData;
import android.content.ClipboardManager;
import android.content.ComponentName;
@@ -164,7 +163,6 @@ public class ChooserActivity extends ResolverActivity implements
private AppPredictor mWorkAppPredictor;
private boolean mShouldDisplayLandscape;
- @UnsupportedAppUsage
public ChooserActivity() {
}
/**
@@ -1760,7 +1758,7 @@ public class ChooserActivity extends ResolverActivity implements
targetList);
fragment.setArguments(bundle);
- fragment.show(getFragmentManager(), TARGET_DETAILS_FRAGMENT_TAG);
+ fragment.show(getSupportFragmentManager(), TARGET_DETAILS_FRAGMENT_TAG);
}
private void modifyTargetIntent(Intent in) {
@@ -1826,7 +1824,7 @@ public class ChooserActivity extends ResolverActivity implements
b.putInt(ChooserStackedAppDialogFragment.WHICH_KEY, which);
f.setArguments(b);
- f.show(getFragmentManager(), TARGET_DETAILS_FRAGMENT_TAG);
+ f.show(getSupportFragmentManager(), TARGET_DETAILS_FRAGMENT_TAG);
return;
}
}
diff --git a/java/src/com/android/intentresolver/ChooserTargetActionsDialogFragment.java b/java/src/com/android/intentresolver/ChooserTargetActionsDialogFragment.java
index b4a102ae..61b54fa9 100644
--- a/java/src/com/android/intentresolver/ChooserTargetActionsDialogFragment.java
+++ b/java/src/com/android/intentresolver/ChooserTargetActionsDialogFragment.java
@@ -27,7 +27,6 @@ import android.annotation.NonNull;
import android.annotation.Nullable;
import android.app.ActivityManager;
import android.app.Dialog;
-import android.app.DialogFragment;
import android.content.ComponentName;
import android.content.Context;
import android.content.DialogInterface;
@@ -49,6 +48,7 @@ import android.view.ViewGroup;
import android.widget.ImageView;
import android.widget.TextView;
+import androidx.fragment.app.DialogFragment;
import androidx.recyclerview.widget.RecyclerView;
import com.android.intentresolver.chooser.DisplayResolveInfo;
diff --git a/java/src/com/android/intentresolver/IntentForwarderActivity.java b/java/src/com/android/intentresolver/IntentForwarderActivity.java
index 9b853c95..78240250 100644
--- a/java/src/com/android/intentresolver/IntentForwarderActivity.java
+++ b/java/src/com/android/intentresolver/IntentForwarderActivity.java
@@ -28,7 +28,6 @@ import android.app.Activity;
import android.app.ActivityThread;
import android.app.AppGlobals;
import android.app.admin.DevicePolicyManager;
-import android.compat.annotation.UnsupportedAppUsage;
import android.content.ComponentName;
import android.content.ContentResolver;
import android.content.Intent;
@@ -38,7 +37,6 @@ import android.content.pm.PackageManager;
import android.content.pm.ResolveInfo;
import android.content.pm.UserInfo;
import android.metrics.LogMaker;
-import android.os.Build;
import android.os.Bundle;
import android.os.RemoteException;
import android.os.UserHandle;
@@ -65,7 +63,6 @@ import java.util.concurrent.Executors;
* be passed in and out of a managed profile.
*/
public class IntentForwarderActivity extends Activity {
- @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.R, trackingBug = 170729553)
public static String TAG = "IntentForwarderActivity";
public static String FORWARD_INTENT_TO_PARENT
diff --git a/java/src/com/android/intentresolver/ResolverActivity.java b/java/src/com/android/intentresolver/ResolverActivity.java
index ea140dcb..0733f4fa 100644
--- a/java/src/com/android/intentresolver/ResolverActivity.java
+++ b/java/src/com/android/intentresolver/ResolverActivity.java
@@ -39,7 +39,6 @@ import android.app.VoiceInteractor.PickOptionRequest.Option;
import android.app.VoiceInteractor.Prompt;
import android.app.admin.DevicePolicyEventLogger;
import android.app.admin.DevicePolicyManager;
-import android.compat.annotation.UnsupportedAppUsage;
import android.content.BroadcastReceiver;
import android.content.ComponentName;
import android.content.Context;
@@ -91,6 +90,7 @@ import android.widget.TabWidget;
import android.widget.TextView;
import android.widget.Toast;
+import androidx.fragment.app.FragmentActivity;
import androidx.viewpager.widget.ViewPager;
import com.android.intentresolver.AbstractMultiProfilePagerAdapter.Profile;
@@ -117,10 +117,9 @@ import java.util.Set;
* which to go to. It is not normally used directly by application developers.
*/
@UiThread
-public class ResolverActivity extends Activity implements
+public class ResolverActivity extends FragmentActivity implements
ResolverListAdapter.ResolverListCommunicator {
- @UnsupportedAppUsage
public ResolverActivity() {
mIsIntentPicker = getClass().equals(ResolverActivity.class);
}
@@ -150,7 +149,6 @@ public class ResolverActivity extends Activity implements
@VisibleForTesting
protected boolean mSupportsAlwaysUseOption;
protected ResolverDrawerLayout mResolverDrawerLayout;
- @UnsupportedAppUsage
protected PackageManager mPm;
protected int mLaunchedFromUid;
@@ -361,7 +359,6 @@ public class ResolverActivity extends Activity implements
* Compatibility version for other bundled services that use this overload without
* a default title resource
*/
- @UnsupportedAppUsage
protected void onCreate(Bundle savedInstanceState, Intent intent,
CharSequence title, Intent[] initialIntents,
List<ResolveInfo> rList, boolean supportsAlwaysUseOption) {