summaryrefslogtreecommitdiff
path: root/java/tests/src
diff options
context:
space:
mode:
author Matt Casey <mrcasey@google.com> 2023-02-22 21:20:25 +0000
committer Matt Casey <mrcasey@google.com> 2023-02-22 21:22:46 +0000
commit84dda853d3ad5769c928ed95f77bcb694fb0d622 (patch)
treec9028dc6e21bc546f4a03dcb4f430b2c4dea1ed9 /java/tests/src
parent34f394c25d429e668d519c01a6936f91296f37ba (diff)
Log number of custom actions and presence of modify share action
Also remove an unused logging parameter. Clarify nullability of custom actions list (should migrate this to kotlin sometime). Bug: 265504112 Test: atest ChooserActivityLoggerTest Change-Id: If3f224ef16755a9a3a2c625d63e2fc35888fa37a
Diffstat (limited to 'java/tests/src')
-rw-r--r--java/tests/src/com/android/intentresolver/ChooserActivityLoggerTest.java12
1 files changed, 7 insertions, 5 deletions
diff --git a/java/tests/src/com/android/intentresolver/ChooserActivityLoggerTest.java b/java/tests/src/com/android/intentresolver/ChooserActivityLoggerTest.java
index d8868fc1..7d1b2488 100644
--- a/java/tests/src/com/android/intentresolver/ChooserActivityLoggerTest.java
+++ b/java/tests/src/com/android/intentresolver/ChooserActivityLoggerTest.java
@@ -112,7 +112,6 @@ public final class ChooserActivityLoggerTest {
@Test
public void testLogShareStarted() {
- final int eventId = -1; // Passed-in eventId is unused. TODO: remove from method signature.
final String packageName = "com.test.foo";
final String mimeType = "text/plain";
final int appProvidedDirectTargets = 123;
@@ -120,16 +119,19 @@ public final class ChooserActivityLoggerTest {
final boolean workProfile = true;
final int previewType = ChooserContentPreviewUi.CONTENT_PREVIEW_FILE;
final String intentAction = Intent.ACTION_SENDTO;
+ final int numCustomActions = 3;
+ final boolean modifyShareProvided = true;
mChooserLogger.logShareStarted(
- eventId,
packageName,
mimeType,
appProvidedDirectTargets,
appProvidedAppTargets,
workProfile,
previewType,
- intentAction);
+ intentAction,
+ numCustomActions,
+ modifyShareProvided);
verify(mFrameworkLog).write(
eq(FrameworkStatsLog.SHARESHEET_STARTED),
@@ -142,8 +144,8 @@ public final class ChooserActivityLoggerTest {
eq(workProfile),
eq(FrameworkStatsLog.SHARESHEET_STARTED__PREVIEW_TYPE__CONTENT_PREVIEW_FILE),
eq(FrameworkStatsLog.SHARESHEET_STARTED__INTENT_TYPE__INTENT_ACTION_SENDTO),
- /* custom actions provided */ eq(0),
- /* reselection action provided */ eq(false));
+ /* custom actions provided */ eq(numCustomActions),
+ /* reselection action provided */ eq(modifyShareProvided));
}
@Test