summaryrefslogtreecommitdiff
path: root/java/src
diff options
context:
space:
mode:
author 1 <mrcasey@google.com> 2023-04-04 19:58:31 +0000
committer 1 <mrcasey@google.com> 2023-04-04 20:01:13 +0000
commit0a8bcadca1a463d8854e944fbb6cc96c08828bf6 (patch)
tree867df87f3bb3e9149aff5de628f4618ffe396f75 /java/src
parent7a9decf0189c8674d2580cc9a117eebfeee0a9d2 (diff)
Remove flag SHARESHEET_RESELECTION_ACTION
Bug: 266982749 Test: Build and run with modify share. Change-Id: Id36a84c82e05c9fc946543c3eaa1271f786a5068
Diffstat (limited to 'java/src')
-rw-r--r--java/src/com/android/intentresolver/ChooserActionFactory.java5
-rw-r--r--java/src/com/android/intentresolver/ChooserRequestParameters.java5
-rw-r--r--java/src/com/android/intentresolver/contentpreview/ContentPreviewUi.java8
-rw-r--r--java/src/com/android/intentresolver/contentpreview/FileContentPreviewUi.java2
-rw-r--r--java/src/com/android/intentresolver/contentpreview/ImageContentPreviewUi.java2
-rw-r--r--java/src/com/android/intentresolver/contentpreview/TextContentPreviewUi.java2
-rw-r--r--java/src/com/android/intentresolver/contentpreview/UnifiedContentPreviewUi.java2
-rw-r--r--java/src/com/android/intentresolver/flags/Flags.kt5
8 files changed, 8 insertions, 23 deletions
diff --git a/java/src/com/android/intentresolver/ChooserActionFactory.java b/java/src/com/android/intentresolver/ChooserActionFactory.java
index d0e6e53f..8dafae86 100644
--- a/java/src/com/android/intentresolver/ChooserActionFactory.java
+++ b/java/src/com/android/intentresolver/ChooserActionFactory.java
@@ -41,7 +41,6 @@ import com.android.intentresolver.chooser.DisplayResolveInfo;
import com.android.intentresolver.chooser.TargetInfo;
import com.android.intentresolver.contentpreview.ChooserContentPreviewUi;
import com.android.intentresolver.flags.FeatureFlagRepository;
-import com.android.intentresolver.flags.Flags;
import com.android.intentresolver.widget.ActionRow;
import com.android.internal.annotations.VisibleForTesting;
@@ -161,9 +160,7 @@ public final class ChooserActionFactory implements ChooserContentPreviewUi.Actio
finishCallback,
logger),
chooserRequest.getChooserActions(),
- (featureFlagRepository.isEnabled(Flags.SHARESHEET_RESELECTION_ACTION)
- ? chooserRequest.getModifyShareAction()
- : null),
+ chooserRequest.getModifyShareAction(),
onUpdateSharedTextIsExcluded,
logger,
finishCallback);
diff --git a/java/src/com/android/intentresolver/ChooserRequestParameters.java b/java/src/com/android/intentresolver/ChooserRequestParameters.java
index d11561df..f9004a9b 100644
--- a/java/src/com/android/intentresolver/ChooserRequestParameters.java
+++ b/java/src/com/android/intentresolver/ChooserRequestParameters.java
@@ -33,7 +33,6 @@ import android.util.Log;
import android.util.Pair;
import com.android.intentresolver.flags.FeatureFlagRepository;
-import com.android.intentresolver.flags.Flags;
import com.google.common.collect.ImmutableList;
@@ -147,9 +146,7 @@ public class ChooserRequestParameters {
mTargetIntentFilter = getTargetIntentFilter(mTarget);
mChooserActions = getChooserActions(clientIntent);
- mModifyShareAction = featureFlags.isEnabled(Flags.SHARESHEET_RESELECTION_ACTION)
- ? getModifyShareAction(clientIntent)
- : null;
+ mModifyShareAction = getModifyShareAction(clientIntent);
}
public Intent getTargetIntent() {
diff --git a/java/src/com/android/intentresolver/contentpreview/ContentPreviewUi.java b/java/src/com/android/intentresolver/contentpreview/ContentPreviewUi.java
index 05d0ee66..15ba96c0 100644
--- a/java/src/com/android/intentresolver/contentpreview/ContentPreviewUi.java
+++ b/java/src/com/android/intentresolver/contentpreview/ContentPreviewUi.java
@@ -37,8 +37,6 @@ import android.widget.TextView;
import androidx.annotation.LayoutRes;
import com.android.intentresolver.R;
-import com.android.intentresolver.flags.FeatureFlagRepository;
-import com.android.intentresolver.flags.Flags;
import com.android.intentresolver.widget.ActionRow;
import java.util.ArrayList;
@@ -129,11 +127,9 @@ abstract class ContentPreviewUi {
protected static void displayModifyShareAction(
ViewGroup layout,
- ChooserContentPreviewUi.ActionFactory actionFactory,
- FeatureFlagRepository featureFlagRepository) {
+ ChooserContentPreviewUi.ActionFactory actionFactory) {
ActionRow.Action modifyShareAction = actionFactory.getModifyShareAction();
- if (modifyShareAction != null && layout != null
- && featureFlagRepository.isEnabled(Flags.SHARESHEET_RESELECTION_ACTION)) {
+ if (modifyShareAction != null && layout != null) {
TextView modifyShareView = layout.findViewById(R.id.reselection_action);
if (modifyShareView != null) {
modifyShareView.setText(modifyShareAction.getLabel());
diff --git a/java/src/com/android/intentresolver/contentpreview/FileContentPreviewUi.java b/java/src/com/android/intentresolver/contentpreview/FileContentPreviewUi.java
index cc087a63..e65538ae 100644
--- a/java/src/com/android/intentresolver/contentpreview/FileContentPreviewUi.java
+++ b/java/src/com/android/intentresolver/contentpreview/FileContentPreviewUi.java
@@ -68,7 +68,7 @@ class FileContentPreviewUi extends ContentPreviewUi {
@Override
public ViewGroup display(Resources resources, LayoutInflater layoutInflater, ViewGroup parent) {
ViewGroup layout = displayInternal(resources, layoutInflater, parent);
- displayModifyShareAction(layout, mActionFactory, mFeatureFlagRepository);
+ displayModifyShareAction(layout, mActionFactory);
return layout;
}
diff --git a/java/src/com/android/intentresolver/contentpreview/ImageContentPreviewUi.java b/java/src/com/android/intentresolver/contentpreview/ImageContentPreviewUi.java
index 1ca2ba61..cf7c5525 100644
--- a/java/src/com/android/intentresolver/contentpreview/ImageContentPreviewUi.java
+++ b/java/src/com/android/intentresolver/contentpreview/ImageContentPreviewUi.java
@@ -83,7 +83,7 @@ class ImageContentPreviewUi extends ContentPreviewUi {
@Override
public ViewGroup display(Resources resources, LayoutInflater layoutInflater, ViewGroup parent) {
ViewGroup layout = displayInternal(layoutInflater, parent);
- displayModifyShareAction(layout, mActionFactory, mFeatureFlagRepository);
+ displayModifyShareAction(layout, mActionFactory);
return layout;
}
diff --git a/java/src/com/android/intentresolver/contentpreview/TextContentPreviewUi.java b/java/src/com/android/intentresolver/contentpreview/TextContentPreviewUi.java
index 8a3c2259..6b5676cc 100644
--- a/java/src/com/android/intentresolver/contentpreview/TextContentPreviewUi.java
+++ b/java/src/com/android/intentresolver/contentpreview/TextContentPreviewUi.java
@@ -73,7 +73,7 @@ class TextContentPreviewUi extends ContentPreviewUi {
@Override
public ViewGroup display(Resources resources, LayoutInflater layoutInflater, ViewGroup parent) {
ViewGroup layout = displayInternal(layoutInflater, parent);
- displayModifyShareAction(layout, mActionFactory, mFeatureFlagRepository);
+ displayModifyShareAction(layout, mActionFactory);
return layout;
}
diff --git a/java/src/com/android/intentresolver/contentpreview/UnifiedContentPreviewUi.java b/java/src/com/android/intentresolver/contentpreview/UnifiedContentPreviewUi.java
index dfc171d2..55e8058b 100644
--- a/java/src/com/android/intentresolver/contentpreview/UnifiedContentPreviewUi.java
+++ b/java/src/com/android/intentresolver/contentpreview/UnifiedContentPreviewUi.java
@@ -89,7 +89,7 @@ class UnifiedContentPreviewUi extends ContentPreviewUi {
@Override
public ViewGroup display(Resources resources, LayoutInflater layoutInflater, ViewGroup parent) {
ViewGroup layout = displayInternal(layoutInflater, parent);
- displayModifyShareAction(layout, mActionFactory, mFeatureFlagRepository);
+ displayModifyShareAction(layout, mActionFactory);
return layout;
}
diff --git a/java/src/com/android/intentresolver/flags/Flags.kt b/java/src/com/android/intentresolver/flags/Flags.kt
index 846f8e64..2b3da725 100644
--- a/java/src/com/android/intentresolver/flags/Flags.kt
+++ b/java/src/com/android/intentresolver/flags/Flags.kt
@@ -22,14 +22,9 @@ import com.android.systemui.flags.UnreleasedFlag
// Flag id, name and namespace should be kept in sync with [com.android.systemui.flags.Flags] to
// make the flags available in the flag flipper app (see go/sysui-flags).
object Flags {
- const val SHARESHEET_RESELECTION_ACTION_NAME = "sharesheet_reselection_action"
const val SHARESHEET_IMAGE_AND_TEXT_PREVIEW_NAME = "sharesheet_image_text_preview"
const val SHARESHEET_SCROLLABLE_IMAGE_PREVIEW_NAME = "sharesheet_scrollable_image_preview"
- // TODO(b/266982749) Tracking Bug
- @JvmField
- val SHARESHEET_RESELECTION_ACTION = releasedFlag(1502, SHARESHEET_RESELECTION_ACTION_NAME)
-
// TODO(b/266983474) Tracking Bug
@JvmField
val SHARESHEET_IMAGE_AND_TEXT_PREVIEW = releasedFlag(