summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author 1 <mrcasey@google.com> 2023-04-27 15:07:41 +0000
committer 1 <mrcasey@google.com> 2023-04-27 15:07:41 +0000
commita4cac30930d70d3694e880d31ab48ff03d3bb82a (patch)
treea86ddd39dca171afce8da07ae72cdb9139dbb436
parentf1107ce7b0771006130ac9fc49944f69d9594076 (diff)
Limit the width of the modify share action.
Also limit the text toggle to match. Bug: 279694425 Test: Manual test on phone and tablet injecting some long strings for all the relevant fields. Change-Id: I51fa108a30a2f1f85c151e036bbff863c0755e88
-rw-r--r--java/res/layout/chooser_headline_row.xml4
-rw-r--r--java/res/values-sw600dp/dimens.xml1
-rw-r--r--java/res/values/dimens.xml1
3 files changed, 6 insertions, 0 deletions
diff --git a/java/res/layout/chooser_headline_row.xml b/java/res/layout/chooser_headline_row.xml
index 997887d1..5074d5bc 100644
--- a/java/res/layout/chooser_headline_row.xml
+++ b/java/res/layout/chooser_headline_row.xml
@@ -49,7 +49,10 @@
android:id="@+id/reselection_action"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:maxWidth="@dimen/modify_share_text_toggle_max_width"
app:layout_constraintEnd_toEndOf="parent"
+ android:maxLines="2"
+ android:ellipsize="end"
android:visibility="gone"
android:paddingTop="3dp"
android:paddingBottom="16dp"
@@ -63,6 +66,7 @@
android:id="@+id/include_text_action"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
+ android:maxWidth="@dimen/modify_share_text_toggle_max_width"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toBottomOf="@id/reselection_action"
android:layout_alignWithParentIfMissing="true"
diff --git a/java/res/values-sw600dp/dimens.xml b/java/res/values-sw600dp/dimens.xml
index fc8ac066..240ee067 100644
--- a/java/res/values-sw600dp/dimens.xml
+++ b/java/res/values-sw600dp/dimens.xml
@@ -19,4 +19,5 @@
-->
<resources>
<dimen name="chooser_width">624dp</dimen>
+ <dimen name="modify_share_text_toggle_max_width">250dp</dimen>
</resources>
diff --git a/java/res/values/dimens.xml b/java/res/values/dimens.xml
index e0a3b2c6..596b3fef 100644
--- a/java/res/values/dimens.xml
+++ b/java/res/values/dimens.xml
@@ -52,6 +52,7 @@
<dimen name="chooser_preview_image_height_tall">192dp</dimen>
<dimen name="chooser_action_view_icon_size">22dp</dimen>
<dimen name="chooser_action_margin">0dp</dimen>
+ <dimen name="modify_share_text_toggle_max_width">150dp</dimen>
<!-- Note that the values in this section are for landscape phones. For screen configs taller
than 480dp, the values are set in values-h480dp/dimens.xml -->