summaryrefslogtreecommitdiff
path: root/tools
AgeCommit message (Collapse)Author
2025-03-18OWNER freeze window William Escande
Bug: 381884217 Flag: EXEMPT only changing OWNERS Test: m . Change-Id: I9c8322fca831c81a158bac4765f79db00ddb061b
2025-02-28Cleanup python version properties Cole Faust
Now that python 2 is fully removed, there's no need for version-specific properties. Remove them. Also remove usages of embedded_launcher: true, as that is the new default value. Bug: 399954452 Test: Presubmits Change-Id: I2ceacd6e62f611df72956373bc014717bb6d003e
2025-02-14RootCanal: Deprecate the beacon_swarm device Henri Chataing
Bug: 331817295 Test: m root-canal Flag: EXEMPT, tool change Change-Id: Id38b79278d6b14c6a607f9e6531869f0384584f7
2025-02-14RootCanal: Remove ScriptedBeacon from the device boutique Henri Chataing
ScriptedBeacon is still being used indirectly in the HAL implementation android.hardware.bluetooth@1.1-service.sim by internal chromecast/nearby tests but never in the root-canal binary. Bug: 331817295 Test: m root-canal Test: m android.hardware.bluetooth@1.1-service.sim Flag: EXEMPT, tool change Change-Id: I9124eb7dcecbb0e7580be6cde25f410627c26b46
2025-01-30Merge "Add platform_testing to rootcanal visibility" into main Zi Wang
2025-01-29Add platform_testing to rootcanal visibility mrziwang
root-canal is a dependency of platform_tests, which is going to converted to fully soong-built. Test: m nothing and CI Bug: 388850000 Change-Id: I523d0b121885d2b01dbf61412cbcb85a252444e6
2025-01-28Merge changes I258a2a3e,Ibfacbc9d into main Treehugger Robot
* changes: RootCanal: Update controller_info.py script RootCanal: Add INTEL_BE200 controller preset
2025-01-28RootCanal: Update controller_info.py script Henri Chataing
Bug: 372977055 Test: manual invocation Flag: EXEMPT, tool change Change-Id: I258a2a3eabfe2704a26559e26971f0915d5d1461
2025-01-28RootCanal: Add INTEL_BE200 controller preset Henri Chataing
Bug: 372977055 Test: m root-canal Flag: EXEMPT, tool change Change-Id: Ibfacbc9dcf52c0c98a1572510e0637bef84a16e2
2025-01-17Merge "Revert "RootCanal: Migrate from {fmt} to std::format"" into main Treehugger Robot
2025-01-17Revert "RootCanal: Migrate from {fmt} to std::format" Shuo Wang Hsu
This reverts commit 24658260758abbea64dab58331bf3cfbaaf9c989. Reason for revert: Breaking netsim-dev builds. Bug: 390672541 Change-Id: Ic99b47195ee9979715d47f04c85b174acb4929a4
2025-01-17Merge "RootCanal: Migrate from {fmt} to std::format" into main Henri Chataing
2025-01-17Merge "Resolve compilation error in ↵ Treehugger Robot
android.hardware.bluetooth@1.1-service.sim" into main
2025-01-16RootCanal: Migrate from {fmt} to std::format Henri Chataing
Bug: 378773651 Test: m root-canal Change-Id: I9bd3ed6e875c43ada35d6c77915f98fe4a885e6d
2025-01-16Resolve compilation error in android.hardware.bluetooth@1.1-service.sim Henri Chataing
system/core/libutils/include/utils/StrongPointer.h:287:14: error: member access into incomplete type 'android::hardware::bluetooth::V1_1::sim::BluetoothDeathRecipient' 287 | m_ptr->decStrong(this); | ^ ...odules/Bluetooth/tools/rootcanal/hal/bluetooth_hci.h:47:7: note: in instantiation of member function 'android::sp<android::hardware::bluetooth::V1_1::sim::BluetoothDeathRecipient>::~sp' requested here 47 | class BluetoothHci : public IBluetoothHci { | ^ packages/modules/Bluetooth/tools/rootcanal/hal/bluetooth_hci.h:37:7: note: forward declaration of 'android::hardware::bluetooth::V1_1::sim::BluetoothDeathRecipient' 37 | class BluetoothDeathRecipient; | ^ Bug: 331817295 Test: m android.hardware.bluetooth@1.1-service.sim Flag: EXEMPT, tool change Change-Id: I457340ed0edd22f3253d74ded3b28ca567263959
2025-01-15Code changes for Rust 1.83.0 Chris Wailes
Test: m rust Bug: 384401387 Change-Id: I647a63976830e5071cb4dac8c0480a00ecf4d973
2024-12-27Revert^2 "OWNER remove freeze window" William Escande
This reverts commit a6f7fa1da0e5ca8b6a0f1734bfa089d542f2afba. Reason for revert: Prebuilt as landed Change-Id: I40a2bd6b29b924f51f9823381485f3adcf249b42
2024-12-20Revert "OWNER remove freeze window" Thomas Girardier
This reverts commit 5616c5a9624baea932bd552ecedd772ceaf9068b. Reason for revert: Freezing Bluetooth during holiday period and transition to Mainline since it is now built from source. Change-Id: I56fe54154296ef1bcee7e92f77a462036ef8008b
2024-12-06OWNER remove freeze window William Escande
This reverts aosp/3387082 Bug: 381884217 Flag: EXEMPT only changing OWNERS Test: m . Change-Id: I716f0283525750a6fc7cfe85251c1c1b8632f9e6
2024-12-02OWNER freeze window William Escande
Bug: 381884217 Flag: EXEMPT only changing OWNERS Test: m . Change-Id: Iff8ed28793141c2463d2c8a251ff454fc25c448e
2024-11-25RootCanal: Update build.rs to directly use the pdl_compiler library Henri Chataing
Bug: 279665786 Test: cargo -C tools/rootcanal/rust build Test: m rootcanal Flag: EXEMPT build change Change-Id: I20ae4a4678b457cf6a1614ddcf5c56342bea0311
2024-11-07RootCanal: Update to Core version 6.0 Henri Chataing
Bug: 339671227 Test: atest --host rootcanal_ll_test Flag: EXEMPT, tool change Change-Id: I5457dd63777ab9a2ca6bee6f69d3343ff86a4ec7
2024-10-23RootCanal: Add Authenticated Payload Timeout Expired event Archie Pusaka
This already exists on system/pdl/hci/hci_packets.pdl. Bug: 289858128 Test: m -j Flag: EXEMPT, tooling change Change-Id: Iaeb06fa41714743c2e65f2efd632cfd5646c91ca
2024-10-14RootCanal: Implement the command LE Read Local P-256 Public Key Henri Chataing
Bug: 354107188 Test: atest --host rootcanal_ll_test Flag: EXEMPT, tool change Change-Id: Ic7342ecd7d1de46dadf88c7d2d71c925f97f3904
2024-10-11Replace fmt::throw_format_error with fmt::report_error Henri Chataing
fmt::throw_format_error is deprecated in favor of fmt::report_error. The behaviour is exactly the same. Bug: 331817295 Test: m com.android.btservices Flag: EXEMPT, no logical change Change-Id: I6f98eca50e77fbedf9d4284590600f3a07384dc7
2024-09-18Actualize owners file William Escande
Bug: 311772251 Test: m . Flag: Exempt OWNERS Change-Id: I060a14ce43035cadc618d0a9217078731cb8ff44
2024-09-11Encryption Change V2 Jakub Pawlowski
Bug: 365846652 Bug: 366018699 Test: mma -j32 Flag: encryption_change_v2 Change-Id: I387b0df153e7dcf7d02a460e182ef12523509a42
2024-08-21RootCanal: Set the default value of acl_data_packet_length to 1023 Henri Chataing
BlueZ sets HCI_MAX_FRAME_SIZE to 1028 (1024 + 4) for the user socket. In practice the length check counts the IDC towards the packet length and the actual limit is 1023 bytes for the ACL payload. Bug: 326997427 Bug: 356867879 Test: m com.android.btservices Flag: EXEMPT, tool change Change-Id: If197a39864a5eda27131aa2f7c58e706ecc4e9dd
2024-08-12Remove unnecessary std::move Yi Kong
Moving a temporary object prevents copy elision, and could reduce performance. This fixes -Wpessimizing-move compiler warning. Test: presubmit Test: m droid Bug: 154270751 Change-Id: I1dc582a755787f16b8bbe10e01c1f6726137b8cf
2024-07-18Remove obsolete owner William Escande
also added myself into tools for the ktfmt & lint Test: None Flag: Exempt owner only Bug: 311772251 Change-Id: If48e75f1b20ca1c519b797a50618ccad527feb97
2024-07-17Update ktfmt to use JDK 21 Sorin Basca
Bug: 342332820 Change-Id: Icaca59872c560b7dc4f1c59ad2b45306902b52d2 Test: TH
2024-07-07Format: apply clang rules William Escande
Restore SpacesBeforeTrailingComments to 2 to match current style Then run clang-format -i **/**.{c,h,cc,cpp,hpp} Then fix a bunch of typo (reported by gerrit) Then fix unnecessary multiline string Then fix whitespace for disabled clang format (reported by cpplint) This is no-op Bug: 311772251 Test: mmm packages/modules/Bluetooth Flag: Exempt Format only Change-Id: If135447803a40a2a07d4630ba2195e08ef8d250c
2024-06-20RootCanal: Reset APCF scanner in LinkLayerController::Reset() Henri Chataing
Change-Id: Ic31628760063e72da4d6436d2020f3084249c2ec Test: m root-canal Flag: EXEMPT, tool change Bug: 331817295
2024-06-12libc++fs is part of libc++ now. Elliott Hughes
Bug: janitorial cleanup Test: treehugger Change-Id: Ie4805bebc3b10612dd94d831c16e61c58f0ea73d
2024-06-11RootCanal: Update cmake pdl_gen definition to support rust_legacy / rust output Henri Chataing
Bug: 331817295 Test: TreeHugger Flag: EXEMPT, build change Change-Id: Ia19cea9daf774f83c4e57c73072a32ba1a4af37a
2024-06-07RootCanal: Typo in LE Apcf Transport Discovery Data command handling Henri Chataing
Bug: 345704960 Test: m root-canal Flag: EXEMPT, tool change Change-Id: I2a2a628a3f8b41e868d6396a04c851d3d5093ee7
2024-06-03Update to pdl 0.3.0 David Duarte
Bug: 343968814 Test: m root-canal Flag: TEST_ONLY Change-Id: Ie16817255a3960dd8cc4976b078f52feaaded21b
2024-05-22RootCanal: Send well formatted Apcf command complete event Henri Chataing
The android stack panics if the LE Apcf Transport Discovery Service command complete event is shortened, even with an error status code Bug: 336513624 Test: m root-canal Flag: EXEMPT, tool change Change-Id: I3a0e7c954ba21d4f89b7dbd7e0b8fa7ae613e337
2024-05-14Remove trendy team William Escande
Bluetooth tree does not support trendy team assignment Test: None Bug: 311772251 Flag: not applicable Change-Id: Ia96e43927ab2cacabcf8de2c33ff936d8ee31029
2024-05-13RootCanal: Do not report an invalid packet for unsupported LE Apcf Transport ↵ Henri Chataing
Discovert Service command The host stack is invoking this command even though the Apcf extended features disables support for it. Bug: 336513624 Test: m root-canal Flag: EXEMPT tool change Change-Id: Ic08b9a8de6550d87add838549125add076159063
2024-05-10Update source for Rust 1.78.0 Chris Wailes
Test: m rust Bug: 333887339 Flag: EXEMPT, toolchain update - no logical change Change-Id: I04304e422d042be02408382532b00b8c857f8c3c
2024-04-25rootcanal/ec: Use pow for consistency David Duarte
Also remove some unneeded references Bug: 335192676 Test: cargo test lmp::ec Flag: EXEMPT, rootcanal Change-Id: I88b040a9c6950dfc88370159ecbc58c2f2380be3
2024-04-25Merge "rootcanal/ec: Use Jacobian Coordinates in Point implementation" into main David Duarte
2024-04-24rootcanal/ec: Use Jacobian Coordinates in Point implementation David Duarte
This allows to speed up multiplication as we don't need to do an expensive mod_inv for each addition but only once when we convert back to affine coordinates. Before: In debug: running 2 tests test lmp::ec::tests::p256 ... ok test lmp::ec::tests::p192 ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 37 filtered out; finished in 2.32s In release: running 2 tests test lmp::ec::tests::p256 ... ok test lmp::ec::tests::p192 ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 37 filtered out; finished in 0.36s After: In debug: running 2 tests test lmp::ec::tests::p256 ... ok test lmp::ec::tests::p192 ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 37 filtered out; finished in 0.30s In release: running 2 tests test lmp::ec::tests::p256 ... ok test lmp::ec::tests::p192 ... ok test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 37 filtered out; finished in 0.04s Resulting in a 6x improvement in debug and 7.5x in release Bug: 335192676 Test: cargo test lmp::ec Flag: EXEMPT, rootcanal Change-Id: I09f8cfd02515f308dcb7f81e75cfafbf7bc50a5a
2024-04-24Merge "RootCanal: Set support for APCF Transport Discovery Service filter to ↵ Treehugger Robot
false" into main
2024-04-23RootCanal: Set support for APCF Transport Discovery Service filter to false Henri Chataing
This bit flag is used to indicate support for the LE APCF Transport Discovery Service command, which RootCanal does not implement Bug: 279665786 Bug: 336513624 Test: m root-canal Flag: EXEMPT tool change Change-Id: I2f527882a2923f29213b7501d4d3c271d797089a
2024-04-08Update owners files William Escande
Bug: 311772251 Test: m . | not needed on owners files Flag: Exempt, OWNERS are not flagged Change-Id: I2d36ba69b797f071e25132a177ff8259cd79204a
2024-04-01Prevent variables with type java.lang.Boolean Sal Savage
Bug: 315046089 Flag: EXEMPT, tooling change Test: atest BluetoothLintCheckerTest --host Change-Id: Ib62b659ed9011d21f5e5b3550aa3761ef99365c8
2024-04-01Create an Android Lint rule to find guarded log invocations Sal Savage
The Bluetooth stack sets a process default log level, which allows the Android Log framework to properly enforce wheth a log invocation fires based on the set log level for the tag. You do not need to guard individual log invocations anymore. This lint rule looks for log lines inside conditionals (if, else if, or even else), where the conditionals use variables that appear to be log enforcement variables as part of their logic. Errors are generated for those usages. Because this is mostly name based, this is very much best effort, and will have to be updated as patterns in the stack evolve. This was able to find all the violations in the stack that existed before our refactor though. Usages of Log.isLoggable() in conditionals are reduced to warnings, as there are a few valid usages to prevent expensive log operations in code. In general, we expect these usages to be minimal and hope developers will consider altering log statements to avoid usages. Run this lint rule together with others using `m Bluetooth-lint`. Results are available in txt/xml/html format in the build output artifacts. See the README for more details. Tag: #feature Bug: 315046089 Flag: EXEMPT, tooling change Test: atest BluetoothLintCheckerTest --host Change-Id: I175f908f97567ed6638af6026f4caf83acd57e60
2024-03-28Merge "Create an Android Lint rule to prevent creation of log enforcement ↵ Treehugger Robot
vars" into main