summaryrefslogtreecommitdiff
path: root/system/stack/pan
AgeCommit message (Collapse)Author
2025-01-06Remove gd/os/logging/log_adapter.h Henri Chataing
Bug: 331817295 Test: m com.android.bt Flag: EXEMPT, no logical change Change-Id: I0caac76d6500e586e8a205915524feb607274762
2024-12-18gd: Remove the IRedactableLoggable abstraction Henri Chataing
Bug: 331817295 Test: m com.android.btservices Flag: EXEMPT, no logical change Change-Id: I0b2cde92dfa6c8bd756eba79316872019bb076c6
2024-12-12system: Convert base::StringPrintf to std::format Henri Chataing
Bug: 331817295 Test: m com.android.btservices Flag: EXEMPT, mechanical refactor Change-Id: Ib6933af3c28a1d429ea0cb6e3eae05b53fc9f2b4
2024-11-20system: Migrate from {fmt} to std::format Henri Chataing
Bug: 305066880 Test: m com.android.btservices Flag: EXEMPT, log change Change-Id: If1dbab99250a4f62626206fc9f73d27e71ebab56
2024-11-12Merge "system/stack: Apply clang-tidy fixes" into main Henri Chataing
2024-11-11system/stack: Apply clang-tidy fixes Henri Chataing
Bug: 374984156 Test: m com.android.btservices Flag: EXEMPT, no logical change Change-Id: I5bb14ad304658e74ea21d6e350a4eee96d5c5725
2024-11-08cpplint: fix and enable whitespace/blank_line William Escande
Bug: 364967694 Test: m . Flag: Exempt refactor Change-Id: Ic26c9b0305b76f66a461a4449845a8ca10726c36
2024-10-17Remove os/log.h Henri Chataing
The logging macros within have long been removed, this is just cleanup work to inline the included headers where necessary Bug: 331817295 Test: m com.android.btservices Flag: EXEMPT, no logical change Change-Id: I2147ce4bdcea977b92318b2cb96e7020a8958161
2024-07-11PAN: prevent NPE William Escande
in some circumstances p_buf can be free which render the p_buf->len invalid. Caching the len prevent it Bug: 328841515 Fix: 328841515 Test: None Flag: Exempt, null pointer prevention Change-Id: I2ca2478f6baf7d0a2a96f62121ec4686ecf2b2ee
2024-07-11pan_api: Address cpplint errors William Escande
Bug: 328841515 Test: None Flag: Exempt format Change-Id: I7f58d71477f5ad888872c7f3161954789b07af94
2024-07-07Format: apply clang rules William Escande
Restore SpacesBeforeTrailingComments to 2 to match current style Then run clang-format -i **/**.{c,h,cc,cpp,hpp} Then fix a bunch of typo (reported by gerrit) Then fix unnecessary multiline string Then fix whitespace for disabled clang format (reported by cpplint) This is no-op Bug: 311772251 Test: mmm packages/modules/Bluetooth Flag: Exempt Format only Change-Id: If135447803a40a2a07d4630ba2195e08ef8d250c
2024-05-14stack::sdp [5/12] handle.SDP_AddAttribute Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: I981a16a9da3098b0ecb2f34e1c52fa086a642dd3
2024-05-13stack::sdp [4/12] handle.SDP_DeleteRecord Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: I77dd9d3c88c9fe796e34fb7b85c64dad770a3ec2
2024-05-11stack::sdp [9/12] handle.SDP_AddLanguageBaseAttrIDList Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: I1d843070bd5e6cc23a954953102695230a74e41c
2024-05-11stack::sdp [8/12] handle.SDP_AddServiceClassIdList Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: I100fb29542f6258cf382e73ae8b52209cf6f25e2
2024-05-11Merge "stack::sdp [10/12] handle.SDP_AddProfileDescriptorList" into main Treehugger Robot
2024-05-10stack::sdp [11/12] handle.SDP_AddUuidSequence Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: Ieb4567d59bb6a06471e1e4ad7b22d0b8b5aab53c
2024-05-10stack::sdp [10/12] handle.SDP_AddProfileDescriptorList Chris Manton
Bug: 339311914 Test: m . Flag: EXEMPT, Logging Change Change-Id: I539b8091ff19c37f756d293d8becf699d6cc20f1
2024-04-24system/stack: Remove UNUSED_ATTR Myles Watson
Comment out unused parameters to have the compiler check that they're unused. Bug: 336310650 Test: mma -j32 Flag: EXEMPT, mechanical refactor Change-Id: I55368273d61a24815dc16a5584994cb1dce15534
2024-04-18system: Remove most ADDRESS_TO_LOGGABLE_(CSTR|STR) Henri Chataing
The added formatters for address types have all the same behavior. ADDRESS_TO_LOGGABLE_STR still occurs in BTM_History, dumpsys, log::assert_that calls Test: m com.android.btservices Bug: 305066880 Flag: EXEMPT, mechanical refactor Change-Id: I950f76bd2f1d000638752759a3f08ba0be6f014c
2024-04-05Remove includes of <base/logging.h> Henri Chataing
Convert remaining DLOG, LOG, CHECK_xx occurences in the same pass Test: m com.android.btservices Bug: 305066880 Flag: EXEMPT, mechanical refactor Change-Id: I7ae3e14c84b6ee5dc2ac0babc652c699c7424418
2024-02-15system/stack/pan: Migrate to libbluetooth_log Henri Chataing
Test: m com.android.btservices Bug: 305066880 Flag: EXEMPT, mechanical refactor Change-Id: Ifb31c46c84018375f9db936552f55f0ee1931d30
2024-02-09Inline osi/include/log.h David Duarte
Bug: 279512287 Test: mmm packages/modules/Bluetooth Flag: Exempt, mechanical refactor Change-Id: I962860d1e39a0b1b32bfa2816c12a79b557b8a62
2024-01-17bnep: Pass addresses using const references Myles Watson
Bug: 301661850 Test: mma -j32 Flag: EXEMPT, no logical change Change-Id: Idae16fef7567f416499a21d1d2c752d8721fddf3
2023-12-12bt_target:[20/37] IWYU stack::pan Chris Manton
Bug: 315176531 Test: m . Flag: EXEMPT, IWYU Change-Id: I4876df0a558e1d59182736c8542b1c0a9cedceea
2023-10-24system: Remove legacy trace_level variables Henri Chataing
Bug: 305066880 Test: m com.android.btservices Change-Id: I67379769f13c3af24fc7d05ebd55df06c7bb3243
2023-10-24system: Convert all xx_TRACE_yy log occurrences to LOG_yy Henri Chataing
Bug: 305066880 Test: m com.android.btservices Change-Id: Ia0326eaf1512fd514248ce8675c112205bec4f52
2023-10-20bt_trace: Prepare conversion to gd LOG_xx macros Henri Chataing
- Add includes for osi/include/log.h and LOG_TAG where missing - Add trailing ; where missing Bug: 305066880 Test: m com.android.btservices Change-Id: I2d47a87214823d00753dcbf73e596a79236f3db0
2023-10-19IA2: Break out sdp uuids from other sdp definitions Chris Manton
Towards UUID unification Bug: 305296453 Test: m . Change-Id: Ia236448a5e1dab5f081d8ae5a6cf11ac07241762
2023-05-25SDP API access am: 40039193ca am: a5b68834f2 am: bced5d0f8c Chris Manton
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2509395 Change-Id: Iaa1949c55e3230aed3752bbc1e6d1681c88db2c2 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25SDP API access am: 40039193ca Chris Manton
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2509395 Change-Id: Ifa28a5486420b2524b45b3128a93d3c3dedbc040 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-24SDP API access Chris Manton
Bug: 267248792 Test: None No-Typo-Check: legacy code Change-Id: I978161fec2cc4fd5a88c7ad4b7a2350247232f82
2023-04-27Merge "Remove extern specifiers from function prototype declarations" am: ↵ Henri Chataing
75a13e1e35 am: 026a2dc758 am: dd2a8755d8 Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2533819 Change-Id: I040f9a266387f8d14c2785a802a4e8bb5f44bb60 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27Merge "Remove extern specifiers from function prototype declarations" am: ↵ Henri Chataing
75a13e1e35 Original change: https://android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/2533819 Change-Id: I1d02227e5f315a0bd264e542a9235b1d9f93b80b Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-27Remove extern specifiers from function prototype declarations Henri Chataing
The extern specifier in this case has no effect as the default for functions is to have external linkage. However the extern specifier affects code search ability to explore function declarations and occurences as the prototype differs from the declaration. Test: mmm packages/modules/Bluetooth Bug: 279964152 Change-Id: I4f2e680d49068a0f708c40373bbe865e110f7db1
2023-03-23[RESTRICT AUTOMERGE] Fix potential use after free in pan_api.cc am: c7b0b8ac7f Brian Delwiche
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/modules/Bluetooth/+/22189109 Change-Id: I61b2d20eb31964a69bed038d8d87b965324ed0bf Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-21[RESTRICT AUTOMERGE] Fix potential use after free in pan_api.cc Brian Delwiche
Structure length is checked in pan_api.cc after the structure may be freed, leading to a potential use after free. Save the buffer length to a local instead. Note that BNEP_WriteBuf may alter the length being written internally; this does not appear to be an issue in this use case because the octet count being tracked is used only for logging purposes within PAN. Bug: 259939435 Test: atest bluetooth_test_gd_unit, validate against researcher POC Tag: #security Ignore-AOSP-First: Security Change-Id: I613b3dd3684182bdc725f9e1512061484448d367
2023-01-10Replace PRIVATE_ADDRESS with ADDRESS_TO_LOGGABLE_CSTR Hui Peng
Test: refactoring CL. Existing unit tests still pass Bug: 174487588 Tag: #security Change-Id: Ia217b2a4ff9fea5d60491c23303764116ad1e94a
2022-08-15Add local to pan_api.cc Brian Delwiche
Bug: 233604485 Test: Manual, connected BT and played audio Tag: #security Ignore-AOSP-First: Security Change-Id: Ibb7fffccde731ecb7c12b8ddf212f02f156ffd89
2021-11-10Merge "legacy: Globalize to prepare refactor bta/pan/bta_pan_main" Treehugger Robot
2021-11-10legacy: Re-do names bta/pan/bta_pan_api::BTA_PanSetRole Chris Manton
Bug: 187824969 Tag: #refactor Test: gd/cert/run Change-Id: Ie4afcb6a07e28fe3454f310ac8f340e0a9b701ff
2021-11-09legacy: Globalize to prepare refactor bta/pan/bta_pan_main Chris Manton
Bug: 187824969 Tag: #refactor Test: gd/cert/run Change-Id: I0c74c582bd1d50af1890e4b5a3228e0183eaef2c
2021-11-02Add pan profile dumpsys Chris Manton
Bug: 188074901 Tag: #refactor Test: gd/cert/run Change-Id: I9a4591c8e541c651bc11a51a1d5c034854a5ea73
2021-10-30legacy: Use proper types tPAN_ROLE Chris Manton
Bug: 188297862 Tag: #refactor Test: gd/cert/run Change-Id: I72e6b1870d30b4ca976331cbea0e6f6ac2ae8b64
2021-10-25legacy: Remove #PAN_SUPPORTS_ROLE_PANU Chris Manton
Stack always supports PAN user profile Bug: 191555414 Tag: #refactor Test: gd/cert/run Change-Id: I82b04308997f7cdb995062eebc425597f6dc70c0
2021-10-22legacy: Remove #PAN_SUPPORTS_ROLE_NAP Chris Manton
Stack always supports NAP Bug: 191555414 Tag: #refactor Test: gd/cert/run Change-Id: I9be6c244e184ac78b1c25d5a09a7aa38f1637d76
2021-10-21legacy: pan: Enum-ify stack/pan connection state Chris Manton
Bug: 188297862 Tag: #refactor Test: gd/cert/run Change-Id: I6fa6f8e4d341a026d373e64bf9b0f286e2aee418
2021-10-19legacy: Use proper types stack/pan::tBTA_PAN_RESULT Chris Manton
Bug: 188297862 Tag: #refactor Test: gd/cert/run Change-Id: I924c630179942351d823aa6ec5597bee2bf909d5
2021-10-15legacy: Type-ify stack/pan::tPAN_ROLE Chris Manton
Bug: 188297862 Tag: #refactor Test: gd/cert/run Change-Id: I4ddc8f24bfd85200bf321cdc1161f3e1347ec7c5
2021-09-25legacy: Explicitly include stack/include/bt_types Chris Manton
Bug: 197478351 Tag: #refactor Test: gd/cert/run Change-Id: I90b27a61820ce138f1ebf33a74f26cd26ff365c8