| Age | Commit message (Collapse) | Author |
|---|
|
Bug: 311772251
Flag: EXEMPT
Test: m .
Change-Id: Ia05d2390f8b7733fd50a7bcdfef50777c3a55b9c
|
|
|
|
Bug: 344615661
Test: None
Flag: Exempt hook configuration
Change-Id: I08b6973a6d226ed2f28192624139d6498d394fd4
|
|
Bug: 343776166
Test: None
Flag: Exempt INFRA
Change-Id: I95aa237aa47222885da1fe07bab1a250ca3e05a1
|
|
Historically, checkstyle was the only one respecting the android style
guide of sorting import.
Since an contribution in 2019, google-java-format does that properly:
https://github.com/google/google-java-format/pull/370/files
Note that checkstyle is now wrong for some import, as libcore is an
android import but checkstyle consider is as third party
The formatter is preferred as it will propose a fix command during the
hook
See style guide:
https://source.android.com/docs/setup/contribute/code-style#order-import-statements
Bug: 343776166
Test: None
Flag: Exempt INFRA
Change-Id: I3505cd15609e159413c0ea68fbcf25ae7c1e8e94
|
|
|
|
Bug: 277168419
Test: None
Change-Id: Iba383125566786d04390b810f1bbe33425476b31
|
|
Bluetooth is not ready to have aidl-format as a hook as non of the aidl
are correctly format.
Plus it looks like aidl-format output is not great and is almost never
used. While looking at other aidl files, none using JavaPassthrough is
using it.
Example of output weirdly generated by the format:
```
@JavaPassthrough(
annotation =
"<redacted>")
boolean
enable(in AttributionSource attributionSource);
```
Why boolean is in its own line ?
Bug: 262605980
Test: None
Change-Id: Ibd3dacca104ed47ae272c8171f5052a439d68403
|
|
PREUPLOAD will now check for java code format and will also enforce aidl
format.
Change will also require a Bug in preupload (is is already a lint error
in gerrit)
Bug: 262605980
Test: Upload java changes
Change-Id: I36dc1fb30f82958a3f6f2daf5926e09d68488bed
|
|
Test: manual with pre-upload.py
Change-Id: I42876cc232115d07d6b9f2131df5b43f8698738a
Bug: 262605980
|
|
Test: None
Change-Id: I34034e9bb7da8002fda9ccf7afd8c39ad7046c22
|
|
Test: Upload a commit with change in BluetoothManagerService
Change-Id: I293d68e8dc35066c9ddacf9096a42129cf5bafa0
|
|
* Apply checkstyle hook to known Java directories
* Apply clang-format hook to C and C++ header and sources only
Test: upload CL
Tag: #refactor
Change-Id: Iab475fd8b8be4ce1f4a8e41d0cb0b3bde77b5141
|
|
The old packages/app/Bluetooth/PREUPLOAD.cfg was no longer executed.
Merge it into the root cfg script
Test: NA
Change-Id: I32422aa95529212767dc49d05d384aace3442806
|
|
Bug: 196026708
Tag: #refactor
Test: gd/cert/run
Change-Id: Ibde81667eeb9885d068bd9f9ba19fc0529448265
|
|
Enable rustfmt repohook.
Test: repo upload
Change-Id: I9836672a755021c16b9f609cea147664f92bd6e5
|
|
* Based on Google style and ensure 4 spaces are used for indentation
* http://google.github.io/styleguide/pyguide.html
Bug: 146016811
Test: upload CLs
Change-Id: I27b9232d59e9e9bd59ca1414ef6f9db85c41a808
|
|
The canonical location of certain parts of the source tree live in
AOSP, and should not be changed internally to avoid merge conflicts.
WARNING only: The PREUPLOAD script warns developer if the change is
not uploaded on AOSP.
Test: create a CL in master and upload
Change-Id: I9a100d86d31ef35d1f4617c75d523724acf8ae60
|
|
Test: repo upload --cbr .
Change-Id: Ib4bea4649320db8890399dda8a285bab69f4b482
|