summaryrefslogtreecommitdiff
path: root/quickstep/tests
AgeCommit message (Collapse)Author
2025-04-04[Memory Leak] Fix leak of Launcher activity from recent view's input consumer Fengjiang Li
Ensure we always clear the consumer, which has strong ref to RecentsView and launcher activity, once gesture is ended Fix: 407823225 Test: presubmit Flag: NONE - released code (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:222fb581bda7f16b8f44c41aae489a025507ef51) Merged-In: I90f2212247965697a4077890404bb577943efa37 Change-Id: I90f2212247965697a4077890404bb577943efa37
2025-03-30Forcefully finish recents animations when launcher is detroyed Schneider Victor-Tulias
If launcher is destroyed while the recents animation start is pending, then the taskanimationmanager and absswipeuphandler states are not properly cleaned up. Adding a new cleanup flow to handle this case. Flag: EXEMPT bug fix Fixes: 405642423 Test: adb shell cmd uimode night yes/no while TaskAnimationManager.mRecentsAnimationStartPending == true (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8d72503263e8108aa78a527dde1487eb60c867f6) Merged-In: I7bf1fc4fc07859f92d7aec6cd78deafa1214dd17 Change-Id: I7bf1fc4fc07859f92d7aec6cd78deafa1214dd17
2025-03-24Merge "Pass `displayId` to `CachedTaskInfo` when needed" into main Min Chen
2025-03-24Make sure the correct input consumer is created minch
Let `isGestureBlockedTask` return false directly if `mGestureBlockingTaskId` is not valid. This can avoid the caller go to create incorrect InputConsumer when the chekcing `taskId` is also invalid. Bug: 402218420 Flag: EXEMPT bug fix Test: m Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
2025-03-24Pass `displayId` to `CachedTaskInfo` when needed minch
Bug: 401582344 Flag: EXEMPT refactor Test: m Change-Id: Id930db727dd0072ab5be04ae4272dc68c8b6dcb3
2025-03-24Merge "Fix Test supporting HSUM" into main Massimo Carli
2025-03-24Add "change aspect ratio" to Recents/Overview Robin Lee
This shows up if the launcher is in a sw600dp-or-greater configuration. Test: AspectRatioSystemShortcutTests Test: OverviewMenuImageTest Test: Manual check on phone, tablet, and inner/outer fold screens. Flag: com.android.window.flags.universal_resizable_by_default Bug: 357141415 Change-Id: I1bcbf9299d28ce68cccd636d92ed7195d64736eb
2025-03-22Merge changes from topic "ttt-refactor" into main Treehugger Robot
* changes: Migrate to TopTaskTracker.getPlaceholderGroupedTaskInfo Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
2025-03-21Merge "[Memory Leak] Avoid spamming DragLayer's run queue" into main Treehugger Robot
2025-03-22Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo minch
This CL just introduces an API inside TopTaskTracker to return a GroupedTaskInfo, no existing logic being migrated to it yet. It will be used to replace `getPlaceholderTasks` and `getSplitPlaceholderTasks` in the follow-up cls. Bug: 401582344 Flag: EXEMPT, introduce a new API without usage Test: m Change-Id: Ic12003833605582d191c4abfd4a0878c266dd30f
2025-03-21[Memory Leak] Avoid spamming DragLayer's run queue Fengjiang Li
Avoid adding duplicated ViewTreeObserver#addOnDrawListener from DepthController Fix: 405158421 Flag: NONE - released code Test: manual - presubmit Change-Id: Ib59c130667c5c0a012de3205d11c8de1d6de3903
2025-03-21Remove flaky test from BubbleBarViewAnimatorTest Liran Binyamin
This test is flaky in robolectric but does not repro locally. Looking at the test it verifies that the animation doesn't get canceled immediately after it starts. So the scenario here is an edge case for something that shouldn't happen generally because the animation is controlled in this class, although theoretically other classes could obtain a reference to the physics animator and cancel it directly. But since the test flakes badly, we're better off without it until it can be fixed. Bug: 404773413 Flag: EXEMPT test only Test: atest BubbleBarViewAnimatorTest Change-Id: I24493b71842a2fe859ffe40b6f375ade7ee8535d
2025-03-21Merge changes from topic "revert_task_content_view" into main Alex Chau
* changes: Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-20Merge "Get top task per display from TopTaskTracker" into main Treehugger Robot
2025-03-20Merge changes Id10bb2ac,Ie8edd55b into main Schneider Victor-tulias
* changes: Have Taskbar listen for RecentsState as well Fix TaskarUIController being wrong with Overview-in-Window enabled
2025-03-20Get top task per display from TopTaskTracker Will Osborn
Test: locally tested on tablet Flag: com.android.launcher3.enable_overview_on_connected_displays Bug: 402362465 Change-Id: I0eb66c5c931fe30ce954657ee1b0eb2d87e58943
2025-03-20Merge changes from topic "cleanup-existing-update-disabled-flags" into main Uwais Ashraf
* changes: Remove existing superceded calls to updateDisableFlags Change actions view disabling logic
2025-03-20Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" Alex Chau
This reverts commit e0cc96df62c93d4e18ae5d36a343f2856d7d055d. Reason for revert: b/403826044, b/402277471 Flag: EXEMPT revert Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20Revert "Remove redundant FrameLayout from task_header_view.xml" Alex Chau
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout Reason for revert: b/403826044, b/402277471 Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20Fix Test supporting HSUM Massimo Carli
Flag: EXEMPT Test fix Fix: 403558856 Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest Change-Id: I2a2ff6bc4cee978267ec19fca32bc1f7f80b1bbd
2025-03-19Have Taskbar listen for RecentsState as well Tony Wickham
Also update parallel animation to GestureEndState instead of assuming it's always a LauncherState. Fixes: 401382426 Test: manual/existing automated tests Flag: com.android.launcher3.enable_fallback_overview_in_window Flag: com.android.launcher3.enable_launcher_overview_in_window Change-Id: Id10bb2ac5601462a3885d24d6484889ddfeb59d6
2025-03-19Fix TaskarUIController being wrong with Overview-in-Window enabled Tony Wickham
- isHomeAndOverviewSame now returns true for launcher in window - added isHomeAndOverviewSameActivity to differentiate specifically when Overview is hosted in the Launcher activity (currently only used for launcherChildTask handling, which we can clean up in a follow up change) - overviewIntent now equals homeIntent for launcher in window - fixed containerInterface to always use FallbackoverviewInWindow when overview-in-window is enabled; this means TaskbarManager gets the proper RecentsViewContainer for creating the correct TaskbarUIController - updated getSwipeUpHandlerFactory based on isHomeAndOverviewSame change above Fixes: 401382430 Test: InputConsumerUtilsTest, manual Flag: com.android.launcher3.enable_fallback_overview_in_window Flag: com.android.launcher3.enable_launcher_overview_in_window Change-Id: Ie8edd55b47d6438af36b9d2a788d72d69afa02f3
2025-03-19Change actions view disabling logic Uwais Ashraf
1. Introduces "central task" - the task relating to the actions view 2. Decouple the overlay and actions view 3. Undo filter of taskViewType == SINGLE for overlay as it can be enabled for split tasks as well Bug: 402351284 Flag: com.android.launcher3.enable_refactor_task_thumbnail Test: OverviewImageTest (attached abtd run) Test: OverviewMenuImageTest (attached abtd run) Change-Id: Id7bc5c9c6620183d91e99d9dc5d2980eb8e3ec36
2025-03-19Merge "Remove BubbleBarViewAnimatorTest from deviceless suite." into main Uwais Ashraf
2025-03-19Remove BubbleBarViewAnimatorTest from deviceless suite. Uwais Ashraf
This test is the leading cause of flakiness for the entire suite. Bug: 404773413 Flag: EXEMPT test-only Test: BubbleBarViewAnimatorTest Change-Id: I7c5658ad55aa0e959e068e5979325d1c41d18310
2025-03-18Merge changes I1b67d065,Ib2e7f859 into main Tony Wickham
* changes: Don't show hover tooltip while an app popup is open Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
2025-03-17Merge "Do not notify desk mode changes on visible desk tasks count changes" ↵ Treehugger Robot
into main
2025-03-17Don't show hover tooltip while an app popup is open Tony Wickham
Flag: EXEMPT bugfix Test: TaskbarHoverToolTipControllerTest Fixes: 397243128 Change-Id: I1b67d065e9e79e13a5a341a5d133da700ef5f40c
2025-03-17Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule Tony Wickham
This means we are now testing real objects instead of mocks Test: TaskbarHoverToolTipControllerTest Fixes: 346394827 Flag: EXEMPT bugfix Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
2025-03-17Merge "Use new PreviewPositionHelper for each GetThumbnailPositionUseCase ↵ Shamali Patwa
call" into main
2025-03-17Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call Shamali P
It is now injected via a factory so a new instance is used each time. Bug: 399641570 Flag: EXEMPT BUGFIX Test: Unit test Change-Id: Iee703f0c954c95599c07ceb788edabb0d808abb2
2025-03-17Merge "Add missing Rule for Flags" into main Massimo Carli
2025-03-14Merge "Make OverviewCommandHelper commands and OverviewCommandHelperTest ↵ Treehugger Robot
display-aware" into main
2025-03-14Make OverviewCommandHelper commands and OverviewCommandHelperTest display-aware Will Osborn
Test: locally tested on Tangor Flag: EXEMPT refactor Bug: 397942185 Change-Id: Ib2c3b2662413d15926215c18421168e93ce2b117
2025-03-14Add missing Rule for Flags Massimo Carli
The SetFlagsRule was missing in tests. Flag: EXEMPT Test fix Fix: 402452969 Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest Change-Id: I80e4fc311b173e32e2d85849656b837deb903aeb
2025-03-14Do not notify desk mode changes on visible desk tasks count changes minch
1. Trigger `notifyIsInDesktopModeChanged` on `visibleDesktopTasksCount` changes only when the multi-desks flags are disabled. 2. Make `DesktopVisibilityController.isInDesktopMode` variable private and legacy, which should only be used when the multi-desks feature is disabled. All the call sites should go to check `DesktopVisibilityController.isInDesktopMode(displayId)`, which works both with and without the multi-desks feature enabled. Bug: 402222877 Test: m Flag: com.android.window.flags.enable_multiple_desktops_frontend Flag: com.android.window.flags.enable_multiple_desktops_backend Change-Id: I291e2be6d99e81b0c918ae7f39c17a8cd4ea0918
2025-03-14Merge "Fix app chip split icon position in RTL" into main Jordan Silva
2025-03-14Merge "Fix App Chip positioning in Fake Orientation" into main Jordan Silva
2025-03-14Fix app chip split icon position in RTL Jordan Silva
Fix: 403284758 Flag: com.android.launcher3.enable_overview_icon_menu Test: Manual, please check b/326377497#comment7. Test: OverviewImageTest Test: OverviewSplitTaskImageTest Change-Id: I217e491355f1221ac1840b2c7c47b1000e1ffe71
2025-03-14Fix App Chip positioning in Fake Orientation Jordan Silva
This CL changes how the layoutDirection of the App Chip is handled and update translations in the PagedViewHandler for the app chip for fake orientation. - The App Chip was updated to use the device layoutDirection instead of the same of RecentsView. This prevents the app chip being displayed in RTL when the device is LTR and vice-versa. - It also applies the correct layout direction to `IconAppChipView` and its related views to ensure proper RTL behavior. - RecentsView now updates layoutDirection for its children when updateChildTaskOrientation is called. This will make sure its children have the the latest and the correct layoutDirection.. Before it was only applied when adding a view (addView). - In `SeascapePagedViewHandler`, it adjust the gravity for app chip be aligned correctly in Seascape. - In `GroupedTaskView`, it checks if the device is in RTL to align the app chip correctly for split tasks. - Multiple test combinations were done to validate this fix, please see table in b/326377497#comment7. Fix: 326377497 Bug: 403284758 Flag: com.android.launcher3.enable_overview_icon_menu Test: Manual, please check b/326377497#comment7. Test: OverviewImageTest Test: OverviewSplitTaskImageTest Change-Id: I8e8050ccf58c3f90718a48773ee7e32ddbc00f13
2025-03-14Merge "Make TaskAnimationManager per-display" into main Will Osborn
2025-03-13Merge "Get `displayId` from DesktopTask for `DesktopTaskView`" into main Min Chen
2025-03-13Get `displayId` from DesktopTask for `DesktopTaskView` minch
Bug: 401011627 Flag: com.android.window.flags.enable_multiple_desktops_frontend Flag: com.android.window.flags.enable_multiple_desktops_backend Test: Added a test in RecentTasksListTest Change-Id: I21164de812d57b79cd84370bbf0426268c4b645d
2025-03-13Merge "Associate ResetGestureInputConsumer and NO_OP input consumers with ↵ Treehugger Robot
display IDs" into main
2025-03-13Merge "Add skeleton Growth Framework nudge controller." into main Li Lin
2025-03-13Make TaskAnimationManager per-display Will Osborn
Test: locally tested on Tangor Flag: com.android.launcher3.enable_overview_on_connected_displays Bug: 402362875 Change-Id: I6acb166c200e8bd9198e2aa73e506b3c3414f526
2025-03-13Associate ResetGestureInputConsumer and NO_OP input consumers with display IDs Schneider Victor-Tulias
All input consumers should be associated with display IDs, especially since these are used by TouchInteractionService.onConsumerInactive and they will be using per-display objects. Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays Bug: 382130680 Test: InputConsumerUtilsTest Change-Id: Ic14121db2361da1f0a819221b85256b1b3926774
2025-03-13Merge "Add end animation listener for trampoline animation" into main Sergey Pinkevich
2025-03-12Merge "Remove redundant FrameLayout from task_header_view.xml" into main Treehugger Robot
2025-03-12Add end animation listener for trampoline animation Sergey Pinkevich
Bug: 399322301 Flag: com.android.window.flags.enable_desktop_trampoline_close_animation_bugfix Test: DesktopAppLaunchAnimatorHelperTest Change-Id: I2d1aaf58113f17b4aa172268e4e9e5fba87cbbd3
generated by cgit v1.2.3-59-g8ed1b (git 2.39.0) at 2025-10-21 07:03:22 +0000