diff options
| author | 2024-11-18 14:59:04 -0800 | |
|---|---|---|
| committer | 2024-11-18 15:16:41 -0800 | |
| commit | df5e51ce34938d89d32412cbf884f606e3d1f167 (patch) | |
| tree | 21ede45f9eeb0f797df8bf6cc6d28cde61ab4f88 /res/drawable | |
| parent | d3a4f9f721b5904881275ab6da15509477c51b27 (diff) | |
Fix work tab accessbility issues.
The issue is that the accessibility scanner says tap target is 46dp rather than 48dp because of the 1dp padding that is added
to the viewgroup. Rather, we should delegate that 1dp to the insets of the drawable instead.
bug: 379222957
Test manually, photos:
beforeAccessibilityscanner: https://drive.google.com/file/d/1-XssMfXstpKQk5Ve7l5UCPFORtCkYluH/view?usp=sharing
before:https://drive.google.com/file/d/1rip4gIKpoOw-cCNroEjrpcJ9TMSthHhB/view?usp=sharing
after: https://drive.google.com/file/d/1dOh4yxEAPBG_pGn92yUGizTCLTTW1w2K/view?usp=sharing
Flag: NONE bug fix changing dp
Change-Id: I5ac69e5d92bbbbc3617e30801316eb04d65ace7a
Diffstat (limited to 'res/drawable')
| -rw-r--r-- | res/drawable/all_apps_tabs_background_selected.xml | 8 | ||||
| -rw-r--r-- | res/drawable/all_apps_tabs_background_unselected.xml | 8 |
2 files changed, 8 insertions, 8 deletions
diff --git a/res/drawable/all_apps_tabs_background_selected.xml b/res/drawable/all_apps_tabs_background_selected.xml index 47f95dd745..6560632fe9 100644 --- a/res/drawable/all_apps_tabs_background_selected.xml +++ b/res/drawable/all_apps_tabs_background_selected.xml @@ -15,10 +15,10 @@ --> <layer-list xmlns:android="http://schemas.android.com/apk/res/android"> <item - android:bottom="@dimen/all_apps_tabs_focus_width" - android:end="@dimen/all_apps_tabs_focus_width" - android:start="@dimen/all_apps_tabs_focus_width" - android:top="@dimen/all_apps_tabs_focus_width"> + android:bottom="@dimen/all_apps_tabs_focus_vertical_inset" + android:end="@dimen/all_apps_tabs_focus_horizontal_inset" + android:start="@dimen/all_apps_tabs_focus_horizontal_inset" + android:top="@dimen/all_apps_tabs_focus_vertical_inset"> <shape android:shape="rectangle"> <corners android:radius="@dimen/all_apps_header_pill_corner_radius" /> <solid android:color="?attr/materialColorPrimary" /> diff --git a/res/drawable/all_apps_tabs_background_unselected.xml b/res/drawable/all_apps_tabs_background_unselected.xml index ab592a8304..ce7b334687 100644 --- a/res/drawable/all_apps_tabs_background_unselected.xml +++ b/res/drawable/all_apps_tabs_background_unselected.xml @@ -15,10 +15,10 @@ --> <layer-list xmlns:android="http://schemas.android.com/apk/res/android"> <item - android:bottom="@dimen/all_apps_tabs_focus_width" - android:end="@dimen/all_apps_tabs_focus_width" - android:start="@dimen/all_apps_tabs_focus_width" - android:top="@dimen/all_apps_tabs_focus_width"> + android:bottom="@dimen/all_apps_tabs_focus_vertical_inset" + android:end="@dimen/all_apps_tabs_focus_horizontal_inset" + android:start="@dimen/all_apps_tabs_focus_horizontal_inset" + android:top="@dimen/all_apps_tabs_focus_vertical_inset"> <shape android:shape="rectangle"> <corners android:radius="@dimen/all_apps_header_pill_corner_radius" /> <solid android:color="?attr/materialColorSurfaceBright" /> |