summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Tomasz Mikolajewski <mtomasz@google.com> 2017-02-01 11:54:48 +0900
committer Tomasz Mikolajewski <mtomasz@google.com> 2017-02-01 11:54:48 +0900
commitd573c7dbfed47170bb584f5c7245bbfe737cff75 (patch)
tree74b0e4679a0fcb789e0a01c05bd0db51fb35f33d
parentd7ed947c6d687fd07b5d22bf56d0c97aa7b4cf33 (diff)
Fix crashing converted files warning dialog.
Test: Tested manually that the dialog works. Bug: None Change-Id: I8e708fbf889dec96ca4d9992581e92463704391a
-rw-r--r--src/com/android/documentsui/OperationDialogFragment.java8
-rw-r--r--src/com/android/documentsui/files/FilesActivity.java2
-rw-r--r--src/com/android/documentsui/services/CopyJob.java3
3 files changed, 8 insertions, 5 deletions
diff --git a/src/com/android/documentsui/OperationDialogFragment.java b/src/com/android/documentsui/OperationDialogFragment.java
index 9aa00692e..8b0b70eb5 100644
--- a/src/com/android/documentsui/OperationDialogFragment.java
+++ b/src/com/android/documentsui/OperationDialogFragment.java
@@ -59,7 +59,7 @@ public class OperationDialogFragment extends DialogFragment {
FragmentManager fm,
@DialogType int dialogType,
ArrayList<DocumentInfo> failedSrcList,
- ArrayList<DocumentInfo> uriList,
+ ArrayList<Uri> uriList,
DocumentStack dstStack,
@OpType int operationType) {
@@ -127,8 +127,10 @@ public class OperationDialogFragment extends DialogFragment {
for (DocumentInfo documentInfo : docList) {
list.append("&#8226; " + Html.escapeHtml(documentInfo.displayName) + "<br>");
}
- for (Uri uri : uriList) {
- list.append("&#8226; " + uri.toSafeString() + "<br>");
+ if (uriList != null) {
+ for (Uri uri : uriList) {
+ list.append("&#8226; " + uri.toSafeString() + "<br>");
+ }
}
list.append("</p>");
diff --git a/src/com/android/documentsui/files/FilesActivity.java b/src/com/android/documentsui/files/FilesActivity.java
index 99eb40f05..9ebfbe6de 100644
--- a/src/com/android/documentsui/files/FilesActivity.java
+++ b/src/com/android/documentsui/files/FilesActivity.java
@@ -156,7 +156,7 @@ public class FilesActivity extends BaseActivity implements ActionHandler.Addons
FileOperationService.OPERATION_COPY);
final ArrayList<DocumentInfo> docList =
intent.getParcelableArrayListExtra(FileOperationService.EXTRA_FAILED_DOCS);
- final ArrayList<DocumentInfo> uriList =
+ final ArrayList<Uri> uriList =
intent.getParcelableArrayListExtra(FileOperationService.EXTRA_FAILED_URIS);
OperationDialogFragment.show(
getFragmentManager(),
diff --git a/src/com/android/documentsui/services/CopyJob.java b/src/com/android/documentsui/services/CopyJob.java
index f9218fe90..e44af2d0a 100644
--- a/src/com/android/documentsui/services/CopyJob.java
+++ b/src/com/android/documentsui/services/CopyJob.java
@@ -27,6 +27,7 @@ import static com.android.documentsui.base.DocumentInfo.getCursorString;
import static com.android.documentsui.base.Shared.DEBUG;
import static com.android.documentsui.services.FileOperationService.EXTRA_DIALOG_TYPE;
import static com.android.documentsui.services.FileOperationService.EXTRA_OPERATION_TYPE;
+import static com.android.documentsui.services.FileOperationService.EXTRA_FAILED_DOCS;
import static com.android.documentsui.services.FileOperationService.EXTRA_SRC_LIST;
import static com.android.documentsui.services.FileOperationService.OPERATION_COPY;
@@ -195,7 +196,7 @@ class CopyJob extends ResolvedResourcesJob {
navigateIntent.putExtra(EXTRA_DIALOG_TYPE, DIALOG_TYPE_CONVERTED);
navigateIntent.putExtra(EXTRA_OPERATION_TYPE, operationType);
- navigateIntent.putParcelableArrayListExtra(EXTRA_SRC_LIST, convertedFiles);
+ navigateIntent.putParcelableArrayListExtra(EXTRA_FAILED_DOCS, convertedFiles);
// TODO: Consider adding a dialog on tapping the notification with a list of
// converted files.