summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Wenbo Jie <wenbojie@google.com> 2025-03-18 00:54:43 +0000
committer Wenbo Jie <wenbojie@google.com> 2025-03-18 06:22:13 +0000
commit98129c980bbd136e8971e268609023e10ac88b2f (patch)
treed0b98fbb7917546e91bb28f1054b403e8cea7be2
parent5d4b99a40e85da7260b2cf034b715ca8ba903ab8 (diff)
[DocsUI M3] Update thumbnail border width to 1dp
Check the attached bug for the before/after comparison. Bug: 404256900 Test: m DocumentsUIGoogle && manual inspection Flag: com.android.documentsui.flags.use_material3 Change-Id: I8471fc177230db3645ff68e502dbc5ef710f849c
-rw-r--r--res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml3
-rw-r--r--src/com/android/documentsui/dirlist/GridDocumentHolder.java2
-rw-r--r--src/com/android/documentsui/dirlist/ListDocumentHolder.java2
3 files changed, 3 insertions, 4 deletions
diff --git a/res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml b/res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml
index cf57e1dce..16f75313c 100644
--- a/res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml
+++ b/res/flag(com.android.documentsui.flags.use_material3)/values/dimens.xml
@@ -27,6 +27,7 @@
<dimen name="button_touch_size">48dp</dimen>
<dimen name="root_icon_size">24dp</dimen>
<dimen name="thumbnail_clip_corner_radius">6dp</dimen>
+ <dimen name="thumbnail_border_width">1dp</dimen>
<!-- TODO(b/379776735): remove this block after use_material3 flag is launched. -->
<dimen name="root_icon_margin">0dp</dimen>
<dimen name="root_spacer_padding">0dp</dimen>
@@ -37,7 +38,6 @@
<dimen name="check_icon_size">20dp</dimen>
<dimen name="zoom_icon_size">24dp</dimen>
<dimen name="list_item_thumbnail_size">40dp</dimen>
- <dimen name="list_item_thumbnail_border_width">2dp</dimen>
<dimen name="grid_item_icon_size">30dp</dimen>
<!-- TODO(b/379776735): remove this after use_material3 flag is launched. -->
<dimen name="progress_bar_height">4dp</dimen>
@@ -77,7 +77,6 @@
<dimen name="grid_item_thumbnail_width">80dp</dimen>
<dimen name="grid_item_thumbnail_height">80dp</dimen>
<dimen name="grid_item_thumbnail_radius">12dp</dimen>
- <dimen name="grid_item_thumbnail_border_width">2dp</dimen>
<dimen name="grid_item_icon_width">64dp</dimen>
<dimen name="grid_item_icon_height">64dp</dimen>
<dimen name="grid_item_layout_margin">@dimen/space_small_1</dimen>
diff --git a/src/com/android/documentsui/dirlist/GridDocumentHolder.java b/src/com/android/documentsui/dirlist/GridDocumentHolder.java
index 67ee1f2bf..703f870e2 100644
--- a/src/com/android/documentsui/dirlist/GridDocumentHolder.java
+++ b/src/com/android/documentsui/dirlist/GridDocumentHolder.java
@@ -95,7 +95,7 @@ final class GridDocumentHolder extends DocumentHolder {
mIconCheck = null;
mThumbnailStrokeWidth =
context.getResources()
- .getDimensionPixelSize(R.dimen.grid_item_thumbnail_border_width);
+ .getDimensionPixelSize(R.dimen.thumbnail_border_width);
} else {
mBullet = null;
mIconWrapper = null;
diff --git a/src/com/android/documentsui/dirlist/ListDocumentHolder.java b/src/com/android/documentsui/dirlist/ListDocumentHolder.java
index d91c9547e..a0db097d0 100644
--- a/src/com/android/documentsui/dirlist/ListDocumentHolder.java
+++ b/src/com/android/documentsui/dirlist/ListDocumentHolder.java
@@ -109,7 +109,7 @@ final class ListDocumentHolder extends DocumentHolder {
if (isUseMaterial3FlagEnabled()) {
mThumbnailStrokeWidth =
context.getResources()
- .getDimensionPixelSize(R.dimen.list_item_thumbnail_border_width);
+ .getDimensionPixelSize(R.dimen.thumbnail_border_width);
int clipCornerRadius = context.getResources()
.getDimensionPixelSize(R.dimen.thumbnail_clip_corner_radius);
IconUtils.applyThumbnailClipOutline(