summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2025-09-18[SP 2025-09-01] Remove get/set of voicemail ringtone uri in shared preferences.banksia-dev Tyler Gunn
Prior to Android P, TelephonyManager#setVoicemailRingtoneUri was used by the dialer app to set the voicemail notification sound played when the platform got a new voicemail notification. Likewise, getVoicemailRingtoneUri was used to retrieve the set value. Prior to P this was just saved in the shared prefs, but after P a migration was done to move the shared preference to the NotificationChannel#getSound for the voicemail notification. If, however, you called `setVoicemailRingtoneUri` it was still possible to change the shared preference and have that migrated to be set on the notification channel, causing a cross-profile exploit. In the current world, the notifications for voicemail are NOT posted in Telephony any more, and are instead associated with the notification channel for voicemail IN the dialer app. On the off chance a dialer does not show the voicemail notification, Telephony can post it as well, but at this point the related sound is expected to be associated with the notification channel. To mitigate this cross-profile vulnerability: 1. Ensure TelephonyManager#setVoicemailRingtoneUri does not save to shared preferences any more. 2. Ensure the TelephonyManager#getVoicemailRingtoneUrigetRingtoneUri ONLY queries from the notification channel, and not from the shared preferences since that is not used. This ensures we can never return a bad URI set via the setter. 3. Remove the code in migrateVoicemailNotificationSettings which will take the shared preference and migrate it over to the channel; this is not needed as realistically ANY device from P would have updated LONG ago and had its notification setting migrated to the channel anyways. Test: Change the default voicemail notification channel sound on "phone services"; verify that Dialer can still get this value. Test: Changed the voicemail notification channel in the dialer app so that it has a different value; verify that voicemail notifications use the correct sound. Flag: EXEMPT security patch. Bug: 325030433 Merged-In: I7252c692eb2a5ff4b4fcbddba77425cb423539f3 Change-Id: I7252c692eb2a5ff4b4fcbddba77425cb423539f3 (cherry picked from commit 8e47af093625b997ffb8ca0379a4a56c02ddeb20) Change-Id: I4fd7224e7c72b5aefe839fd94e3022f51cae7a04
2025-05-07Merge cherrypicks of ['googleplex-android-review.googlesource.com/33443931'] ↵ Android Build Coastguard Worker
into 25Q2-release. Change-Id: I51a951e3fa0595a07d664d964cdf63592f674b1e
2025-05-07Use all satellite plmn list in isSatellitePlmn() Aishwarya Mallampati
Bug: 415139661 Test: atest SatelliteControllerTest SatelliteSOSMessageRecommenderTest Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6ae905b27f1c0647d1aca13431a3cbce994782f4) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c5b6966d60ceae44a74e31f7bf2c24909daad915) Merged-In: Ied17b1004e0254ce99c93251061f4617c3f06526 Change-Id: Ied17b1004e0254ce99c93251061f4617c3f06526
2025-04-09Merge cherrypicks of ['googleplex-android-review.googlesource.com/32798805'] ↵ Android Build Coastguard Worker
into 25Q2-release. Change-Id: Iecf9e00d122f9298021bbfc92548637a9371d077
2025-04-09Fix wrong report for satelite eSOS event count Hakjun Choi
remove the case satellite sms event was counted into sos metrics field Bug: 407545648 Flag: EXEMPT bug fix Test: atest ControllerMetricsStatsTest SatelliteControllerTest (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b142982da8c05da0f7cb0083ddfefdb4e5e3c48d) Merged-In: Id81b18dee5e6b0ca1162ef82afb1a413cb56cfdc Change-Id: Id81b18dee5e6b0ca1162ef82afb1a413cb56cfdc
2025-04-03Merge cherrypicks of ['googleplex-android-review.googlesource.com/32666722'] ↵ Android Build Coastguard Worker
into 25Q2-release. Change-Id: Ic26de0d5cf701647303e94f6ea1dae48ec4b1849
2025-04-03Fix UiccController crash due to inconsistent phone count Tomasz Wasilczyk
Using TelephonyManager.getDefault() causes mContext to be null, which makes getPhoneCount quietly fall back to default values. This makes it return sometimes 0, sometimes 1, depending on whether the calling code used TelephonyManager.getDefault() or TelephonyManager.from(Context). Bug: 404627136 Flag: EXEMPT bugfix Test: boot gcar_x86_64-trunk_staging-userdebug and observe NPEs in logcat (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5a3ba387198cc50f42a032bc799112649a6be6b3) Merged-In: Ibf87e7cac9595d87ac593d581928b3863953a274 Change-Id: Ibf87e7cac9595d87ac593d581928b3863953a274
2025-03-30Merge cherrypicks of ['googleplex-android-review.googlesource.com/32710850', ↵ Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/32711605', 'googleplex-android-review.googlesource.com/32744249'] into 25Q2-release. Change-Id: I44b4e719004d211babfd876d9373c5d1cf169480
2025-03-30Do check for throttled before allowing sms is throttled Sooraj Sasindran
Bug: 406623065 Test: Manual verification of polling tests that device does not send out more than 1 sms in 3 minutes for polling Test: atest DatagramDispatcherTest Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dcf5c1b546ce3cc04823cd3a88d608efc5f2e870) Merged-In: I78b4f5c78efd736a673e2b3ad8ef2f9ad6b357b7 Change-Id: I78b4f5c78efd736a673e2b3ad8ef2f9ad6b357b7
2025-03-30Ignore geofence carrier tag IDs requirements for old devices Thomas Nguyen
- Ignore geofence carrier tag IDs requirements for device that don't support new format of geofence data Flag: EXEMPT bugfix Bug: 404710263 Test: SatelliteManagerTestOnMockService Manual test (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8e9b66a36e2562a4084e056a8fcc62b8d57c84fb) Merged-In: I92d6d630c0cf0d8c64bbb9710b4c1ed1f7bd6904 Change-Id: I92d6d630c0cf0d8c64bbb9710b4c1ed1f7bd6904
2025-03-30Check if ar.result is boolean before calling cast Aishwarya Mallampati
Bug: 405485612 Test: atest SatelliteControllerTest Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dfc58e7543c8c6842f236c62f6307d46875ab468) Merged-In: I4f07455f1a5842f5d26308db9c596da316524cce Change-Id: I4f07455f1a5842f5d26308db9c596da316524cce
2025-03-24Snap for 13264465 from 36664cac465be5eff4ad3968fba2565c4a99594d to 25Q2-release Android Build Coastguard Worker
Change-Id: I2d2ffedb127105eb47bb1ab7c041e167c268c6e5
2025-03-24Merge "add is_opportunistic into related atoms" into main Joonhun Shin
2025-03-24Merge "Don't send selected satellite subscription ID changed when there is ↵ Thomas Nguyen
no change" into main
2025-03-21Snap for 13256841 from de83bcf1305f7597c1a6d50a2356bc394e7fc7f6 to 25Q2-release Android Build Coastguard Worker
Change-Id: I2997e731db4f6fe31b09e7864b8b3840284b546c
2025-03-21Don't send selected satellite subscription ID changed when there is no change Thomas Nguyen
- Replace Rlog with Log since it does not work with mock modem Flag: EXEMPT bugfix Bug: 405143491 Test: SatelliteManagerTestOnMockService Manual test Change-Id: I221d161d970c3cbfdc80d417718aaeaad4cb2b79
2025-03-21Merge "DSDA: Handle call resume failure" into main Treehugger Robot
2025-03-21Merge "Return highest preferred data policy if input plmn is empty." into main Sooraj Sasindran
2025-03-21add is_opportunistic into related atoms joonhunshin
It is needed whether the subscription is an opprtunistic. Related Atoms : CellularServiceState, CellularDataServiceSwitch Flag: EXEMPT bug fix Bug: 405260276 Test: build test Change-Id: I53f3c5160c7c54a0e484a8692eff7924e40e82e2
2025-03-21Return highest preferred data policy if input plmn is empty. Aishwarya Mallampati
Bug: 404629211 Test: atest SatelliteControllerTest Flag: EXEMPT bugfix Change-Id: I14feb99ef015ce0aae17353ffe49f8cad21108b7
2025-03-20Merge "Revert "Fix video Call goes on hold instead of terminating when ↵ Joonhun Shin
accepting 2nd video call as audio only"" into main
2025-03-20Merge "Update satellite mode condition for emergency call" into main Hwangoo Park
2025-03-20Snap for 13248265 from ac903221061d0b5ab0c7debd7707604e36cf0ecc to 25Q2-release Android Build Coastguard Worker
Change-Id: I84cfaf3f2574b2a5d4afe0618ff0bd658809fcb6
2025-03-20Merge "Fixed the phone number issue" into main Treehugger Robot
2025-03-20Merge "Don't send disable request to modem when enable is in progress if ↵ Treehugger Robot
device does not support this feature" into main
2025-03-20Merge "Add is_nb_iot_ntn field into related atoms" into main Hakjun Choi
2025-03-20Fix wrong time logging for satellite connection time Hakjun Choi
1. Introduce a data class to match start time log and end time log, if on connectionEnd() is not invoked, session start time info will be dropped 2. use SystemClock.elapsedRealtime() instead of System.currentTimeMillis() as this is used for logging difference between start and end 3. in case connection is less than 2, return empty session gap list Bug: 403572038 Bug: 404344425 Flag: EXEMPT Bug fix Test: atest ControllerMetricsStatsTest CarrierRoamingSatelliteControllerStatsTest SatelliteControllerTest Test: manually run E2E Starlink and VZW P2P test then verify DB is logged as inteded Change-Id: I5239e5f61babe69f3a4a9edb5ddb53be33eb3d46
2025-03-20Add is_nb_iot_ntn field into related atoms Hakjun Choi
It is needed whether reported atom is generated on the NB-IoT-NTN network. Related Atoms: DataCallSession, CellularServiceState, IncomingSms, OutgoingSms, IncomingMms, OutgoingMms CarrierRoamingSatelliteControllerStats, CarrierRoamingSatelliteSessionStats Flag: EXEMPT bug fix Bug: 402275266 Test: atest PersistAtomsStorageTest DataCallSessionStatsTest ServiceStateStatsTest SatelliteControllerTest SatelliteStatsTest CarrierRoamingSatelliteControllerTest Test: manually run e2e live network test and verify locally saved atom DB Change-Id: I9f403ac4e5a76aed096c993eb7ba1f158ddafc66
2025-03-19Fixed the phone number issue Jack Yu
The phone number from UICC should always reflect the content from the SIM card instead of cached value. Fix: 387519623 Test: atest SubscriptionManagerServiceTest Flag: EXEMPT bug fixing Change-Id: Ied676c39b8459a02ec6debf4bcfdb666ecb13dbe
2025-03-19Revert "Fix video Call goes on hold instead of terminating when accepting ↵ Joonhun Shin
2nd video call as audio only" This reverts commit acbd1ee4f25512cf2b0dd8adb099590bcd034fe8. Reason for revert: <Requirement is incorrect> https://b.corp.google.com/issues/397821412#comment10 Live network verification : b/404768831 Change-Id: Ie01aa3252d53a6c65e5d1155d8158a6464aad9a6
2025-03-19Merge "Only do performance-based switch for HOME" into main Ling Ma
2025-03-19Snap for 13241370 from 5b8c294481c94bf5cf10f6a2b5ce6f36caf16176 to 25Q2-release Android Build Coastguard Worker
Change-Id: I012a157b58f2aad22afa62d1b074ccbdc4bb4f4c
2025-03-19Merge "Check data registration state in isCellularAvailable" into main Aishwarya Mallampati
2025-03-19Only do performance-based switch for HOME Ling Ma
Upon offline discussion, to minimize the risk for users who are roaming with data plans with different rate, enforce switching only for HOME registration. Fix: 404875440 Test: basic voice call + data browsing Flag: EXEMPT bugfix Change-Id: Id0d33bfb9b62c912a62784baf2e8f6fb52cc8077
2025-03-19DSDA: Handle call resume failure Pranav Madapurmath
Handles the call resume failure across subscriptions. We will attempt to auto-unhold the foreground call that was previously held as part of the original operation to swap the foreground and background calls as it is historically more likely to succeed. Bug: 390116261 Flag: com.android.server.telecom.flags.enable_call_sequencing Test: atest CallTest Test: atest CallSequencingBasicCallTest Change-Id: Ic795e2468717ae80d7eaa25d83db6c0725dd5d1d
2025-03-19Check data registration state in isCellularAvailable Aishwarya Mallampati
Bug: 403826786 Test: atest SatelliteServiceUtilsTest Test: b/404360253 Flag: EXEMPT bugfix Change-Id: I3416255e8a5b0363ebefba62dfe53f7561eff008
2025-03-19Merge "Extend canoical linger time" into main Ling Ma
2025-03-18Merge "Removing the overwrite logic of sim slot length to mCi's length" into ↵ Sandeep Jawalkar
main
2025-03-18Snap for 13235988 from 69f71d053dd7cda7485f24935817fdfff544afdb to 25Q2-release Android Build Coastguard Worker
Change-Id: I86a63aa6e4bfcfd9a55bd067f32ab0d18b21d14c
2025-03-18Merge "Fix incorrect satellite config udater metrics logging" into main Sooraj Sasindran
2025-03-18Merge "logic for api getSatelliteDataMode" into main Sooraj Sasindran
2025-03-18Merge "Telephony: remove usages of deprecated Mockito matchers" into main Adrian Roos
2025-03-18Extend canoical linger time Ling Ma
Previously, the linger time for a requets is 0.5 second. Extend it to 5 seconds after reviewing the BR to give TNF enough time to move requests to the new DDS. Bug: 396490332 Test: basic voice call + data browsing Flag: EXEMPT bugfix Change-Id: I0ec72554cd678e1c0033b4ff679599442be1ef01
2025-03-18Don't send disable request to modem when enable is in progress if device ↵ Thomas Nguyen
does not support this feature Flag: EXEMPT bugfix Bug: 396157049 Test: SatelliteManagerTestOnMockService SatelliteControllerTest Manual system tests Change-Id: I3eb0acbd9ad9b6330b5742b213ee0fc7f52cab74
2025-03-18Fix incorrect satellite config udater metrics logging Karthick M J
We are emitting CONFIG_UPDATE_RESULT_NO_DATA whenever we update plmn, supported services. And satellite config being empty is totally fine, in case if there hasn't been a config update. So reporting it as CONFIG_UPDATE_RESULT_NO_DATA seems like noise. Test: atest TelephonyConfigUpdateInstallReceiverTest Bug: 404563574 Flag: EXEMPT bugfix Change-Id: Iddce82393435230dc0cccac8b6a1485cc5307f75
2025-03-17Removing the overwrite logic of sim slot length to mCi's length sandeepjs
This fix was added because of crash that can be seen if “config_num_physical_slots” is not configured properly, Its the OEM responsibility to configure this property . Test: b/398782613 Bug: b/396750634 Flag: EXEMPT bug fix Change-Id: Ia0ce90e5914f30b6b88212e164a742417f39021f
2025-03-17Merge "Temporarily ignore tests using reflection on NetworkAgent" into main ↵ Jean Chalard
am: 3078069160 am: c73a6103e4 Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/telephony/+/3545885 Change-Id: I0a5ead1e6c2d15da1b72cdff1de526dbcd47e72b Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-03-17Merge "Temporarily ignore tests using reflection on NetworkAgent" into main ↵ Jean Chalard
am: 3078069160 Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/telephony/+/3545885 Change-Id: I50a0d6c2304d30935586b892111a33a350fde45c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-03-17Merge "Temporarily ignore tests using reflection on NetworkAgent" into main Jean Chalard
2025-03-18Temporarily ignore tests using reflection on NetworkAgent Chalard Jean
NetworkAgent needs a bugfix and these tests are preventing it. In the interest of expediency, ignore these tests now. A followup will reinstate them when we have time to write a good fix. Test: FrameworksTelephonyTests Change-Id: Ieaf5a7f9d112c5779b0720b60d81633cc790ffbe