summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Azhara Assanova <azharaa@google.com> 2024-09-25 15:39:16 +0000
committer Azhara Assanova <azharaa@google.com> 2024-09-25 15:39:16 +0000
commit5bc58b55ebf559b9351463f0ff578584094a9412 (patch)
treedbe1d64751d96dc371484de4f85fca023cb54536
parent67590c56722bb2379c5e7e1d51b2e37642a77018 (diff)
Baseline global lint errors in telephony
We're trying to update AndroidGlobalLintChecker to the latest version in Change-Id I2918f6f94bf1e6b5c153ac743c14082ac7d13600, however, a few lint errors fail presubmit, hence this change updates the baseline file to make presubmit pass for now. Bug: 366207898 Test: treehugger Test: m telephony-common-lint Change-Id: I03cf77ff44a1e299f24202ac5440b2df8cf433b0
-rw-r--r--Android.bp3
-rw-r--r--lint-baseline.xml48
2 files changed, 51 insertions, 0 deletions
diff --git a/Android.bp b/Android.bp
index c3b43735f1..da32208ad6 100644
--- a/Android.bp
+++ b/Android.bp
@@ -116,4 +116,7 @@ java_library {
obfuscate: false,
proguard_flags_files: ["proguard.flags"],
},
+ lint: {
+ baseline_filename: "lint-baseline.xml",
+ },
}
diff --git a/lint-baseline.xml b/lint-baseline.xml
new file mode 100644
index 0000000000..491d0132b8
--- /dev/null
+++ b/lint-baseline.xml
@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<issues format="6" by="lint 8.4.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha08">
+
+ <issue
+ id="SimpleManualPermissionEnforcement"
+ message="IEuiccCardController permission check should be converted to @EnforcePermission annotation"
+ errorLine1=" mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DUMP, &quot;Requires DUMP&quot;);"
+ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+ <location
+ file="frameworks/opt/telephony/src/java/com/android/internal/telephony/euicc/EuiccCardController.java"
+ line="1525"
+ column="9"/>
+ </issue>
+
+ <issue
+ id="SimpleManualPermissionEnforcement"
+ message="IEuiccController permission check can be converted to @EnforcePermission annotation"
+ errorLine1=" mContext.enforceCallingPermission(Manifest.permission.MASTER_CLEAR,"
+ errorLine2=" ^">
+ <location
+ file="frameworks/opt/telephony/src/java/com/android/internal/telephony/euicc/EuiccController.java"
+ line="1679"
+ column="9"/>
+ </issue>
+
+ <issue
+ id="SimpleManualPermissionEnforcement"
+ message="IEuiccController permission check should be converted to @EnforcePermission annotation"
+ errorLine1=" mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DUMP, &quot;Requires DUMP&quot;);"
+ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+ <location
+ file="frameworks/opt/telephony/src/java/com/android/internal/telephony/euicc/EuiccController.java"
+ line="1812"
+ column="9"/>
+ </issue>
+
+ <issue
+ id="SimpleManualPermissionEnforcement"
+ message="ISub permission check should be converted to @EnforcePermission annotation"
+ errorLine1=" mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DUMP,"
+ errorLine2=" ^">
+ <location
+ file="frameworks/opt/telephony/src/java/com/android/internal/telephony/subscription/SubscriptionManagerService.java"
+ line="4800"
+ column="9"/>
+ </issue>
+
+</issues>