From 27e3108d15a93dc52f23a036b800d052fe38b3d3 Mon Sep 17 00:00:00 2001 From: Jooyung Han Date: Mon, 13 Nov 2023 13:50:42 +0900 Subject: Vulkan: log dlerror on error Previously, it prints dlerror even when it succeeds, which leads to a misleading log entry. Bug: n/a Test: cvd start -gpu_mode=guest_swiftshader Change-Id: I6eaf9df6b3fc5c848c999847d712391e6d8b1633 --- vulkan/libvulkan/driver.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'vulkan/libvulkan/driver.cpp') diff --git a/vulkan/libvulkan/driver.cpp b/vulkan/libvulkan/driver.cpp index aea897c84c..0b5bb1504c 100644 --- a/vulkan/libvulkan/driver.cpp +++ b/vulkan/libvulkan/driver.cpp @@ -183,8 +183,12 @@ int LoadDriver(android_namespace_t* library_namespace, .library_namespace = library_namespace, }; so = android_dlopen_ext(lib_name.c_str(), LIB_DL_FLAGS, &dlextinfo); - ALOGE("Could not load %s from updatable gfx driver namespace: %s.", - lib_name.c_str(), dlerror()); + if (!so) { + ALOGE( + "Could not load %s from updatable gfx driver namespace: " + "%s.", + lib_name.c_str(), dlerror()); + } } else { // load built-in driver so = android_load_sphal_library(lib_name.c_str(), LIB_DL_FLAGS); -- cgit v1.2.3-59-g8ed1b