From 2606ec0e279e912b3be4ea53794c07a211e84b3a Mon Sep 17 00:00:00 2001 From: Melody Hsu Date: Thu, 4 Apr 2024 22:31:34 +0000 Subject: Place recordLayerHistoryAnimationTx behind flag Current block of code uses the legacy layer, which will eventually be removed. It is already called elsewhere and is doubly called without the LayerLifecycleManager flag. Bug: b/330785038 Test: presubmit Change-Id: Iea6cb58c3885967ccbf0245549f060380bc1d745 --- services/surfaceflinger/SurfaceFlinger.cpp | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to 'services/surfaceflinger/SurfaceFlinger.cpp') diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 734058a371..cd7a9c1a18 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -5205,17 +5205,19 @@ bool SurfaceFlinger::applyTransactionState(const FrameTimelineInfo& frameTimelin desiredPresentTime, isAutoTimestamp, postTime, transactionId); } - if ((flags & eAnimation) && resolvedState.state.surface) { - if (const auto layer = LayerHandle::getLayer(resolvedState.state.surface)) { - const auto layerProps = scheduler::LayerProps{ - .visible = layer->isVisible(), - .bounds = layer->getBounds(), - .transform = layer->getTransform(), - .setFrameRateVote = layer->getFrameRateForLayerTree(), - .frameRateSelectionPriority = layer->getFrameRateSelectionPriority(), - .isFrontBuffered = layer->isFrontBuffered(), - }; - layer->recordLayerHistoryAnimationTx(layerProps, now); + if (!mLayerLifecycleManagerEnabled) { + if ((flags & eAnimation) && resolvedState.state.surface) { + if (const auto layer = LayerHandle::getLayer(resolvedState.state.surface)) { + const auto layerProps = scheduler::LayerProps{ + .visible = layer->isVisible(), + .bounds = layer->getBounds(), + .transform = layer->getTransform(), + .setFrameRateVote = layer->getFrameRateForLayerTree(), + .frameRateSelectionPriority = layer->getFrameRateSelectionPriority(), + .isFrontBuffered = layer->isFrontBuffered(), + }; + layer->recordLayerHistoryAnimationTx(layerProps, now); + } } } } -- cgit v1.2.3-59-g8ed1b