From 9896b3b371ce6f08abcc0d2f8bb4eb89188fcc04 Mon Sep 17 00:00:00 2001 From: Ady Abraham Date: Wed, 4 Nov 2020 11:01:06 -0800 Subject: SurfaceFlinger: call setFrameTimelineVsyncForTransaction with valid id Remove unnecessary calls to setFrameTimelineVsyncForTransaction when the vsync id is not valid. Test: atest SurfaceFlinger_tests Bug: 171252403 Change-Id: I6233baf5f623c1bc0f3856abb360982c566328ab --- services/surfaceflinger/SurfaceFlinger.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'services/surfaceflinger/SurfaceFlinger.cpp') diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp index 1119fcefb1..57c4d52653 100644 --- a/services/surfaceflinger/SurfaceFlinger.cpp +++ b/services/surfaceflinger/SurfaceFlinger.cpp @@ -3787,9 +3787,7 @@ uint32_t SurfaceFlinger::setClientStateLocked( } if (what & layer_state_t::eFrameTimelineVsyncChanged) { layer->setFrameTimelineVsyncForTransaction(s.frameTimelineVsyncId, postTime); - } else { - // TODO (b/171252403) We are calling this too much, potentially triggering - // unnecessary work + } else if (frameTimelineVsyncId != ISurfaceComposer::INVALID_VSYNC_ID) { layer->setFrameTimelineVsyncForTransaction(frameTimelineVsyncId, postTime); } if (what & layer_state_t::eFixedTransformHintChanged) { -- cgit v1.2.3-59-g8ed1b