From ba266f24e580de2d8339050b62fad7e66441f843 Mon Sep 17 00:00:00 2001 From: Prabir Pradhan Date: Tue, 3 Sep 2019 17:11:27 -0700 Subject: Let InputReader handle its own thread Previously, InputManager created and managed the InputReaderThread, which interacted with InputReader through the loopOnce() method in InputReaderInterface. We move the threading logic from InputManager to InputReader by removing the loopOnce() method from InputReaderInterface and adding a start() and stop() method in its place. Once InputReader is created, InputManager will call InputReaderInterface::start(), which creates and starts InputReader's own thread. InputManager can also call InputReaderInterface::stop() to halt further processing on InputReader's thread. Bug: 130819454 Test: atest inputflinger_tests Test: Touch input works on crosshatch Change-Id: Ic732436d4f00a831e317be1f16ac106a11652cff --- services/inputflinger/InputReaderBase.cpp | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'services/inputflinger/InputReaderBase.cpp') diff --git a/services/inputflinger/InputReaderBase.cpp b/services/inputflinger/InputReaderBase.cpp index 0422d8342b..2d6f2c1cc9 100644 --- a/services/inputflinger/InputReaderBase.cpp +++ b/services/inputflinger/InputReaderBase.cpp @@ -33,20 +33,6 @@ using android::base::StringPrintf; namespace android { -// --- InputReaderThread --- - -InputReaderThread::InputReaderThread(const sp& reader) : - Thread(/*canCallJava*/ true), mReader(reader) { -} - -InputReaderThread::~InputReaderThread() { -} - -bool InputReaderThread::threadLoop() { - mReader->loopOnce(); - return true; -} - // --- InputReaderConfiguration --- std::string InputReaderConfiguration::changesToString(uint32_t changes) { -- cgit v1.2.3-59-g8ed1b