From 73aa6f88e40bb66945ac67a87cdc0f271d655133 Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Wed, 15 Mar 2023 21:49:07 +0000 Subject: binderRpcTest: undo ThreadPoolLimit optimization This test started flaking when we reduced the time it took. It should be re-written to avoid needing to sleep so long, but for now, restoring it so it isn't breaking. Fixes: 272429574 Test: binderRpcTest Change-Id: Ieef2d585f6743a9a7ac79101d5f7724cff7936c3 --- libs/binder/tests/binderRpcTest.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'libs') diff --git a/libs/binder/tests/binderRpcTest.cpp b/libs/binder/tests/binderRpcTest.cpp index 5952c4172e..7cd34a3b5a 100644 --- a/libs/binder/tests/binderRpcTest.cpp +++ b/libs/binder/tests/binderRpcTest.cpp @@ -465,7 +465,9 @@ TEST_P(BinderRpc, ThreadPoolOverSaturated) { constexpr size_t kNumThreads = 10; constexpr size_t kNumCalls = kNumThreads + 3; auto proc = createRpcTestSocketServerProcess({.numThreads = kNumThreads}); - testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 250 /*ms*/); + + // b/272429574 - below 500ms, the test fails + testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/); } TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { @@ -478,7 +480,9 @@ TEST_P(BinderRpc, ThreadPoolLimitOutgoing) { constexpr size_t kNumCalls = kNumOutgoingConnections + 3; auto proc = createRpcTestSocketServerProcess( {.numThreads = kNumThreads, .numOutgoingConnections = kNumOutgoingConnections}); - testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 250 /*ms*/); + + // b/272429574 - below 500ms, the test fails + testThreadPoolOverSaturated(proc.rootIface, kNumCalls, 500 /*ms*/); } TEST_P(BinderRpc, ThreadingStressTest) { -- cgit v1.2.3-59-g8ed1b