From f6b3dc2a356c3147a8b6525716439c2c773b13a0 Mon Sep 17 00:00:00 2001 From: Fan Xu Date: Mon, 14 Jan 2019 15:27:40 -0800 Subject: Remove BufferHubBuffer:Poll function In the new eventFd design, BufferHubBuffer will only provide with the eventfd itself, and user can decide what to do with it. Therefore, the Poll function is not needed any more. Test: BufferHub_test, GraphicBuffer_test Bug: 118891412 Change-Id: I5f5ff71bcedc20de81f246764e878d81b0768eb1 --- libs/ui/BufferHubBuffer.cpp | 5 ----- libs/ui/include/ui/BufferHubBuffer.h | 3 --- 2 files changed, 8 deletions(-) (limited to 'libs') diff --git a/libs/ui/BufferHubBuffer.cpp b/libs/ui/BufferHubBuffer.cpp index c70f18823c..87314ecf76 100644 --- a/libs/ui/BufferHubBuffer.cpp +++ b/libs/ui/BufferHubBuffer.cpp @@ -319,11 +319,6 @@ bool BufferHubBuffer::IsValid() const { mMetadata.IsValid() && mBufferClient != nullptr; } -// TODO(b/68770788): implement Poll() once we have event fd -int BufferHubBuffer::Poll(int /* timeoutMs */) { - return -ENOSYS; -} - native_handle_t* BufferHubBuffer::Duplicate() { if (mBufferClient == nullptr) { ALOGE("%s: missing BufferClient!", __FUNCTION__); diff --git a/libs/ui/include/ui/BufferHubBuffer.h b/libs/ui/include/ui/BufferHubBuffer.h index 44dfa95e67..c6a4a232d1 100644 --- a/libs/ui/include/ui/BufferHubBuffer.h +++ b/libs/ui/include/ui/BufferHubBuffer.h @@ -94,9 +94,6 @@ public: // current cycle of the usage of the buffer. int Release(); - // Polls the fd for |timeoutMs| milliseconds (-1 for infinity). - int Poll(int timeoutMs); - // Creates a token that stands for this BufferHubBuffer client and could be used for Import to // create another BufferHubBuffer. The new BufferHubBuffer will share the same underlying // gralloc buffer and ashmem region for metadata. Note that the caller owns the token and -- cgit v1.2.3-59-g8ed1b