From ef51fbaf55a7f85bda1be264d6a20852bb3367a9 Mon Sep 17 00:00:00 2001 From: Matt Buckley Date: Tue, 12 Oct 2021 19:30:12 +0000 Subject: Send power hints from surfaceflinger using the PowerAdvisor Have SurfaceFlinger send timing hints to the PowerHAL to help meet the frame deadline and dynamically scale clock frequency for different workloads. This patch additionally refactors a few closely related parts of the PowerAdvisor, and expands the logging there for this feature. To enable the power hint session, use: adb shell device_config put surface_flinger_native_boot AdpfFeature__adpf_cpu_hint true Bug: b/195990840 Test: manual Change-Id: Ib3eca9d08e0fb5e446ea7075630f741b48940f84 --- libs/renderengine/include/renderengine/RenderEngine.h | 4 ++++ libs/renderengine/threaded/RenderEngineThreaded.cpp | 14 ++++++++++++++ libs/renderengine/threaded/RenderEngineThreaded.h | 1 + 3 files changed, 19 insertions(+) (limited to 'libs') diff --git a/libs/renderengine/include/renderengine/RenderEngine.h b/libs/renderengine/include/renderengine/RenderEngine.h index b9cc6485e5..d646756fc4 100644 --- a/libs/renderengine/include/renderengine/RenderEngine.h +++ b/libs/renderengine/include/renderengine/RenderEngine.h @@ -189,6 +189,10 @@ public: static void validateInputBufferUsage(const sp&); static void validateOutputBufferUsage(const sp&); + // Allows flinger to get the render engine thread id for power management with ADPF + // Returns the tid of the renderengine thread if it's threaded, and std::nullopt otherwise + virtual std::optional getRenderEngineTid() const { return std::nullopt; } + protected: RenderEngine() : RenderEngine(RenderEngineType::GLES) {} diff --git a/libs/renderengine/threaded/RenderEngineThreaded.cpp b/libs/renderengine/threaded/RenderEngineThreaded.cpp index 08fc81468c..a7176d3279 100644 --- a/libs/renderengine/threaded/RenderEngineThreaded.cpp +++ b/libs/renderengine/threaded/RenderEngineThreaded.cpp @@ -389,6 +389,20 @@ void RenderEngineThreaded::onActiveDisplaySizeChanged(ui::Size size) { mCondition.notify_one(); } +std::optional RenderEngineThreaded::getRenderEngineTid() const { + std::promise tidPromise; + std::future tidFuture = tidPromise.get_future(); + { + std::lock_guard lock(mThreadMutex); + mFunctionCalls.push([&tidPromise](renderengine::RenderEngine& instance) { + tidPromise.set_value(gettid()); + }); + } + + mCondition.notify_one(); + return std::make_optional(tidFuture.get()); +} + } // namespace threaded } // namespace renderengine } // namespace android diff --git a/libs/renderengine/threaded/RenderEngineThreaded.h b/libs/renderengine/threaded/RenderEngineThreaded.h index 0159cfaece..1ba72ddf81 100644 --- a/libs/renderengine/threaded/RenderEngineThreaded.h +++ b/libs/renderengine/threaded/RenderEngineThreaded.h @@ -66,6 +66,7 @@ public: int getContextPriority() override; bool supportsBackgroundBlur() override; void onActiveDisplaySizeChanged(ui::Size size) override; + std::optional getRenderEngineTid() const override; protected: void mapExternalTextureBuffer(const sp& buffer, bool isRenderable) override; -- cgit v1.2.3-59-g8ed1b