From aadacbb21b8285ff0ac2f5f107cd14c293dad393 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 11 Jan 2023 14:19:03 -0800 Subject: Suppress clang-analyzer-security.FloatLoopCounter warnings * Suppress also the alias check name cert-flp30-c. * These loops don't care about the actual float values, just about the behavior for many values over a known range. Bug: 265171053 Test: presubmit; tidy-frameworks-native-libs-ui-tests_subset Change-Id: I8c5541d517e27a555998b89c57d5020c789f964f --- libs/ui/tests/colorspace_test.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'libs') diff --git a/libs/ui/tests/colorspace_test.cpp b/libs/ui/tests/colorspace_test.cpp index 0a4873c8d3..3fb33b4a12 100644 --- a/libs/ui/tests/colorspace_test.cpp +++ b/libs/ui/tests/colorspace_test.cpp @@ -111,6 +111,7 @@ TEST_F(ColorSpaceTest, TransferFunctions) { EXPECT_NEAR(1.0f, sRGB.getEOTF()(1.0f), 1e-6f); EXPECT_NEAR(1.0f, sRGB.getOETF()(1.0f), 1e-6f); + // NOLINTNEXTLINE(clang-analyzer-security.FloatLoopCounter,cert-flp30-c) for (float v = 0.0f; v <= 0.5f; v += 1e-3f) { ASSERT_TRUE(v >= sRGB.getEOTF()(v)); ASSERT_TRUE(v <= sRGB.getOETF()(v)); @@ -118,6 +119,7 @@ TEST_F(ColorSpaceTest, TransferFunctions) { float previousEOTF = std::numeric_limits::lowest(); float previousOETF = std::numeric_limits::lowest(); + // NOLINTNEXTLINE(clang-analyzer-security.FloatLoopCounter,cert-flp30-c) for (float v = 0.0f; v <= 1.0f; v += 1e-3f) { ASSERT_TRUE(previousEOTF < sRGB.getEOTF()(v)); previousEOTF = sRGB.getEOTF()(v); @@ -131,6 +133,7 @@ TEST_F(ColorSpaceTest, TransferFunctions) { {0.3127f, 0.3290f} // linear transfer functions ); + // NOLINTNEXTLINE(clang-analyzer-security.FloatLoopCounter,cert-flp30-c) for (float v = 0.0f; v <= 1.0f; v += 1e-3f) { ASSERT_EQ(v, sRGB2.getEOTF()(v)); ASSERT_EQ(v, sRGB2.getOETF()(v)); -- cgit v1.2.3-59-g8ed1b