From c7263fb43297744eb04b11025424c0c526d5584c Mon Sep 17 00:00:00 2001 From: Taiju Tsuiki Date: Thu, 30 Apr 2015 22:15:33 +0900 Subject: Close Fence FDs in error cases of Surface and GraphicBufferMapper Surface::{cancel,queue}Buffer and GraphicBufferMapper::lockAsyncYCbCr take the ownership of |fenceFd|s. Though they don't close it on error cases. Change-Id: I49a7ce8837d5c510c4ac4ad4649f310d18610e80 --- libs/ui/GraphicBufferMapper.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'libs/ui/GraphicBufferMapper.cpp') diff --git a/libs/ui/GraphicBufferMapper.cpp b/libs/ui/GraphicBufferMapper.cpp index 31bfb2d0fc..32f4909407 100644 --- a/libs/ui/GraphicBufferMapper.cpp +++ b/libs/ui/GraphicBufferMapper.cpp @@ -160,6 +160,9 @@ status_t GraphicBufferMapper::lockAsyncYCbCr(buffer_handle_t handle, bounds.left, bounds.top, bounds.width(), bounds.height(), ycbcr); } else { + if (fenceFd >= 0) { + close(fenceFd); + } return -EINVAL; // do not log failure } -- cgit v1.2.3-59-g8ed1b