From 0b3ad46a26dc3717260fa9347c77f673f3198606 Mon Sep 17 00:00:00 2001 From: Mathias Agopian Date: Fri, 2 Oct 2009 18:12:30 -0700 Subject: Attempt to fix [2152536] ANR in browser The ANR is caused by SurfaceFlinger waiting for buffers of a removed surface to become availlable. When it is removed from the current list, a Surface is marked as NO_INIT, which causes SF to return immediately in the above case. For some reason, the surface here wasn't marked as NO_INIT. This change makes the code more robust by always (irregadless or errors) setting the NO_INIT status in all code paths where a surface is removed from the list. Additionaly added more information in the logs, should this happen again. --- libs/surfaceflinger/Layer.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'libs/surfaceflinger/Layer.h') diff --git a/libs/surfaceflinger/Layer.h b/libs/surfaceflinger/Layer.h index 6c7b27b205..f111840fd7 100644 --- a/libs/surfaceflinger/Layer.h +++ b/libs/surfaceflinger/Layer.h @@ -85,8 +85,6 @@ private: return mBuffers[mFrontBufferIndex]; } - virtual void onRemoved(); - void reloadTexture(const Region& dirty); sp requestBuffer(int index, int usage); -- cgit v1.2.3-59-g8ed1b