From 9c0a86bfe0b9cee1b4bbf6e65c5fe3e26921acc4 Mon Sep 17 00:00:00 2001 From: Vishnu Nair Date: Tue, 14 Jan 2025 12:47:04 -0800 Subject: Remove obsolete BLASTBufferQueue constructor This constructor may apply a transaction using the default apply token. Calling update after construction allows the caller to specify the token. Remove the constructor since its redundant and maybe error prone in cases where the caller needs to specify a token. Bug: 386289111 Test: presubmit Flag: EXEMPT refactor Change-Id: Id4f196b029a5c07e2b3c299d14b81f9c548d6d6b --- libs/gui/SurfaceControl.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libs/gui/SurfaceControl.cpp') diff --git a/libs/gui/SurfaceControl.cpp b/libs/gui/SurfaceControl.cpp index f126c0be2f..b735418d4b 100644 --- a/libs/gui/SurfaceControl.cpp +++ b/libs/gui/SurfaceControl.cpp @@ -141,7 +141,8 @@ sp SurfaceControl::generateSurfaceLocked() ISurfaceComposerClient::eOpaque); mBbqChild = mClient->createSurface(String8::format("[BBQ] %s", mName.c_str()), 0, 0, mFormat, flags, mHandle, {}, &ignore); - mBbq = sp::make("[BBQ]" + mName, mBbqChild, mWidth, mHeight, mFormat); + mBbq = sp::make("[BBQ] " + mName, /* updateDestinationFrame */ true); + mBbq->update(mBbqChild, mWidth, mHeight, mFormat); // This surface is always consumed by SurfaceFlinger, so the // producerControlledByApp value doesn't matter; using false. -- cgit v1.2.3-59-g8ed1b