From 1db73f66624e7d151710483dd58e03eed672f064 Mon Sep 17 00:00:00 2001 From: Robert Carr Date: Wed, 21 Dec 2016 12:58:51 -0800 Subject: SurfaceFlinger: Add support for non-privileged clients. Allow clients without privilege to create child layers through scoped connections. We enable this in preparation for allowing SurfaceView to bypass the WindowManager. We include support for reparenting of all of a layer's children for the WindowManager to use in cases where one surface is replacing another (while keeping its children around). Test: Tested with corresponding SurfaceView modifications. Change-Id: I9920e6730d719113522a68788e63fb59f70d3406 --- libs/gui/SurfaceComposerClient.cpp | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) (limited to 'libs/gui/SurfaceComposerClient.cpp') diff --git a/libs/gui/SurfaceComposerClient.cpp b/libs/gui/SurfaceComposerClient.cpp index c2be6eb751..ece07a33fb 100644 --- a/libs/gui/SurfaceComposerClient.cpp +++ b/libs/gui/SurfaceComposerClient.cpp @@ -170,6 +170,9 @@ public: status_t deferTransactionUntil(const sp& client, const sp& id, const sp& handle, uint64_t frameNumber); + status_t reparentChildren(const sp& client, + const sp& id, + const sp& newParentHandle); status_t setOverrideScalingMode(const sp& client, const sp& id, int32_t overrideScalingMode); status_t setGeometryAppliesWithResize(const sp& client, @@ -455,6 +458,20 @@ status_t Composer::deferTransactionUntil( return NO_ERROR; } +status_t Composer::reparentChildren( + const sp& client, + const sp& id, + const sp& newParentHandle) { + Mutex::Autolock lock(mLock); + layer_state_t* s = getLayerStateLocked(client, id); + if (!s) { + return BAD_INDEX; + } + s->what |= layer_state_t::eReparentChildren; + s->reparentHandle = newParentHandle; + return NO_ERROR; +} + status_t Composer::setOverrideScalingMode( const sp& client, const sp& id, int32_t overrideScalingMode) { @@ -564,10 +581,18 @@ SurfaceComposerClient::SurfaceComposerClient() { } +SurfaceComposerClient::SurfaceComposerClient(const sp& root) + : mStatus(NO_INIT), mComposer(Composer::getInstance()), mParent(root) +{ +} + void SurfaceComposerClient::onFirstRef() { sp sm(ComposerService::getComposerService()); if (sm != 0) { - sp conn = sm->createConnection(); + auto rootProducer = mParent.promote(); + sp conn; + conn = (rootProducer != nullptr) ? sm->createScopedConnection(rootProducer) : + sm->createConnection(); if (conn != 0) { mClient = conn; mStatus = NO_ERROR; @@ -768,6 +793,11 @@ status_t SurfaceComposerClient::deferTransactionUntil(const sp& id, return getComposer().deferTransactionUntil(this, id, handle, frameNumber); } +status_t SurfaceComposerClient::reparentChildren(const sp& id, + const sp& newParentHandle) { + return getComposer().reparentChildren(this, id, newParentHandle); +} + status_t SurfaceComposerClient::setOverrideScalingMode( const sp& id, int32_t overrideScalingMode) { return getComposer().setOverrideScalingMode( -- cgit v1.2.3-59-g8ed1b