From ad74480d6d9b15878bb14701aa81e73f86f70c75 Mon Sep 17 00:00:00 2001 From: Ian Elliott Date: Wed, 26 Jul 2017 21:46:43 +0000 Subject: Revert "Have the Surface class track the buffer age." This reverts commit b4f7493fbdb1d9d5b437a1dcb82e98b1531f4e3e. Change-Id: I9a783c8e768637bd73ac53a856e5f42703dcd82b --- libs/gui/Surface.cpp | 43 ++++++++++++++++++------------------------- 1 file changed, 18 insertions(+), 25 deletions(-) (limited to 'libs/gui/Surface.cpp') diff --git a/libs/gui/Surface.cpp b/libs/gui/Surface.cpp index 78eb69d132..409a3cb076 100644 --- a/libs/gui/Surface.cpp +++ b/libs/gui/Surface.cpp @@ -44,19 +44,21 @@ namespace android { -Surface::Surface(const sp& bufferProducer, bool controlledByApp) - : mGraphicBufferProducer(bufferProducer), - mCrop(Rect::EMPTY_RECT), - mBufferAge(0), - mGenerationNumber(0), - mSharedBufferMode(false), - mAutoRefresh(false), - mSharedBufferSlot(BufferItem::INVALID_BUFFER_SLOT), - mSharedBufferHasBeenQueued(false), - mQueriedSupportedTimestamps(false), - mFrameTimestampsSupportsPresent(false), - mEnableFrameTimestamps(false), - mFrameEventHistory(std::make_unique()) { +Surface::Surface( + const sp& bufferProducer, + bool controlledByApp) + : mGraphicBufferProducer(bufferProducer), + mCrop(Rect::EMPTY_RECT), + mGenerationNumber(0), + mSharedBufferMode(false), + mAutoRefresh(false), + mSharedBufferSlot(BufferItem::INVALID_BUFFER_SLOT), + mSharedBufferHasBeenQueued(false), + mQueriedSupportedTimestamps(false), + mFrameTimestampsSupportsPresent(false), + mEnableFrameTimestamps(false), + mFrameEventHistory(std::make_unique()) +{ // Initialize the ANativeWindow function pointers. ANativeWindow::setSwapInterval = hook_setSwapInterval; ANativeWindow::dequeueBuffer = hook_dequeueBuffer; @@ -504,10 +506,9 @@ int Surface::dequeueBuffer(android_native_buffer_t** buffer, int* fenceFd) { nsecs_t startTime = systemTime(); FrameEventHistoryDelta frameTimestamps; - status_t result = mGraphicBufferProducer->dequeueBuffer(&buf, &fence, reqWidth, reqHeight, - reqFormat, reqUsage, &mBufferAge, - enableFrameTimestamps ? &frameTimestamps - : nullptr); + status_t result = mGraphicBufferProducer->dequeueBuffer(&buf, &fence, + reqWidth, reqHeight, reqFormat, reqUsage, + enableFrameTimestamps ? &frameTimestamps : nullptr); mLastDequeueDuration = systemTime() - startTime; if (result < 0) { @@ -844,14 +845,6 @@ int Surface::query(int what, int* value) const { } return err; } - case NATIVE_WINDOW_BUFFER_AGE: { - if (mBufferAge > INT32_MAX) { - *value = 0; - } else { - *value = static_cast(mBufferAge); - } - return NO_ERROR; - } case NATIVE_WINDOW_LAST_DEQUEUE_DURATION: { int64_t durationUs = mLastDequeueDuration / 1000; *value = durationUs > std::numeric_limits::max() ? -- cgit v1.2.3-59-g8ed1b