From 1b700199c9f0d7169fd4598d8efaac2ab80c4a30 Mon Sep 17 00:00:00 2001 From: Vishnu Nair Date: Fri, 4 Feb 2022 10:09:47 -0800 Subject: SF: Remove layer mRefreshPending tracking This flag was used to ensure we do not latch a second buffer without going through the composition stage. This flag is not needed because if we latch a buffer, then we are guaranteed to go into the composition stage. Incentive for this change: to rebuild the layer state, via layertracegenerator, we invoke the commit stage over and over again. This flag prevents us from latching another buffer because the tool does not call composite. Test: presubmit, also presubmit with fatal log if we ever try to latch when mRefreshPending is true (ag/16790650) Bug: 200284593 Change-Id: I332349865b19ae7a205002167f26f5a2f76688af --- libs/gui/LayerDebugInfo.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'libs/gui/LayerDebugInfo.cpp') diff --git a/libs/gui/LayerDebugInfo.cpp b/libs/gui/LayerDebugInfo.cpp index 0827bbe3ee..ea5fb293a6 100644 --- a/libs/gui/LayerDebugInfo.cpp +++ b/libs/gui/LayerDebugInfo.cpp @@ -58,7 +58,6 @@ status_t LayerDebugInfo::writeToParcel(Parcel* parcel) const { RETURN_ON_ERROR(parcel->writeInt32(mActiveBufferStride)); RETURN_ON_ERROR(parcel->writeInt32(mActiveBufferFormat)); RETURN_ON_ERROR(parcel->writeInt32(mNumQueuedFrames)); - RETURN_ON_ERROR(parcel->writeBool(mRefreshPending)); RETURN_ON_ERROR(parcel->writeBool(mIsOpaque)); RETURN_ON_ERROR(parcel->writeBool(mContentDirty)); RETURN_ON_ERROR(parcel->write(mStretchEffect)); @@ -103,7 +102,6 @@ status_t LayerDebugInfo::readFromParcel(const Parcel* parcel) { RETURN_ON_ERROR(parcel->readInt32(&mActiveBufferStride)); RETURN_ON_ERROR(parcel->readInt32(&mActiveBufferFormat)); RETURN_ON_ERROR(parcel->readInt32(&mNumQueuedFrames)); - RETURN_ON_ERROR(parcel->readBool(&mRefreshPending)); RETURN_ON_ERROR(parcel->readBool(&mIsOpaque)); RETURN_ON_ERROR(parcel->readBool(&mContentDirty)); RETURN_ON_ERROR(parcel->read(mStretchEffect)); @@ -146,8 +144,7 @@ std::string to_string(const LayerDebugInfo& info) { StringAppendF(&result, " activeBuffer=[%4ux%4u:%4u,%s],", info.mActiveBufferWidth, info.mActiveBufferHeight, info.mActiveBufferStride, decodePixelFormat(info.mActiveBufferFormat).c_str()); - StringAppendF(&result, " queued-frames=%d, mRefreshPending=%d", info.mNumQueuedFrames, - info.mRefreshPending); + StringAppendF(&result, " queued-frames=%d", info.mNumQueuedFrames); result.append("\n"); return result; } -- cgit v1.2.3-59-g8ed1b