From 29936fa194516a906585eb3938d62d1944a21172 Mon Sep 17 00:00:00 2001 From: Darwin Huang Date: Wed, 8 Sep 2021 18:29:18 +0000 Subject: BufferQueueProducer: Log verbose log to warning instead of error. Previously, this printed very verbose/spammy logs when there was nothing actionable users or developers could do to improve what seemed like correct behavior to the user. Move this log to 'warning' to still provide the information while reducing spam. Bug: http://b/140581935 Change-Id: Iba5fc100a99594a7ac6df240b2468ffedfde249c --- libs/gui/BufferQueueProducer.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'libs/gui/BufferQueueProducer.cpp') diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index df308d897b..5fe5e71db9 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -645,7 +645,10 @@ status_t BufferQueueProducer::detachBuffer(int slot) { slot, BufferQueueDefs::NUM_BUFFER_SLOTS); return BAD_VALUE; } else if (!mSlots[slot].mBufferState.isDequeued()) { - BQ_LOGE("detachBuffer: slot %d is not owned by the producer " + // TODO(http://b/140581935): This message is BQ_LOGW because it + // often logs when no actionable errors are present. Return to + // using BQ_LOGE after ensuring this only logs during errors. + BQ_LOGW("detachBuffer: slot %d is not owned by the producer " "(state = %s)", slot, mSlots[slot].mBufferState.string()); return BAD_VALUE; } else if (!mSlots[slot].mRequestBufferCalled) { -- cgit v1.2.3-59-g8ed1b